Commit Graph
650 Commits
Author SHA1 Message Date
Anna Yeddi f351d96411 Bug 1884970 - Close current tab button is missing an accessible name and role. r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson,flod
The [tab-close-button](https://searchfox.org/mozilla-central/rev/f9157a03835653cd3ece8d2dc713a782b7e4374e/browser/base/content/tabbrowser-tab.js#40) is not labeled and is missing an interactive role of button, while it is functioning as one.

Note: we do not want this control to be keyboard focusable, because keyboard-only user could close the tab via the context menu and we don't want to create an additional tab stop for the navigation as well, but making sure the control is marked up as a button with an accessible name would allow it to be actionable with speech-to-text software, with touch devices, with switch controls in scan mode, and for screen readers via their navigation shortcuts as well.

Differential Revision: https://phabricator.services.mozilla.com/D204413
2024-08-06 13:51:06 +00:00
Cristian Tuns 49bd8e8edd Backed out changeset 6ac47dbd939c (bug 1884970) for causing bc failures in browser_tab_tooltips.js CLOSED TREE 2024-06-28 15:23:44 -04:00
Anna Yeddi f0d91c0df0 Bug 1884970 - Close current tab button is missing an accessible name and role. r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson,flod
The [tab-close-button](https://searchfox.org/mozilla-central/rev/f9157a03835653cd3ece8d2dc713a782b7e4374e/browser/base/content/tabbrowser-tab.js#40) is not labeled and is missing an interactive role of button, while it is functioning as one.

Note: we do not want this control to be keyboard focusable, because keyboard-only user could close the tab via the context menu and we don't want to create an additional tab stop for the navigation as well, but making sure the control is marked up as a button with an accessible name would allow it to be actionable with speech-to-text software, with touch devices, with switch controls in scan mode, and for screen readers via their navigation shortcuts as well.

Differential Revision: https://phabricator.services.mozilla.com/D204413
2024-06-28 18:23:45 +00:00
Cristian Tuns 29b9dc4717 Backed out changeset 87d3cf2b45b2 (bug 1884970) for causing bc failures in browser_multiselect_tabs_close.js CLOSED TREE 2024-06-28 14:15:24 -04:00
Anna Yeddi 9bcc35ccaa Bug 1884970 - Close current tab button is missing an accessible name and role. r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson,flod
The [tab-close-button](https://searchfox.org/mozilla-central/rev/f9157a03835653cd3ece8d2dc713a782b7e4374e/browser/base/content/tabbrowser-tab.js#40) is not labeled and is missing an interactive role of button, while it is functioning as one.

Note: we do not want this control to be keyboard focusable, because keyboard-only user could close the tab via the context menu and we don't want to create an additional tab stop for the navigation as well, but making sure the control is marked up as a button with an accessible name would allow it to be actionable with speech-to-text software, with touch devices, with switch controls in scan mode, and for screen readers via their navigation shortcuts as well.

Differential Revision: https://phabricator.services.mozilla.com/D204413
2024-06-28 17:19:31 +00:00
Julien Cristau c5f590926f Bug 1901717 - add esr128 to cross-channel. r=flod
Differential Revision: https://phabricator.services.mozilla.com/D213434
2024-06-12 16:26:43 +00:00
Bryan Olsson b0f925858e Bug 1897003 - Remove Fluent migration recipes for Firefox 120-123 and others, r=flod DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D210580
2024-05-16 05:50:09 +00:00
Eemeli Aro bfb3ebfef6 Bug 1877104 - Default to git source repo for fluent migration tests. r=flod,bolsson
Now that we've switched Pontoon to read from git, tools should do so as well.

Differential Revision: https://phabricator.services.mozilla.com/D209636
2024-05-13 10:41:21 +00:00
Niklas Baumgardner 286abf76a1 Bug 1892125 - Refactor screenshots preview. r=sfoster,fluent-reviewers,desktop-theme-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D207884
2024-04-30 23:55:55 +00:00
Erik Nordin e7348948e2 Bug 1893022 - Move Select Translations Fluent Strings out of Preview r=fluent-reviewers,flod
Moves the Fluent strings for Select Translations out of
locales preview and into the en-US locale to mark them
to be translated by localizers for release.

Differential Revision: https://phabricator.services.mozilla.com/D208383
2024-04-25 07:03:31 +00:00
Niklas Baumgardner 1abddd1c95 Bug 1864038 - Add keyboard shortcuts for screenshots overlay. r=sfoster,fluent-reviewers,bolsson,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D193847
2024-04-03 23:51:56 +00:00
Cristian Tuns 83896edc65 Backed out changeset d41d18cecc78 (bug 1864038) for causing bc failures in browser_screenshots_drag_scroll_test.js CLOSED TREE 2024-04-02 12:41:01 -04:00
Niklas Baumgardner c7874fdeb6 Bug 1864038 - Add keyboard shortcuts for screenshots overlay. r=sfoster,fluent-reviewers,bolsson,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D193847
2024-04-02 15:53:57 +00:00
Norisz Fay 61257b3d08 Backed out changeset 13111643fbf4 (bug 1864038) for causing bc failures on browser_screenshots_drag_scroll_test.js CLOSED TREE 2024-04-02 05:04:20 +03:00
Niklas Baumgardner 70450dd2d1 Bug 1864038 - Add keyboard shortcuts for screenshots overlay. r=sfoster,fluent-reviewers,bolsson,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D193847
2024-04-01 22:33:12 +00:00
Narcis Beleuzu 8e1286070a Backed out changeset 4bcd94d558a6 (bug 1864038) for bc failure on browser_screenshots_drag_scroll_test.js 2024-04-01 17:29:08 +03:00
Niklas Baumgardner 9be70cc492 Bug 1864038 - Add keyboard shortcuts for screenshots overlay. r=sfoster,fluent-reviewers,bolsson,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D193847
2024-04-01 13:51:16 +00:00
Mark Hammond f5852b3983 Bug 1884748 - add alt text to images in about:preferences#sync. r=fluent-reviewers,flod,mconley,accessibility-frontend-reviewers,ayeddi
Differential Revision: https://phabricator.services.mozilla.com/D205090
2024-03-28 19:11:27 +00:00
Neil Deakin 43f6108d3c Bug 1881582, implement the address autofill warning on the popup as a separate row and remove the implementation based on the custom class MozAutocompleteProfileListitemFooter, r=credential-management-reviewers,fluent-reviewers,desktop-theme-reviewers,reusable-components-reviewers,mstriemer,bolsson,sgalich,dao
Differential Revision: https://phabricator.services.mozilla.com/D202750
2024-03-20 15:37:15 +00:00
Neil Deakin d385e794a1 Bug 1881582, replace MozAutocompleteProfileListitemClearButton with an implementation based on the generic MozAutocompleteTwoLineRichlistitem type, r=credential-management-reviewers,fluent-reviewers,bolsson,tgiles,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D202747
2024-03-20 15:37:14 +00:00
Alex Franchuk 841ff2bf0b Bug 1759175 pt3 - Crashreporter business logic r=gsvelto,fluent-reviewers,flod,eemeli,cmartin
Differential Revision: https://phabricator.services.mozilla.com/D185942
2024-03-20 14:59:44 +00:00
Narcis Beleuzu f3700687c3 Backed out 4 changesets (bug 1881582) for bc failure on autocomplete-item.css
Backed out changeset 3f9778571c70 (bug 1881582)
Backed out changeset c429c3d10f6a (bug 1881582)
Backed out changeset f2d5d0925cfd (bug 1881582)
Backed out changeset 496f2f2ad959 (bug 1881582)
2024-03-20 03:48:30 +02:00
Neil Deakin 83c159714f Bug 1881582, implement the address autofill warning on the popup as a separate row and remove the implementation based on the custom class MozAutocompleteProfileListitemFooter, r=credential-management-reviewers,fluent-reviewers,desktop-theme-reviewers,reusable-components-reviewers,mstriemer,bolsson,sgalich,dao
Differential Revision: https://phabricator.services.mozilla.com/D202750
2024-03-20 00:55:06 +00:00
Neil Deakin 8fb12b9f32 Bug 1881582, replace MozAutocompleteProfileListitemClearButton with an implementation based on the generic MozAutocompleteTwoLineRichlistitem type, r=credential-management-reviewers,fluent-reviewers,bolsson,tgiles,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D202747
2024-03-20 00:55:05 +00:00
Iulian Moraru b01a3d6734 Backed out 4 changesets (bug 1881582) for causing bc failures on browser_parsable_css.js. CLOSED TREE
Backed out changeset 7e0133076c73 (bug 1881582)
Backed out changeset 17ae2064cb82 (bug 1881582)
Backed out changeset 6005be94c74e (bug 1881582)
Backed out changeset 02e295ea9b67 (bug 1881582)
2024-03-19 07:22:40 +02:00
Neil Deakin 533aa5ece8 Bug 1881582, implement the address autofill warning on the popup as a separate row and remove the implementation based on the custom class MozAutocompleteProfileListitemFooter, r=credential-management-reviewers,fluent-reviewers,desktop-theme-reviewers,reusable-components-reviewers,mstriemer,bolsson,sgalich,dao
Differential Revision: https://phabricator.services.mozilla.com/D202750
2024-03-18 16:34:20 +00:00
Neil Deakin 6e52ea0528 Bug 1881582, replace MozAutocompleteProfileListitemClearButton with an implementation based on the generic MozAutocompleteTwoLineRichlistitem type, r=credential-management-reviewers,fluent-reviewers,bolsson,tgiles,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D202747
2024-03-18 16:34:19 +00:00
Tim Giles 4b1c3b2da6 Bug 1864606 - Fix missing label association for crash reports checkbox r=fluent-reviewers,Gijs,bolsson
Thanks to mhowell for the STRIP_ANCHOR function in the Fluent migration.

We were using the "for" attribute on a XUL label which does not behave
like an HTML label. This prevented the programmatic association
between the checkbox and the label. By utilizing moz-label, we maintain
the accesskey behavior of the previous XUL label.

Additionally we use moz-support-link to remove the
"collection-backlogged-crash-reports-link" Fluent string.

Differential Revision: https://phabricator.services.mozilla.com/D204557
2024-03-15 00:10:38 +00:00
Norisz Fay c303710ef4 Backed out 10 changesets (bug 1759175) for causing Bp build bustage CLOSED TREE
Backed out changeset 3caff3bcb5f3 (bug 1759175)
Backed out changeset b0cbac1ae1c0 (bug 1759175)
Backed out changeset 8ab327d18125 (bug 1759175)
Backed out changeset 94b619f7ae5a (bug 1759175)
Backed out changeset 4e16215b14af (bug 1759175)
Backed out changeset e994c818703c (bug 1759175)
Backed out changeset caf59b01fb96 (bug 1759175)
Backed out changeset 4a525dace3cf (bug 1759175)
Backed out changeset ac608a17d8c7 (bug 1759175)
Backed out changeset 2e605dcdcf83 (bug 1759175)
2024-03-08 02:08:29 +02:00
Alex Franchuk 1496b659d2 Bug 1759175 pt3 - Crashreporter business logic r=gsvelto,fluent-reviewers,flod,eemeli,cmartin
Differential Revision: https://phabricator.services.mozilla.com/D185942
2024-03-07 20:59:13 +00:00
Norisz Fay 8732f86cdc Backed out 10 changesets (bug 1759175) for causing build bustage CLOSED TREE
Backed out changeset 3f7b865cce56 (bug 1759175)
Backed out changeset 3ce2c92bdee2 (bug 1759175)
Backed out changeset e8b6ce00b503 (bug 1759175)
Backed out changeset 6736f34d5642 (bug 1759175)
Backed out changeset 5894c03ccb0e (bug 1759175)
Backed out changeset 28ee74b69b66 (bug 1759175)
Backed out changeset 027be772e29a (bug 1759175)
Backed out changeset 35350f3c3b68 (bug 1759175)
Backed out changeset 754fe9369002 (bug 1759175)
Backed out changeset f2aa40301a39 (bug 1759175)
2024-03-07 22:44:32 +02:00
Morgan Rae Reschenberg e077d14d14 Bug 1875957: Update web appearance warning to use moz-message-bar r=fluent-reviewers,flod,mconley
Differential Revision: https://phabricator.services.mozilla.com/D199402
2024-03-07 20:12:44 +00:00
Alex Franchuk f1043cdefa Bug 1759175 pt3 - Crashreporter business logic r=gsvelto,fluent-reviewers,flod,eemeli,cmartin
Differential Revision: https://phabricator.services.mozilla.com/D185942
2024-03-07 19:47:09 +00:00
Narcis Beleuzu a0bddd48d2 Backed out 10 changesets (bug 1759175) for build bustages . CLOSED TREE
Backed out changeset dce52d34bd91 (bug 1759175)
Backed out changeset 51ee5a685214 (bug 1759175)
Backed out changeset 021559ebc1e7 (bug 1759175)
Backed out changeset 6888a063a0c3 (bug 1759175)
Backed out changeset 84b443488fb5 (bug 1759175)
Backed out changeset f39525560fd6 (bug 1759175)
Backed out changeset 6b0d3b266dea (bug 1759175)
Backed out changeset 5d33c3516218 (bug 1759175)
Backed out changeset b50fd0148c7f (bug 1759175)
Backed out changeset 7cb85f06517a (bug 1759175)
2024-03-07 18:16:59 +02:00
Alex Franchuk 3f671834b2 Bug 1759175 pt3 - Crashreporter business logic r=gsvelto,fluent-reviewers,flod,eemeli,cmartin
Differential Revision: https://phabricator.services.mozilla.com/D185942
2024-03-07 14:03:54 +00:00
Cristina Horotan bc213eb4bd Backed out 10 changesets (bug 1759175) for causing build bustages cocoabind related. CLOSED TREE
Backed out changeset 3d8279b62b0e (bug 1759175)
Backed out changeset fa1545689826 (bug 1759175)
Backed out changeset 00b28a515e8d (bug 1759175)
Backed out changeset 40dfe0d499df (bug 1759175)
Backed out changeset acde6c99092c (bug 1759175)
Backed out changeset e6d83c21eadc (bug 1759175)
Backed out changeset b34e196120aa (bug 1759175)
Backed out changeset 45a2a256b9d4 (bug 1759175)
Backed out changeset 4aba1755a610 (bug 1759175)
Backed out changeset 68d2d1abab21 (bug 1759175)
2024-02-26 23:35:36 +02:00
Alex Franchuk 5bb5a03a7c Bug 1759175 pt3 - Crashreporter business logic r=gsvelto,fluent-reviewers,flod,eemeli,cmartin
Differential Revision: https://phabricator.services.mozilla.com/D185942
2024-02-26 19:12:34 +00:00
serge-sans-paille 67fb85ad18 Bug 1879120 - Remove all python deprecation warning: invalid escape sequence r=ahochheiden,webdriver-reviewers,perftest-reviewers,afinder UPGRADE_NSPR_RELEASE
Differential Revision: https://phabricator.services.mozilla.com/D201012
2024-02-26 08:26:38 +00:00
Johannes J. Schmidt d8b8a2b7a9 Bug 1864340 - display correct wording in ac footer - r=sgalich,dimi,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D198828
2024-02-20 14:21:18 +00:00
Noemi Erli 845ab3292b Backed out changeset cd949da4b9b6 (bug 1864340) foe causing failures in browser_creditCard_telemetry.js CLOSED TREE 2024-02-19 23:23:21 +02:00
Johannes J. Schmidt 11df9c4a78 Bug 1864340 - display correct wording in ac footer - r=sgalich,dimi,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D198828
2024-02-19 16:49:17 +00:00
Norisz Fay eaa4787926 Backed out changeset 9e33a77369d3 (bug 1864340) for causing bc failures on browser_creditCard_telemetry.js CLOSED TREE 2024-02-19 16:23:37 +02:00
Johannes J. Schmidt 2b80fb5845 Bug 1864340 - display correct wording in ac footer - r=sgalich,dimi,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D198828
2024-02-19 10:12:28 +00:00
Eemeli Aro 025462cf2d Bug 1877105 - Add git source support to test_fluent_migrations. r=flod,bolsson
Adds a CLI option `--l10n-git` that uses the firefox-l10n-source git repo instead of the gecko-strings hg repo when testing Fluent migrations.

When we complete the git migration, the option and mercurial repo support should be removed.

Differential Revision: https://phabricator.services.mozilla.com/D200184
2024-02-02 12:25:29 +00:00
Emily McMinn e3233ed67d Bug 1863022 - Render message from browser-siteProtections.js, replace messaging system telemetry, and migrate strings r=pdahiya,omc-reviewers,pbz,fluent-reviewers,flod
The protections panel message should show once when the panel is first opened; after that it will be collapsed by default and can be shown again by clicking the "info" button on the panel

Messaging system previously sent the following pings on message show, and when the "learn more" link was clicked:

```
{“message_id”:“PROTECTIONS_PANEL_1",“event”:“IMPRESSION”,“addon_version”:“20231106094018",“locale”:“en-US”,“client_id”:“6fabd2de-3d0a-4b11-be4c-86b0ea1a1144",“browser_session_id”:“4b0f34b1-75ef-4704-907e-18d84e5187c3",“pingType”:“whats-new-panel”}
```
and

```
{“message_id”:“PROTECTIONS_PANEL_1",“event”:“CLICK”,“addon_version”:“20231106094018",“locale”:“en-US”,“client_id”:“6fabd2de-3d0a-4b11-be4c-86b0ea1a1144",“browser_session_id”:“4b0f34b1-75ef-4704-907e-18d84e5187c3",“pingType”:“whats-new-panel”}
```

This patch replaces these pings with 'RecordEvents' telemetry on the `protectionsPopup` object:

```
33153 	security.ui.protectionspopup 	open 	protectionspopup_cfr 	impression 	{"message": "PROTECTIONS_PANEL_1"}
```
and

```
34932 	security.ui.protectionspopup 	click 	protectionspopup_cfr
```

Differential Revision: https://phabricator.services.mozilla.com/D192968
2024-01-10 22:20:05 +00:00
Hanna Jones c6a82fe0de Bug 1845150 - Update notificationbox usage for search engine removal notification r=search-reviewers,fluent-reviewers,Standard8,bolsson
Notification can be triggered locally via this snippet:

```js
BrowserSearch.removalOfSearchEngineNotificationBox("Google", "Foogle")
```

Depends on D189872

Differential Revision: https://phabricator.services.mozilla.com/D194312
2024-01-10 18:55:30 +00:00
Stanca Serban be900c093d Backed out changeset f737edc6cd59 (bug 1863022) for causing mochitests failures in browser_protectionsUI.js. CLOSED TREE 2024-01-10 01:49:46 +02:00
Emily McMinn 4603bdaaf5 Bug 1863022 - Render message from browser-siteProtections.js, replace messaging system telemetry, and migrate strings r=pdahiya,omc-reviewers,pbz,fluent-reviewers,flod
The protections panel message should show once when the panel is first opened; after that it will be collapsed by default and can be shown again by clicking the "info" button on the panel

Messaging system previously sent the following pings on message show, and when the "learn more" link was clicked:

```
{“message_id”:“PROTECTIONS_PANEL_1",“event”:“IMPRESSION”,“addon_version”:“20231106094018",“locale”:“en-US”,“client_id”:“6fabd2de-3d0a-4b11-be4c-86b0ea1a1144",“browser_session_id”:“4b0f34b1-75ef-4704-907e-18d84e5187c3",“pingType”:“whats-new-panel”}
```
and

```
{“message_id”:“PROTECTIONS_PANEL_1",“event”:“CLICK”,“addon_version”:“20231106094018",“locale”:“en-US”,“client_id”:“6fabd2de-3d0a-4b11-be4c-86b0ea1a1144",“browser_session_id”:“4b0f34b1-75ef-4704-907e-18d84e5187c3",“pingType”:“whats-new-panel”}
```

This patch replaces these pings with 'RecordEvents' telemetry on the `protectionsPopup` object:

```
33153 	security.ui.protectionspopup 	open 	protectionspopup_cfr 	impression 	{"message": "PROTECTIONS_PANEL_1"}
```
and

```
34932 	security.ui.protectionspopup 	click 	protectionspopup_cfr
```

Differential Revision: https://phabricator.services.mozilla.com/D192968
2024-01-09 22:34:35 +00:00
Norisz Fay 0847da64fd Backed out 7 changesets (bug 1845150) for causing failures on browser_datachoices_notification.js CLOSED TREE
Backed out changeset a07c835a4bf7 (bug 1845150)
Backed out changeset 0016d7f4e556 (bug 1845150)
Backed out changeset 46cfe5fe6e6a (bug 1845150)
Backed out changeset 83190b8a08d0 (bug 1845150)
Backed out changeset ada948351267 (bug 1845150)
Backed out changeset 7aa4340bfd96 (bug 1845150)
Backed out changeset 683745289588 (bug 1845150)
2024-01-05 18:52:01 +02:00
Hanna Jones db6fb1fdda Bug 1845150 - Update notificationbox usage for search engine removal notification r=search-reviewers,fluent-reviewers,Standard8,bolsson
Notification can be triggered locally via this snippet:

```js
BrowserSearch.removalOfSearchEngineNotificationBox("Google", "Foogle")
```

Differential Revision: https://phabricator.services.mozilla.com/D194312
2024-01-05 15:04:19 +00:00