As js has different flags compared to the remaining parts of the
codebase, set a specific variable (namely MOZ_JS_OPTIMIZE_FLAGS) and use
it instead of MOZ_OPTIMIZE_FLAGS using a specific hook in
python/mozbuild/mozbuild/frontend/context.py
Also:
- harmonize moz_optimize_flags type to always return a list.
- moz_optimize now either returns "1" or None (no use case distinguishes
between returning 1 or 2)
Differential Revision: https://phabricator.services.mozilla.com/D216098
As js has different flags compared to the remaining parts of the
codebase, set a specific variable (namely MOZ_JS_OPTIMIZE_FLAGS) and use
it instead of MOZ_OPTIMIZE_FLAGS using a specific hook in
python/mozbuild/mozbuild/frontend/context.py
Also:
- harmonize moz_optimize_flags type to always return a list.
- moz_optimize now either returns "1" or None (no use case distinguishes
between returning 1 or 2)
Differential Revision: https://phabricator.services.mozilla.com/D216098
One notable change in this patch: a code path that checks for pre-existing distribution.ini and .desktop files.
If you place a distribution.ini or .desktop file in the root of any of the Linux .deb templates directories (paths specified in deb-templates and deb-l10n-templates), the supplied file will be used instead of generating or downloading a default file.
Differential Revision: https://phabricator.services.mozilla.com/D211141
Comma is the separator for values in options. Like in --with-foo=bar,baz.
This is meant to be useful for options with nargs="*", "+", or a fixed
value greater than 1.
Currently, when an option with another nargs is passed a comma, we
reject the value as being multiple values, while one or less is
expected. This causes problems with options with nargs=1 that actually
CAN have legitimate values containing commas. Examples include:
CFLAGS="-Wp,--preprocessor-flag -Wa,--assembler-flag"
LDFLAGS=-Wl,--linker-flag"
Since options with multiple arguments are the exception, not the norm,
let's allow commas in cases where at most a single argument is expected.
An alternative would be to explicitly disable comma-splitting on the set
of options that can take values containing commas, but that's error-prone.
Differential Revision: https://phabricator.services.mozilla.com/D217021
Instead, position MOZ_OPTIMIZE_FLAGS to -O3 under PGO on Linux.
This creates a dependency on PGO from toolchain.configure, break it by
splitting moz_optimize in two functions, one for the optimization status
and one for the optimization flags.
Differential Revision: https://phabricator.services.mozilla.com/D214843
This makes IMPORT_LIBRARY a full path, to match the change to
SHARED_LIBRARY so that the IMPORT_LIBRARY target can be found in
js/src/build/Makefile.in. Fixes regression in js standalone build 'make
install'.
Initial patch by Philip Chimento.
Differential Revision: https://phabricator.services.mozilla.com/D215992
For consistency with other Library classes, import_name should be the
"import" library name, while import_path is the full path.
Differential Revision: https://phabricator.services.mozilla.com/D216141
This makes IMPORT_LIBRARY a full path, to match the change to
SHARED_LIBRARY so that the IMPORT_LIBRARY target can be found in
js/src/build/Makefile.in. Fixes regression in js standalone build 'make
install'.
Initial patch by Philip Chimento.
Differential Revision: https://phabricator.services.mozilla.com/D215992
For consistency with other Library classes, import_name should be the
"import" library name, while import_path is the full path.
Differential Revision: https://phabricator.services.mozilla.com/D216141
Added one field:
- The `--target` of a build.
Re-added `python/mach/metrics.yaml` to `./mach doc mach-telemetry` generation (Not sure why it was missing).
Re-generated the associated docs. (It looks like this was not done for previously when other fields were added.
Differential Revision: https://phabricator.services.mozilla.com/D208811
Emilio Cobos Álvarez