Commit Graph
37 Commits
Author SHA1 Message Date
Tom Ritter 0ed035eea0 Bug 1633097: Revert IsOS MinGW hack-around r=firefox-build-system-reviewers,ahochheiden
Differential Revision: https://phabricator.services.mozilla.com/D169372
2023-02-15 19:01:55 +00:00
Mike Hommey 67709fcc39 Bug 1766359 - Fix unreachable-code-return warnings in Windows builds. r=emilio,mhowell,nika,rkraesig
dom/system/PathUtils.cpp(77,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
  return false;
         ^~~~~
ipc/chromium/src/chrome/common/ipc_channel_win.cc(479,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
  return true;
         ^~~~
mozglue/misc/PreXULSkeletonUI.cpp(1263,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
  return 0;
         ^
mozglue/tests/TestPEExportSection.cpp(348,12): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
    return 0;
           ^
security/manager/ssl/OSReauthenticator.cpp(428,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
  return NS_OK;
         ^~~~~
toolkit/components/maintenanceservice/maintenanceservice.cpp(214,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
  return 0;
         ^
widget/windows/WindowsUIUtils.cpp(383,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
  return false;
         ^~~~~

Differential Revision: https://phabricator.services.mozilla.com/D144661
2022-04-26 21:44:54 +00:00
Simon Giesecke 0fbb2d2c0a Bug 1660470 - Avoid including IPCMessageUtils.h from header files. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D93235

Depends on D93234
2020-11-23 16:03:47 +00:00
Simon Giesecke 46908cfb51 Bug 1660470 - Add missing include directives/forward declarations. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
R. Martinho Fernandes 100a79aa07 Bug 1574259 - Improve resource management in ReauthenticateUserWindows r=dmajor,mhowell
Differential Revision: https://phabricator.services.mozilla.com/D82393
2020-07-07 14:46:41 +00:00
Simon Giesecke a69d79b6db Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Jared Wein e2ab83e5b8 Bug 1636729 - Record in telemetry if power settings are configured to not prompt for OS password. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D74692
2020-05-30 06:54:16 +00:00
Jared Wein 8a6523f276 Bug 1636729 - Record in telemetry if the user has enabled the AutoAdminLogon feature. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D74670
2020-05-30 06:50:12 +00:00
Jared Wein d89e000476 Bug 1633090 - Cache the result of the empty password checks. r=cmartin
Differential Revision: https://phabricator.services.mozilla.com/D72426
2020-05-08 18:32:45 +00:00
Matthew Noorenberghe 4e60246cf6 Bug 1631879 - Workaround IsOS/OS_DOMAINMEMBER missing from mingw headers.
Differential Revision: https://phabricator.services.mozilla.com/D72510
2020-04-25 05:16:13 +00:00
Jared Wein 143ac8ecfb Bug 1631879 - Remove the domain portion of the username when testing for a blank password. r=MattN,cmartin
Differential Revision: https://phabricator.services.mozilla.com/D72425
2020-04-25 02:52:05 +00:00
Jared Wein 92a1e63856 Bug 1631879 - Remove unused 'save' variable. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D72424
2020-04-24 19:36:27 +00:00
Jared Wein 47de2333a4 Bug 1631879 - Only check for blank passwords if the OS is not on a domain. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D72423
2020-04-24 19:57:42 +00:00
Jared Wein 3663b385d1 Bug 1631879 - Use GetUserNameEx with NameSamCompatible to make sure that we are retrieving fully qualified usernames. r=MattN,cmartin
Importing security.h introduced namespace collisions so I removed the `using namespace mozilla;` and replaced it with specific names.

Differential Revision: https://phabricator.services.mozilla.com/D72422
2020-04-24 20:04:34 +00:00
Jared Wein f9315c0914 Bug 1631835 - Remove the limit of 3 attempts for authenticating with the OS account to allow for environments where more than three invalid auth attempts are allowed. r=MattN
One attempt will still be used by the blank password auth attempt. This does not completely fix the problem in this case but will allow a user to continue attempting until their account is locked out now.

Differential Revision: https://phabricator.services.mozilla.com/D71811
2020-04-21 19:32:18 +00:00
Jared Wein d799a3047d Bug 1629873 - Display login-related error messages in the Windows credential UI upon a failed authentication attempt. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D71701
2020-04-21 04:34:55 +00:00
Jared Wein 6b6309a013 Bug 1630991 - Add missing initialization of out parameter. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D71366
2020-04-17 16:51:19 +00:00
Jared Wein c6e8fba581 Bug 1623745 - Add a value to the pwmgr.reauthenticated telemetry event to specify if the user was able to authenticate without a password. r=MattN,spohl
Differential Revision: https://phabricator.services.mozilla.com/D70136
2020-04-16 21:33:24 +00:00
Jared Wein acc24c4246 Bug 1623695 - Change the asyncReauthenticateUser API to use wide strings to fix encoding issues with user-facing dialog strings. r=agashlin,spohl
Differential Revision: https://phabricator.services.mozilla.com/D67530
2020-03-20 18:56:40 +00:00
Jared Wein d786b7992b Bug 1622542 - Skip showing the credential UI for user accounts with a blank password. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D67242
2020-03-18 21:04:41 +00:00
Jared Wein 44d541fb0b Bug 1506602 - Show the full product name in the OS auth dialog. r=MattN,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D64521
2020-03-12 14:47:52 +00:00
Jared Wein 2f3ba91f71 Bug 1506602 - Associate the OS auth dialog with the parent window on Windows to center the dialog and prevent the user from interacting with the browser while the dialog is present. r=MattN,keeler
Differential Revision: https://phabricator.services.mozilla.com/D62348
2020-03-12 14:47:45 +00:00
Dorel Luca 71883bf92b Backed out 8 changesets (bug 1506602, bug 1194529) for Browser-chrome failures in browser/browser_aaa_eventTelemetry_run_first.js. CLOSED TREE
Backed out changeset 0848e3945164 (bug 1506602)
Backed out changeset a8b80ec1830e (bug 1506602)
Backed out changeset e83a89eb5007 (bug 1194529)
Backed out changeset 7bf0a8463e53 (bug 1194529)
Backed out changeset 5b5cbd52e30f (bug 1194529)
Backed out changeset 55c38d92f65a (bug 1194529)
Backed out changeset 3242adb0ff8e (bug 1194529)
Backed out changeset c2f10d341da8 (bug 1194529)
2020-03-11 01:48:36 +02:00
Jared Wein dd5d8fa7a2 Bug 1506602 - Show the full product name in the OS auth dialog. r=MattN,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D64521
2020-03-10 20:01:40 +00:00
Jared Wein e66f11abb2 Bug 1506602 - Associate the OS auth dialog with the parent window on Windows to center the dialog and prevent the user from interacting with the browser while the dialog is present. r=MattN,keeler
Differential Revision: https://phabricator.services.mozilla.com/D62348
2020-03-10 20:01:33 +00:00
Emilio Cobos Álvarez 118c790577 Bug 1602317 - Add a missing include in OSReauthenticator to unbust win builds. a=malexandru
CLOSED TREE

MANUAL PUSH: build bustage
2019-12-09 14:19:26 +01:00
Aaron Klotz 18a8732bb4 Bug 1578786: Fix up some includes and namespaces in security/manager/ssl so that it may compile in non-unified mode; r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D44700
2019-09-04 18:35:50 +00:00
Dana Keeler 1cba55883e bug 1555854 - avoid creating transient threads in PSM (particularly CryptoTask) r=KevinJacobs
CryptoTask is a helper class that makes it easier to implement code that runs on
a background thread and then notifies completion on the main thread (this is
useful for not blocking the main thread with long-running cryptography or I/O).
Before this patch, each CryptoTask would create a new thread each time it ran,
which was inefficient. This patch updates CryptoTask to use the stream transport
service (which is essentially a pool of threads for doing exactly these kinds of
things and notably is not to be confused with the socket transport service) to
run each task. Additionally, there were a few places in PSM where we
unnecessarily created new threads to perform similar tasks. These now use the
stream transport service as well.

Differential Revision: https://phabricator.services.mozilla.com/D33534
2019-06-03 23:47:48 +00:00
Nathan Froyd 78d1c4c954 Bug 1542347 - eliminate needless string flattening in OSReauthenticator; r=keeler
We already have a null-terminated `nsString` in this code; we don't need
to turn it into another null-terminated `nsString`.

Depends on D26355

Differential Revision: https://phabricator.services.mozilla.com/D26356
2019-04-08 16:26:10 +00:00
Ehsan Akhgari 498e2df734 Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
# ignore-this-changeset
2019-01-18 10:16:18 +01:00
Franziskus Kiefer 9586bb0d03 Bug 1508936 - Fix conversion to wide characters in OSReauthenticator r=keeler,mhowell
Fix conversion to wide characters in OSReauthenticator

Differential Revision: https://phabricator.services.mozilla.com/D12727
2019-01-15 01:21:00 +00:00
Sylvestre Ledru e5a134f73a Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset
2018-11-30 11:46:48 +01:00
J.C. Jones 07e42ca3ae Bug 1505106 - Support TouchID/FaceID for Reauthentication r=spohl
In Bug 1499846 we added support for OSX to do Keychain-based reauthentication.
On newer versions of OSX, it's possible to instead do TouchID/FaceID for bio-
metric reauthentication, with a fallback to Keychain.

This implements that functionality. There's no C++ interface to access the
LocalAuthentication framework, so it adds an Objective-C method called by the
existing OSReauthenticator methods to perform its work.

Differential Revision: https://phabricator.services.mozilla.com/D11700
2018-11-28 18:35:02 +00:00
Franziskus Kiefer 1f767ea337 Bug 1505197 - allow the user to retry reauthentication on Windows 2 times r=keeler
This adds a hard coded number of retries for Windos re-auth.
I also changed to always return NS_OK unless a real error occurred to make this behave like the macOS version.

Differential Revision: https://phabricator.services.mozilla.com/D11438
2018-11-14 09:07:20 +00:00
David Keeler 5cbccbe8e5 bug 1499846 - implement user reauthentication on MacOS r=franziskus,spohl
Differential Revision: https://phabricator.services.mozilla.com/D9025
2018-10-25 00:24:04 +00:00
Franziskus Kiefer ac7f1869e1 Bug 1498518 - user authentication prompts for Windows, r=keeler,mhowell
Depends on D8480

Differential Revision: https://phabricator.services.mozilla.com/D8530
2018-10-23 09:05:07 +00:00
Dana Keeler 0ff71db879 bug 1498351 - add interface to allow OS-specific user re-authentication r=franziskus
This patch introduces the interface with a stub implementation that does
nothing. Follow-up bugs will add platform-specific implementations.

Differential Revision: https://phabricator.services.mozilla.com/D8480
2018-10-16 16:06:30 +00:00