Commit Graph
33 Commits
Author SHA1 Message Date
serge-sans-paille a5bc7d11e9 Bug 1820573 - Make security/ buildable outside of a unified build environment r=andi,keeler
Differential Revision: https://phabricator.services.mozilla.com/D171732
2023-03-15 07:30:36 +00:00
Aaron Klotz 18a8732bb4 Bug 1578786: Fix up some includes and namespaces in security/manager/ssl so that it may compile in non-unified mode; r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D44700
2019-09-04 18:35:50 +00:00
Sylvestre Ledru e5a134f73a Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset
2018-11-30 11:46:48 +01:00
David Keeler 4b5f5a04c3 bug 1466942 - avoid l10n string bundles in nsNSSComponent initialization r=fkiefer
Before this patch, nsNSSComponent initialization would call PK11_ConfigurePKCS11
with some localized strings, which contributed to startup time. Also,
PK11_UnconfigurePKCS11 was never called, so the memory allocated to these
strings would stick around forever. This patch addresses both of these problems
by not calling PK11_ConfigurePKCS11. This means that some properties of NSS'
internal "PKCS#11 slots/tokens" have to be localized when displaying them to the
user.

MozReview-Commit-ID: BbAgbgpFfFG
2018-06-04 17:07:06 -07:00
David Keeler 59a43893cf bug 1465976 - remove all find*ByName APIs from PSM PKCS#11 module/slot/token interfaces r=fkiefer,jcj
Before this patch, we exposed a few interfaces that revolved around mapping a
name to a specific PKCS#11 module, slot, or token. These APIs were all either
problematic and/or unnecessary. In theory there could be two tokens in different
modules with the same name, so nsIPK11TokenDB.findTokenByName wasn't guaranteed
to return what the consumer expected it to. In general, these APIs were used by
front-end code to go from a handle on the specific object in question to a
string identifier and then back to a handle on the object. This was unnecessary
- we can just retain the original handle.

MozReview-Commit-ID: IbqLbV4wceA
2018-05-31 14:46:06 -07:00
Felipe Gomes e06c365132 Bug 1429148 - Add nsIPK11Token.isInternalKeyToken. r=keeler,MattN
MozReview-Commit-ID: Gdd7MxDXoTC
2018-02-20 20:43:41 -03:00
David Keeler f592ab3550 bug 1421084 - part 3/4 - remove nsNSSShutDownObject::shutdown and virtualDestroyNSSReference r=mt,ttaubert
MozReview-Commit-ID: ErL7ZjAGVVC
2018-01-24 14:29:08 -08:00
David Keeler 96fbe77852 bug 1421084 - part 2/4 - remove nsNSSShutDownObject::isAlreadyShutDown() r=mt,ttaubert
MozReview-Commit-ID: DlS16pHE0Ik
2018-01-23 12:22:56 -08:00
David Keeler ef94d8cd22 bug 1421084 - part 1/4 - remove now-unnecessary nsNSSShutDownPreventionLock r=mt,ttaubert
As of bug 1417680, the NSS shutdown tracking infrastructure is unnecessary (and
does nothing anyway). This series of changesets removes the remaining pieces in
a way that is hopefully easy to confirm is correct.

MozReview-Commit-ID: 8Y5wpsyNlGc
2018-01-23 10:37:47 -08:00
David Keeler efa6fe7b8e bug 1393143 - remove a few unused attributes and methods on PKCS#11 interfaces r=Cykesiopka
MozReview-Commit-ID: FKO6G6ZKjAZ
2017-08-17 16:11:57 -07:00
David Keeler 2d3e064e23 bug 1389664 - centralize on-demand empty pin initialization of the user's NSS database r=Cykesiopka,jcj
The sqlite-backed NSS database implementation requires explicitly setting some
kind of pin (password, really). To maintain behavior compatibility with the old
database implementation, we set the pin to the empty string as necessary.
Previously this would only happen on Android (NSS_DISABLE_DBM builds), but
because we're moving towards using the sqlite-backed implementation on all
platforms, we should enable this code everywhere and move it to a more central
location.

This also fixes some now-unnecessary test behavior.

MozReview-Commit-ID: KKtxmvOZt78
2017-07-18 15:05:58 -07:00
David Keeler 8dc61a62d7 bug 1372656 - load loadable roots on a background thread r=Cykesiopka,jcj
In a profile, loading the loadable roots PKCS#11 module (i.e. the built-in root
CA module) accounted for about 60% of the time to initialize PSM/NSS. Since we
only need the roots module loaded when we're actually looking for an issuing
certificate or querying a certificate's trust, we can do the load
asynchronously (where it hopefully finishes before we actually need it, because
otherwise we'll have to wait anyway).

MozReview-Commit-ID: JyY6NtpQAUj
2017-06-08 16:10:00 -07:00
Cykesiopka c68aa5712d Bug 1358183 - Remove some unused PSM IDL constants and functions. r=keeler
MozReview-Commit-ID: C8EGosXvTQL
2017-05-04 00:06:43 +08:00
David Keeler 64dca01f31 bug 1328456 - disallow empty token names for nsIPK11TokenDB.findTokenByName r=Cykesiopka
MozReview-Commit-ID: 5SBxAUjX579
2017-01-03 16:23:39 -08:00
David Keeler cc632437a5 bug 1324071 - add nsIPK11Token.hasPassword to replace unnecessary uses of nsIPKCS11Slot.status r=Cykesiopka,gps,MattN,sebastian
MozReview-Commit-ID: C2jwQHPEDC0
2016-12-02 15:09:35 -08:00
Cykesiopka f8939a2915 Bug 1305930 - Stop using PL_strnlen() in PSM.
strnlen() is available on all the platforms we care about, so we should use that
instead.

MozReview-Commit-ID: H3ac5AHiRJk
2016-10-05 00:32:23 +08:00
Cykesiopka 37b83df006 Bug 1304587 - Avoid using types that correspond to char/char16_t strings in PKCS #11 IDL files. r=keeler
Typically, the interfaces involved don't need to use raw char/char16_t strings,
and hence can benefit from the additional safety of using the Mozilla string
classes.

In some places, this patch also changes some UTF-16 APIs to UTF-8 where the
implementations can never actually support UTF-16. This reduces the amount of
code and runtime conversion.

MozReview-Commit-ID: y8o5wLBohe
2016-10-01 00:46:13 +08:00
Ryan VanderMeulen 65e0550627 Merge m-c to inbound. a=merge 2016-08-24 09:09:05 -04:00
Cykesiopka 93dcea2866 Bug 1296316 - Convert nsNSSShutDownObject::CalledFromType to an enum class. r=mgoodwin
enum classes are in general safer than plain enums, and as such should be
preferred.

MozReview-Commit-ID: 1FK89SNhdk4
2016-08-20 23:00:19 +08:00
Kan-Ru Chen a9b19d0584 Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
The patch is generated from following command:

  rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,

MozReview-Commit-ID: AtLcWApZfES
2016-08-24 14:47:04 +08:00
Cykesiopka e82de86c37 Bug 1271501 - Use mozilla::BitwiseCast instead of reinterpret_cast in PSM. r=keeler
mozilla::BitwiseCast does the same thing, but provides static asserts that
mitigate some of the risk of using reinterpret_cast.

MozReview-Commit-ID: ENQ8QC6Nl9o
2016-05-18 21:20:56 -07:00
Cykesiopka 0a6b81c9b1 Bug 1251801 - Ensure arguments of all public methods are checked. r=keeler
MozReview-Commit-ID: 1UQ4thOmUGb
2016-03-29 18:14:29 -07:00
Cykesiopka 7399315227 Bug 1251801 - Improve handling of PK11_* function error codes. r=keeler
MozReview-Commit-ID: 18acVVAuapm
2016-03-29 18:14:29 -07:00
Cykesiopka 6c40df0ef3 Bug 1251801 - Fully implement nsNSSShutDownObject and obviate manual NSS resource management. r=keeler
MozReview-Commit-ID: A7a9TVikRPh
2016-03-29 18:14:28 -07:00
sajitk 35d9982d18 Bug 1219482: Replace PRLogModuleInfo with LazyLogModule in security subdirectory.r=nfroyd 2016-01-28 10:36:00 -08:00
Cykesiopka 82ce8f993d Bug 1220237 - Remove uses of nsIEnumerator from PSM. r=keeler
MozReview-Commit-ID: 3FhBCqnJz4n
2016-02-24 17:42:45 -08:00
Wes Kocher 8f36d57440 Backed out changeset 7ec471c99263 (bug 1219482) to hopefully fix the intermittent hazard failures CLOSED TREE 2016-01-29 10:15:34 -08:00
sajitk 942a08ea8b Bug 1219482 - Replace PRLogModuleInfo with LazyLogModule in security subdirectory. r=froydnj 2016-01-28 10:36:00 -05:00
Birunthan Mohanathas d382a21947 Bug 1217320 - Remove more XPIDL signature comments in .cpp files. r=froydnj
Comment-only, DONTBUILD.
2015-10-27 06:54:25 +02:00
David Keeler c0de9ffccb bug 1215690 - remove nsPSMUITracker r=Cykesiopka r=mgoodwin
nsPSMUITracker was problematic. Apparently it was originally intended to prevent
NSS shutdown while NSS-related UI operations were going on (such as choosing a
client certificate). However, when nsNSSComponent would receive the event that
told it to shutdown NSS, it would attempt to call
mShutdownObjectList->evaporateAllNSSResources(), which would call
mActivityState.restrictActivityToCurrentThread(), which failed if such a UI
operation was in progress. This actually prevented the important part of
evaporateAllNSSResources, which is the releasing of all NSS objects in use by
PSM objects. Importantly, nsNSSComponent didn't check for or handle this failure
and proceeded to call NSS_Shutdown(), leaving PSM in an inconsistent state where
it thought it was okay to keep using the NSS objects it had when in fact it
wasn't.
In any case, nsPSMUITracker isn't really necessary as long as we have the
nsNSSShutDownPreventionLock mechanism, which mostly works and is what we should
use instead (or not at all, if no such lock is needed for the operation being
performed (for example, if no NSS functions are being called)).
2015-10-16 14:31:57 -07:00
Nathan Froyd b479538bca Bug 1193021 - clean up reference-counting in security/; r=keeler 2015-07-01 13:10:53 -04:00
Birunthan Mohanathas a0f7c73250 Bug 1191100 - Remove XPIDL signature comments in .cpp files. r=ehsan
Comment-only so DONTBUILD.
2015-08-04 16:17:36 -07:00
Birunthan Mohanathas 0988fd7527 Bug 1164714 - Flatten security/manager/ssl/src/ directory. r=keeler 2015-05-26 10:31:23 -07:00