Commit Graph
93 Commits
Author SHA1 Message Date
Lingqi Chi ff28b6b1b9 Bug 1916291 [wpt PR 47928] - [text-box-trim] add test for before and after pseudo elements, a=testonly
Automatic update from web-platform-tests
[text-box-trim] add test for before and after pseudo elements

Bug: 40254880
Change-Id: I797294696cace0236997f45cacddc3ac967d198c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5815191
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1349916}

--

wpt-commits: f89ace04e2fa1df68126ffbb48582c591c5908b0
wpt-pr: 47928
2024-09-04 07:51:55 +00:00
Sam Weinig 4d3a131c56 Bug 1915913 [wpt PR 47895] - WebKit export: [Part 1] All numeric CSSPrimitiveValue resolvers need to take CSSToLengthConversionData, a=testonly
Automatic update from web-platform-tests
WebKit export: [Part 1] All numeric CSSPrimitiveValue resolvers need to take CSSToLengthConversionData (#47895)

https://bugs.webkit.org/show_bug.cgi?id=278547
--

wpt-commits: 71e44fec2083609f590e92ecdac82b4e9e4ed519
wpt-pr: 47895
2024-08-31 08:44:57 +00:00
Koji Ishii 89d9155b55 Bug 1914208 [wpt PR 47715] - [text-box-trim] Fix text-box-trim-height-002, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Fix text-box-trim-height-002

This patch fixes the text-box-trim-height-002 test added in
<https://github.com/web-platform-tests/wpt/pull/47606>.

The test assumes that a line box taller than its container
with `align-content: end` aligns the block-end of the line box
to the block-end of the container.

All 3 engines align the block-start side of such line box and
its container. This patch fixes the test to match the behavior.

Bug: 359926563
Change-Id: I17c726ce38394b37d87cc94a992fcfbb69f08a62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5803518
Reviewed-by: Lingqi Chi <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Commit-Queue: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1344791}

--

wpt-commits: e6e8541bc7c77d7a469059e3630cc13c513ddd31
wpt-pr: 47715
2024-08-22 07:52:39 +00:00
Koji Ishii 4f0265e142 Bug 1914136 [wpt PR 47709] - [text-box-trim] Fix wpt tests, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Fix wpt tests

This patch fixes tests for the `text-box-trim` and
`text-box-edge` properties that started to fail since the
wpt PR [1].

The PR also adds some new tests. They will be investigated
separately.

[1] https://github.com/web-platform-tests/wpt/pull/47606

Fixed: 359926563
Change-Id: I3e3ef01b22dc828b74f5088511d32eaf680f9dbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5796255
Commit-Queue: Kent Tamura <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1344665}

--

wpt-commits: e1462ff2ec72e0a7595626a85624076a2eeeeb51
wpt-pr: 47709
2024-08-22 07:52:35 +00:00
Tim Nguyen 824dba0697 Bug 1913394 [wpt PR 47630] - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=278184, a=testonly
Automatic update from web-platform-tests
WebKit export: [text-box] Fix serialization of text-box shorthand (#47630)

https://bugs.webkit.org/show_bug.cgi?id=278184
--

wpt-commits: 3276bb3322a5061c4931f52fcf4641442f2bf070
wpt-pr: 47630
2024-08-20 08:23:06 +00:00
fantasai 46ddf68b0a Bug 1913498 [wpt PR 47646] - [css-inline-3] Rename file to match imports (fix typo), a=testonly
Automatic update from web-platform-tests
[css-inline-3] Rename file to match imports (fix typo)

--

wpt-commits: 600d084a5d6f0da260539d8374440f7c2348f217
wpt-pr: 47646
2024-08-20 08:23:00 +00:00
Tim Nguyen bf82bad679 Bug 1913380 [wpt PR 47626] - [css-inline] Fix text_invalid_value typo, a=testonly
Automatic update from web-platform-tests
[css-inline] Fix `text_invalid_value` typo in text-box tests (#47626)

--

wpt-commits: 1597db5641eb6a8c2a11adc5fdc358e5e4f4f785
wpt-pr: 47626
2024-08-20 08:22:18 +00:00
fantasai c0fcc82d5d Bug 1913342 [wpt PR 47617] - [css-inline-3] Fix typo, a=testonly
Automatic update from web-platform-tests
[css-inline-3] Fix typo

--

wpt-commits: 053a9a2f4393081cbed7c14899d64cd019f06c69
wpt-pr: 47617
2024-08-20 08:22:13 +00:00
fantasai e7c5d35415 Bug 1913220 [wpt PR 47606] - [css-inline-3] Update and improve text-box* test suite, a=testonly
Automatic update from web-platform-tests
[css-inline-3] Update and improve text-box* test suite

* update to latest spec changes
* add coverage
* improve metadata
* consolidate font declarations to reduce noise

--

wpt-commits: b4c7a25ce851095e165dd327428ad1dc2554d1db
wpt-pr: 47606
2024-08-16 08:11:28 +00:00
fantasai db59109d43 Bug 1913192 [wpt PR 47604] - [css-inline-3] Test parsing of new text-box* syntax, a=testonly
Automatic update from web-platform-tests
[css-inline-3] Expand tests for text-box* parsing and computation

--

wpt-commits: d85c6acff29191d2cefb65abd2cb3aa8c59b4ca0
wpt-pr: 47604
2024-08-16 08:11:25 +00:00
Koji Ishii 63e3de12d0 Bug 1913122 [wpt PR 47599] - [text-box-trim] Add text-box shorthand, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Add `text-box` shorthand

As per the resolution at:
https://github.com/w3c/csswg-drafts/issues/10675#issuecomment-2274517610
and the new spec at:
https://drafts.csswg.org/css-inline-3/#propdef-text-box

Bug: 358204934, 40254880
Change-Id: I641340e92855267627dbed6628b2df50c4608cec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5776351
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1341553}

--

wpt-commits: b38816e5fdb12c0e2a7f5c98fe37905a59bbbd0a
wpt-pr: 47599
2024-08-16 08:11:20 +00:00
Koji Ishii 1306a7204d Bug 1913041 [wpt PR 47598] - [text-box-trim] Rename text-box-edge values, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Rename `text-box-edge` values

This patch renames `text-box-edge` values from:
```
  text-box-edge: leading | <text-edge>
```
to:
```
  text-box-edge: auto | <text-edge>
```

Note the `<text-edge>` definition is unchanged.
```
  <text-edge> = [ text | cap | ex ] [ text | alphabetic ]?
```

as per the resolution at:
https://github.com/w3c/csswg-drafts/issues/10675#issuecomment-2274517610
and the new spec at:
https://drafts.csswg.org/css-inline-3/#propdef-text-box-edge

As per the new spec, the new `auto` value is identical to
`text` when the `line-fit-edge` property is initial.

The functionality the `leading` value provided is removed.

Bug: 358204934, 40254880
Change-Id: I738058cc79b5525b2cbb151b5765f65363b44e7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5776349
Reviewed-by: Lingqi Chi <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1341434}

--

wpt-commits: 277b9cb6fd5ba4dc0c41afa30410960b38a9fab8
wpt-pr: 47598
2024-08-16 08:11:18 +00:00
Koji Ishii 286a6dc9bb Bug 1913025 [wpt PR 47595] - [text-box-trim] Rename text-box-trim values, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Rename `text-box-trim` values

This patch renames `text-box-trim` values from:
```
  text-box-trim: none | start | end | both
```
to:
```
  text-box-trim: none | trim-start | trim-end | trim-both
```

as per the resolution at:
https://github.com/w3c/csswg-drafts/issues/10675#issuecomment-2274517610
and the new spec at:
https://drafts.csswg.org/css-inline-3/#propdef-text-box-trim

There is no functionality changes other than the renaming.

Bug: 358204934, 40254880
Change-Id: I5370cac4cfb44d3d4e399cb507e163d3a75a0194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5779079
Commit-Queue: Kent Tamura <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1341342}

--

wpt-commits: 2e6b59c7cb6c5ca476586f5f96840a170697c809
wpt-pr: 47595
2024-08-16 08:11:15 +00:00
Lingqi Chi c7cf02901d Bug 1906031 [wpt PR 46975] - text-box-trim: add tests for text-emphasis + ruby, a=testonly
Automatic update from web-platform-tests
text-box-trim: add tests for text-emphasis + ruby

Both of the annotations should be trimmed when text-box-trim is set.

Bug: 40254880
Change-Id: Ie0f05ad292e0e76f633a3862c826545f509f1797
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5671194
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1322584}

--

wpt-commits: 313fd03a0bd414fe8bde4773e3a318622823a43f
wpt-pr: 46975
2024-07-11 07:59:37 +00:00
Lingqi Chi 146a98aa0f Bug 1905837 [wpt PR 46959] - text-box-trim: add tests for text-emphasis, a=testonly
Automatic update from web-platform-tests
text-box-trim: add tests for text-emphasis

Bug: 40254880
Change-Id: I5dcc6bf1c91c66aa4dd1f3e5a8ea5a1719341454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5632630
Commit-Queue: Lingqi Chi <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1322012}

--

wpt-commits: 6054ee68f94b09548e4b8287cb7fac54b1f30617
wpt-pr: 46959
2024-07-11 07:59:26 +00:00
Jonathan Kew a46fca66c1 Bug 1901624 - Land the testcase here as a crashtest. r=dholbert
No code change here; the underlying cause of the issue is being fixed in bug 1902974.

Differential Revision: https://phabricator.services.mozilla.com/D213815
2024-06-17 12:32:00 +00:00
Koji Ishii 2c0b71639e Bug 1901654 [wpt PR 46683] - [text-box-trim] Add tests for height and min-height, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Add tests for `height` and `min-height`

This patch adds tests for the `height` and `min-height`
properties are effective for a box that is trimmed by the
`text-box-trim` property.

This patch has no behavior changes.

Bug: 40254880
Change-Id: Idf9493c0990ea5b91b95729064901ed3d4f3bcc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5612952
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1313092}

--

wpt-commits: 55e466472e80124a3416d6c01731c67b1cb89167
wpt-pr: 46683
2024-06-14 07:17:06 +00:00
Koji Ishii 4dea3f03ac Bug 1901481 [wpt PR 46667] - Fix to re-run CollectInlines when turning on/off initial-letter, a=testonly
Automatic update from web-platform-tests
Fix to re-run `CollectInlines` when turning on/off `initial-letter`

The `initial-letter` creates a special `InlineItem` with the
`kInitialLetter` type in the parent IFC. This patch fixes to
re-run `CollectInlines` for the parent IFC when it's turned
on or off.

Fixed: 342802976
Change-Id: If1ef00fb74c961bb065a4df8d5e8c9ad48860711
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5612813
Commit-Queue: Kent Tamura <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312632}

--

wpt-commits: 099a3a1ec8808bd60165b41c741eebdaa937942c
wpt-pr: 46667
2024-06-14 07:16:57 +00:00
Koji Ishii d61a5b895e Bug 1901201 [wpt PR 46652] - [text-box-trim] Fix when line-clamp is applied, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Fix when `line-clamp` is applied

This patch fixes the `text-box-trim` behavior when
`line-clamp` or `-webkit-line-clamp` is applied.

All changes are under a runtime flag enabled only for testing.

Bug: 40254880
Change-Id: Ib8ead4e083b727a3be3c6b36ae5cc42f85ba01f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5606785
Auto-Submit: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1311806}

--

wpt-commits: 921085c5e8d1ac91e60d2d46791d71ae2d247dfd
wpt-pr: 46652
2024-06-12 06:41:27 +00:00
Koji Ishii 32767c6961 Bug 1900480 [wpt PR 46604] - [text-box-trim] Test hit-testing, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Test hit-testing

This patch adds tests for `getBoundingClientRect()` and
`elementFromPoint()`, two CSSOM View functions that represent
the logic for hit-testing.

This patch has no behavior changes.

Bug: 40254880
Change-Id: I2d416b042ed278a339daeabfe3c8702b020c458d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5587766
Commit-Queue: Kent Tamura <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1309621}

--

wpt-commits: 060cd155991666227d7b314c5919158e54a1c06d
wpt-pr: 46604
2024-06-07 07:38:49 +00:00
Koji Ishii 8da04c7c01 Bug 1900311 [wpt PR 46585] - [text-box-trim] Fix end for block-in-inline, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Fix end for block-in-inline

This patch fixes trimming the end for block-in-inline.

All changes are under a runtime flag enabled only for testing.

Bug: 40254880
Change-Id: Id711aa3f28b458a9594ba659b308a03cb381de1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5588017
Commit-Queue: Lingqi Chi <[email protected]>
Reviewed-by: Lingqi Chi <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1309228}

--

wpt-commits: 30374552aeb865ab70f691844aedd6534657f37c
wpt-pr: 46585
2024-06-05 09:01:30 +00:00
Koji Ishii ad7f063674 Bug 1900298 [wpt PR 46582] - [text-box-trim] Fix two block-in-inline in a row, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Fix two block-in-inline in a row

When the first formatted line is inside of a block-in-inline,
`IsBlockStartTrimmed` needs to be propagated from the block.

When normal inline follows, the propagation isn't necessary
because the algorithm checks `IsFirstFormattedLine()`, but the
issue appears when a block-in-inline follows it. The test for
followed by normal inline is in:
`text-box-trim-block-in-inline-start-001`.

Tests for end will be in following patches.

All changes are under a runtime flag enabled only for testing.

Bug: 40254880
Change-Id: I5f053d5999d98378ef4b39cacec2d6923aa1d8c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5591191
Reviewed-by: Lingqi Chi <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Commit-Queue: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1309185}

--

wpt-commits: edf44fecb0e82a320eb94acaed95189ec80ab87c
wpt-pr: 46582
2024-06-05 09:01:28 +00:00
Koji Ishii f04056006d Bug 1900267 [wpt PR 46578] - [text-box-trim] Add tests for atomic inlines, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Add tests for atomic inlines

This patch adds tests to ensure that the `text-box-trim`
property trims the line containing atomic inlines, but it
doesn't propagate into the atomic inline, and therefore the
lines inside of the atomic inline isn't trimmed.

This patch has no behavior changes.

Bug: 40254880
Change-Id: I7ffd34238a30f0178b4070dc23452e5e59c47fd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5588337
Auto-Submit: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1309110}

--

wpt-commits: b71de6ef028f53a4dfa3648533d1ed0ecf56bd1e
wpt-pr: 46578
2024-06-05 09:01:25 +00:00
Koji Ishii 042cc91c10 Bug 1899985 [wpt PR 46563] - [text-box-trim] Add tests for block-in-inline, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Add tests for block-in-inline

This patch adds tests for `text-box-trim: start` applying to
blocks in inline container.

This patch has no behavior changes.

Bug: 40254880
Change-Id: I7d9c1e3f60856b5b9002c608d4b0599f10cd765d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5587757
Reviewed-by: Lingqi Chi <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1308528}

--

wpt-commits: fe5bef8bac69c12f725912dff079c8c5ca301a9a
wpt-pr: 46563
2024-06-05 09:01:18 +00:00
Koji Ishii 4c988c3502 Bug 1899143 [wpt PR 46496] - [text-box-trim] Support when the last line is empty, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Support when the last line is empty

Normally, empty lines can exist only in an empty inline
formatting context. But there are some rare cases where empty
lines can exist in non-empty inline formatting context. When
such empty lines are at the end of the inline formatting
context, `RelayoutForTextBoxTrimEnd()` needs to let
`InlineLayoutAlgorithm` know whether the line is the last
non-empty line or not.

This patch adds `ShouldForceTextBoxTrimEnd()` to communicate
that information from `BlockLayoutAlgorithm` to
`InlineLayoutAlgorithm`.

Bug: 40254880
Change-Id: Ia440325c502db0dcc3c8f248cc3c7ec3588f7fd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5568835
Auto-Submit: Koji Ishii <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Reviewed-by: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1306386}

--

wpt-commits: 35aa590085d4d417d65d917f1df43a07146874c3
wpt-pr: 46496
2024-06-03 07:40:02 +00:00
Koji Ishii e516c77810 Bug 1899089 [wpt PR 46488] - [text-box-trim] Make ClearanceAfterLine() optional, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Make `ClearanceAfterLine()` optional

Following up crrev.com/c/5561849, this patch supports when
`ClearanceAfterLine()` exists but 0, by changing it to
`std::optional<LayoutUnit>`.

Bug: 40254880
Change-Id: I407d6cf418b3e4765881ef454ca7f38e5d66338e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5564483
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1306284}

--

wpt-commits: 1660c36f05f0f39d6add4f0e88f15a35847dfa92
wpt-pr: 46488
2024-06-03 07:39:54 +00:00
Koji Ishii fc5d2a935d Bug 1898670 [wpt PR 46470] - [text-box-trim] Add tests for multi-col, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Add tests for multi-col

The `text-box-trim` should apply only to the top of the first
fragment and the bottom of the last fragment, resolved at
https://github.com/w3c/csswg-drafts/issues/5335.

This patch adds tests for this, `001` for when the
`text-box-trim` is applied to the multicol container, and
`002` for when a box with `text-box-trim` is block fragmented
by ancestor multicol.

Bug: 40254880
Change-Id: Ice29f39cbef0c20284edd809942754176a395d23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5564105
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1305545}

--

wpt-commits: 592dc0a3df19c530baec9079edce72a2625b798e
wpt-pr: 46470
2024-06-03 07:39:37 +00:00
Koji Ishii b9bcc16c85 Bug 1898447 [wpt PR 46452] - [text-box-trim] Honor clearance with <br>, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Honor clearance with `<br>`

While `text-box-trim` can trim objects in a line box that
pushes following boxes down, `ClearanceAfterLine()` should be
still valid, because the clearance space isn't part of the
line box. This patch fixes it.

Changes are under a runtime flag enabled only for testing.

Bug: 40254880
Change-Id: Ifc1cdbfbe40adcd69a245c8e0594c41f57bc94b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5561849
Auto-Submit: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1304935}

--

wpt-commits: c1ec59cdb730955e1972d04f7b9621a778118646
wpt-pr: 46452
2024-05-30 07:56:44 +00:00
Koji Ishii 10b19e4df3 Bug 1898302 [wpt PR 46440] - [text-box-trim] Support invalidations, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Support invalidations

This patch adds the layout invalidations for the
`text-box-trim` and the `text-box-edge` properties.

Changes are under a runtime flag enabled only for testing.

Bug: 40254880
Change-Id: I56f1d1f0a7e9c6667937c90e94d7dfa91615771a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5552565
Reviewed-by: Lingqi Chi <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1304491}

--

wpt-commits: fbffd1d2a410c06bcf81fd488240b842526f71e7
wpt-pr: 46440
2024-05-30 07:56:26 +00:00
Koji Ishii 1f534324a9 Bug 1898201 [wpt PR 46431] - [text-box-trim] Test block-end with Ruby, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Test block-end with Ruby

This patch adds a test of the `text-box-trim` property for the
block-end behavior when a Ruby hangs to the block-end side.

The test and reference for the block-start added in
crrev.com/c/5539108 are updated to share the reference file.

Bug: 40254880
Change-Id: Ie068940eff74aab2eb4baa7588b37baaef59c590
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5553008
Commit-Queue: Koji Ishii <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Commit-Queue: Lingqi Chi <[email protected]>
Reviewed-by: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1304323}

--

wpt-commits: e7a9f83c6176839320eb67e4423599bf29d4492a
wpt-pr: 46431
2024-05-30 07:56:20 +00:00
Koji Ishii 4e07c5e153 Bug 1898200 [wpt PR 46430] - [text-box-trim] Test block-end with initial-letter, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Test block-end with initial-letter

This patch adds a test of the `text-box-trim` property for the
block-end behavior when an initial-letter hangs to the
block-end side.

The block-start side test was added at crrev.com/c/5540990.

Bug: 40254880
Change-Id: I6c71de66106aa3accf092c39b5b2717faf972f22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5552564
Commit-Queue: Lingqi Chi <[email protected]>
Reviewed-by: Lingqi Chi <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1304320}

--

wpt-commits: 0e122283465030b319a805fa77c52a8f9ee3eb55
wpt-pr: 46430
2024-05-30 07:56:18 +00:00
Koji Ishii 60faed552b Bug 1898189 [wpt PR 46427] - [text-box-trim] Test block-end accumulations, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Test block-end accumulations

This patch updates a test for when the element to trim has
different `text-box-edge` value from the `text-box-edge` value
of the element that has `text-box-trim`, the same condition as
crrev.com/c/5547563, but for block-end side.

Bug: 40254880
Change-Id: Ibaaadee9ef41319c78921b116ca2daae340c3492
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5553822
Auto-Submit: Koji Ishii <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1304304}

--

wpt-commits: 16e779dd4b54b9dc240084cea510132ae698efc7
wpt-pr: 46427
2024-05-30 07:56:16 +00:00
Koji Ishii f56834e691 Bug 1898034 [wpt PR 46408] - [text-box-trim] Add tests for block-end trimming, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Add tests for block-end trimming

This patch adds tests of the block-end trimming, for all
supported variants of `text-box-edge` and `writing-mode`.

Bug: 40254880
Change-Id: I35bb604e8367b63121fc7157ea784c95081fcc24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5553180
Commit-Queue: Kent Tamura <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1304197}

--

wpt-commits: 6d1a09aaab32d898ae10eddc593dce0348120e69
wpt-pr: 46408
2024-05-30 07:56:12 +00:00
Lingqi Chi 527b98c49a Bug 1897969 [wpt PR 46401] - [text-box-trim] fix the case where there are multiple inline nodes, a=testonly
Automatic update from web-platform-tests
[text-box-trim] fix the case where there are multiple inline nodes

IsBlockEndTrimmed should be used separately from IsTextBoxTrimApplied

Bug: 40254880
Change-Id: I62c53d504631684a1171bc072b218daf69992e45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5553237
Commit-Queue: Lingqi Chi <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1304163}

--

wpt-commits: 33dea5fedbbc01bb912a42afb8634e994eb31d44
wpt-pr: 46401
2024-05-30 07:56:11 +00:00
Lingqi Chi f47161cc78 Bug 1897888 [wpt PR 46395] - [text-box-trim] trim the last line, a=testonly
Automatic update from web-platform-tests
[text-box-trim] trim the last line

This CL implements the logic of changing the last non-empty node's size
of a block with text-box-trim:end/both specified.

Bug: 40254880
Change-Id: I19c70f69a549a2d5b5740e491f9190679e596f7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5553234
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1303658}

--

wpt-commits: 699a024b416e0c4a66dbba03df329bb055f55b31
wpt-pr: 46395
2024-05-23 10:01:36 +00:00
Koji Ishii cd5582a55c Bug 1897393 [wpt PR 46340] - [text-box-trim] Test accumulations, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Test accumulations

This patch adds a test for when the element to trim has
different `text-box-edge` value from the `text-box-edge` value
of the element that has `text-box-trim`. Discussed and
resolved at:
https://github.com/w3c/csswg-drafts/issues/5426

Bug: 40254880
Change-Id: I5685fbaebddb8c7429b3b041c5fe0f88b982fc3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5547563
Auto-Submit: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1303166}

--

wpt-commits: 5e6793faa62943090d88eca7fa6390219f06832d
wpt-pr: 46340
2024-05-23 10:01:13 +00:00
Koji Ishii 7398c60794 Bug 1897389 [wpt PR 46339] - [text-box-trim] Test when the line is taller than strut, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Test when the line is taller than strut

As the `text-box-trim` trims at the specified metrics of the
line box, objects taller than that are trimmed, by overflowing
to over and under side of the line box.

This test verifies only the block-start side, but can be
extended to the block-end side when it's implemented.

Bug: 40254880
Change-Id: I7be386cff8f46f58b164c01381253d1b2cbe034f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5547519
Reviewed-by: Kent Tamura <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1302464}

--

wpt-commits: 2119943ab8129f45dfd8639f4111886f51138f38
wpt-pr: 46339
2024-05-23 10:01:01 +00:00
Koji Ishii 4e94de9f6d Bug 1896889 [wpt PR 46283] - [text-box-trim] Support vertical flow, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Support vertical flow

In doing this, this patch adds the `FontBaseline` variations
of `Alphabetic()`, `CapHeight()`, and `XHeight()` in the
`FontMetrics` class.

Also, the rounding methods in `AdjustEdges()` were different
from what `FontMetrics::FixedAscent()` does. This patch adds
`Fixed` variants to `FontMetrics` to make reviewing the
consistency easier.

All changes are under a currently disabled runtime flag.

Bug: 40254880
Change-Id: I470f1df976ff210ee7c3cdb336b73f44a59909d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539097
Reviewed-by: Kent Tamura <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1301750}

--

wpt-commits: 044beefe2fe9706c899bd503c5953abf07546fc0
wpt-pr: 46283
2024-05-23 10:00:39 +00:00
Koji Ishii 0e8ea1672f Bug 1896812 [wpt PR 46277] - [text-box-trim] Fix when there is an initial-letter, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Fix when there is an initial-letter

`text-box-trim` is supposed to trim all parts above the point
specified by the `text-box-edge`. This patch fixes initial
letter boxes preventing the trimming, similar to
crrev.com/c/5539108 fixed for the Ruby annotation.

This patch has no behavior changes as the changes are under a
runtime flag.

Bug: 40254880
Change-Id: I7741f6a78e34371959d4ab3ca9cb8a5a9a2a8460
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540990
Auto-Submit: Koji Ishii <[email protected]>
Commit-Queue: Lingqi Chi <[email protected]>
Reviewed-by: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1301161}

--

wpt-commits: d11ce9e05714b062ad3b9cb4184e65763cdc2393
wpt-pr: 46277
2024-05-23 10:00:21 +00:00
Koji Ishii c8913abe3f Bug 1896811 [wpt PR 46276] - [text-box-trim] Fix when there is a Ruby annotation, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Fix when there is a Ruby annotation

`text-box-trim` is supposed to trim all parts above the point
specified by the `text-box-edge`. This patch fixes Ruby
annotation preventing the trimming.

This patch has no behavior changes as the changes are under a
runtime flag.

Bug: 40254880
Change-Id: I52f40bbba919beddad398c4400b5715b6e5f2fb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539108
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1301089}

--

wpt-commits: ed61cad1fd266b46dc25edd9656ba636b660e9cf
wpt-pr: 46276
2024-05-23 10:00:19 +00:00
Koji Ishii bce37e70a3 Bug 1896698 [wpt PR 46258] - [text-box-trim] Add a test for floats and BFC, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Add a test for floats and BFC

This patch adds a test for how a box with `text-box-trim`
resolves the BFC offset.

This patch has no behavior changes.

Bug: 40254880
Change-Id: I92f5b86d3ce07f612c52c7a76e5faa94010f5ed4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5537810
Reviewed-by: Lingqi Chi <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1301081}

--

wpt-commits: b5cfef8d1c4e75ccb4669b1cb38a3fe56a3ed942
wpt-pr: 46258
2024-05-23 10:00:17 +00:00
Koji Ishii fecf7ec52c Bug 1896342 [wpt PR 46223] - [text-box-trim] Use text-box-edge when trimming start, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Use `text-box-edge` when trimming start

This patch uses the `text-box-edge` property when trimming the
block start.

The vertical flow isn't fully supported yet.

Bug: 40254880
Change-Id: I4f51aa15ceb681ec3db1c8751c64e2425679a5a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5531306
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Reviewed-by: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1300556}

--

wpt-commits: 6e75d40942c5357d8d5e55a0f1f3f9b455fd4815
wpt-pr: 46223
2024-05-23 10:00:01 +00:00
Koji Ishii 205e17f087 Bug 1896554 [wpt PR 46245] - Reland "[text-box-trim] Fix text-box-edge to be inherited", a=testonly
Automatic update from web-platform-tests
Reland "[text-box-trim] Fix `text-box-edge` to be inherited"

This is a reland of commit 66b9710a5337aaefeb1a4e71ba5675b2a8744cb2

The original CL caused performance regressions at
crbug.com/339684347. This is likely because, as a result of
the change, a same explicit `field_group` had both inherited
and non-inherited as in comment 13 of the issue.

This patch changes the `field_group` to `*`, and add it to
`css_properties_ranking.json5`. As the feature hasn't shipped
yet, the ranking order is just a guesstimate.

Original change's description:
> [text-box-trim] Fix `text-box-edge` to be inherited
>
> As per the spec for:
> * `text-box-trim`: https://drafts.csswg.org/css-inline-3/#propdef-text-box-trim
> * `text-box-edge`: https://drafts.csswg.org/css-inline-3/#propdef-text-box-edge
>
> Bug: 41494590
> Change-Id: I934e272f964fce6f2c57818c94102046fc0f309a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5532122
> Commit-Queue: Koji Ishii <[email protected]>
> Commit-Queue: Kent Tamura <[email protected]>
> Auto-Submit: Koji Ishii <[email protected]>
> Reviewed-by: Kent Tamura <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1299895}

Bug: 41494590
Change-Id: Ia16086866b7b67f187495a3d1968b210abb2e956
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5531316
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1300538}

--

wpt-commits: 00c155959f0a01db082b1cce4de8b1fbbcc63563
wpt-pr: 46245
2024-05-23 09:59:58 +00:00
Koji Ishii f46da4bc7d Bug 1896498 [wpt PR 46234] - Revert "[text-box-trim] Fix text-box-edge to be inherited", a=testonly
Automatic update from web-platform-tests
Revert "[text-box-trim] Fix `text-box-edge` to be inherited"

This reverts commit 66b9710a5337aaefeb1a4e71ba5675b2a8744cb2.

Reason for revert: crbug.com/339684347

Original change's description:
> [text-box-trim] Fix `text-box-edge` to be inherited
>
> As per the spec for:
> * `text-box-trim`: https://drafts.csswg.org/css-inline-3/#propdef-text-box-trim
> * `text-box-edge`: https://drafts.csswg.org/css-inline-3/#propdef-text-box-edge
>
> Bug: 41494590
> Change-Id: I934e272f964fce6f2c57818c94102046fc0f309a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5532122
> Commit-Queue: Koji Ishii <[email protected]>
> Commit-Queue: Kent Tamura <[email protected]>
> Auto-Submit: Koji Ishii <[email protected]>
> Reviewed-by: Kent Tamura <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1299895}

Bug: 41494590, 339684347
Change-Id: I4768cd2ba204b147a8e9bd8ac5459393763c7d91
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5533288
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1300233}

--

wpt-commits: fd41fbc81f2c88f45721608aa7a97200ca402fa9
wpt-pr: 46234
2024-05-21 09:47:09 +00:00
Koji Ishii c43b8b5e87 Bug 1896321 [wpt PR 46221] - [text-box-trim] Fix text-box-edge to be inherited, a=testonly
Automatic update from web-platform-tests
[text-box-trim] Fix `text-box-edge` to be inherited

As per the spec for:
* `text-box-trim`: https://drafts.csswg.org/css-inline-3/#propdef-text-box-trim
* `text-box-edge`: https://drafts.csswg.org/css-inline-3/#propdef-text-box-edge

Bug: 41494590
Change-Id: I934e272f964fce6f2c57818c94102046fc0f309a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5532122
Commit-Queue: Koji Ishii <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1299895}

--

wpt-commits: f0aad9ad39c260c0ce1d8e3cdac5c759d12198e3
wpt-pr: 46221
2024-05-21 09:46:49 +00:00
Philip Jägenstedt 9f04a8f7ec Bug 1895287 [wpt PR 46096] - Map baseline-source tests to web-features, a=testonly
Automatic update from web-platform-tests
Map baseline-source tests to web-features (#46096)

--

wpt-commits: a61055a46fd9ff77718168c32f7437ed8c6f3111
wpt-pr: 46096
2024-05-14 07:21:37 +00:00
Lingqi Chi bdb96ad13a Bug 1885092 [wpt PR 45077] - text-box-trim: Handle the start side's inline box, a=testonly
Automatic update from web-platform-tests
text-box-trim: Handle the start side's inline box

0. Store the first non-empty inline box's edge in
   PhysicalLineBoxFragment, as intrinsic_metrics_, to allow block box
   to trim itself.
1. The first non-empty inline box will by be moved by the trimming
   unit

See the doc for more details.
https://docs.google.com/document/d/1eT0xEOrfVI3RhZ6goJLW1yOWHXLBq2tzAYrHe3NIiO8/edit#bookmark=id.pkbu9w2ipp14

Bug: 40254880
Change-Id: I0f127e078b4fc4c2bf477c16812dc060adc9c390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5367205
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1290487}

--

wpt-commits: 08d87adf61b7710ce0d7f8a5baae2ec6124d8788
wpt-pr: 45077
2024-04-25 13:28:48 +00:00
Lingqi Chi dce3d211cf Bug 1885083 [wpt PR 45076] - Reland "text-box-trim: remove inline box tests (tentatively)", a=testonly
Automatic update from web-platform-tests
Reland "text-box-trim: remove inline box tests (tentatively)"

This is a reland of commit b42e5ff036c53862314fd556281d3e6c601db784

text-box-trim-half-leading-block-box-001.html's reference file was
set to inline box's by mistake, and this reland fixes the issue.

Original change's description:
> text-box-trim: remove inline box tests (tentatively)
>
> The specification is not updated yet, and it is not that clear to us
> which edges could be cut in these cases.
> Since we do not plan to implement the text-line-edge? property for
> now, I'd like to remove these tests to avoid confusion.
>
> Bug: 40254880
> Change-Id: I08af3d3806e4e49a9e46de0f85271fb995259bbf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5360144
> Commit-Queue: Lingqi Chi <[email protected]>
> Reviewed-by: Koji Ishii <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1271417}

Bug: 40254880
Change-Id: Ie2c1821c37c838f81bccbe51c6d15864f8550462
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5366868
Commit-Queue: Lingqi Chi <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1273240}

--

wpt-commits: 309231a7f3e900d04914bc4963b016efd9989a00
wpt-pr: 45076
2024-03-18 10:35:33 +00:00
Lingqi Chi fe8ab7746d Bug 1876710 [wpt PR 44221] - [text-box-trim] add parser for text-box-edge, a=testonly
Automatic update from web-platform-tests
[text-box-trim] add parser for text-box-edge

The property is defined in
https://drafts.csswg.org/css-inline-3/#text-edges.

Now we're going to allow the following rule:
leading | [ text | cap | ex ] [ text | alphabetic ]?

ideographic and ideographic-ink are not implemented yet.

Bug: 41494590
Change-Id: I50a3111da0a8fd9f353494dfcca40e4836ba8520
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5237969
Commit-Queue: Lingqi Chi <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1265659}

--

wpt-commits: 88803cebf503aa02f759a63fcccff4a55b2888f7
wpt-pr: 44221
2024-03-01 20:10:33 +00:00
Philip Jägenstedt 6a5db228e8 Bug 1867051 [wpt PR 43390] - Map even more tests to web-features, a=testonly
Automatic update from web-platform-tests
Map even more tests to web-features (#43390)

The list of tests for nesting are from here:
https://github.com/web-platform-tests/interop/issues/420#issuecomment-1755268425
--

wpt-commits: 6495c91853a3cf028a401cf4d228fc0b6a5465e4
wpt-pr: 43390
2023-12-21 05:50:09 +00:00