Automatic update from web-platform-tests
RubyLB: Fix a crash by RTL + zero-available-width + break-spaces
LineBreaker should not produce an empty LineInfo for ruby-base.
Bug: 352467338
Change-Id: Ifaa9f300ef9fa22e7697896d8434506f50257dc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5759423
Commit-Queue: Kent Tamura <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1337535}
--
wpt-commits: 45ad9b4f4b03b3b69c3e8f5945b65e6ce8ae9fce
wpt-pr: 47457
Automatic update from web-platform-tests
RubyLB: Fix PaintLayer for annotations
If the ruby container for a ruby-text establishes a PaintLayer, it was
the owner layer of the ruby-text. However, a physical fragment for the
layer didn't contain physical fragments or fragment items for the
ruby-text.
This CL updates LayoutObject::PaintLayer() so that it skips inline
parents for a ruby-text.
Bug: 347597917
Change-Id: I568fc9caae6c3c9255ce7b01c65f99bb0b17a877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5633063
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1316295}
--
wpt-commits: 10dd725c7f37898c2be40cb6ed7ff55494b72b22
wpt-pr: 46806
Automatic update from web-platform-tests
RubyLB: Annotation positioning should refer to padding/border/margin
If a ruby-text box has non-zero block-axis padding/border/margin,
they should affect annotation positioning. The new behavior matches to
Firefox and Safari.
Bug: 345367386
Change-Id: Id4eebd9c79bcad03ec3374ecf470a3fb0146b1c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5624453
Reviewed-by: Koji Ishii <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1313855}
--
wpt-commits: 36d326c3f220b9bf08f9c26e87eef8c6c308b74f
wpt-pr: 46712
Automatic update from web-platform-tests
css-ruby: Reorganize a text-wrap test
* Move pretty/balance tests out from WPT. It's Chromium's
implementation limitation.
* Add a test file only for `nowrap`.
Change-Id: I372585dec7ba64658c64868f8d93f5ac291e797a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5599323
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1310426}
--
wpt-commits: 98092b7f7a30c79f67184698958e0f7d472a7909
wpt-pr: 46628
Automatic update from web-platform-tests
ruby-align: Implement the layout behavior
... and make the status "experimental".
The main logic is ApplyRubyAlign() in ruby_utils.cc. We already have
alignment logic. So this CL just adjusts it for ruby-align values.
* LineBreaker::AddRubyColumnResult() should set LineStyle to pass
<ruby>'s style.
* GetOverhang() should return an empty AnnotationOverhang instance
for ruby-align:space-between and an end-only instance for
ruby-align:start.
* Move out space-around tests from css-ruby/ruby-align-00*.html because
Firefox and Chrome have different justification opportunity counts
for "X X X".
Bug: 40249572
Change-Id: I78af66e853356301135dc03bd1ab82c1a0e6ca31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5595788
Reviewed-by: Koji Ishii <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1309784}
--
wpt-commits: 55b8d9e9a6ab75a494bcb9b4e5a2fba75060edc2
wpt-pr: 46613
Automatic update from web-platform-tests
RubyLB: Support breaking in HandleOverflow()
* The intrinsic inline-size of a ruby column fits in the available
space of the current line,
* There is no soft break opportunity at the end of the ruby column, and
* The following text exceeds the available space.
If the above conditions met, the entire ruby column was rewound though
it has soft break opportunities.
This CL supports breaking at the last soft break opportunity inside
the ruby column.
Bug: 324111880
Change-Id: Ia40ba37d552fae8f411834a7a1288a285cff9202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5569799
Commit-Queue: Koji Ishii <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1306306}
--
wpt-commits: dba739b1cd4d37ca8f4783ec43dceb3bb132e645
wpt-pr: 46491
Automatic update from web-platform-tests
RubyLB: Fix an issue with text-indent
A line with `text-indent` and <ruby> had a wrong wrapping position.
Sub-LineBreakers should not apply `text-indent` values.
Bug: 324111880
Change-Id: I84c778750805eb332c9ffc6cc26e416243bc099b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5553214
Auto-Submit: Kent Tamura <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1303656}
--
wpt-commits: b0bf123f83753aa51183dad38940eefb95998b72
wpt-pr: 46396
Automatic update from web-platform-tests
css-ruby: Update ruby-no-transform.html
... so that it fails even if <rtc> is not supported and `transform`
works for <rt>.
Change-Id: Ieb1f16ca8a11fd3560530fd7391e0b5b36ff3928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5550253
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1303209}
--
wpt-commits: b09972b8d8cb771bedba3f8e1ed559dc6b103c4b
wpt-pr: 46367
Automatic update from web-platform-tests
RubyLB: Make ruby columns breakable
If a ruby columns is not monolithic and its intrinsic inline size is
larger than line's available size, we try to break inside the ruby
column. We provide RubyBreakTokenData if it succeeds.
Bug: 324111880
Change-Id: Ib8692d8c05b93fa7791350413597425f7b64f2af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539116
Auto-Submit: Kent Tamura <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1302421}
--
wpt-commits: 75f1a348305b43bb835334f42478f42e627d5d87
wpt-pr: 46311
Automatic update from web-platform-tests
RubyLB: ::first-line style should not be applied to all rubies
Sub-LineBreakers always referred to InlineItems for ::first-line
incorrectly because the constructor for them don't have an
InlineBreakToken.
This CL fixes it by passing the parent LineBreaker through
SetInputRange(), then PrepareNextLine() updates items_data_.
Bug: 324111880
Change-Id: I1c19b727335fb1b636f731b58155789b60480c09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528710
Reviewed-by: Koji Ishii <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1299875}
--
wpt-commits: b9491b534cb1a6991c5afaf65fc4960e55c506b4
wpt-pr: 46220
Automatic update from web-platform-tests
RubyLB: position:relative outside of ruby-text should move it.
InlineLayoutStateStack::ApplyRelativePositioning() for annotation
lines should be applied after ApplyRelativePositioning() for the base
line.
* Call ApplyRelativePositioning() for the base line and annotation lines
almost same time, with passing ancestor relative offsets.
* Call CreateBoxFragments() for annotation lines just before
CreateBoxFragments() for the base line.
* Remove FinalizeAnnotationLines().
* Don't move InlineLayoutStateStack::ruby_column_list_ out. It's
necessary until CreateBoxFragments().
Bug: 324111880
Change-Id: I2cf66af6118ad52ffedf7579930bde25c794ca5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493166
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1298506}
--
wpt-commits: 6ca6cf86c9378bc6659febb8f1fc4185b1fdf757
wpt-pr: 46178
Automatic update from web-platform-tests
Layout: Fix incorrect annotation space computation for atomic-inlines
ComputeAnnotationOverflow() should take into account of atomic inline
boxes.
Bug: 336592423
Change-Id: Ia6343f13ecb59b44c26bc00f19476479013a34aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5480273
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1291724}
--
wpt-commits: 270b59561b55d2dd50345e92448fc2bcdb4cca5b
wpt-pr: 45865
Automatic update from web-platform-tests
[CSS display:ruby*] Don't fix position and float for <rt>
We have forced `position: static; float: none;` for <rt>. We don't need
it any longer. Changing these property values blockifies
`display: ruby-text`, and it won't work as ruby-text. The new behavior
is compatible with Firefox.
Bug: 880802
Change-Id: Iec2886c64f48f360258ef17a6885b047dfff3be8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5028779
Commit-Queue: Koji Ishii <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1224752}
--
wpt-commits: f6e86730951e1dac4377e0ad67342180df1ee29c
wpt-pr: 43162
Automatic update from web-platform-tests
[CSS display:ruby*] Don't fix position and float for <rt>
We have forced `position: static; float: none;` for <rt>. We don't need
it any longer. Changing these property values blockifies
`display: ruby-text`, and it won't work as ruby-text. The new behavior
is compatible with Firefox.
Bug: 880802
Change-Id: Iec2886c64f48f360258ef17a6885b047dfff3be8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5028779
Commit-Queue: Koji Ishii <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1224752}
--
wpt-commits: f6e86730951e1dac4377e0ad67342180df1ee29c
wpt-pr: 43162
Automatic update from web-platform-tests
rbc-rtc-basic-001.html test was missing a <link rel='match' href='' to its reference (#35365)
--
wpt-commits: 19d452e70a4ace1014d47c4eeb2d44ee88bb8218
wpt-pr: 35365
Automatic update from web-platform-tests
[css-ruby] Adding japanese .woff font resource into block-ruby-001 test and reference (#33271)
* Replaced japanese char. with latin char. in block-ruby-001
* Improved block-ruby-001 and added japanese .woff font
--
wpt-commits: e7c65660d5183d41a1c1330f9615f40dbe6f447e
wpt-pr: 33271
Automatic update from web-platform-tests
Creating a reliable ruby text pairing test and reference
--
wpt-commits: 0387de5dd1d67e2fa9c6c63d32d47ff17c11bb42
wpt-pr: 29535
Automatic update from web-platform-tests
Don't include BR clearance in the line's height.
Including clearance in the line height may result in tall monolithic
content, which is problematic for block fragmentation, especially for
column balancing.
Instead, store trailing clearance in the layout result, so that the
block layout algorithm can add it to the layout position for subsequent
content.
We already use a similar trick for ruby annotations, and some care is
required so that we don't move back above the clearance offset when
canceling ruby annotations overflow (which happens in some cases). There
was no test coverage for this, so added three tests for that (they pass
both and without this CL).
Also added a multicol test that demonstrates what this fixes in column
balancing.
Bug: 829028
Change-Id: I84e58326e9ada78e3f29ad01d8043a173626aea3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168645
Commit-Queue: Morten Stenshorne <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923502}
--
wpt-commits: faa9a85d068538c986ba01119789194f92f8d344
wpt-pr: 30876
Automatic update from web-platform-tests
Don't include BR clearance in the line's height.
Including clearance in the line height may result in tall monolithic
content, which is problematic for block fragmentation, especially for
column balancing.
Instead, store trailing clearance in the layout result, so that the
block layout algorithm can add it to the layout position for subsequent
content.
We already use a similar trick for ruby annotations, and some care is
required so that we don't move back above the clearance offset when
canceling ruby annotations overflow (which happens in some cases). There
was no test coverage for this, so added three tests for that (they pass
both and without this CL).
Also added a multicol test that demonstrates what this fixes in column
balancing.
Bug: 829028
Change-Id: I84e58326e9ada78e3f29ad01d8043a173626aea3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168645
Commit-Queue: Morten Stenshorne <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#923502}
--
wpt-commits: faa9a85d068538c986ba01119789194f92f8d344
wpt-pr: 30876
Automatic update from web-platform-tests
[css-ruby] Tweaked block-ruby-005 test and reference (#29841)
* Tweaked block-ruby-005 test and reference
* Improved, tweaked block-ruby-005 and its reference
--
wpt-commits: 4935b8010a8121913c30bad6460b31a8554d9090
wpt-pr: 29841
Automatic update from web-platform-tests
[css-ruby] Created basic test on rbc and rtc elements (#29840)
* Created basic test on rbc and rtc elements
* Removing useless, unneeded declarations
* Improving rbc-rtc-basic-001.html and its reference
--
wpt-commits: be2c5bd43833b03f515ebc0283512926195eac50
wpt-pr: 29840
Automatic update from web-platform-tests
[block-in-inline] Fix various ruby + floats issues.
Ruby had a few different issues (see new tests).
- A ruby annotation would "pull" down a float (test 001).
- A ruby annotation would intersect with floats (test 002,003).
This fixes these issues. Specifically we look at annotation overflow
to determining if a line will fix in a given layout opportunity, and
use the ruby block adjust to positioning floats.
Bug: 716930
Change-Id: I4a25fbd22a93647e7af54b654e786a8d3504ae4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3065855
Reviewed-by: Kent Tamura <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/master@{#912571}
--
wpt-commits: 139f569b206ec3b24351b0eb98f7a76c95c553cb
wpt-pr: 30044
Automatic update from web-platform-tests
[css-ruby] Basic improperly-contained-annotation test and 2 references (#29809)
* Created a basic improperly-contained-annotation test and 2 references
* Removing 1 reference, renaming the other
* Removed comment and tuned test and reference
--
wpt-commits: a668cd5a949a11c1039abfc7d2b1e4a9a48dc744
wpt-pr: 29809
Automatic update from web-platform-tests
Tweaked block-ruby-003 test and reference (#29843)
--
wpt-commits: 9650980b2c8e313a395be04c960346c8980bc83f
wpt-pr: 29843
Automatic update from web-platform-tests
Tweaked block-ruby-004 test and reference (#29842)
--
wpt-commits: c9625eb5cfc604191fec066e6ce217ab59b3c6ae
wpt-pr: 29842
Automatic update from web-platform-tests
RubyNG: A line shouldn't provide annotation space if it has text-emphasis
* A line has text-emphasis at the 'under' side, and the next line has
ruby at 'over' side, or
* A line has ruby at the 'under' side, and the next line has
text-emphasis at 'over' side
In these two cases, text-emphasis and ruby could be overlapped. This CL
fixes this issue.
Note:
- The legacy ruby also has this issue, but this CL doesn't fix it for
the legacy ruby.
- The FAIL line in external/wpt/css/css-ruby/line-spacing-expected.txt
is expected. We'll fix it soon.
Bug: 1069817
Change-Id: Ie2201d577c58a77000c7ace7a1f3de718866a989
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245991
Reviewed-by: Yoshifumi Inoue <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/master@{#778687}
--
wpt-commits: bfcaaa8a2261e974b1a162ddd4155984098e90ca
wpt-pr: 24161
Automatic update from web-platform-tests
css-ruby: Add a test for '3.5. Line Spacing'
Bug: crbug.com/1069817
Change-Id: Ie3b4bb52e9151939026df20e37459de596d78545
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217714
Commit-Queue: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#772573}
--
wpt-commits: 5389f61985bba1bee593247dbf01ce5d89048b3d
wpt-pr: 23817
Automatic update from web-platform-tests
[css-ruby] test parsing of the ruby-merge property (#23591)
See https://github.com/w3c/csswg-drafts/issues/5004
--
wpt-commits: 48950262c7bfde62ce876471f354b878b06958ce
wpt-pr: 23591
Kent Tamura