Automatic update from web-platform-tests
Don't apply appearance:base-select to non-<select> elements
By letting the EffectiveAppearance of other elements allow base-select,
it caused weird rendering. base-select is specifically reserved for
<select>, so when applying it to other elements, it should change it to
appearance:auto just like other invalid keywords provided to appearance.
Change-Id: I910629cf922c7866f1f7af5550160229aad548e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5820012
Reviewed-by: Traian Captan <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1348253}
--
wpt-commits: 521a70ea71f1862d01cc340f03e6f75327a834c3
wpt-pr: 47846
Automatic update from web-platform-tests
Remove author-provided <datalist> from <select>
The author-provided datalist imposes a lot of complexity, and now that
we aren't requiring it for HTML parser changes, it doesn't provide any
additional capabilities.
This patch also makes the UA popover actually have the popover attribute
and makes it a <div> instead of a <datalist>.
No code or concepts have "datalist" in them anymore except
::select-fallback-datalist because that is likely to get a different
standards-approved name soon.
This was discussed here: https://github.com/openui/open-ui/issues/1082
This patch also moves a bunch of tests from external/wpt to wpt_internal
because we aren't allowed to use test_driver in reftests in
external/wpt, and I was using datalist.showPicker() in a bunch of
reftests which we can't do anymore because the popover is now a
pseudo-element which can only be opened via select.showPicker() which
requires user activation, and in order to get user activation, we have
to run test_driver.bless().
Change-Id: Ib8230bc5eec214f09147ae806490df729f1e4412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5801649
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1348235}
--
wpt-commits: 0e5708e71e2ea4743e5da44e511579f31c33064c
wpt-pr: 47827
Automatic update from web-platform-tests
Replace base-select svg with disclosure-open
This was suggested here:
https://github.com/w3c/csswg-drafts/issues/10380#issuecomment-2189397947
This patch also adds min-inline-size and min-block-size to
::select-fallback-button because changing the icon caused the total size
of the button to decrease which revealed the lack of min sizing which is
already tested by
select-accessibility-minimum-target-size.tentative.html
The UA select:open rules caused a performance regression for large
<select>s because it caused a style recalc immediately after opening the
appearance:auto picker which in re-serializes all of the data for the
popup and sends it to the popup, which is very slow for large selects. I
addressed this by starting to match :open before creating the popup in
MenuListSelectType::ShowPopup.
Bug: 1511354
Change-Id: Id7b3b0aa6c9c79299240a7212023f849f3703fb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5660759
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1347324}
--
wpt-commits: 8108d046baa2bb0a947617b52dd568f59ec7c27f
wpt-pr: 47672
Automatic update from web-platform-tests
Add test cases to select-mouse-behavior.tentative.html
This test was missing the combinations of having author provided or
fallback datalists or buttons.
This patch also adds select-mouse-behavior to TestExpectations due to
different failure messages on different platforms, just like the
keyboard test in this patch: http://crrev.com/1339476
Change-Id: I60481c5525d03656891ecf1550b34fb656edf4d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5766778
Reviewed-by: Traian Captan <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1344470}
--
wpt-commits: a918d4987c0f37b4d1bc83c6acc91031e0d5d3d7
wpt-pr: 47701
Automatic update from web-platform-tests
Support top layer animations on ::select-fallback-datalist
This patch makes :popover-open work on ::select-fallback-datalist and
fixes an issue with slotting which makes <option>s disappear during exit
animations.
Fixed: 359279550
Change-Id: Ie9d8338699c0df9f37318d7a353fc7945456e4f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5791861
Reviewed-by: David Baron <[email protected]>
Commit-Queue: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1343143}
--
wpt-commits: e0e775f590a623acc2c39ffe84de02ab37b4eab4
wpt-pr: 47654
Automatic update from web-platform-tests
Add slow test meta tag to test that gets timed out on buildbots
The test "control-active-with-multiple-clicks.html" added
in a previous change
(https://chromium-review.googlesource.com/c/chromium/src/+/5724697)
is getting timed out on Mac and Win11 buildbots,
which is why the test has been disabled for them.
This fix adds a meta tag to the test indicating that it is slow, so that
it will no longer be timed out.
Fixed: 358591568, 358437643
Bug: 40934455
Change-Id: Ida9cc1e9c4d42b2fd2989af81234ea5e598e6ad7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5782735
Reviewed-by: David Baron <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1341236}
--
wpt-commits: e32afc253b1400ee7ae4019ed2f36aebdb0b5232
wpt-pr: 47592
Automatic update from web-platform-tests
Make shift+tab close <select> listbox
The tab key already closes the listbox, and allowing shift+tab to be
pressed without making it close the listbox allows the user to
unexpectedly be able to move focus outside of the listbox.
Fixed: 358045504
Bug: 40266261
Change-Id: I2aa3533e60dc5bcb0789b936d340faf6e8ad6cbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5769331
Reviewed-by: Traian Captan <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1341047}
--
wpt-commits: b9f7bf53bfd7370a597e597cc77abc1e60e95931
wpt-pr: 47581
Automatic update from web-platform-tests
Fix appearance:auto <select size/multiple> with new content model
Now that we are allowing new elements in <select> like <datalist>s and
<div>s, we should make them render in a sensible way for ListBox
<selects> which have size=2 or multiple attributes.
I already made sure that appearance:auto <select size=1> works with the
new content model, but I didn't handle these ListBox <select>s until
now.
Fixed: 357047901
Change-Id: I9f7b9f07e48eefd4b646a5bc2fdefb017765aadd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5770852
Reviewed-by: Traian Captan <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1340644}
--
wpt-commits: f88871bc421ddb8e087c38e41dd63cd375911bef
wpt-pr: 47549
Automatic update from web-platform-tests
Fix focus and activation for base-select <select disabled>
This patch makes the button in appearance:base-select <select>s disabled
when the <select> is disabled, which prevents it from being focusable or
openable.
Fixed: 40265812
Change-Id: I7a45b4419282b904e089bd22bdd57cd9bc97ec8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5746873
Auto-Submit: Joey Arhar <[email protected]>
Commit-Queue: Traian Captan <[email protected]>
Reviewed-by: Traian Captan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1340574}
--
wpt-commits: e13ef7418666f26b30f17199f0b3c8f2a8ec8f6f
wpt-pr: 47548
Automatic update from web-platform-tests
Fix :active state applying to control during second click on <label>
Prior to this change, clicking the <label> of a focused button, checkbox or radio would appear to not apply :active state to the element during a mousedown. Because of this, clicking on a <label> twice (without double clicking) would seem to not apply :active state to its control on the second click because the first click had focused the control.
The reason a focused control appeared to not gain :active state was because performing a mousedown on the label would blur the control, which cleared :active state right after it was applied by the label code.
This fix stops button, checkbox and radio elements from clearing their :active state on blur if they have an :active label, so that :active state is visibly applied on the second click of the label.
Fixed: 40934455
Change-Id: Ic10fd2b791994c1f98f314af6fa0c66e9266356c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5724697
Reviewed-by: David Baron <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1339868}
--
wpt-commits: a9bfd0afc6b67b8181aabc4fc1b878fd66e42eae
wpt-pr: 47553
Automatic update from web-platform-tests
Fix optgroup and hr rendering for appearance:base-select
<optgroup> and <hr> elements, like <option>s, are slotted into the UA
shadowroot of <select>s but removed from the layout tree in
LayoutFlexibleBox in order to give them a computed style. We have a
separate case for this logic in LayoutFlexibleBox when rendering a
<select> with appearance:base-select which was only accounting for
<option>s. This results in a bug where <optgroup>s and <hr>s are
rendered outside of the <select> when the picker is closed. This patch
fixes this by including <optgroup> and <hr> along with <option> in
LayoutFlexibleBox.
Change-Id: I5066a564e3ccbbc79722741d4de598b713bf7832
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5750124
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1339736}
--
wpt-commits: 57e4f23132622648068835050184c3cd754712b8
wpt-pr: 47543
Automatic update from web-platform-tests
Replace option-arbitrary-content <selectlist> tests
This patch deletes some <selectlist> tests which test the arbitrary
rendering of <option>s. This behavior is already tested by the following
tests:
select-child-button-and-datalist-invalidation.tentative.html
select-child-button-and-datalist.tentative.html
select-open-invalidation.tentative.html
The deleted tests also test that images are rendered and that the
arbitrary rendering still works after the <option> is removed and
re-appended, so I added a new reftest which tests for these.
Fixed: 338513292
Bug: 335458492
Change-Id: Id1d5e1ffcfe9d2adecaada7188198fb933eca5c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5767634
Reviewed-by: Traian Captan <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1339276}
--
wpt-commits: f0414120abca52a08f73edb511952597b8bed9c1
wpt-pr: 47521
Automatic update from web-platform-tests
Delete selectlist-parts-structure test
- "HTMLOptionElements (and not other element types) should receive
option controller code" is not needed because the behavior attribute
no longer exists.
- "To receive option part controller code, an option must be a
descendant of the listbox part in a flat tree traversal" is no longer
relevant because it isn't possible to render a descendant <option>
outside of the listbox.
- "To receive button part controller code, an element labeled as a
button must not be a descendant of the listbox part in a flat tree
traversal" is not relevant anymore because the behavior attribute is
gone and there is no other way of explicitly labeling a button as the
button which opens the listbox.
- "To receive listbox part controller code, an element labeled as a
listbox must not be a descendant of the button part in a flat tree
traversal" is not relevant anymore because there is no behavior
attribute or other way of specifying which <datalist> is the listbox.
- "Button controller code should be applied in flat tree traversal order
regardless of dynamic insertion order" is not relevant anymore because
we aren't using flat tree traversals anymore.
- "Listbox controller code should be applied in flat tree traversal
order regardless of dynamic insertion order" is not relevant anymore
because we aren't using flat tree traversals anymore.
- "selected-value controller code should be applied in flat tree
traversal order regardless of dynamic insertion order" isn't relevant
anymore because we aren't using flat tree traversals anymore.
- "Ensure that controller code is applied when slot and part attributes
are different" isn't relevant anymore since we aren't using slot or
part attributes anymore.
- "Ensure that controller code is synchronously applied" isn't relevant
anymore since we don't have the behavior attribute anymore.
- "Controller code should be updated when nested parts are removed"
isn't relevant anymore since there is not behavior attribute and there
is otherwise no way to nest the relevant elements which would get
behaviors applied to them.
- "Moving a selectlist between documents should keep controller code
active" is not relevant because we aren't listening to lifecycle
events which need to be transferred to the new document and the async
MutationObserver which <option> elements are using don't seem to need
any special handling to be moved to the new document either.
- "New parts should be detected even when in the subtree of an inserted
node" is not relevant anymore because we don't have the behavior
attribute anymore.
Bug: 335458492
Fixed: 40199394
Change-Id: I58607ffdd31b319b93f5bbb1bf79e979b880fc3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5770893
Reviewed-by: Traian Captan <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1339274}
--
wpt-commits: 21630ac9632a74707cfb1c4b52e826e4c95c2068
wpt-pr: 47522
Automatic update from web-platform-tests
Remove selectlist-popover.tentative.html
I would migrate this test to <select>, but everything this test does is
already covered in existing <select> tests:
- Opening the popover and clicking on options is covered by
select-mouse-behavior.tentative.html
- "Clicking a popover with no listbox part does nothing" and "Clicking a
popover with a listbox that was removed does nothing" do not apply
to <select> because there will always be a fallback <datalist> popover
if there is not an author provided one.
Fixed: 40281603
Bug: 335458492
Change-Id: I59673a430b30f34ea543a2fa4e532c2767a49fa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5767329
Auto-Submit: Joey Arhar <[email protected]>
Commit-Queue: Di Zhang <[email protected]>
Reviewed-by: Di Zhang <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1338193}
--
wpt-commits: 3b96ae2f89867c862667f99ae6e73bb9daca111f
wpt-pr: 47501
Automatic update from web-platform-tests
Remove button type=popover for select
Instead of supporting the "split button" use case for selects by
slotting multiple button elements and having the type=popover attribute
to differentiate them, we will now support them with the
selectedoptionelement attribute. This was decided here:
https://github.com/openui/open-ui/issues/1063
The type=popover behavior will automatically be applied to <button>s
which are children of <select>.
Change-Id: Ie43fcec33453e81742679272a4ca6cd892c4a886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5710709
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1338166}
--
wpt-commits: a290a0cedac4af6ffb64f4816c6fa98a623d43d4
wpt-pr: 47488
Automatic update from web-platform-tests
Improve <selectedoption> performance
This patch improves the performance of <selectedoption> by replacing the
SynchronousMutationObserver with the existing async MutationObserver in
HTMLOptionElement.
The change from sync to async impacts some tests. The timing is being
discussed in a standards issue here:
https://github.com/whatwg/html/issues/10520
Fixed: 336844298
Change-Id: I9693de9cf35913e7daaebb364c4923dcd4a2dc39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5758741
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1337462}
--
wpt-commits: d32c223215aaa166fce5162b4f76d323e9d513e7
wpt-pr: 47467
Automatic update from web-platform-tests
Relax <select> parser rules
This patch makes <select> allow tags besides <option>, <optgroup>, and
<hr>. Previously this was only allowed within a child <button> or
<datalist> tag inside <select>, but based on the feedback in whatwg we
should try to allow this content everywhere:
https://github.com/whatwg/html/issues/10310
This behavior is guarded behind a flag. Since I am planning on shipping
parser changes for <select> before appearance:base-select, I am creating
a new flag for parser changes instead of reusing the existing
StylableSelect flag for appearance:base-select. The new flag is intended
to not only make the parser change, but also update the algorithms which
associate option/optgroup/hr elements with select elements to account
for the newly parsed elements.
If everything goes well, then we will need to change these WPTs which
this patch effectively marks as failing:
html/infrastructure/common-dom-interfaces/collections/htmloptionscollection.html
html/semantics/forms/the-select-element/select-value.html
html/syntax/parsing/
Bug: 1511354
Change-Id: I441f9645a592ac63764fef928e4e5acf3fdec5db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5518837
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1329137}
--
wpt-commits: 8e71820a49e67752c5f9ef6fad7a52753b004b5a
wpt-pr: 47179
Automatic update from web-platform-tests
Mark form-validation-reportValidity.html as a slow test
This is reported (crbug.com/352483161) as both flaky and slow,
so this should fix the timeouts at least. I'm leaving this marked
as flaky (see crbug.com/40668225) for now.
Fixed: 352483161
Bug: 40668225
Change-Id: I86a5e8be40068d42468496f7b3298a8e72cd3ad7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5704255
Auto-Submit: Mason Freed <[email protected]>
Reviewed-by: Di Zhang <[email protected]>
Commit-Queue: Di Zhang <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1327080}
--
wpt-commits: 3202257995f1eb3aaf5a7ace11d56f26beca0136
wpt-pr: 47122
Automatic update from web-platform-tests
Add checkmark to base-select options
This is being discussed in OpenUI here:
https://github.com/openui/open-ui/issues/863
The discussion suggested that we should use a unicode checkmark instead
of an SVG, so that's what this patch does.
It might be better to use ::marker instead of ::before, but we might
also end up with something else entirely and I think that reusing
::marker would be harder to implement, so I am using ::before for now.
Bug: 1511354
Change-Id: I29c1dfc26208e6fc13cf42782a3d9d6fae2e711c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5578818
Reviewed-by: David Baron <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1313329}
--
wpt-commits: 56ec66da8735eb2ccbd9be689917b2b1aad6faed
wpt-pr: 46609
I don't reproduce the crash even if I rewrite the test using `attachShadow`
which replaced `createShadowRoot`. Therefore, this patch just adds the reported
testcase into the tree.
Differential Revision: https://phabricator.services.mozilla.com/D213375
Automatic update from web-platform-tests
Update indicator when list attribute is removed
When <input list=datalist> has its list attribute removed, we should
remove the visual dropdown indicator from the text input.
Fixed: 342660638
Change-Id: I6e47e1fe3d6d2840b4814ace767493164874ed6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5588810
Reviewed-by: Di Zhang <[email protected]>
Commit-Queue: Di Zhang <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1309531}
--
wpt-commits: 9e7efc1687270aa5d606788992bdce0e2f801c42
wpt-pr: 46598
Automatic update from web-platform-tests
Make showPicker() consume user activation
Allowing the page to call showPicker() on select elements as much as it
wants without consuming user activation may result in the user being
unable to interact with the browser UI due to popups always taking
focus.
The HTML spec also says to do this for input elements, so I added code
to do it there as well.
This patch also modified the select showPicker test because calling
showPicker on a select twice in a row in the test somehow resulted in
blink not seeing any input events on the second test_driver.bless(),
perhaps because the select's popup is still open and is somehow
intercepting the input.
HTML spec: https://github.com/whatwg/html/pull/10344
Bug: 1521345
Fixed: 343302069, 343093082, 343473478
Change-Id: If6308a67bac9050f695d18d275ea86c23ac22b0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5235516
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Di Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1309009}
--
wpt-commits: 17375f41ccf41e081764d2786ec535dede108c47
wpt-pr: 44181
Automatic update from web-platform-tests
Cleanup "check show the picker consumes user activation" (#46513)
Remove bad `<select>` click() test and fix some syntax errors. Cleanup of #46502.
--
wpt-commits: 3a85f98daac7c034c2a2b50853625d1f4c89272d
wpt-pr: 46513
Automatic update from web-platform-tests
Add invalidation to select:open when datalist popover toggles
This patch makes select:open selectors get updated when the select is
toggled open or closed due to popover triggering code. Without this,
appearance:base-select <select>s might have styles applies for the
closed state when they are open or vice versa.
Bug: 40146374
Change-Id: If955675abf45a059f23cd005111152e72e1e5cda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545431
Reviewed-by: David Baron <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1303858}
--
wpt-commits: a29a71679c17f62c7f9768c24d6bfa320d8c8ed5
wpt-pr: 46356
Automatic update from web-platform-tests
Set minimum target size of 24px for appearance:base-select
According to accessibility guidelines, we must ensure that all of the
pointer targets in appearance:base-select must be at least 24x24 CSS
pixels. https://github.com/openui/open-ui/issues/1026
Bug: 1511354
Change-Id: Iba814399e4061f7ce36c24296aef37a540444612
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503502
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1301595}
--
wpt-commits: f23e47a0774b10c5af7de68d5d89fdd07b41871d
wpt-pr: 45998
Automatic update from web-platform-tests
De-flake native-popup-with-datalist
I was able to reproduce the flake which was happening because sometimes
the button was still focused. I fixed it by blurring the focused element
and adding a rAF.
Fixed: 334122678
Change-Id: Iede088900b888ab32c3a9554d5c6fc83b980ccc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5530688
Reviewed-by: Di Zhang <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1300308}
--
wpt-commits: ebdc4e73b12d3565e9e6345ab2e689175bbcb0a2
wpt-pr: 46195
Automatic update from web-platform-tests
Change base-select icon from background-image to svg elements (#46152)
Putting the svg in a data url for background-image was not as
customizable in CSS for developers, but using an actual svg element is:
https://github.com/openui/open-ui/issues/881
Bug: 40146374
Fixed: 337904202
Change-Id: If1528b3df97e31de5b86b27a6aa935223ff0f0a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5522663
Reviewed-by: David Baron <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1300224}
Co-authored-by: Joey Arhar <[email protected]>
--
wpt-commits: bc5292b8507cb38199367aa04fdca7b1028819d5
wpt-pr: 46152
Automatic update from web-platform-tests
Add option:hover styles to appearance:base-select
These styles were implemented for <selectlist> and I think they should
be included for appearance:base-select as well.
Bug: 1511354
Change-Id: I22b23cd7102cb197ba37b3d150071306ef9d8b9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493158
Reviewed-by: David Baron <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1297145}
--
wpt-commits: d3214b5c466152ce514521d1751e83d75444d1d6
wpt-pr: 46041
Automatic update from web-platform-tests
Fuzzy rule for .../selectlist-option-arbitrary-content-displayed.tentative.html
The test has been failing on win11-arm64 since crrev.com/1296415.
There are some slight and invisible differences in the shadow
gradient.
Bug: 332331854
Change-Id: Ib60fa209c8622e97c643f6e59b1be0198b61902f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5517269
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Philip Rogers <[email protected]>
Auto-Submit: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1296596}
--
wpt-commits: 536297144c737f84096d1f448e790de0fb654956
wpt-pr: 46074
Automatic update from web-platform-tests
Add content to appearance:base-select fallback button
This patch adds extra content and styling to the fallback button in the
UA shadowroot of <select> which gets rendered when it is
appearance:base-select and the author does not provide a <button>
element to replace it with.
In order to do this, this patch also adds 3 pseudo-elements to the
<select> element:
- ::select-fallback-button which targets the fallback <button>
- ::select-fallback-button-icon which targets the <div> inside the
fallback <button> which renders an svg as its background-image
- ::select-fallback-selectedoption which targets the <span> inside the
fallback <button> which gets the selected <option>'s text content
copied into it.
The CSS and contents are all exactly the same as they are in
<selectlist>. <selectlist> also has the same pseudo elements.
This patch also changes some tests to inherit from PageTestBase. Adding
the svg background-image caused a scheduling crash in v8 with something
about microtask queues. I don't know what PageTestBase does differently
from these tests which are making their own TaskEnvironment, but
PageTestBase does it in a way which doesn't make the test crash.
Bug: 1511354
Change-Id: Iaf362dd1253f4dd9e5984cc3301c31e9e9ae558c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464171
Reviewed-by: David Baron <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1295509}
--
wpt-commits: 7048e31e507463ca6d91205f21885dad939ca483
wpt-pr: 45774
Automatic update from web-platform-tests
Make setting defaultValue from a trusted input event validate
This adds a large-ish test of the validation behavior of the
textarea element, which as far as I can tell is under-specified,
or at least I could not find this behavior in the spec. I looked
mainly here:
https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#validity-states
In particular, there are some interesting differences in the
validity of initially-empty vs initially-non-empty textareas.
This CL, though, also aligns the behavior of Chromium with both
WebKit and Gecko in the specific case where the `input` event
handler sets textarea.defaultValue. In that case, the textarea
will be validated correctly. Previous to this CL, Chromium would
not validate the textarea as a result of the change.
Fixed: 333940413
Change-Id: Iec38fb510296d34419b7ed3df8ab396d2d737d69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463568
Auto-Submit: Mason Freed <[email protected]>
Reviewed-by: David Baron <[email protected]>
Commit-Queue: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1293030}
--
wpt-commits: 3dad9a8b7f17fa61262de8713c6db4dac1c227c5
wpt-pr: 45776
Automatic update from web-platform-tests
StepDown should default to min when no current val
When `stepDown()` is called on an input box that has a minimum value
defined that is greater than zero and no current value, no value is
set.
This can seem unintuitive to users and mismatches what currently
happens when the user uses the spinner or keyboard down arrow.
The reason for nothing seeming to happen is due to interpretation of
step 10 in the stepDown(n) method specified algorithm [1]:
"10. If either the method invoked was the stepDown() method and value
is greater than valueBeforeStepping, or the method invoked was the
stepUp() method and value is less than valueBeforeStepping, then
return."
when applying the default value in step 5:
"5. If applying the algorithm to convert a string to a number to the
string given by the element's value does not result in an error, then
let value be the result of that algorithm. Otherwise, let value be
zero."
If the minimum value defined for the input is greater than the default
of zero, the check in step 10 fails and an early return is executed.
The proposed fix for this is to keep track of whether there was an
actual `valueBeforeStepping` (current value) or the default is used,
and execute the early return defined in step 10 only if the default
was not used. This will result in a more intuitive behavior for the
users, and align the `stepDown()` behavior in this case with the
spinner/keyboard arrow down behavior and also match FireFox.
[1]https://html.spec.whatwg.org/multipage/input.html#dom-input-stepup
Bug: 40692746
Change-Id: Ie4cabb9169911f8c8cb0149c716133f0a1951cb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5474199
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Traian Captan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1291586}
--
wpt-commits: 2c67022fcbacef33b1090e1eb0008e9af7ed6181
wpt-pr: 45838
Automatic update from web-platform-tests
Map HTML tests to web-features (#45588)
--
wpt-commits: c29dcddf3752377da16049c17ef89e391456bc6e
wpt-pr: 45588
Automatic update from web-platform-tests
Support border in -internal-auto-base-select()
This patch adds support for -internal-auto-base-select() as a value for the
border shorthand property and uses it in the UA stylesheet for stylable
select.
With this, we can remove the proprietary UA styles for select from the
stylable select WPTs.
Bug: 1511354
Change-Id: Ib0de97cf4d90b915dedc979f36470e045e1737f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5401916
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1285996}
--
wpt-commits: daba59ad18bb87d65918965f130b30035bd277c9
wpt-pr: 45652
Automatic update from web-platform-tests
Add WPT for nested <options> in <select> <datalist>
This patch had a question about nested <option>s, so I am adding a
basic test to make sure that nested <option>s are permitted even though
there isn't a use case for it:
https://chromium-review.googlesource.com/c/chromium/src/+/5441435
Bug: 1511354
Change-Id: Ide803ed97b55928aeba04c62e6061608b18dd629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5445118
Reviewed-by: David Baron <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1285495}
--
wpt-commits: 321b4a774e2a8a10d7884bbc57cb9cc101140579
wpt-pr: 45653
Automatic update from web-platform-tests
Make <select> native popup render descendant <option>s
This patch makes the <select>'s native popup render descendant <option>s
even in appearance:auto mode.
Based on the standards discussions, it is expected that the
native/appearance:auto rendering will have a basic level of
incorporating the new HTML structure of <select>.
Bug: 1511354
Change-Id: I3fbd703d8030d1ee1a4de21fabe2f85a7718eb1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5441435
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1285415}
--
wpt-commits: 073f56c256ef0c248aacc4595420e5b4a630e797
wpt-pr: 45634
Automatic update from web-platform-tests
Implement -internal-appearance-auto-base-select()
This patch implements -internal-appearance-auto-base-select(), a CSS
function that can be used in UA stylesheets which takes two values. If
the computed style of the element is not appearance:base-selet, then the
first value is used. Otherwise, the second value is used.
This patch only uses it for background-color on <select>, but I will try
using it for additional properties like border next.
Bug: 1511354
Change-Id: I70fea56ef8a8c931418872039f1df38e5324f55f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5389566
Reviewed-by: Chris Harrelson <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Auto-Submit: Joey Arhar <[email protected]>
Commit-Queue: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1285298}
--
wpt-commits: 293b22bffa09048bbca34ab9a1357b1af0951699
wpt-pr: 45291
Automatic update from web-platform-tests
Remove ASSERT_NO_EXCEPTION for toggling <select> popovers
I remembered that HidePopoverInternal and ShowPopoverInternal don't need
to take ExceptionStates for internal toggling like this, so I am
removing the ASSERT_NO_EXCEPTIONs so that we don't make it crash.
Bug: 1511354
Change-Id: Ifd4a6b2a2bf7167e3e361ff447cffe34e9668d89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5384726
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1285189}
--
wpt-commits: ed8ba2bd60d15c2423f013b62138756423cb08ed
wpt-pr: 45462