Serge Guelton
166f30c9fd
Bug 1765593 - Cleanup mozilla-unified includes r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D144202
2022-05-03 14:57:45 +00:00
Nicklas Boman
5c92c19176
Bug 1724526 - Stop using PL_strchr in toolkit code r=Gijs
...
Depends on D122060
Differential Revision: https://phabricator.services.mozilla.com/D122061
2021-08-18 08:28:49 +00:00
Nicklas Boman
b3fd3ad36f
Bug 1308094 - Remove deprecated PL_strdup calls from toolkit code r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D122148
2021-08-17 19:34:32 +00:00
Gijs Kruitbosch
484bd1365a
Bug 1666221 - cope with not having a working directory, r=robwu,mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D91221
2020-10-22 19:44:46 +00:00
Narcis Beleuzu
fbf78b38f3
Backed out 3 changesets (bug 1308104) for bustages on nsHttp.cpp . CLOSED TREE
...
Backed out changeset e78791b93526 (bug 1308104)
Backed out changeset b5c1875c11c7 (bug 1308104)
Backed out changeset 9c8433be706e (bug 1308104)
2020-09-10 22:43:25 +03:00
Nicklas Boman
7b9af7ac28
Bug 1308104 - Replace PL_strchr with a safer Gecko string class or function commandlines/ r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D89325
2020-09-10 17:38:30 +00:00
Simon Giesecke
4e6a97b4f4
Bug 1644640 - Rename RemoveElementsAt(const_iterator, const_iterator) to RemoveElementsRange. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D79033
2020-06-11 07:17:25 +00:00
Simon Giesecke
00eddcee05
Bug 1642949 - Replace uses of RemoveElementAt by RemoveLastElement/PopLastElement where possible. r=necko-reviewers,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D78027
2020-06-10 10:46:14 +00:00
Butkovits Atila
7f9b16b938
Backed out 3 changesets (bug 1643289, bug 1642949) for causing failure at test_headless_screenshot.html. CLOSED TREE
...
Backed out changeset 98c420f73380 (bug 1643289)
Backed out changeset 9447ea8910aa (bug 1643289)
Backed out changeset 0c827da9d847 (bug 1642949)
2020-06-10 10:07:23 +03:00
Simon Giesecke
1c59dae9e4
Bug 1642949 - Replace uses of RemoveElementAt by RemoveLastElement/PopLastElement where possible. r=necko-reviewers,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D78027
2020-06-10 05:49:28 +00:00
Emilio Cobos Álvarez
03cfd95496
Bug 1641245 - Make string comparators not virtual. r=froydnj,necko-reviewers,geckoview-reviewers,jgilbert,agi,valentin
...
There's no use case for stateful comparators, so they can be just plain
function pointers.
This is used in some hot places like CSS selector matching.
Differential Revision: https://phabricator.services.mozilla.com/D77084
2020-05-27 18:11:12 +00:00
Gabriele Svelto
f03cdb2b2d
Bug 1600545 - Remove useless inclusions of header files generated from IDL files in modules/, netwerk/, parser/, security/, startupcache/, storage/, toolkit/, tools/, uriloader/, widget/, xpcom/ and xpfe/ r=Ehsan
...
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.
find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
if [ -n "$interfaces" ]; then
if [[ "$interfaces" == *$'\n'* ]]; then
regexp="\("
for i in $interfaces; do regexp="$regexp$i\|"; done
regexp="${regexp%%\\\|}\)"
else
regexp="$interfaces"
fi
interface=$(basename "$path")
rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
if [ $hits -eq 0 ]; then
echo "Removing ${interface} from ${path2}"
grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
mv -f "$path2".tmp "$path2"
fi
done
fi
done
Differential Revision: https://phabricator.services.mozilla.com/D55444
2019-12-06 09:17:57 +00:00
Gabriele Svelto
652cb568da
Bug 1585156 - Remove useless inclusions of nsIDOMWindow.h and nsIDOMWindowUtils.h r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D47678
2019-09-30 22:06:47 +00:00
Nicholas Nethercote
e2bb468069
Bug 1535226 - Remove uses of XP_WIN32 in Gecko. r=glandium
...
The definitions can't be entirely removed yet because NSS still needs them.
Differential Revision: https://phabricator.services.mozilla.com/D23454
2019-03-21 01:28:50 +00:00
Dave Townsend
920aaaa961
Bug 1518639: Remove some unused functionality from the remote service. r=Felipe
...
Differential Revision: https://phabricator.services.mozilla.com/D19065
2019-02-08 21:00:08 +00:00
Ehsan Akhgari
498e2df734
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
...
# ignore-this-changeset
2019-01-18 10:16:18 +01:00
Sylvestre Ledru
e5a134f73a
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
2018-11-30 11:46:48 +01:00
Ehsan Akhgari
f9231bc798
Bug 1491560 - Remove the XPCOM registration for nsCommandLine; r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D5944
2018-09-15 12:16:39 -04:00
Kris Maglione
edfa25a364
Bug 1486182: Follow-up: Fix straggler nsIUTF8StringEnumerator references. r=bustage CLOSED TREE
2018-08-28 14:29:16 -07:00
Kris Maglione
b399327a89
Bug 1486182: Part 1 - Include both category names and values in category enumerator. r=froydnj
...
Nearly all of the consumers of category enumerators require the entry value,
either along with or instead of the name. Including both by default simplifies
things considerably for most consumers, and allows us to remove the XPCOMUtils
wrapper that JS callers typically use to enumerate category entries.
Differential Revision: https://phabricator.services.mozilla.com/D4277
2018-08-24 22:22:07 -07:00
Kris Maglione
03b182d3da
Bug 1477579: Part 3 - Avoid duplicating static strings in category manager entries. r=froydnj
...
Much like the component manager, many of the strings that we use for category
manager entries are statically allocated. There's no need to duplicate these
strings.
This patch changes the category manager APIs to take nsACStrings rather than
raw pointers, and to pass literal nsCStrings when we know we have a literal
string to begin with. When adding the category entry, it then skips making
copies of any strings with the LITERAL flag.
MozReview-Commit-ID: EJEcYSdNMWs
***
amend-catman
2018-07-23 17:41:06 -07:00
Brindusan Cristian
52e593c35b
Backed out 3 changesets (bug 1477579) for build bustages on xpcshell\selftest.py and crashtest failures on /components/nsComponentManager.cpp. CLOSED TREE
...
Backed out changeset aa9a8f18e98f (bug 1477579)
Backed out changeset 5fb0b7746a5d (bug 1477579)
Backed out changeset 8359f8fe4184 (bug 1477579)
2018-07-24 04:55:03 +03:00
Kris Maglione
49963c786f
Bug 1477579: Part 3 - Avoid duplicating static strings in category manager entries. r=froydnj
...
Much like the component manager, many of the strings that we use for category
manager entries are statically allocated. There's no need to duplicate these
strings.
This patch changes the category manager APIs to take nsACStrings rather than
raw pointers, and to pass literal nsCStrings when we know we have a literal
string to begin with. When adding the category entry, it then skips making
copies of any strings with the LITERAL flag.
MozReview-Commit-ID: EJEcYSdNMWs
***
amend-catman
2018-07-23 17:41:06 -07:00
Myk Melez
d430b61149
Bug 1410564 - support double-dash args on Windows in nsCommandLine; r=mossop
2017-10-23 12:54:13 -07:00
Myk Melez
d0ecb4b4c9
Bug 1406590 - support single-dash arguments with values; r=mossop
2017-10-23 12:54:13 -07:00
Tom Tromey
917fa8e294
Bug 1388789 - make va_list nsTextFormatter private; r=froydnj
...
The runtime type-checking rewrite of nsTextFormatter will not support
va_list uses. So, make these functions private and fix the sole user.
MozReview-Commit-ID: IBWALVzIcHC
2017-08-31 15:21:37 -06:00
Nicholas Nethercote
848397a70b
Bug 1390428 (part 4) - Remove still more nsXPIDLCString local variables. r=erahm.
...
These are all easy cases where an nsXPIDLCString local variable is set via
getter_Copies() and then is null checked. The patch uses IsVoid() to replace
the null checks (and get() and EqualsLiteral() calls to replace any implicit
conversions).
2017-08-16 13:58:55 +10:00
Nicholas Nethercote
d634dfac08
Bug 1388253 - Convert nsTextFormatter:[v]smprintf() use to [v]ssprintf(). r=erahm.
...
[v]ssprintf() is just a better way of doing things.
2017-08-09 10:41:14 +10:00
Sylvestre Ledru
9d4a84d778
Bug 1378712 - Remove all trailing whitespaces r=Ehsan
...
MozReview-Commit-ID: Kdz2xtTF9EG
2017-07-06 14:00:35 +02:00
L. David Baron
8250722e62
Bug 1363262 - Don't call First() on empty strings in nsCommandLine::HandleFlagWithParam. r=bsmedberg
...
MozReview-Commit-ID: 91J55PjzwmF
2017-05-11 15:41:41 -07:00
Sylvestre Ledru
a15f1c5d08
Bug 1318004 - Replace default bodies of special member functions with = default; r=Ehsan
...
MozReview-Commit-ID: 33AOhtFrXS8
2016-11-16 18:26:14 +01:00
Wes Kocher
b620596e75
Backed out 4 changesets (bug 1318004) for xpcshell failures a=backout CLOSED TREE
...
Backed out changeset a3fe53641526 (bug 1318004 )
Backed out changeset a5d1676b6f88 (bug 1318004 )
Backed out changeset b56b37f0f4d7 (bug 1318004 )
Backed out changeset fb5254baf1cb (bug 1318004 )
2016-11-21 16:15:38 -08:00
Sylvestre Ledru
eaf1a1bb8c
Bug 1318004 - Replace default bodies of special member functions with = default; r=Ehsan
...
MozReview-Commit-ID: 33AOhtFrXS8
2016-11-16 18:26:14 +01:00
Wes Kocher
13642ca8af
Backed out 4 changesets (bug 1318004) for xpcshell failures a=backout
...
Backed out changeset 6995bd33872b (bug 1318004 )
Backed out changeset 9be5c856bc78 (bug 1318004 )
Backed out changeset 365b0b7f289a (bug 1318004 )
Backed out changeset 2f2ebf176eac (bug 1318004 )
2016-11-21 12:23:17 -08:00
Sylvestre Ledru
c30faf12df
Bug 1318004 - Replace default bodies of special member functions with = default; r=Ehsan
...
MozReview-Commit-ID: 33AOhtFrXS8
2016-11-16 18:26:14 +01:00
Nicholas Nethercote
cc4d39daaa
Bug 1297300 - Add missing checks to GetSpec() calls in toolkit/. r=froydnj.
2016-09-08 14:32:20 +10:00
Chris Peterson
6c0f810682
Bug 1277106 - Part 2: Expand MOZ_UTF16() strings to u"" string literals. r=Waldo
2016-07-20 22:03:25 -07:00
Emanuel Hoogeveen
b30abdc582
Bug 905127 - Part 1 - Make some functions from nsNetUtil not inline. r=jduell
2015-07-07 04:17:00 +02:00
Mike Hommey
4d93988786
Bug 1134923 - Remove NS_Alloc/NS_Realloc/NS_Free. r=nfroyd
...
They are kept around for the sake of the standalone glue, which is used
for e.g. webapprt, which doesn't have direct access to jemalloc, and thus
still needs a wrapper to go through the xpcom function list and get to
jemalloc from there.
2015-05-01 09:40:30 +09:00
Nathan Froyd
023e3d5c3f
Bug 1153267 - part 1 - use smart-pointer .forget() instead of NS_ADDREF+assign; r=ehsan
2015-03-31 10:03:49 -04:00
Ehsan Akhgari
ea41d8de48
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Birunthan Mohanathas
eeb9aaaa94
Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj
2014-04-27 03:06:00 -04:00
Ehsan Akhgari
860f2c1f29
Bug 969757 - Remove the dead code in our tree which pretends to support OS/2; r=roc,mcmanus,gps,jorendorf,bsmedberg sr=bsmedberg
2014-02-10 17:57:01 -05:00
Ehsan Akhgari
68bfe70f09
Bug 927728 - Part 1: Replace PRUnichar with char16_t; r=roc
...
This patch was automatically generated by the following script:
#!/bin/bash
# Command to convert PRUnichar to char16_t
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*modules/libmar*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name prtypes.h \
! -name Char16.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRUnichar char16_t
2014-01-04 10:02:17 -05:00
Trevor Saunders
b4ae5fdd96
bug 949821 - use MOZ_UTF16 more and NS_LITERAL_STRING less r=froydnj
2013-12-12 20:50:01 -05:00
Birunthan Mohanathas
37fac24a80
Bug 784739 - Switch from NULL to nullptr in toolkit/components/ (2/2); r=ehsan
2013-10-10 16:38:19 -04:00
Trevor Saunders
5f4dc421fd
bug 829288 - fix some toolkit/ warnings r=ehsan
2013-01-10 06:44:15 -05:00
Nicholas Nethercote
f05eba28bf
Bug 825150 - Remove const_casts by adding some const-ness to nsICommandLineRunner.init(). r=karlt, sr=bsmedberg.
2013-01-03 13:52:32 -08:00
Randell Jesup
3b4961b603
Bug 773151: Convert nsCAutoString->nsAutoCString CLOSED TREE r=bsmedberg
2012-09-01 22:35:17 -04:00
Ehsan Akhgari
243c878d26
Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
...
This patch was generated by a script. Here's the source of the script for
future reference:
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t
convert PRIntn int
convert PRUintn unsigned
convert PRSize size_t
convert PROffset32 int32_t
convert PROffset64 int64_t
convert PRPtrdiff ptrdiff_t
convert PRFloat64 double
2012-08-22 11:56:38 -04:00