Commit Graph
79 Commits
Author SHA1 Message Date
Edgar Chen 546880ae4d Bug 1867636 - Rename nsITransferable::requestingPrincipal; r=nika
Differential Revision: https://phabricator.services.mozilla.com/D207272
2024-04-18 10:06:07 +00:00
Greg Stoll b2839267e7 Bug 1871135 - Add content analysis support to clipboard operations r=edgar,nika,masayuki,devtools-reviewers
When content analysis is on, pastes will be checked by the CA
agent while tab input is blocked. The synchronous nsIClipboard.getData()
method must block until the analysis result is received, so this
requires doing a SpinEventLoopUntil.

Differential Revision: https://phabricator.services.mozilla.com/D196997
2024-02-13 11:26:48 +00:00
Cristian Tuns 35a4843e35 Backed out changeset 9dfe3fe4ccc5 (bug 1871135) for causing mochitest failures in nsClipboardProxy.cpp CLOSED TREE 2024-02-12 12:04:41 -05:00
Greg Stoll 215d43e99f Bug 1871135 - Add content analysis support to clipboard operations r=edgar,nika,masayuki,devtools-reviewers
When content analysis is on, pastes will be checked by the CA
agent while tab input is blocked. The synchronous nsIClipboard.getData()
method must block until the analysis result is received, so this
requires doing a SpinEventLoopUntil.

Differential Revision: https://phabricator.services.mozilla.com/D196997
2024-02-12 16:05:06 +00:00
Cristian Tuns 907b8f6b06 Backed out changeset 3caca1d10dcc (bug 1871135) for causing build bustages in nsBaseClipboard.cpp CLOSED TREE 2024-02-12 09:59:09 -05:00
Greg Stoll 1d234e67c7 Bug 1871135 - Add content analysis support to clipboard operations r=edgar,nika,masayuki,devtools-reviewers
When content analysis is on, pastes will be checked by the CA
agent while tab input is blocked. The synchronous nsIClipboard.getData()
method must block until the analysis result is received, so this
requires doing a SpinEventLoopUntil.

Differential Revision: https://phabricator.services.mozilla.com/D196997
2024-02-12 00:49:39 +00:00
Tom Schuster 30930ea2b7 Bug 1808146 - When creating a file promise for images, remember the referrer. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D172920
2023-03-22 21:55:08 +00:00
Andrew McCreight 291afe14f4 Bug 1792574, part 3 - Don't include nsMemory where it isn't needed. r=xpcom-reviewers,necko-reviewers,valentin,nika
There are only 3 places where nsMemory.h is still needed (image/RasterImage.cpp,
gfx/thebes/gfxFT2FontList.cpp, and nsMemory.cpp). Remove the rest.

Differential Revision: https://phabricator.services.mozilla.com/D158213
2022-09-28 15:17:46 +00:00
Neill Miller 724ea2ffaf Bug 1768907 - Part 2: nsTransferable disk-leaks when private browsing mode is enabled by default. r=handyman
nsTransferable was modified to prevent disk leakings when copying data
in private browsing mode with Bug 1123480.
However, the context is nullptr when it is initialized, so it still
leaks if PBM is enabled by default.
Our solution is to check the browser.privatebrowsing.autostart in this
condition.

Differential Revision: https://phabricator.services.mozilla.com/D157800
2022-09-22 00:26:17 +00:00
Tim Huang b0c841cd20 Bug 1641270 - Part 7: Add setter/getter of nsICookieJarSettings to nsITransferable. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D95617
2020-11-11 11:14:07 +00:00
Mihai Alexandru Michis a232075e0f Backed out 9 changesets (bug 1641270) for causing dt failures in browser_jsonview_save_json.js
CLOSED TREE

Backed out changeset 89a6dab92f1a (bug 1641270)
Backed out changeset 5f9c5af66b77 (bug 1641270)
Backed out changeset dfeb879f4131 (bug 1641270)
Backed out changeset 143728b1b1ab (bug 1641270)
Backed out changeset 265ae2953416 (bug 1641270)
Backed out changeset 55ea7810c160 (bug 1641270)
Backed out changeset 7bef9112f296 (bug 1641270)
Backed out changeset 2663dc1e9a3e (bug 1641270)
Backed out changeset fcba6dba3649 (bug 1641270)
2020-11-11 13:10:11 +02:00
Tim Huang 613d51e559 Bug 1641270 - Part 7: Add setter/getter of nsICookieJarSettings to nsITransferable. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D95617
2020-11-10 20:40:34 +00:00
Simon Giesecke 1ee0a47195 Bug 1613985 - Use default for equivalent-to-default constructors/destructors in widget. r=jmathies
Differential Revision: https://phabricator.services.mozilla.com/D66012
2020-03-16 10:56:57 +00:00
Bogdan Tara 22b0fa7e80 Backed out 4 changesets (bug 1613985) for causing build bustages CLOSED TREE
Backed out changeset fba0caac746c (bug 1613985)
Backed out changeset 8605d7a19107 (bug 1613985)
Backed out changeset 41e858fbf235 (bug 1613985)
Backed out changeset 847433cf1e0a (bug 1613985)
2020-03-16 12:41:41 +02:00
Simon Giesecke 36f6c9d797 Bug 1613985 - Use default for equivalent-to-default constructors/destructors in widget. r=jmathies
Differential Revision: https://phabricator.services.mozilla.com/D66012
2020-03-16 09:14:12 +00:00
Gabriele Svelto f03cdb2b2d Bug 1600545 - Remove useless inclusions of header files generated from IDL files in modules/, netwerk/, parser/, security/, startupcache/, storage/, toolkit/, tools/, uriloader/, widget/, xpcom/ and xpfe/ r=Ehsan
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55444
2019-12-06 09:17:57 +00:00
Sylvestre Ledru e5a134f73a Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset
2018-11-30 11:46:48 +01:00
Jonathan Watt 572a781474 Bug 1510247. Fix some unified build issues in widget code. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D13061
2018-11-14 17:03:36 +00:00
Tom Schuster a85a1bfa32 Bug 1493292 - Remove len from nsIFormatConverter. r=smaug
Depends on D11204

Differential Revision: https://phabricator.services.mozilla.com/D11205
2018-11-20 17:01:46 +00:00
Tom Schuster 7d1decf955 Bug 1493292 - Remove len from nsIFlavorDataProvider r=smaug
Depends on D11203

Differential Revision: https://phabricator.services.mozilla.com/D11204
2018-11-20 17:01:44 +00:00
Tom Schuster e92e7e3bf5 Bug 1493292 - Remove len from nsTransferable. r=smaug
Depends on D11202

Differential Revision: https://phabricator.services.mozilla.com/D11203
2018-11-20 17:01:42 +00:00
Tom Schuster 4aff127bcd Bug 1493292 - Remove aDataLen parameters from nsITransferable.setTransferData. r=smaug
Depends on D11201

Differential Revision: https://phabricator.services.mozilla.com/D11202
2018-11-20 17:00:09 +00:00
Tom Schuster 8b2f90e93c Bug 1493292 - Remove aDataLen parameters from nsITransferable.getTransferData. r=smaug
Depends on D11200

Differential Revision: https://phabricator.services.mozilla.com/D11201
2018-11-20 16:59:56 +00:00
Tom Schuster 77af0dcdb5 Bug 1493292 - GetStringSize instead of aDataLen. r=mats
Differential Revision: https://phabricator.services.mozilla.com/D11200
2018-11-20 16:59:39 +00:00
Csoregi Natalia 5ada471f97 Backed out 6 changesets (bug 1493292) for bustage on /nsTransferable.cpp. CLOSED TREE
Backed out changeset f198bf91320b (bug 1493292)
Backed out changeset 6487aa307123 (bug 1493292)
Backed out changeset f2cabd69c568 (bug 1493292)
Backed out changeset 71430fceb4a3 (bug 1493292)
Backed out changeset 3a9b6d65d8c7 (bug 1493292)
Backed out changeset 55769869037c (bug 1493292)
2018-11-20 17:13:18 +02:00
Tom Schuster b2f368ccad Bug 1493292 - Remove len from nsIFormatConverter. r=smaug
Depends on D11204

Differential Revision: https://phabricator.services.mozilla.com/D11205
2018-11-20 14:47:13 +00:00
Tom Schuster fd4ea95eb8 Bug 1493292 - Remove len from nsIFlavorDataProvider r=smaug
Depends on D11203

Differential Revision: https://phabricator.services.mozilla.com/D11204
2018-11-20 14:47:11 +00:00
Tom Schuster 881593ac9a Bug 1493292 - Remove len from nsTransferable. r=smaug
Depends on D11202

Differential Revision: https://phabricator.services.mozilla.com/D11203
2018-11-20 14:47:09 +00:00
Tom Schuster f500ae50a9 Bug 1493292 - Remove aDataLen parameters from nsITransferable.setTransferData. r=smaug
Depends on D11201

Differential Revision: https://phabricator.services.mozilla.com/D11202
2018-11-20 14:47:04 +00:00
Tom Schuster e294f7e628 Bug 1493292 - Remove aDataLen parameters from nsITransferable.getTransferData. r=smaug
Depends on D11200

Differential Revision: https://phabricator.services.mozilla.com/D11201
2018-11-20 14:47:02 +00:00
Tom Schuster 3c8ca4e7a5 Bug 1493292 - GetStringSize instead of aDataLen. r=mats
Differential Revision: https://phabricator.services.mozilla.com/D11200
2018-11-20 14:45:27 +00:00
Boris Zbarsky 0b17fcf81f Bug 1507540 part 5. Use more notxpcom attributes in widget/. r=ehsan 2018-11-19 20:17:54 -05:00
Rob Wu 89a2f88466 Bug 1482540 - Avoid file IO in content proceesses in nsTransferable r=Ehsan,mstange
Large clipboard data (in nsTransferable) in content processes is no
longer stored in a temporary file, but kept in memory.

Differential Revision: https://phabricator.services.mozilla.com/D10336
2018-11-14 22:16:17 +01:00
Tom Schuster d3ca356650 Bug 1503577 - Change CreateDataFromPrimitive aDataLen to out parameter with size of string in bytes. r=mstange
Right now CreateDataFromPrimitive doesn't use the aDataLen parameter, and after this change the out
value should be the same as the value passed in, as long as we are dealing with strings.

Differential Revision: https://phabricator.services.mozilla.com/D10718
2018-11-09 13:24:28 +00:00
Tom Schuster 9c64b67174 Bug 1503588 - Remove aDataLen parameter from nsITransferable.getAnyTransferData. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D10441
2018-11-02 11:02:25 +00:00
Gabriele Svelto 6036698e99 Bug 1503207 - Remove nsWeakPtr.h and cleanup all files including weak reference-related headers r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D10251
2018-10-31 20:39:03 +00:00
Tom Schuster 5bdbd30146 Bug 1499821 - Introduce the FindDataFlavor helper function to nsTransferable. r=froydnj
This combines some of your ideas from D8074, in which I think is quite a big improvement to the overall code.

The code for nsTransferable::GetTransferData, especially nsIFlavorDataProvider is a bit wonky, because I tried to preserve the current behavior.

Differential Revision: https://phabricator.services.mozilla.com/D9599
2018-10-25 10:04:43 +00:00
Csoregi Natalia 07b9f8f150 Backed out changeset 7b87be447ed8 (bug 1499821) for bustages on nsTransferable.h. CLOSED TREE 2018-10-25 01:26:25 +03:00
Tom Schuster 854230e5fd Bug 1499821 - Introduce the FindDataFlavor helper function to nsTransferable. r=froydnj
This combines some of your ideas from D8074, in which I think is quite a big improvement to the overall code.

The code for nsTransferable::GetTransferData, especially nsIFlavorDataProvider is a bit wonky, because I tried to preserve the current behavior.

Differential Revision: https://phabricator.services.mozilla.com/D9599
2018-10-24 21:34:32 +00:00
Tom Schuster 467c9cb0eb Bug 1500954 - Remove special zero length handling in nsITransferable.GetTransferData. r=mats
Differential Revision: https://phabricator.services.mozilla.com/D9423
2018-10-24 21:32:04 +00:00
Tom Schuster 6b6f0ad2d7 Bug 1499821 - Some general code style fixes for nsTransferable. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D9496
2018-10-23 12:17:02 +00:00
Tom Schuster 73b02a2a28 Bug 1499821 - Remove unused nsITransferable.isLargeDataSet. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D9440
2018-10-22 21:46:38 +00:00
Tom Schuster ef1837777b Bug 1497476 - Remove nsITransferable.kFlavorHasDataProvider. r=NeilDeakin
Depends on D8074

Differential Revision: https://phabricator.services.mozilla.com/D8075
2018-10-16 20:35:10 +00:00
Tom Schuster 01783a4c3d Bug 1497476 - Clang-format nsTransferable.cpp. r=froydnj
Running clang-format makes this code at least a bit more pleasant to look at.

Differential Revision: https://phabricator.services.mozilla.com/D8074
2018-10-17 16:48:43 +00:00
Tom Schuster 2b5e95f0f2 Bug 1497831 - Use nsTArray instead of nsIArray for nsIFormatConverter. r=smaug
Depends on D8194

Differential Revision: https://phabricator.services.mozilla.com/D8195
2018-10-10 20:26:06 +00:00
Tom Schuster 8e820b5c01 Bug 1497831 - Use nsTArray instead of nsIArray for nsITransferable. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D8194
2018-10-10 20:25:54 +00:00
Boris Zbarsky 5f546dac16 Bug 1455676 part 3. Remove nsIDOMNode usage from widget/. r=qdot 2018-05-29 22:58:48 -04:00
Rob Wu 66d8ec0ec6 Bug 1433030 - Initialize nsTransferable::mPrivateData with false r=jdm
Initialize mPrivateData to false by default again, because the
change that changed the default value from true to false, i.e.
https://hg.mozilla.org/mozilla-central/rev/9e19b58d6494
prevented the clipboard from being backed by the filesystem,
as shown at https://bugzilla.mozilla.org/show_bug.cgi?id=1433030#c7

MozReview-Commit-ID: DEw5ETVqab8
2018-03-07 10:21:50 +01:00
Rob Wu 14795ac60e Bug 335545 - Make DataStruct non-copyable r=mstange
DataStruct cannot safely be copied if its mCacheFD member is set.
Currently there is no code for this case, but to avoid problems later,
mark the copy and assignment constructors private and delete them.

A move-constructor was added to compensate for the deleted copy
constructor. nsTransferable::AddDataFlavor uses this new constructor
instead of the previous implicit default copy constructor.

MozReview-Commit-ID: 3N5xjFXOUKB
2018-02-25 17:36:08 +01:00
Rob Wu 510491a7b2 Bug 335545 - Store clipboard data in memory XOR file r=mstange
Ensure that only DataStruct::mData + mDataLen, XOR
DataStruct::mCacheFD is used.
(Previously it was possible that all of these members were populated,
 which is a waste of memory.)

The effect of this change is visible when SetTransferData is called
multiple times with the same flavor, but with one below the threshold
for storing in-memory, and the other above (=store in a file).

MozReview-Commit-ID: 4UlkKAYsjf
2017-09-03 03:21:45 +02:00