Commit Graph
66 Commits
Author SHA1 Message Date
Gregory Pappas 0e57f440a0 Bug 1914559 - Remove fallback to hidden window in WindowsUIUtils::UpdateInTabletMode r=win-reviewers,rkraesig
If there aren't any browser windows, we're either very early in startup
or shutting down. In these cases, it's probably fine to not know if
tablet mode is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D219945
2024-08-28 19:30:43 +00:00
Magnus Melin bbd67965e9 Bug 1898709 - Use GetMostRecentBrowserWindow() instead of GetMostRecentWindow(u"navigator:browser") to cater for Thunderbird's main window. r=nalexander
Based on https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1863798-toast-notification-foreground-mail-client-m-c.patch

Fixed cases where general code assume main window is Firefox.
GetMostRecentBrowserWindow is getting "navigator:browser" for Firefox, so there is no change in behavior,
but it means more things will work for Thunderbird.

Differential Revision: https://phabricator.services.mozilla.com/D211520
2024-05-24 17:43:52 +00:00
Masatoshi Kimura 1ffc0764f4 Bug 1852806 - Remove macros for older Windows SDK from widget/windows/. r=handyman
Depends on D188031

Differential Revision: https://phabricator.services.mozilla.com/D188032
2023-09-15 03:19:28 +00:00
Cosmin Sabou eab17df623 Backed out 15 changesets (bug 1852806) for causing mda failures on test_video_low_power_telemetry.html. CLOSED TREE
Backed out changeset faea1f4cb9a9 (bug 1852806)
Backed out changeset 4db93c374f9b (bug 1852806)
Backed out changeset 7e40e0e04921 (bug 1852806)
Backed out changeset b0a66c4269ce (bug 1852806)
Backed out changeset 4ff3545936f9 (bug 1852806)
Backed out changeset 02c0a8eb3fd6 (bug 1852806)
Backed out changeset ae2c7b33acfb (bug 1852806)
Backed out changeset 2b89ba254a1a (bug 1852806)
Backed out changeset dfa4f73fc548 (bug 1852806)
Backed out changeset daffcc4c1877 (bug 1852806)
Backed out changeset 33855bcdf15e (bug 1852806)
Backed out changeset 694f29707f3e (bug 1852806)
Backed out changeset 1891eda22a59 (bug 1852806)
Backed out changeset 1b854941389c (bug 1852806)
Backed out changeset 2f7cfe04be59 (bug 1852806)
2023-09-15 09:48:27 +03:00
Masatoshi Kimura 22c1cfabaa Bug 1852806 - Remove macros for older Windows SDK from widget/windows/. r=handyman
Depends on D188031

Differential Revision: https://phabricator.services.mozilla.com/D188032
2023-09-15 03:19:28 +00:00
Peter Van der Beken 5dc8782829 Bug 1846277 - Untangle nsGlobalWindow*.h includes. r=dom-core,media-playback-reviewers,sessionstore-reviewers,padenot,farre
Differential Revision: https://phabricator.services.mozilla.com/D184978
2023-08-02 20:41:49 +00:00
Masatoshi Kimura a3e419385e Bug 1844908 - Remove pre-Win10-specific codepath from widget/. r=handyman
Differential Revision: https://phabricator.services.mozilla.com/D184307
2023-07-26 08:52:54 +00:00
Natalia Csoregi 42e803a2dd Backed out 19 changesets (bug 1844908) for causing win bustage on AvailableMemoryTracker.cpp. CLOSED TREE
Backed out changeset 44c66f2233cf (bug 1844908)
Backed out changeset a8010ff534bf (bug 1844908)
Backed out changeset 225dc3aeb220 (bug 1844908)
Backed out changeset a1414db64e33 (bug 1844908)
Backed out changeset 7f1e0a527839 (bug 1844908)
Backed out changeset 6dc7646d1ffa (bug 1844908)
Backed out changeset 8d715131510f (bug 1844908)
Backed out changeset 4b6fe8a4e7db (bug 1844908)
Backed out changeset 2b419fabf1e8 (bug 1844908)
Backed out changeset af84e701d616 (bug 1844908)
Backed out changeset 2fa203969ec5 (bug 1844908)
Backed out changeset 2b3d2df94db3 (bug 1844908)
Backed out changeset 7eca452f5fd7 (bug 1844908)
Backed out changeset 3d961cf25afe (bug 1844908)
Backed out changeset 3c59143f8dd7 (bug 1844908)
Backed out changeset ab50c6c5425a (bug 1844908)
Backed out changeset b2c5636df673 (bug 1844908)
Backed out changeset e9a0f1c6760c (bug 1844908)
Backed out changeset 945ccbedde0b (bug 1844908)
2023-07-25 19:55:35 +03:00
Masatoshi Kimura 4182954d50 Bug 1844908 - Remove pre-Win10-specific codepath from widget/. r=handyman
Differential Revision: https://phabricator.services.mozilla.com/D184307
2023-07-25 14:41:05 +00:00
CanadaHonk 78363430df Bug 1736914 - Implement prefers-reduced-transparency media query r=geckoview-reviewers,emilio,jonalmeida,ohall
Implemented the prefers-reduced-transparency media query for all
platforms.

Windows and Mac have specific settings which are used, others (Android
and Linux/GTK) have it enabled if prefers-reduced-motion is also enabled
as there is no dedicated setting to check.

Locked behind new pref `layout.css.prefers-reduced-transparency.enabled`,
off by default always for now.

Also added new WPT tests (none previously).

Demo video: https://goose.icu/firefox_prt.mp4
Test page: https://goose.icu/prefers-reduced-transparency

Differential Revision: https://phabricator.services.mozilla.com/D172424
2023-03-13 21:30:17 +00:00
Emilio Cobos Álvarez 2ecea6f071 Bug 1778444 - Clear UISettings on shutdown. r=kaie
This should be the right fix.

Differential Revision: https://phabricator.services.mozilla.com/D151311
2022-07-07 21:17:36 +00:00
Emilio Cobos Álvarez e75f1ad698 Bug 1776556 - Restore Windows' accent-color / system-color behavior for now. r=mstange
This basically pref-gates some of the accent-color changes that landed before
the soft-freeze to match current release behavior, at least for now.

In the future we might want to reconsider turning these on, but at the very
least we should figure out a good story for the grey-ish accent colors, see the
comments in the pref definitions.

The only tricky bit is the use-theme-accent pref handling. I made it specific
to the non-native-theme again so that AccentColor and NNT kept behaving
consistently, but AccentColor in the browser chrome used the real accent color.

Differential Revision: https://phabricator.services.mozilla.com/D150339
2022-06-28 18:55:27 +00:00
Emilio Cobos Álvarez 7f9951da6c Bug 1775310 - Add some accent-color-based dark mode system colors on Windows. r=handyman
This matches UWP apps like Settings on Windows 11, and what we do for other
desktop platforms too.

The system colors match the ones from Win32 otherwise, but using UIUtils we can
access the accent color pallete from UWP apps.

Add a pref just to be safe in any case.

Differential Revision: https://phabricator.services.mozilla.com/D149905
2022-06-22 09:47:27 +00:00
Emilio Cobos Álvarez 950b711edf Bug 1773342 - Expose Windows' text scale factor to LookAndFeel. r=handyman
Much like we expose overlay scrollbars.

Differential Revision: https://phabricator.services.mozilla.com/D148675
2022-06-09 22:44:28 +00:00
Mike Hommey 67709fcc39 Bug 1766359 - Fix unreachable-code-return warnings in Windows builds. r=emilio,mhowell,nika,rkraesig
dom/system/PathUtils.cpp(77,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
  return false;
         ^~~~~
ipc/chromium/src/chrome/common/ipc_channel_win.cc(479,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
  return true;
         ^~~~
mozglue/misc/PreXULSkeletonUI.cpp(1263,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
  return 0;
         ^
mozglue/tests/TestPEExportSection.cpp(348,12): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
    return 0;
           ^
security/manager/ssl/OSReauthenticator.cpp(428,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
  return NS_OK;
         ^~~~~
toolkit/components/maintenanceservice/maintenanceservice.cpp(214,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
  return 0;
         ^
widget/windows/WindowsUIUtils.cpp(383,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
  return false;
         ^~~~~

Differential Revision: https://phabricator.services.mozilla.com/D144661
2022-04-26 21:44:54 +00:00
Emilio Cobos Álvarez 0505b039de Bug 1757647 - Implement Windows 11 overlay scrollbars. r=cmartin
Put it behind a pref for nightly and early beta for now.

Differential Revision: https://phabricator.services.mozilla.com/D139987
2022-03-02 12:02:00 +00:00
Emilio Cobos Álvarez 9b50d5f02b Bug 1757647 - Simplify WindowsUIUtils tablet mode stuff. r=saschanaz
No need for it to use so much XPCOM.

Differential Revision: https://phabricator.services.mozilla.com/D139986
2022-03-02 12:02:00 +00:00
Ben Hearsum a43d6f6bf9 Bug 1751010: Use a unique icon for the Private Browsing taskbar pin r=mhowell
This is subject to the same issue as an earlier patch in this series -- the icon will be wrong briefly at first launch, before the code in `BrowserContentHandler.jsm` replaces the default icon with the correct one.

Differential Revision: https://phabricator.services.mozilla.com/D138601
2022-03-01 14:16:48 +00:00
Butkovits Atila 441a1d2141 Backed out 5 changesets (bug 1751010) for causing failures at browser_startup_mainthreadio.js. CLOSED TREE
Backed out changeset af347bb985d4 (bug 1751010)
Backed out changeset 9944e42017ff (bug 1751010)
Backed out changeset 282a5cd52cd0 (bug 1751010)
Backed out changeset 2f54afb16002 (bug 1751010)
Backed out changeset 6ad85a8edf15 (bug 1751010)
2022-02-27 03:40:08 +02:00
Ben Hearsum 6a6d5f22b9 Bug 1751010: Use a unique icon for the Private Browsing taskbar pin r=mhowell
This is subject to the same issue as an earlier patch in this series -- the icon will be wrong briefly at first launch, before the code in `BrowserContentHandler.jsm` replaces the default icon with the correct one.

Differential Revision: https://phabricator.services.mozilla.com/D138601
2022-02-25 18:33:46 +00:00
Marian-Vasile Laza 7824ab98b3 Backed out 4 changesets (bug 1751010) for causing xpcshell failures on test_taskbar_jumplistitems.js. CLOSED TREE
Backed out changeset 1ff3b5528d53 (bug 1751010)
Backed out changeset a21f1d8b6d8b (bug 1751010)
Backed out changeset 11df8f060a35 (bug 1751010)
Backed out changeset b94765877d57 (bug 1751010)
2022-02-23 14:56:22 -08:00
Ben Hearsum 8e1d3e8289 Bug 1751010: Use a unique icon for the Private Browsing taskbar pin r=mhowell
This is subject to the same issue as an earlier patch in this series -- the icon will be wrong briefly at first launch, before the code in `BrowserContentHandler.jsm` replaces the default icon with the correct one.

Differential Revision: https://phabricator.services.mozilla.com/D138601
2022-02-23 13:58:18 +00:00
Csoregi Natalia e8626c4668 Backed out 4 changesets (bug 1751010) for win bustages on nsWindow.cpp. CLOSED TREE
Backed out changeset b68d86cc545d (bug 1751010)
Backed out changeset b51b389bd0fd (bug 1751010)
Backed out changeset f128c61e50eb (bug 1751010)
Backed out changeset 1cbe75d59770 (bug 1751010)
2022-02-22 21:17:27 +02:00
Ben Hearsum fb468e5e03 Bug 1751010: Use a unique icon for the Private Browsing taskbar pin r=mhowell
This is subject to the same issue as an earlier patch in this series -- the icon will be wrong briefly at first launch, before the code in `BrowserContentHandler.jsm` replaces the default icon with the correct one.

Differential Revision: https://phabricator.services.mozilla.com/D138601
2022-02-22 18:16:36 +00:00
Rashelle Hopkins 8596b81d86 Bug 1592234 - Add window icon to PiP window r=kpatenio,mhowell
Differential Revision: https://phabricator.services.mozilla.com/D134429
2022-01-11 16:21:09 +00:00
Alexandru Michis 71dfbea440 Backed out changeset 539230e86e11 (bug 1722208) for causing windows to get stuck in tablet mode on Windows 11 - no minimize and maximize buttons (bug 1735961)
CLOSED TREE
2021-10-15 18:32:49 +03:00
Gabriele Svelto 2089daed7c Bug 1722208 - Workaround to make the Windows on-screen keyboard work properly on convertible slates running Windows 11 r=cmartin
Differential Revision: https://phabricator.services.mozilla.com/D128229
2021-10-14 08:30:32 +00:00
Kagami Sascha Rosylight 6d7fd6c1fe Bug 1641280 - Part 2: Resolve WindowsUIUtils::Share without waiting action on Windows r=smaug,agashlin
Windows does not fire any DataPackage event when a user selects copy action from the OS dialog, potentially causing never-resolved promise. Windows still does not provide any other way to detect that action, even on Windows 11.

Per https://github.com/w3c/web-share/issues/188 Chromium gave up and decided not to wait for user action.

Given that Microsoft is not expected to fix the situation anytime soon, it's probably better to follow what others do.

Depends on D121420

tmp

Differential Revision: https://phabricator.services.mozilla.com/D121421
2021-08-04 13:53:12 +00:00
Kagami Sascha Rosylight 51230037be Bug 1641280 - Part 1: Fix lint warnings in WindowsUIUtils r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D121420
2021-08-04 13:53:12 +00:00
Alexandru Michis 4c97b63367 Backed out 3 changesets (bug 1641280) for causing bustages.
CLOSED TREE

Backed out changeset aa2915f66825 (bug 1641280)
Backed out changeset 080107249a1c (bug 1641280)
Backed out changeset b183dae47176 (bug 1641280)
2021-08-04 16:45:32 +03:00
Kagami Sascha Rosylight 65308a534b Bug 1641280 - Part 2: Resolve WindowsUIUtils::Share without waiting action on Windows r=smaug,agashlin
Windows does not fire any DataPackage event when a user selects copy action from the OS dialog, potentially causing never-resolved promise. Windows still does not provide any other way to detect that action, even on Windows 11.

Per https://github.com/w3c/web-share/issues/188 Chromium gave up and decided not to wait for user action.

Given that Microsoft is not expected to fix the situation anytime soon, it's probably better to follow what others do.

Depends on D121420

tmp

Differential Revision: https://phabricator.services.mozilla.com/D121421
2021-08-04 13:27:15 +00:00
Kagami Sascha Rosylight d855ee3ecb Bug 1641280 - Part 1: Fix lint warnings in WindowsUIUtils r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D121420
2021-08-04 13:27:14 +00:00
Simon Giesecke d6bac217cb Bug 1677284 - Move PackingStrategy::Variant implementation to separate header file. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D97075
2020-11-23 15:49:14 +00:00
Simon Giesecke a69d79b6db Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Masatoshi Kimura d41aaad457 Bug 1615769 - Move using namespace mozilla in order to resolve conflicts with Windows headers. r=saschanaz
Differential Revision: https://phabricator.services.mozilla.com/D62989
2020-02-15 05:57:58 +00:00
Kagami Sascha Rosylight 0a9b518b43 Bug 1573029 - Windows Web Share implementation r=marcosc,farre
Differential Revision: https://phabricator.services.mozilla.com/D44613
2020-02-13 14:21:06 +00:00
Kagami Sascha Rosylight 2c4b8a3a78 Bug 1613643 - Fix build failure by Err(). a=bustage-fix-for-mingw CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D61822
2020-02-06 16:13:29 +01:00
Kagami Sascha Rosylight b0a4fca289 Bug 1613643 - Fix build failure by Result<>
Differential Revision: https://phabricator.services.mozilla.com/D61818
2020-02-06 13:33:27 +00:00
Kagami Sascha Rosylight b54e0c81f8 Bug 1573029 - Add WindowsShare API r=marcosc,agashlin
Currently WindowsUIUtils::ShareUrl only support sharing a URL and a title and then ignores what the user actually do with it. This patch adds text sharing support and returns MozPromise to resolve or reject as the user wants.

Differential Revision: https://phabricator.services.mozilla.com/D42484
2020-02-06 11:12:55 +00:00
Dave Townsend 9f448e9415 Bug 1602194: Use the site's icons for the SSB UI window. r=mhowell,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D56634
2019-12-18 16:37:55 +00:00
Narcis Beleuzu 9f61abce8d Backed out 3 changesets (bug 1602191, bug 1602194, bug 1602196) for Windows MinGW bustages on WindowsUIUtils.cpp. CLOSED TREE
Backed out changeset 73c93dc0c790 (bug 1602196)
Backed out changeset ab3c0af1ec40 (bug 1602194)
Backed out changeset f1b308c595c8 (bug 1602191)
2019-12-17 05:41:41 +02:00
Dave Townsend 57790ebe9b Bug 1602194: Use the site's icons for the SSB UI window. r=mhowell,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D56634
2019-12-16 20:14:43 +00:00
Gabriele Svelto f03cdb2b2d Bug 1600545 - Remove useless inclusions of header files generated from IDL files in modules/, netwerk/, parser/, security/, startupcache/, storage/, toolkit/, tools/, uriloader/, widget/, xpcom/ and xpfe/ r=Ehsan
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55444
2019-12-06 09:17:57 +00:00
Brendan Dahl ef30c33394 Bug 1470510 - Rename nsXULWindow and nsIXULWindow to AppWindow and nsIAppWindow. r=smaug
nsXULWindow is no longer XUL specific and is somewhat confusing name.

Differential Revision: https://phabricator.services.mozilla.com/D51486
2019-11-05 17:56:28 +00:00
Mihai Alexandru Michis 5803a050c4 Backed out 2 changesets (bug 1470510) for causing bustages in widget/cocoa/nsChildView.mm CLOSED TREE
Backed out changeset a343f30c34a3 (bug 1470510)
Backed out changeset 4da64790094d (bug 1470510)
2019-11-05 09:24:26 +02:00
Brendan Dahl b484de8fe7 Bug 1470510 - Rename nsXULWindow and nsIXULWindow to AppWindow and nsIAppWindow. r=smaug
nsXULWindow is no longer XUL specific and is somewhat confusing name.

Differential Revision: https://phabricator.services.mozilla.com/D51486
2019-11-04 23:37:31 +00:00
Dorel Luca bcbec745b9 Backed out 2 changesets (bug 1470510) for build bustage on /build/src/widget/cocoa/nsChildView.mm. CLOSED TREE
Backed out changeset 5967bf633574 (bug 1470510)
Backed out changeset 067a556bb614 (bug 1470510)
2019-11-04 19:18:56 +02:00
Brendan Dahl 4f87b88cc6 Bug 1470510 - Rename nsXULWindow and nsIXULWindow to AppWindow and nsIAppWindow. r=smaug
nsXULWindow is no longer XUL specific and is somewhat confusing name.

Differential Revision: https://phabricator.services.mozilla.com/D51486
2019-11-04 16:52:35 +00:00
Felipe Gomes ac9745e8b0 Bug 827976 - Tablet Mode detection should favor using an existing window instead of the hidden window. r=aklotz
Differential Revision: https://phabricator.services.mozilla.com/D21073
2019-03-04 20:21:09 +00:00
Cosmin Sabou 45f2559b66 Backed out 16 changesets (bug 827976) for causing bug 1532054. a=backout
Backed out changeset 54c0b12443ed (bug 827976)
Backed out changeset 92b45080d080 (bug 827976)
Backed out changeset 443087a359f9 (bug 827976)
Backed out changeset f976c2d4cebb (bug 827976)
Backed out changeset 66cffb171024 (bug 827976)
Backed out changeset 845e1d0b2402 (bug 827976)
Backed out changeset fd94066a1d76 (bug 827976)
Backed out changeset e253b264e7bd (bug 827976)
Backed out changeset 07ef335770a8 (bug 827976)
Backed out changeset 9d3805d77b99 (bug 827976)
Backed out changeset eed600ceb606 (bug 827976)
Backed out changeset 3b64368cff52 (bug 827976)
Backed out changeset 69d0378e0c09 (bug 827976)
Backed out changeset 9203871a5c6f (bug 827976)
Backed out changeset 96a507c818e2 (bug 827976)
Backed out changeset e254496ff95b (bug 827976)
2019-03-02 20:40:01 +02:00