Commit Graph
399 Commits
Author SHA1 Message Date
Sylvestre Ledru a3ea006705 Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,necko-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,devtools-reviewers,anti-tracking-reviewers,profiler-reviewers,win-reviewers,migration-reviewers,padenot,mconley,nchevobbe,kershaw,gstoll,mstange,bytesized,m_kato
This new version of clang 17 also slightly changed the formatting.

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D215914
2024-07-17 11:15:31 +00:00
Paul Bone 8339509cc6 Bug 1885466 - Rename jemalloc_stats::page_cache to pages_dirty r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D204724
2024-03-28 02:41:09 +00:00
Paul Bone 09c11af7e9 Bug 1878806 - pt 2. Add about:memory entries for fresh and madvised pages r=mccr8,glandium
Differential Revision: https://phabricator.services.mozilla.com/D200750
2024-03-26 05:06:15 +00:00
Paul Bone a6944726a3 Bug 1878806 - pt 1. Move mozjemalloc stats into their own tree r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D200749
2024-03-26 05:06:15 +00:00
Paul Bone 3fec5a84b4 Bug 1854550 - pt 9. Move PHC interface from the bridge to PHC.h r=glandium
Building PHC in a unified build now also works.

Differential Revision: https://phabricator.services.mozilla.com/D191133
2023-10-19 06:38:42 +00:00
Sylvestre Ledru b0fe72dee5 Bug 1856795 - Remove redundant member init r=emilio
Done with:
./mach static-analysis check --checks="-*, readability-redundant-member-init" --fix .

https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html

Differential Revision: https://phabricator.services.mozilla.com/D190002
2023-10-15 15:29:02 +00:00
Cristina Horotan 7388749830 Backed out 2 changesets (bug 1856795) for causing build bustage at BasicEvents.h CLOSED TREE
Backed out changeset 1d98b028923a (bug 1856795)
Backed out changeset eae2ac93e17c (bug 1856795)
2023-10-14 21:42:14 +03:00
Sylvestre Ledru 4a97019e39 Bug 1856795 - Remove redundant member init r=emilio
Done with:
./mach static-analysis check --checks="-*, readability-redundant-member-init" --fix .

https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html

Differential Revision: https://phabricator.services.mozilla.com/D190002
2023-10-14 17:34:26 +00:00
Nika Layzell f56b27a28d Bug 1851045 - Part 3: Fix potential issue with late shutdown nsThread creation, r=xpcom-reviewers,KrisWright
This fixes the issue described in comment 7 by doing a few changes to how threads are created, and members on nsThreadManager are managed.

 * The thread list is moved to be a member of `nsThreadManager`, which is
   already a statically allocated singleton.

 * The flag for whether new thread creation is allowed is moved from being an
   atomic to being guarded by the same mutex as the thread list, meaning that
   it could be checked and a new thread could be added to the list atomically.

 * Threads which require shutdown are initialized atomically from the point of
   view of the thread manager, meaning that the check in ShutdownNonMainThreads
   is guaranteed to catch all successfully started nsThread instances.

Differential Revision: https://phabricator.services.mozilla.com/D188623
2023-09-27 19:14:16 +00:00
Iulian Moraru 4a4a6a9477 Backed out 3 changesets (bug 1851045) for causing multiple crashes related to LinkedList.
Backed out changeset c813616ed664 (bug 1851045)
Backed out changeset c53ebef234df (bug 1851045)
Backed out changeset 3350d1b78562 (bug 1851045)
2023-09-21 03:07:37 +03:00
Nika Layzell 4cd32e8655 Bug 1851045 - Part 3: Fix potential issue with late shutdown nsThread creation, r=xpcom-reviewers,KrisWright
This fixes the issue described in comment 7 by doing a few changes to how threads are created, and members on nsThreadManager are managed.

 * The thread list is moved to be a member of `nsThreadManager`, which is
   already a statically allocated singleton.

 * The flag for whether new thread creation is allowed is moved from being an
   atomic to being guarded by the same mutex as the thread list, meaning that
   it could be checked and a new thread could be added to the list atomically.

 * Threads which require shutdown are initialized atomically from the point of
   view of the thread manager, meaning that the check in ShutdownNonMainThreads
   is guaranteed to catch all successfully started nsThread instances.

Differential Revision: https://phabricator.services.mozilla.com/D188623
2023-09-20 21:46:05 +00:00
Paul Bone bab2dfabbe Bug 1831852 - Avoid extra call to jemalloc_stats in telemetry r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D177596
2023-05-11 04:40:44 +00:00
Paul Bone 309a477c41 Bug 1831852 - Use const refs for the HeapOverhead parameter r=mccr8
Improve style by using const refs rather than raw pointers for these
functions.

Differential Revision: https://phabricator.services.mozilla.com/D177595
2023-05-11 04:40:44 +00:00
Andrew McCreight 43a7ece656 Bug 1806852 - Use nsThread::GetThreadName in the threads memory reporter. r=xpcom-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D176191
2023-04-21 22:00:55 +00:00
Paul Bone e2a51aae2f Bug 1825467 - Add missing include r=cosmins
Differential Revision: https://phabricator.services.mozilla.com/D174086
2023-03-30 11:51:46 +00:00
Paul Bone 2f8dd751d0 Bug 1822451 - Add about:memory entries for PHC r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D173099

Depends on D173098
2023-03-29 11:08:17 +00:00
Cosmin Sabou e451c9aafd Backed out 3 changesets (bug 1822451) for busting thunderbird builds and causing bug 1825467. CLOSED TREE
Backed out changeset 5c399ec3dae0 (bug 1822451)
Backed out changeset ac5d1057c562 (bug 1822451)
Backed out changeset 42250977529b (bug 1822451)
2023-03-30 14:30:22 +03:00
Cosmin Sabou 8498353405 Backed out changeset e5b65704ade8 (bug 1825467) for causing asan/tsan build bustages on nsMemoryReporterManager.cpp. 2023-03-30 14:23:02 +03:00
Paul Bone 20f32c7a73 Bug 1825467 - Add missing include r=CosminS
Differential Revision: https://phabricator.services.mozilla.com/D174086
2023-03-30 10:50:56 +00:00
Paul Bone edf5f6581e Bug 1822451 - Add about:memory entries for PHC r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D173099
2023-03-29 11:08:17 +00:00
Makoto Kato 865324c155 Bug 1821004 - Add summary.java-heap memory report. r=geckoview-reviewers,owlish
Android's memory profiler can show current java-heap size. Android M+
can get this usages from API. So this fix adds this entry to
about:memory.

Differential Revision: https://phabricator.services.mozilla.com/D172211
2023-03-22 12:31:46 +00:00
Andreas Farre 18b9822941 Bug 1812035 - Fix broken about:memory tests. r=smaug
Tests for about:memory doesn't know about utility processes. Make sure
to hide the utility process reporter when needed.

Differential Revision: https://phabricator.services.mozilla.com/D167662
2023-02-06 15:52:28 +00:00
Narcis Beleuzu 47cb05bbf5 Backed out 3 changesets (bug 1812275, bug 1812035, bug 1806501) for bc failures on browser_aboutprocesses_default_options.js .
Backed out changeset 4f13d8470d97 (bug 1806501)
Backed out changeset a276a2939cee (bug 1812275)
Backed out changeset 67775732c1a8 (bug 1812035)
2023-01-27 17:14:57 +02:00
Andreas Farre 8ef1c9c7af Bug 1812035 - Fix broken about:memory tests. r=smaug
Tests for about:memory doesn't know about utility processes. Make sure
to hide the utility process reporter when needed, and count the number
of living processes, also when needed.

Differential Revision: https://phabricator.services.mozilla.com/D167662
2023-01-27 09:17:16 +00:00
Sandor Molnar f9b2395cee Backed out 2 changesets (bug 1812035, bug 1806501) for causing bc failures in ipc/glue/test/browser/browser_utility_audioDecodeCrash.js CLOSED TREE
Backed out changeset d7f1a776a986 (bug 1806501)
Backed out changeset 4a44daa59af4 (bug 1812035)
2023-01-24 18:31:34 +02:00
Andreas Farre ad29180b54 Bug 1812035 - Fix broken about:memory tests. r=smaug
Tests for about:memory doesn't know about utility processes. Make sure
to hide the utility process reporter when needed, and count the number
of living processes, also when needed.

Differential Revision: https://phabricator.services.mozilla.com/D167662
2023-01-24 15:37:49 +00:00
Paul Bone 2f27878131 Bug 1786860 - Use phys_footprint on MacOS to provide MEMORY_TOTAL r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D156309
2022-09-26 02:42:43 +00:00
Paul Bone e006f39ca6 Bug 1786860 - Use TASK_VM_INFO on Mac to provide a new about:memory measurement r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D153569
2022-09-26 02:42:42 +00:00
Paul Bone 2fcb78a4cd Bug 1777220 - Remove memory map assertions r=glandium
Now that we know these assertions fire, we can remove them.

Differential Revision: https://phabricator.services.mozilla.com/D150695
2022-06-30 04:11:11 +00:00
Paul Bone 536e83081d Bug 1743781 - The memory reporter will count jemalloc chunks as unique r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D144702
2022-06-29 06:47:04 +00:00
Randell Jesup 68cf532b4d Bug 1762469: xpcom memory reporter cleanup r=nika
Differential Revision: https://phabricator.services.mozilla.com/D142614
2022-04-04 22:57:37 +00:00
Alexandre Lissy d75f6c5c9b Bug 1753424 - Support running multiple UtilityProcess r=nika
Differential Revision: https://phabricator.services.mozilla.com/D139817
2022-03-26 19:46:43 +00:00
Cristian Tuns c6cb3415f1 Backed out 6 changesets (bug 1753424) for causing build bustages CLOSED TREE
Backed out changeset 930136daf858 (bug 1753424)
Backed out changeset d62c1e5d1881 (bug 1753424)
Backed out changeset 911060d2bd8e (bug 1753424)
Backed out changeset cce723862a92 (bug 1753424)
Backed out changeset 97b3fd69185b (bug 1753424)
Backed out changeset 4748652694c7 (bug 1753424)
2022-03-26 14:49:47 -04:00
Alexandre Lissy 5ddd71a38b Bug 1753424 - Support running multiple UtilityProcess r=nika
Differential Revision: https://phabricator.services.mozilla.com/D139817
2022-03-26 09:53:47 +00:00
Butkovits Atila 471aa4e8c0 Backed out 5 changesets (bug 1753424) for causing bustages. CLOSED TREE
Backed out changeset e2b40064eb59 (bug 1753424)
Backed out changeset 0892c1d3c379 (bug 1753424)
Backed out changeset 4df499ef4647 (bug 1753424)
Backed out changeset f27fbfb9e8f1 (bug 1753424)
Backed out changeset 0f244f2eb2de (bug 1753424)
2022-03-26 16:39:16 +02:00
Alexandre Lissy 457f0ad529 Bug 1753424 - Support running multiple UtilityProcess r=nika
Differential Revision: https://phabricator.services.mozilla.com/D139817
2022-03-26 09:53:47 +00:00
Paul Bone 18a336184b Bug 1704996 - Account for Apple Aarch64 shared memory region r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D139254
2022-02-22 23:42:08 +00:00
Alexandre Lissy 024fb283b1 Bug 1749809 - Basic memory reporting test for UtilityProcess r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D137774
2022-02-04 21:05:50 +00:00
Cristian Tuns 5a574896af Backed out 2 changesets (bug 1749809) for causing reftest failures on UtilityProcessManager.cpp CLOSED TREE
Backed out changeset 78a4a462c698 (bug 1749809)
Backed out changeset 4f55d4cc7b8c (bug 1749809)
2022-02-04 13:02:11 -05:00
Alexandre Lissy 8e9de4edef Bug 1749809 - Basic memory reporting test for UtilityProcess r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D137774
2022-02-04 15:17:26 +00:00
Paul Bone 77f2521440 Bug 1737199 - Avoid some VLAs when using jemalloc_stats r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D129228
2021-10-27 08:46:51 +00:00
criss 4fafb2df88 Backed out changeset 27b73fdbb4a9 (bug 1737199) for causing bustages on memory/replace/logalloc/replay/Replay.cpp. CLOSED TREE 2021-10-26 13:00:29 +03:00
Paul Bone 9b5c9187ca Bug 1737199 - Avoid some VLAs when using jemalloc_stats r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D129228
2021-10-26 05:22:05 +00:00
Paul Bone d51e99da4f Bug 1735250 - Provide a less-magic array size for jemalloc_stats r=glandium
jemalloc_stats takes an array for its second argument.  It expects this
array to have enough space for all the bins, previously the maximum was set
as a magic number.  To make it dependent on the configured bins this patch
replaces the compile-time constant with a function.

Differential Revision: https://phabricator.services.mozilla.com/D127761
2021-10-21 06:42:34 +00:00
Toshihito Kikuchi f607b1ae8c Bug 1586236 - Use memory resource notifications to detect low memory scenarios on Windows. r=gsvelto
This patch uses the low memory resource notification facility to detect
scenarios where physical memory is running low without polling. This is a
significant change compared to the previous behavior which measured both
available virtual memory (only on 32-bit builds) and available commit space.

Since we're not trying to avoid OOMs anymore we don't save memory reports
anymore when hitting a low-memory condition.

Differential Revision: https://phabricator.services.mozilla.com/D110354
2021-03-31 15:18:05 +00:00
Simon Giesecke 86e29e162f Bug 1695162 - Use range-based for instead of custom hashtable iterators. r=xpcom-reviewers,kmag
Differential Revision: https://phabricator.services.mozilla.com/D108585
2021-03-17 15:49:46 +00:00
Simon Giesecke 95c38cc6b8 Bug 1691913 - Rename nsBaseHashtable::Put to InsertOrUpdate. r=xpcom-reviewers,necko-reviewers,jgilbert,dragana,nika
This makes the naming more consistent with other functions called
Insert and/or Update. Also, it removes the ambiguity whether
Put expects that an entry already exists or not, in particular because
it differed from nsTHashtable::PutEntry in that regard.

Differential Revision: https://phabricator.services.mozilla.com/D105473
2021-02-26 09:11:46 +00:00
Simon Giesecke 5efd1faf25 Bug 1678062 - Remove unnecessary includes. r=andi
Differential Revision: https://phabricator.services.mozilla.com/D97467

Depends on D96561
2020-11-23 16:12:02 +00:00
Sylvestre Ledru 2785fba8c1 Bug 1519636 - Reformat with clang-format-11 to the Google coding style r=andi,sg,geckoview-reviewers,snorp
It is bringing some minor changes

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D90795
2020-11-18 09:05:59 +00:00
Paul Bone 47de2cafd9 Bug 1656155 - pt 3. Report bin stats in about:memory r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D85727
2020-10-08 22:43:18 +00:00