Commit Graph
28 Commits
Author SHA1 Message Date
Mark Banner 3d6aaad3f5 Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (automatic fixes). r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D8389
2018-10-19 12:55:39 +00:00
Julian Descottes de5cde2836 Bug 1480384 - Remove unused theme option for autocomplete-popup;r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D2666
2018-08-02 15:05:50 +00:00
Nicolas Chevobbe 767d3664e3 Bug 1478435 - Apply photon-styling to autocomplete popup; r=nchevobbe.
This removes the border-radius from the autocomplete popup (and
its items) and refines the spacing.
Since we have more padding for the autocomplete items, we need
to adjust the xOffset when showing the popup.
The yOffset of the webconsole autocomplete is tweaked a bit so
we see its border; the xOffset of the markup search input is also
tweaked to consider the left padding we use to display the search
icon in the input.

MozReview-Commit-ID: JyLySLBUgGy
2018-07-26 09:08:10 +02:00
Julian Descottes 82711b9a8f Bug 1454696 - Run eslint --fix for prefer-const;r=yulia
MozReview-Commit-ID: F6xUXCgdRE4
2018-06-01 12:36:09 +02:00
J. Ryan Stinnett 8d1c817851 Bug 1443081 - Apply spacing via eslint --fix for DevTools. r=jdescottes
MozReview-Commit-ID: 2RVNt140Zte
2018-03-12 13:44:41 -05:00
Jared Wein b00c9db5b7 Bug 1436575 - Add exceptions for cases that cannot be simplified by negation or !! coercion. r=standard8
MozReview-Commit-ID: 8uiZAPq4N2h
2018-02-09 10:10:08 -05:00
Jared Wein db0a992247 Bug 1436575 - Autofix errors from no-compare-against-boolean-literal. r=standard8
MozReview-Commit-ID: 66sXxnOWDgw
2018-02-08 12:57:31 -05:00
Tom Tromey 2c4ab81b95 Bug 1395262 - use plain console.error in devtools promise catches; r=bgrins
MozReview-Commit-ID: C8IhVPckQJ7
2017-08-30 12:05:41 -06:00
Paolo Amadini 7afba17088 Bug 1362970 - Part 2 - Script-generated patch to convert .then(null, ...) to .catch(...). r=florian
Changes to Promise tests designed to test .then(null) have been reverted, and the browser/extensions directory was excluded because the projects it contains have a separate process for accepting changes.

MozReview-Commit-ID: 1buqgX1EP4P
2017-06-19 11:32:37 +01:00
Sebastian Hengst c6d9ef3e98 Backed out changeset 6bc38f188ef2 (bug 1330099) for devtools failures. r=backout 2017-01-11 23:21:56 +01:00
Tim Nguyen 548b6bdbef Bug 1330099 - Enable object-shorthand eslint rule. r=jryans
MozReview-Commit-ID: 3wA25rfznBv
2017-01-11 21:22:15 +00:00
Gabriel Luong a61285b0f2 Bug 1322028 - Avoid destructuring requires where possible in the inspector. r=jdescottes 2016-12-17 12:44:56 +09:00
Gabriel Luong 4943d23a3b Bug 1307481 - Part 3: HTMLTooltip should receive the document that it should be attached to instead of the toolbox r=jdescottes 2016-10-08 09:49:07 -04:00
Greg Tatum d852cb3bc9 Bug 1289425 - Remove domUtils from source editor and autocomplete; r=tromey
MozReview-Commit-ID: HIhUkuKOsjg
2016-08-05 11:44:23 -05:00
Tom Tromey 44ebe29d9c Bug 1290227 - add replacement module for DOM_VK_ constants; r=bgrins
MozReview-Commit-ID: INmMxfP8ZuL
2016-08-08 15:41:37 -06:00
Tom Tromey 767191925e Bug 1293756 - avoid dynamic requires in autocomplete.js; r=bgrins
MozReview-Commit-ID: 8dMW32TkENl
2016-08-09 13:25:48 -06:00
Tom Tromey 42e05a9fc5 Bug 1292591 - use reject-some-requires eslint rule in sourceeditor; r=gregtatum
MozReview-Commit-ID: LdPU8bdSGd5
2016-08-05 09:09:27 -06:00
Julian Descottes 5bc2788731 Bug 1266456 - part9: use HTMLTooltip for autocomplete-popup;r=bgrins
Modify the devtools autocomplete-popup to rely on a HTMLTooltip instance
instead of a XUL panel.

Other than the straightforward migration to HTML, the main difference with
the new implementation is that the richlistbox has now been replace with a
simple HTML list element. The former XUL widget used to be able to take the
focus from the input it was linked to.

This is no longer the case. Most autocomplete users were always keeping the
focus in the input, except for the inspector-search, which was moving the
focus back and forth between the input and the autocomplete's richlistbox.
Now the focus is always in the input. A practical example to illustrate how
this changes the UX: before when the user had the focus on the first element
of the list, pressing "DOWN" would keep the element selected but visually move
the focus in the input. Now the selection simply cycles to the next item.

Even though this introduces a difference in behaviour compared to the previous
implementation, it makes the inspector search UX consistent with the other
autocomplete widgets used in devtools.

Another difference is about the display for the inspector-search. The position
of the autocomplete popup used to be above the input. This is now impossible to
achieve because the search input is at the top of the toolbox and the HTML tooltip
can not exceed the limits of the toolbox.

For this #2 issue, either we manage to use XUL panel wrappers, in which case, the
autocomplete will be displayed as it used to. Or we can invert the order in which
items are inserted and explicitly ask for the autocomplete to be displayed below the
input. I prefered not to change this here in order to make the code change easier to
understand, but it should be addressed in a follow-up.

MozReview-Commit-ID: jH9aXm9Jvz
2016-07-07 16:32:42 +02:00
Nicolas Chevobbe 48a36fbc0a Bug 1276465 - Check if autompleter map item exists before using it. r=bgrins
MozReview-Commit-ID: JqOnT1tT4rS
2016-05-28 18:52:10 +02:00
J. Ryan Stinnett 530b903fcf Bug 1271084 - Apply ESLint autofixes to ignored /devtools files. r=tromey
For simple rules like function spacing, we can auto-fix these across the code
base so they are followed in a consistent way.

To generate this patch, I ran:

./mach eslint devtools --no-ignore --fix

After this, I reverted any changes to third party files that we really do want
to ignore.

MozReview-Commit-ID: 6Q8BApkAW20
2016-05-18 12:49:23 -05:00
James Long ece81a7a77 Bug 1265775 - replace Cu.reportError with console.error in devtools client code r=tromey 2016-05-06 11:29:10 -04:00
Gabriel Luong e5b1dd480d Bug 1206463 - Eslint cleanup for source editor r=mratcliffe 2015-12-25 15:57:20 -05:00
Alexandre Poirot 67466b7507 Bug 1232290 - Package codemirror with the same layout than in source tree. r=jlongster 2015-12-17 04:34:21 -08:00
Tom Tromey 57a6e85c0f Bug 1192486 - make completion work in any selected style editor; r=mratcliffe 2015-11-11 09:43:00 +01:00
J. Ryan Stinnett 13dd75d0ae Bug 1196047 - Move tern to client/sourceeditor. r=bgrins 2015-10-09 18:26:10 -05:00
J. Ryan Stinnett 2dada8f365 Bug 912121 - Rewrite require / import to match source tree. rs=devtools
In a following patch, all DevTools moz.build files will use DevToolsModules to
install JS modules at a path that corresponds directly to their source tree
location.  Here we rewrite all require and import calls to match the new
location that these files are installed to.
2015-09-21 12:04:18 -05:00
J. Ryan Stinnett 2df2dd8be3 Bug 912121 - Package DevTools client content in devtools.jar. rs=devtools
Break DevTools content files out of browser.jar and move to a new DevTools
specific jar.  Update all paths of the form:

chrome://browser/content/devtools/<X>

to

chrome://devtools/content/<Y>

where <Y> is the source tree path that comes after /devtools/client.
2015-09-21 12:02:37 -05:00
J. Ryan Stinnett a3073e0420 Bug 912121 - Migrate major DevTools directories. rs=devtools
Move major DevTools files to new directories using the following steps:

hg mv browser/devtools devtools/client
hg mv toolkit/devtools/server devtools/server
hg mv toolkit/devtools devtools/shared

No other changes are made.
2015-09-21 12:02:24 -05:00