These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.
MozReview-Commit-ID: DCChktTc5TW
***
Bug 1454202: Part 1a - Auto-replace uses of callback-based AddonManager APIs with Promise-based versions. r=aswan
This was done using the following script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/4cd5ae959765d0965dd0cc635de3e953bf46edbb/processors/aom-api-generators.jsm
MozReview-Commit-ID: 8hobLz15a66
***
Bug 1454202: Part 1b - Manually fix eslint errors after auto-rewrite. r=aswan
This also deletes an obsolete test whose xpcshell variant was already deleted.
MozReview-Commit-ID: DM9W9Q2SVIE
***
Bug 1454202: Part 1c - Manually fix non-eslint issues after auto-rewrite. r=aswan
MozReview-Commit-ID: DtMscWZuExc
Extract all the logic that will be shared between about debugging and the application
panel to a dedicated client module.
MozReview-Commit-ID: Ccnmp3dCZpW
Extract all the logic that will be shared between about debugging and the application
panel to a dedicated client module.
MozReview-Commit-ID: Ccnmp3dCZpW
Extract all the logic that will be shared between about debugging and the application
panel to a dedicated client module.
MozReview-Commit-ID: Ccnmp3dCZpW
In about:debugging's browser_addon_reload.js test, we would request a reload
without waiting for it to reply. This led to the RDP connection closing before
the reply could be sent, triggering later errors.
For better test correctness, we now emit an event on reply and the test waits to
receive it before proceeding.
MozReview-Commit-ID: Jfps7MJ6Pzo
By moving only the rejections that actually still apply into each test and out
of the shared head file, we are much more likely to notice new instances and
catch them when writing and editing tests in the future.
Bug 1018184 can be used to actually resolve these issues.
MozReview-Commit-ID: Qb71PsuutB
This patch was autogenerated by my decomponents.py
It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.
It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.
It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)
MozReview-Commit-ID: DeSHcClQ7cG
This changeset adds basic remote connection functionality to about:debugging.
About:debugging can target a remote firefox instance if the host and port
parameters are passed as URL search params.
The feature is not explicitly exposed at the moment and there is no UI to
connect an instance, and no UI feedback when connected to a remote instance.
When connected, about:debugging should correctly list tabs, workers and addons
for the target instance of Firefox. Debugging features work for all supported
targets.
Known limitations:
- preferences are read from the local Firefox instance (multiprocess, addon
debugging etc...). At the moment the remote instance must be manually
correctly configured
MozReview-Commit-ID: DOekSCb96XC
Most of the codebase that needs to create a debugger server
can use a server with all actors registered.
Define an additional method registerAllActors to do that.
By previous implementations, all the call sites that were
using browser: true were indirectly using tab & root: true
as well. So all the call sites using browser: true have been
migrated to registerAllActors and the specific behavior of
the browser: true case has been removed. Passing browser:true
to registerActors now only registers browser specific actors.
MozReview-Commit-ID: F3sx71eGrdG
DebuggerServer.init() already bails out if it was previously initialized
so we could avoid guarding the calls to init() with it everywhere.
Registering an actor module several times is also a noop as the Server
keeps a map of all the already registered modules and will bail out if
the module is already known.
MozReview-Commit-ID: 4ONLlx9253i