Commit Graph
285 Commits
Author SHA1 Message Date
Kris Maglione 947129c122 Bug 1453881: Part 1b - Manually fix tests that await generators in async functions. r=ochameau
MozReview-Commit-ID: 2oetVEj7yF
2018-04-15 00:30:04 -07:00
Kris Maglione 31b62bd68b Bug 1453881: Part 1a - Automatically write add_task(function*) to add_task(async function) r=ochameau
This was done using the script at:

https://bitbucket.org/kmaglione/m-c-rewrites/src/bc5629735d8c7e4150f376d4a906e7c7c23132ba/processors/add-task-async.jsm?at=default&fileviewer=file-view-default

MozReview-Commit-ID: KxuS9Cen87
2018-04-12 21:10:04 -07:00
Brian Birtles 0e2ddba629 Bug 1444301 - Move Options button into meatball menu; r=jryans
MozReview-Commit-ID: HnTbtdI5gS6
2018-04-05 10:13:21 +09:00
Timothy Guan-tin Chien 58bf21ba35 Bug 1447544 - Remove the event listeners and timers when the videocontrols binding is destroyed r=Gijs
Additionally,

- Remove `self = this` usage
- Remove access of the `Utils` object from the scope chain
- Modify DevTools debugger test case because all event listeners are the one unwrap-able object

MozReview-Commit-ID: 5kbLgD951CM
2018-03-28 15:35:33 +08:00
Nicolas Chevobbe 7a62823af2 Bug 1447715 - Remove old-event-emitter usage from sourceeditor; r=gl.
MozReview-Commit-ID: 6o8I7TtPiFU
2018-03-21 18:30:21 +01:00
Nicolas Chevobbe b4d70690f7 Bug 1382581 - Adapt debugger code to the EventEmitter change in devtools/client/framework; r=yulia.
MozReview-Commit-ID: GGbylfsYM6x
2018-03-14 18:15:04 +01:00
Kris Maglione c52d401bb4 Bug 1445551: Part 1b - Whitelist unsafe CPOW use in existing tests. r=mconley
MozReview-Commit-ID: 4ojwvjw9XGT
2018-03-14 14:35:05 -07:00
Michael Ratcliffe ec7ed48b6b Bug 1443457 - Stop referencing the addon-sdk loader in devtools code r=jdescottes
MozReview-Commit-ID: 7lwCG8JT7cV
2018-03-09 15:36:45 +00:00
Dorel Luca 3533489bdf Backed out changeset ae1924aff61b (bug 1443457) as requested by developer 2018-03-14 12:35:38 +02:00
Michael Ratcliffe b37dad2dfb Bug 1443457 - Stop referencing the addon-sdk loader in devtools code r=jdescottes
MozReview-Commit-ID: 7lwCG8JT7cV
2018-03-09 15:36:45 +00:00
Coroiu Cristina a1647fc116 Backed out changeset 2c8540f7800f (bug 1443457) for ESlint failure at /builds/worker/checkouts/gecko/devtools/server/tests/mochitest/test_getProcess.html 2018-03-14 11:41:12 +02:00
Michael Ratcliffe 433c9dfe42 Bug 1443457 - Stop referencing the addon-sdk loader in devtools code r=jdescottes
MozReview-Commit-ID: 7lwCG8JT7cV
2018-03-09 15:36:45 +00:00
Alexandre Poirot 22e91d7acd Bug 1440321 - Convert Task.jsm to async/await in devtools/client. r=jryans
MozReview-Commit-ID: HaGOC5cn3JD
2018-03-12 19:46:35 -05:00
J. Ryan Stinnett a7231a768e Bug 1442312 - Move allowed rejections into specific tests they apply to. r=ochameau
By moving only the rejections that actually still apply into each test and out
of the shared head file, we are much more likely to notice new instances and
catch them when writing and editing tests in the future.

Bug 1018184 can be used to actually resolve these issues.

MozReview-Commit-ID: Qb71PsuutB
2018-03-08 18:14:52 -06:00
J. Ryan Stinnett 230370edaf Bug 1436187 - Centralize frame-script-utils loading via shared-head. r=bgrins
Use `loadFrameScriptUtils` from shared-head as a central utility for loading the
frame script utils helper.  This means less stray references to the utils file's
path across our tests.

As part of this, I went ahead and converted Canvas Debugger, Shader Editor, and
Web Audio Editor to shared-head, as that seemed like the best path to reduce
duplication.

(I left one extra path reference in profiler-mm-utils.js as-is, since it's a
module, so shared-head is not easily usable there.)

MozReview-Commit-ID: AKbZt8Jo0GM
2018-03-05 16:31:49 -06:00
J. Ryan Stinnett aa067adb85 Bug 1436187 - Move existing shared head files to devtools/client/shared. r=bgrins
Move shared-head.js and shared-redux-head.js into shared.

MozReview-Commit-ID: 5NUxcl9gkLl
2018-03-02 19:14:05 -06:00
Cosmin Sabou 111a73f847 Backed out 4 changesets (bug 1436187) for mochitest devtools failures at browser_se_editors-error-gutter.js on a CLOSED TREE
Backed out changeset 253f74e28723 (bug 1436187)
Backed out changeset 9875771c9967 (bug 1436187)
Backed out changeset b2d808aa8c2e (bug 1436187)
Backed out changeset e747480f3cd2 (bug 1436187)
2018-03-07 22:04:35 +02:00
J. Ryan Stinnett 702bf36b8f Bug 1436187 - Centralize frame-script-utils loading via shared-head. r=bgrins
Use `loadFrameScriptUtils` from shared-head as a central utility for loading the
frame script utils helper.  This means less stray references to the utils file's
path across our tests.

As part of this, I went ahead and converted Canvas Debugger, Shader Editor, and
Web Audio Editor to shared-head, as that seemed like the best path to reduce
duplication.

(I left one extra path reference in profiler-mm-utils.js as-is, since it's a
module, so shared-head is not easily usable there.)

MozReview-Commit-ID: AKbZt8Jo0GM
2018-03-05 16:31:49 -06:00
J. Ryan Stinnett 039b00fd39 Bug 1436187 - Move existing shared head files to devtools/client/shared. r=bgrins
Move shared-head.js and shared-redux-head.js into shared.

MozReview-Commit-ID: 5NUxcl9gkLl
2018-03-02 19:14:05 -06:00
Florian Quèze 5715aadbec Bug 1433175 - more aggressive scripted patch to replace remaining Components.classes, Components.interfaces, Components.utils and Components.results uses with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:35 +01:00
Florian Quèze f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Hiroyuki Ikezoe 0f3d7d3206 Bug 1437712 - Skip browser_dbg_break-on-next.js. r=bgrins
This test will cause timeout once we have a microtask checkpoint at the end of
a callback (bug 1193394).  Fortunately the test is for the old debugger UI that
we don't ship anymore, so we can just skip it.

MozReview-Commit-ID: AjB1YSNyToD
2018-02-17 09:08:03 +09:00
Brian Grinstead 4a8db086aa Bug 1438487 - Restore the Browser Toolbox using session store;r=jryans
MozReview-Commit-ID: JUbafbthojm
2018-02-21 15:47:36 -08:00
Masayuki Nakano efaea0aaa7 Bug 1438157 - part 2: Remove unnecessary second argument of EventUtils.synthesizeKey() r=smaug
Note that this patch also replaces legacy VK_* with KEY_*, and replaces
synthesizeKey() for inputting some characters with sendString() because
it's better and clearer what it does and it sets shiftKey state properly.

MozReview-Commit-ID: De4enbjux3T
2018-02-15 04:15:39 +09:00
Jeff Walden 91f1d95536 Bug 1434429 - Use the current offset, not the offset of the start of the current token, when reporting errors for unterminated string/template literals. r=till 2018-01-18 11:34:26 -08:00
Jeff Walden cc6052cb85 Bug 1436150 - Make debugger-controller.js properly handle watch expressions, containing syntax errors, where the error message for the syntax error contains U+0022 QUOTATION MARK within it. r=jimb 2018-02-06 02:08:55 -08:00
Alexandre Poirot 13e5d4f0f5 Bug 1434374 - Auto-rewrite Cu.import into ChromeUtils.import or require calls. r=jdescottes
MozReview-Commit-ID: 7YyLu5q23Hs
2018-02-07 01:37:36 -08:00
Alexandre Poirot 0021aa3d94 Bug 1434374 - Always import deprecated-sync-promises as a module. r=jdescottes
MozReview-Commit-ID: B97O55CxD8T
2018-02-05 08:11:30 -08:00
Gurzau Raul fd98e21567 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-02-07 02:29:42 +02:00
Andrew McCreight 272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Florian Quèze c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Jason Orendorff 66df757921 Bug 1431202 - Part 2: Fix weird debugger stepping behavior with nested functions. r=nbp, r=jlast.
FunctionDeclarations are instantiated when we enter a scope, before any of the
code in that block/script/function is evaluated. The spec calls this phase
"declaration instantiation"; sometimes it's informally called "hoisting".

Before this patch, stepping would show this. You would step into a function,
and hitting the Step Over button a few times would visit all the nested functions
in that function. Then you would jump back to the top of the outer function and
actually start running the statements. This is so confusing that we are
changing it; now opcodes that instantiate functions don't have location
information, so stepping doesn't stop on those opcodes.
2018-02-06 10:58:03 -06:00
Kris Maglione 0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/37e3803c7a23385bab5ea077ba8692bcfe1608fc/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/37e3803c7a23385bab5ea077ba8692bcfe1608fc/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian 483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione 683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/37e3803c7a23385bab5ea077ba8692bcfe1608fc/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Julian Descottes eb870727ad Bug 1272774 - migrate all listTabs() callers to use promise;r=ochameau
MozReview-Commit-ID: 9PtRZHG5GuF
2018-01-15 18:38:34 +01:00
Tooru Fujisawa 4a51f02509 Bug 1430408 - Part 2: Wait for the next event tick after transitionend event to make sure the all event handlers finish in devtools/client/debugger/test/mochitest/browser_dbg_instruments-pane-collapse_keyboard.js r=pbro 2018-01-20 20:40:10 +09:00
Tooru Fujisawa 3beb7a65d2 Bug 1430408 - Part 1: Use Async Function in devtools/client/debugger/test/mochitest/browser_dbg_instruments-pane-collapse_keyboard.js r=pbro 2018-01-20 20:40:10 +09:00
Bill McCloskey 142c9a9dbb Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-07 12:55:24 -08:00
Andreea Pavel 26ac595cba Backed out 9 changesets (bug 1412456) for crashing talos g2 and unexpected network connections in browser-chrome's browser_searchEngine_behaviors.js r=backout a=backout on a CLOSED TREE
Backed out changeset 0c01a98f4fd5 (bug 1412456)
Backed out changeset 27077db47231 (bug 1412456)
Backed out changeset f35ec2a884f8 (bug 1412456)
Backed out changeset 602b30ac3c69 (bug 1412456)
Backed out changeset b1ff1050c589 (bug 1412456)
Backed out changeset f100d953f9eb (bug 1412456)
Backed out changeset d85af60fe259 (bug 1412456)
Backed out changeset 736f38486832 (bug 1412456)
Backed out changeset 13a637602dc2 (bug 1412456)
2017-12-07 12:20:21 +02:00
Bill McCloskey 427710d960 Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-06 21:17:05 -08:00
Dorel Luca 81b4b85d01 Backed out 8 changesets (bug 1412456) for ESlint failure on browser_urlbarKeepStateAcrossTabSwitches.js:13:49 r=backout on a CLOSED TREE
Backed out changeset 0e88de036c55 (bug 1412456)
Backed out changeset 49b93f807db0 (bug 1412456)
Backed out changeset 039e980b7dc6 (bug 1412456)
Backed out changeset c7698410ddbd (bug 1412456)
Backed out changeset e56a1ba26b7c (bug 1412456)
Backed out changeset 0c4506e124ac (bug 1412456)
Backed out changeset a7aec2ce903b (bug 1412456)
Backed out changeset 3e9fb71f1e8e (bug 1412456)
2017-12-07 07:09:33 +02:00
Bill McCloskey a0f07d3df7 Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-06 20:46:58 -08:00
Brian Grinstead b3e399c2b1 Bug 1408949 - Remove unnecessary clearing of devtools.toolbox.splitconsoleEnabled;r=Honza
This is already cleared in shared-head.js

MozReview-Commit-ID: 7svp6ZiUqnE
2017-12-01 10:36:22 -08:00
Andrea Marchesini f5caa705b6 Bug 1418860 - Adding telemetry to see how often version param is used in ScriptLoader type, r=jonco, data-r=francois 2017-11-29 09:01:04 +01:00
Julian Descottes 21b6d9f77b Bug 1416711 - Add registerAllActors API;r=ochameau
Most of the codebase that needs to create a debugger server
can use a server with all actors registered.

Define an additional method registerAllActors to do that.

By previous implementations, all the call sites that were
using browser: true were indirectly using tab & root: true
as well. So all the call sites using browser: true have been
migrated to registerAllActors and the specific behavior of
the browser: true case has been removed. Passing browser:true
to registerActors now only registers browser specific actors.

MozReview-Commit-ID: F3sx71eGrdG
2017-11-13 21:22:15 +01:00
Julian Descottes 6e8668e849 Bug 1416711 - Stop guarding consumer calls to DebuggerServer.init();r=ochameau
DebuggerServer.init() already bails out if it was previously initialized
so we could avoid guarding the calls to init() with it everywhere.

Registering an actor module several times is also a noop as the Server
keeps a map of all the already registered modules and will bail out if
the module is already known.

MozReview-Commit-ID: 4ONLlx9253i
2017-11-13 21:04:43 +01:00
Julian Descottes 2c1ef484ef Bug 1416711 - Migrate addBrowser/TabActors to registerActors;r=ochameau
DebuggerServer has old APIs addBrowserActors & addTabActors that can be
replaced by calls to registerActors.

MozReview-Commit-ID: KpYJpbSHM8I
2017-11-13 20:29:55 +01:00