Commit Graph
1612 Commits
Author SHA1 Message Date
Kris Maglione b3990a2d91 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW
2018-04-24 20:18:09 -07:00
Yura Zenevich 89e96d1b47 Bug 1450927 - use new getBoundsInCSSPixels method for accessible bounds in accessible highlighter. r=jryans
MozReview-Commit-ID: 4Ixj2ksuDrP
2018-04-25 14:51:18 -04:00
Yura Zenevich 35bbacd53a Bug 1451241 - check text children of non-accessible nodes when retrieving accessible objects. r=jdescottes
MozReview-Commit-ID: 2SFe6g3hOCc
2018-04-25 14:06:16 -04:00
Tiberius Oros 88eb417d2a Backed out 2 changesets (bug 1450927) for failing on ProxyAccessible.cpp(247) on a CLOSED TREE
Backed out changeset ca285aed3926 (bug 1450927)
Backed out changeset d7dd8b0d2473 (bug 1450927)
2018-04-25 19:31:50 +03:00
Yura Zenevich d5a7a3749f Bug 1450927 - use new getBoundsInCSSPixels method for accessible bounds in accessible highlighter. r=jryans
MozReview-Commit-ID: 4Ixj2ksuDrP
2018-04-25 11:45:46 -04:00
Margareta Eliza Balazs 7f5598fb91 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-04-24 14:51:28 +03:00
Ciure Andrei 8688f53e8a Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2018-04-24 04:29:20 +03:00
Ciure Andrei 5b1552790b Merge inbound to mozilla-central. a=merge 2018-04-24 04:14:21 +03:00
Mats Palmgren c24797b4a4 Bug 1398482 part 6 - Update devtools with the renamed longhands. r=me 2018-04-24 01:52:51 +02:00
Michael Ratcliffe 2cd66f01bc Bug 1441070 - Instrument toolbox panel navigation with event telemetry r=yulia
This is pretty simple... finding the best locations for the probes was the
struggle here.

In order to land these probes before the freeze the test for these events will
be created as part of bug 1456073.

MozReview-Commit-ID: 7hIfbD3wQ1I
2018-04-19 12:09:28 +01:00
Razvan Caliman dbf955e1ec Bug 1455535 - Add support for vmin/vmax units. Ensure vh/vw are computed against actual host window. r=pbro
MozReview-Commit-ID: 1ifVJu1OW5L
2018-04-20 17:31:39 +02:00
Kris Maglione d3bbf87c83 Bug 1454202: Part 1 - Update legacy callers to use Promise-based AddonManager APIs. r=aswan
***
Bug 1454202: Part 1a - Auto-replace uses of callback-based AddonManager APIs with Promise-based versions. r=aswan

This was done using the following script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/4cd5ae959765d0965dd0cc635de3e953bf46edbb/processors/aom-api-generators.jsm

MozReview-Commit-ID: 8hobLz15a66
***
Bug 1454202: Part 1b - Manually fix eslint errors after auto-rewrite. r=aswan

This also deletes an obsolete test whose xpcshell variant was already deleted.

MozReview-Commit-ID: DM9W9Q2SVIE
***
Bug 1454202: Part 1c - Manually fix non-eslint issues after auto-rewrite. r=aswan

MozReview-Commit-ID: DtMscWZuExc
2018-04-14 19:38:18 -07:00
Boris Zbarsky ca1e80f478 Bug 1453869 part 9. Stop creating DOMParser by contract in devtools. r=tromey
There are some extra hoops here because devtools has a lint to prevent Cu.importGlobalProperties, which is the normal way one would import a WebIDL constructor.

MozReview-Commit-ID: 2mdNI6N1z5B
2018-04-20 23:04:40 -04:00
Dorel Luca bd168c48a9 Merge mozilla-inbound to mozilla-central. a=merge 2018-04-21 02:00:04 +03:00
Boris Zbarsky 47f9a4d9f2 Bug 1455052 part 12. Remove JS uses of nsIDOMEvent. r=masayuki,kmag
MozReview-Commit-ID: 5g0H3rzxTXt
2018-04-20 12:55:31 -04:00
Xidorn Quan ae5f6fcb9e Bug 1448757 part 2 - Move longhand animation type table into devtools. r=daisuke
After switching to Stylo, animation is handled by Servo, and thus it no
longer relies on the animation type recorded in nsCSSPropList.h, and
devtools become the only consumer of that information.

This patch puts a map of longhands to animation types into devtools
instead. The map is extracted from nsCSSPropList.h by the script below
based on the logic of nsDOMWindowUtils::GetAnimationTypeForLonghand.

There are two reasons that I don't port this into Servo:

First, Servo doesn't have a concept of property-level animation type.
Animation change in Servo is directly encoded into value types. It means
porting this to Servo would require creating a new concept purely for
devtools. It's not great because that data doesn't reflect how animation
is handled in the engine, and people may keep forgetting to give proper
animation type to new animatable types they add.

Second, the handling of animation type in devtools also looks rather
arbitrary to me. For example, eStyleAnimType_Corner_* types are actually
two coordinate values, bug GetAnimationTypeForLonghand returns "coord"
for them, and devtools just parses the first value and uses it. This
means the animation type here is really more closely related to how
devtools handles the value, rather than how the style engine does so.

Given above, I decided to put the list into devtools rather than encode
the information into Servo code. To encourage people to think about
animation handling in devtools for new properties, there is also a new
test added to ensure every property has a devtools animation type.

The content of ANIMATION_TYPE_FOR_LONGHANDS is generated via running
the following script in layout/style:

```python
#!/usr/bin/env python3

import subprocess
from collections import defaultdict

ANIMTYPE_MAPPING = {
    "Custom": "custom",
    "Coord": "coord",
    "Sides_Top": "coord",
    "Sides_Right": "coord",
    "Sides_Bottom": "coord",
    "Sides_Left": "coord",
    "Corner_TopLeft": "coord",
    "Corner_TopRight": "coord",
    "Corner_BottomRight": "coord",
    "Corner_BottomLeft": "coord",
    "nscoord": "length",
    "float": "float",
    "Color": "color",
    "ComplexColor": "color",
    "PaintServer": "paintServer",
    "Shadow": "shadow",
    "Discrete": "discrete",
    "None": "none",
}

input = b"""
#define CSS_PROP(name, id, method, flags, pref, \\
                 variant, kwtable, animtype) name, flags, animtype
#include "nsCSSPropList.h"
"""
props = subprocess.check_output(["clang", "-E", "-P", "-"], input=input)
props = props.decode("ascii")
result = defaultdict(list)
for line in props.splitlines():
    line = line.strip()
    if not line:
        continue
    name, flags, animtype = line.split(", ")
    assert animtype.startswith("eStyleAnimType_")
    if "CSS_PROPERTY_PARSE_INACCESSIBLE" in flags:
        continue
    animtype = ANIMTYPE_MAPPING[animtype[15:]]
    result[animtype].append(name)
print("[")
for animtype, names in result.items():
    print('  ["{}", new Set(['.format(animtype))
    for name in names:
        print('    "{}",'.format(name))
    print("  ])],")
print("]")
```

MozReview-Commit-ID: BGiGq0jUgG5
2018-04-20 14:06:47 +10:00
Mike Ratcliffe 0bf1ee2118 Bug 1451991 - Devtools: Localstorage didn't list item whose key names "key" r=nchevobbe
MozReview-Commit-ID: 3AQC47GKud0
2018-04-14 00:33:42 +01:00
Bogdan Tara a9cb321e4f Merge inbound to mozilla-central. a=merge 2018-04-19 01:36:28 +03:00
Razvan Caliman d75a2a42d9 Bug 1450650 - Clamp x/y values to current viewport when dragging a marker in the shape editor. r=gl
- Compute constraints so that a dragged marker stays visible with the viewport.
- Constrain dragging of marker to the viewport of the node's host window.
- If the marker is visible outside of the node host's viewport (ex:
shapes within a smaller iframe nested in a larger document), do not
constrain that marker and allow dragging it outside the viewport.
If dragging starts while the marker is within its intended viewport,
do constrain it to that viewport.

MozReview-Commit-ID: 9JyEfseSLXW
2018-04-18 15:00:48 -04:00
Nicolas Chevobbe 177bf9490e Bug 1451021 - Migrate PropertyIteratorActor to protocol.js; r=ochameau.
MozReview-Commit-ID: 1yTtcO92HWU
2018-04-10 09:44:38 +02:00
Dorel Luca 7bf351a923 Merge mozilla-central to autoland. CLOSED TREE 2018-04-18 14:07:45 +03:00
Boris Zbarsky 30658b874a Bug 1452183 part 2. Stop using nsIDOMDocumentFragment in JS. r=mccr8 2018-04-17 21:13:03 -04:00
Razvan Caliman 2b33925395 Bug 1453428 - Handle cases for shape coordinates like 0%, 0em, 0rem, etc. without overwriting to pixels. r=gl
The previous implementation treated any zero coordinate as pixels,
regardless of its unit type. For example, 0% would be converted to 0px.
This changed the shape value resulting in unintentional unit mismatch
after editing a coordinate which started off as 0% or 0em or 0vh, etc.

This patch fixes that and preserves the unit type for zero coordinates.

It changes the implementation of isUnitless() to return false for values
like 0%, 0px, 0em, 0.00000%, etc.

It introduces getUnitToPixelRatio() to get the ratio by which to
multiply a pixel value to convert it to the given unit during shape
editing operations (point move, scale, translate, rotate, etc.)

The ratio is constant by unit type. Previously, this ratio was
calculated in-place for each unit value. Values which started as zero,
always resulted in a ratio equal to zero. This multiplied with a pixel
value resulted zero. So the previous code defaulted to ratio of 1 when
the ratio was zero, but this meant that a 1:1 ratio between pixels and
another unit type (%, em, vh) would result in disproportionate
shape changes (1px of mouse travel would result in 1em). This is why
isUnitless() originally discarded the original unit from a zero
coordinate and replaced it with pixels; to account for this fallback
ratio of 1.

MozReview-Commit-ID: 49tyLfYjkLO
2018-04-11 22:21:18 +02:00
Brindusan Cristian e3aad97ba5 Backed out changeset 3ab522801015 (bug 1450650) for mochitest devtools failures on browser_inspector_highlighter-cssshape_iframe_01.js. 2018-04-17 19:26:52 +03:00
Brindusan Cristian 1ce90e6ca3 Backed out changeset 3f95bbb60e43 (bug 1453428) for mochitest devtools failures on browser_inspector_highlighter-cssshape_iframe_01.js. CLOSED TREE 2018-04-17 19:16:33 +03:00
Razvan Caliman f5d0de1cb9 Bug 1453428 - Handle cases for shape coordinates like 0%, 0em, 0rem, etc. without overwriting to pixels. r=gl
The previous implementation treated any zero coordinate as pixels,
regardless of its unit type. For example, 0% would be converted to 0px.
This changed the shape value resulting in unintentional unit mismatch
after editing a coordinate which started off as 0% or 0em or 0vh, etc.

This patch fixes that and preserves the unit type for zero coordinates.

It changes the implementation of isUnitless() to return false for values
like 0%, 0px, 0em, 0.00000%, etc.

It introduces getUnitToPixelRatio() to get the ratio by which to
multiply a pixel value to convert it to the given unit during shape
editing operations (point move, scale, translate, rotate, etc.)

The ratio is constant by unit type. Previously, this ratio was
calculated in-place for each unit value. Values which started as zero,
always resulted in a ratio equal to zero. This multiplied with a pixel
value resulted zero. So the previous code defaulted to ratio of 1 when
the ratio was zero, but this meant that a 1:1 ratio between pixels and
another unit type (%, em, vh) would result in disproportionate
shape changes (1px of mouse travel would result in 1em). This is why
isUnitless() originally discarded the original unit from a zero
coordinate and replaced it with pixels; to account for this fallback
ratio of 1.

MozReview-Commit-ID: 49tyLfYjkLO
2018-04-11 22:21:18 +02:00
Razvan Caliman 98523d458e Bug 1450650 - Clamp x/y values to current viewport when dragging a marker in the shape editor. r=gl
MozReview-Commit-ID: 9JyEfseSLXW
2018-04-13 16:13:37 +02:00
Greg Tatum 86e156f5b7 Bug 1455017 - Document the preferences actor; r=jryans
MozReview-Commit-ID: 9wCanCMltHX
2018-04-18 11:32:17 -05:00
Alexandre Poirot a686848de3 Bug 1454373 - Switch protocol.js to native promises. r=jryans
MozReview-Commit-ID: ALifNayHJJG
2018-04-13 14:34:12 -07:00
Gabriel Luong 10ed4d8ba2 Bug 1433897 - Implement hasMoved method in the flexbox highlighter to update the highlighter on changes. r=pbro 2018-04-23 09:21:36 -04:00
Emilio Cobos Álvarez 4acd15a22c Bug 1452143: Reparse doc sheets after enabling error reporting on a docshell. r=jryans
While at it, remove useless charset rule lookups, since charset rules aren't
part of the OM, and have no effect at all anymore.

MozReview-Commit-ID: EefGrOZvmm7
2018-04-17 11:24:32 +02:00
Emilio Cobos Álvarez 74eefeed1a Bug 1452143: Hook the filters and enable error reporting on demand. r=nchevobbe
MozReview-Commit-ID: BDFmxWjbDgj
2018-04-17 11:24:23 +02:00
Alexandre Poirot cd8f8a21a3 Bug 1453385 - Fix actors using something else than RetVal in response's spec. r=jryans
MozReview-Commit-ID: 2fRciZoqQSY
2018-04-13 02:56:46 -07:00
Alexandre Poirot 722e1257c8 Bug 1453385 - Fix actors trying to transfer functions or xpcom objects. r=jryans
MozReview-Commit-ID: 74l85ePCcrY
2018-04-12 14:45:10 -07:00
Alexandre Poirot 416a52eac1 Bug 1453385 - Fix typo to prevent passing Infinity to protocol.js. r=jryans
`Infinity` object can't be serialized via structuredclone and so actors
should not communicate such object. Fix this code which meant to prevent that.

MozReview-Commit-ID: 3TpldcSE88F
2018-04-11 09:08:19 -07:00
Alexandre Poirot 2ed4e3ab48 Bug 1453385 - Remove NodeActor custom form attributes. r=Honza
This feature introduced in bug 1036949 is not longer used as it was designed for XUL add-ons.
The setFormProperty method was prevently Node's form from getting correctly
serialized between processes.

MozReview-Commit-ID: AiNnHSkwsEM
2018-04-11 08:54:27 -07:00
Brian Grinstead 6d333a8aa0 Bug 1448936 - Remove unused server side logging code;r=jryans
MozReview-Commit-ID: 3X14cDdj0qp
2018-04-13 11:36:13 -07:00
Emilio Cobos Álvarez 9007e9a305 Bug 1453789: Remove Element.createShadowRoot. r=smaug
MozReview-Commit-ID: Hgxbp1Icgvh
2018-04-13 20:51:55 +02:00
Markus Stange 896c28e92a Bug 1444430 - Add a profiler feature called "screenshots". r=njn
MozReview-Commit-ID: 8blNvvliuog
2018-04-12 15:21:40 -04:00
arthur.iakab 411a3efdc6 Merge inbound to mozilla-central. a=merge 2018-04-13 19:01:59 +03:00
Jason Laster cf5c8132dd Bug 1450323 - Debugger: Update Pause Points (v37). r=jimb
MozReview-Commit-ID: ISKSyng6noM
2018-04-13 08:46:54 -04:00
Alexandre Poirot d10cea6483 Bug 1453712 - Use a preference to set the testing flag. r=jryans
MozReview-Commit-ID: 1cjSQnXtc4h
2018-04-12 09:22:42 -07:00
Erica Wright e13fa89c2e Bug 1431071 - Grid line names suggestions offered in inspector autocomplete if element is in a grid and rule applies. r=gl, jdescottes
MozReview-Commit-ID: HGINxducS4x
2018-04-04 14:01:19 -04:00
Boris Zbarsky 0f52bda7da Bug 1453053 part 3. Remove JS QIs to nsIMessageSender. r=qdot
MozReview-Commit-ID: 4TS38gebl7l
2018-04-12 00:06:25 -04:00
Nicolas Chevobbe 1b790ef4b4 Bug 1451025 - Convert SymbolIteratorActor to protocol.js; r=ochameau.
MozReview-Commit-ID: E9xjaaV50mt
2018-04-05 16:49:30 +02:00
Martin Balfanz e7379b8606 Bug 1449528 - Don't rotate grid line number markers when close to the viewport edge. r=gl 2018-03-28 19:59:07 +02:00
Nika Layzell f614b85fbe Bug 1443379 - Stop pretending cacheKey can be anything other than uint32_t, r=smaug 2018-04-10 17:49:46 -04:00
Gurzau Raul 3501ab0447 Merge inbound to mozilla-central. a=merge 2018-04-10 19:54:34 +03:00
Razvan Caliman 794d47794b Bug 1435373 - Shapes editor: implementation to map shape value changes to rule. r=pbro
MozReview-Commit-ID: i20YChYAxd
2018-04-10 13:59:00 +02:00
Razvan Caliman 07391f3e67 Bug 1435373 - Minor refactor for shape output string guarding against empty this.geometryBox. Round values in getDistance() util function to avoid verbose precision.r=gl
MozReview-Commit-ID: IBB4mkvAu6h
2018-04-10 13:58:48 +02:00