These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.
MozReview-Commit-ID: DCChktTc5TW
This is a short-term solution to our inability to apply CSP to
chrome-privileged documents.
Ideally, we should be preventing all inline script execution in
chrome-privileged documents, since the reprecussions of XSS in chrome
documents are much worse than in content documents. Unfortunately, that's not
possible in the near term because a) we don't support CSP in system principal
documents at all, and b) we rely heavily on inline JS in our static XUL.
This stop-gap solution at least prevents some of the most common vectors of
XSS attack, by automatically sanitizing any HTML fragment created for a
chrome-privileged document.
MozReview-Commit-ID: 5w17celRFr
Most of the codebase that needs to create a debugger server
can use a server with all actors registered.
Define an additional method registerAllActors to do that.
By previous implementations, all the call sites that were
using browser: true were indirectly using tab & root: true
as well. So all the call sites using browser: true have been
migrated to registerAllActors and the specific behavior of
the browser: true case has been removed. Passing browser:true
to registerActors now only registers browser specific actors.
MozReview-Commit-ID: F3sx71eGrdG
Bug 1345294 introduced nsPrefBranch::{get,set}StringPref(), which allowed the
getting of utf8 strings from prefs, which previously required using
nsISupportsString with {get,set}ComplexValue. That bug also converted most
uses.
This patch finishes the job.
- It removes the nsISupportsString support.
- It converts existing code that relied on the nsISupportsString.
- It removes the lint that was set up to detect such uses of nsISupportsString.
Using fill instead of filter we don't need to define each icon as
invertable or not. If the icon is a SVG and supports fill="context-fill"
then it will be inverted/highlighted etc... as expected.
If not then it won't be impacted by DevTools themes.
MozReview-Commit-ID: CLFprKMuCt9
Changes to Promise tests designed to test .then(null) have been reverted, and the browser/extensions directory was excluded because the projects it contains have a separate process for accepting changes.
MozReview-Commit-ID: 1buqgX1EP4P
Removed obsolete browser_dbg_event-listeners-03/4.js tests (they are for the
old debugger, and the new debugger doesn't even support event listeners
yet, so no use keeping this test around).
Removed getBrowserForTab SDK dependency from command-state.js.
Changed the implementation of addTab/removeTab in perf test's tab-utils
helper.
MozReview-Commit-ID: 7EXJ5K3kaJm
Removed obsolete browser_dbg_event-listeners-03/4.js tests (they are for the
old debugger, and the new debugger doesn't even support event listeners
yet, so no use keeping this test around).
Removed getBrowserForTab SDK dependency from command-state.js.
Changed the implementation of addTab/removeTab in perf test's tab-utils
helper.
MozReview-Commit-ID: 7EXJ5K3kaJm
This is easy to test:
Green tick marks (gcli_sec_good.svg) and Red Crosses (gcli_sec_bad.svg):
1. Go to https://csp-evaluator.withgoogle.com/
2. Shift+F2
3. security csp
I couldn't find a way to show the Orange Minus (gcli_sec_moderate.svg) but the path is changed in line with the other images and I did test it programatically so it will be fine.
MozReview-Commit-ID: 5897IV7epax
This is easy to test:
Green tick marks (gcli_sec_good.svg) and Red Crosses (gcli_sec_bad.svg):
1. Go to https://csp-evaluator.withgoogle.com/
2. Shift+F2
3. security csp
I couldn't find a way to show the Orange Minus (gcli_sec_moderate.svg) but the path is changed in line with the other images and I did test it programatically so it will be fine.
MozReview-Commit-ID: 5897IV7epax