Commit Graph
22416 Commits
Author SHA1 Message Date
Nicolas Chevobbe ca1ab8f378 Bug 1590432 - [devtools] Update style for active toggle buttons. r=devtools-reviewers,ochameau.
This adds a light background alongside a bottom border that makes it clear that
the state changed.

Differential Revision: https://phabricator.services.mozilla.com/D196409
2024-05-23 06:02:57 +00:00
Cristian Tuns 732a76714e Backed out changeset 4c4e846a4ebf (bug 1590432) for causing dt failures in browser_parsable_css.js CLOSED TREE 2024-05-22 10:54:16 -04:00
Nicolas Chevobbe b5b368576d Bug 1590432 - [devtools] Update style for active toggle buttons. r=devtools-reviewers,ochameau.
This adds a light background alongside a bottom border that makes it clear that
the state changed.

Differential Revision: https://phabricator.services.mozilla.com/D196409
2024-05-22 13:35:10 +00:00
Cristian Tuns d0272b92b7 Backed out 8 changesets (bug 1651518, bug 1883847) dt failures in nsTArray.h. CLOSED TREE
Backed out changeset 481558275c1d (bug 1651518)
Backed out changeset 5337435e8bca (bug 1651518)
Backed out changeset 8fe0c1a4da7f (bug 1651518)
Backed out changeset 840a0d9db260 (bug 1651518)
Backed out changeset eaab9de5819d (bug 1651518)
Backed out changeset cf71de92d782 (bug 1651518)
Backed out changeset d778691464db (bug 1651518)
Backed out changeset af28e5f719e8 (bug 1883847)
2024-05-22 09:02:19 -04:00
Alexandre Poirot 76d52e829a Bug 1651518 - [devtools] Enable server side worker targets for browser toolbox. r=devtools-reviewers,nchevobbe
Note that the ignore code for subprocess is being ported from the legacy worker watcher.

The Worker Target URL is now correctly set to the Absolute URL,
this has an impact on the context selector as we are displaying it.

Also, this patch highlights some issues around Common JS Loader and the distinct compartment
to be used when debugging privileged page, or when running the browser toolbox.
It caused leaks when running browser toolbox tests in debug builds.
The JS Process Actor is directly loaded in a distinct global and compartment "DevTools global",
thanks to `loadInDevToolsLoader` flag of BrowserToolboxDevToolsProcess JS Process Actor configuration.
There is no need to use `useDistinctSystemPrincipalLoader` helper as Loader.sys.mjs, loaded from
the JS Process Actor will also be loaded in the distinct global.
Then, we only need to ensure that the CommonJS Loader will also pick up the "DevTools global"
when it is loaded in that distinct global.
Things will be significantly easier once we migrate from CommonJS to ESM as the `{ global: "contextual" }`
option passed to `ChromeUtils.importESModule` will do the right thing, as well as static `import` statements.

Differential Revision: https://phabricator.services.mozilla.com/D204874
2024-05-22 11:50:45 +00:00
Alexandre Poirot 34e5032104 Bug 1651518 - [devtools] Ensure spawning DistinctSystemPrincipalLoader.sys.mjs only once. r=devtools-reviewers,nchevobbe
This is important to spawn this ESM only once between regular and browser toolbox,
and especially between various callsites used by the browser toolbox.
Otherwise we may start loading modules in two distinct system loaders
and may have inconsistancies when using `instanceof`.

Differential Revision: https://phabricator.services.mozilla.com/D207432
2024-05-22 11:50:44 +00:00
Alexandre Poirot 2ca6803e58 Bug 1651518 - [devtools] Ensure waiting for CSS Warning full listening when toggling the filter from tests. r=devtools-reviewers,nchevobbe
The enhancer was brittle as nothing was waiting for its completion.
We should rather do such work from the action layer. At least this can delay the action completion,
which the test header (setFilterState) already wait for.

Differential Revision: https://phabricator.services.mozilla.com/D205602
2024-05-22 11:50:43 +00:00
Florian Quèze 6bf97a67e5 Bug 1897772 - Allow sampling at 1Hz, r=profiler-reviewers,aabh
Differential Revision: https://phabricator.services.mozilla.com/D210917
2024-05-22 06:15:20 +00:00
Cristina Horotan ca70119cfa Backed out 8 changesets (bug 1651518, bug 1883847) for causing damp failures at toolbox/browser-toolbox.js CLOSED TREE
Backed out changeset 4ec70db12f48 (bug 1651518)
Backed out changeset b2b138889ad6 (bug 1651518)
Backed out changeset efda5c09b0ea (bug 1651518)
Backed out changeset b0de4113f8fb (bug 1651518)
Backed out changeset 03cf235d2a80 (bug 1651518)
Backed out changeset 58e71c27f1fd (bug 1651518)
Backed out changeset f7fb390c3965 (bug 1651518)
Backed out changeset b8a2473c47c0 (bug 1883847)
2024-05-22 04:00:53 +03:00
Alexandre Poirot 64b2f242bc Bug 1651518 - [devtools] Enable server side worker targets for browser toolbox. r=devtools-reviewers,nchevobbe
Note that the ignore code for subprocess is being ported from the legacy worker watcher.

Also, this patch highlights some issues around Common JS Loader and the distinct compartment
to be used when debugging privileged page, or when running the browser toolbox.
It caused leaks when running browser toolbox tests in debug builds.
The JS Process Actor is directly loaded in a distinct global and compartment "DevTools global",
thanks to `loadInDevToolsLoader` flag of BrowserToolboxDevToolsProcess JS Process Actor configuration.
There is no need to use `useDistinctSystemPrincipalLoader` helper as Loader.sys.mjs, loaded from
the JS Process Actor will also be loaded in the distinct global.
Then, we only need to ensure that the CommonJS Loader will also pick up the "DevTools global"
when it is loaded in that distinct global.
Things will be significantly easier once we migrate from CommonJS to ESM as the `{ global: "contextual" }`
option passed to `ChromeUtils.importESModule` will do the right thing, as well as static `import` statements.

Differential Revision: https://phabricator.services.mozilla.com/D204874
2024-05-21 14:09:35 +00:00
Alexandre Poirot 3d2406db93 Bug 1651518 - [devtools] Ensure spawning DistinctSystemPrincipalLoader.sys.mjs only once. r=devtools-reviewers,nchevobbe
This is important to spawn this ESM only once between regular and browser toolbox,
and especially between various callsites used by the browser toolbox.
Otherwise we may start loading modules in two distinct system loaders
and may have inconsistancies when using `instanceof`.

Differential Revision: https://phabricator.services.mozilla.com/D207432
2024-05-21 14:09:33 +00:00
Alexandre Poirot 77d5f78f48 Bug 1651518 - [devtools] Ensure waiting for CSS Warning full listening when toggling the filter from tests. r=devtools-reviewers,nchevobbe
The enhancer was brittle as nothing was waiting for its completion.
We should rather do such work from the action layer. At least this can delay the action completion,
which the test header (setFilterState) already wait for.

Differential Revision: https://phabricator.services.mozilla.com/D205602
2024-05-21 14:09:33 +00:00
Alexandre Poirot b2844dc4bf Bug 1781941 - [devtools] Fix browser_dbg-integration-reloading-uncompressed-sourcemaps.js intermittent. r=devtools-reviewers,nchevobbe
We seem to never wait for the breakpoint to be actually visibile before calling assertBreakpoint,
but it seems that it is relevant in this particular test, in the uncompressed codepath.

Differential Revision: https://phabricator.services.mozilla.com/D210991
2024-05-21 12:24:29 +00:00
Nicolas Chevobbe b64ccccc10 Bug 1896847 - [devtools] Add matching bracket styling in cm6. r=bomsy,devtools-reviewers.
Differential Revision: https://phabricator.services.mozilla.com/D210901
2024-05-21 05:43:20 +00:00
Alexandre Poirot f27b54d9d0 Bug 1835255 - [devtools] Fix browser_dbg-reducer-cleanup-on-target-removal.js intermittent. r=devtools-reviewers,nchevobbe
We were waiting for Sources, which are resources, but not the targets,
which are updated with a different logic and timings.

Differential Revision: https://phabricator.services.mozilla.com/D210943
2024-05-20 16:03:27 +00:00
Alexandre Poirot 467f34b667 Bug 1874227 - [devtools] Fix browser_many_toggles.js intermittent. r=devtools-reviewers,nchevobbe
ResponsiveUI was instantiated a promise which wasn't awaited by any code,
and especially the test codepath which explicitely ignore rejections.

Differential Revision: https://phabricator.services.mozilla.com/D210902
2024-05-20 16:03:26 +00:00
Alexandre Poirot be63276971 Bug 1770282 - [devtools] Fix browser_toolbox_toolbar_overflow_button_visibility.js intermittent. r=devtools-reviewers,nchevobbe
This is MacOS specific.

Differential Revision: https://phabricator.services.mozilla.com/D210899
2024-05-20 16:03:25 +00:00
Valentin Gosu 4079e2222e Bug 1711622 - Update tests r=necko-reviewers,devtools-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D203115
2024-05-20 15:35:29 +00:00
Iulian Moraru 256c02a385 Backed out 2 changesets (bug 1711622) for causing reftest failures on accept-image-catchall.html. CLOSED TREE
Backed out changeset 877d9c37605a (bug 1711622)
Backed out changeset c315e89b6e4b (bug 1711622)
2024-05-20 16:59:04 +03:00
Alexandre Poirot 08943eeb3b Bug 1874711 - [devtools] Fix browser_styleeditor_init.js intermittent. r=devtools-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D210699
2024-05-20 12:46:49 +00:00
Valentin Gosu 968cfaf0f1 Bug 1711622 - Update tests r=necko-reviewers,devtools-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D203115
2024-05-20 11:53:58 +00:00
Hubert Boma Manilla 6ee10584ed Bug 1890269 - [devtools] Implementing search highlight in codemirror 6 r=devtools-reviewers,nchevobbe
This patch
- Gets the search in file feature working for codemirror 6 (Use Ctrl/CMD F to open in the editor)
- Highlights search results in the editor, when using the search panel on the left.
- Includes the @codemirror/search package in the codemirror bundle. This enables using the `RegExpCursor`

Differential Revision: https://phabricator.services.mozilla.com/D208110
2024-05-20 09:50:41 +00:00
Hubert Boma Manilla 999135a4da Bug 1891336 - [devtools] Highlight text during pause and for exceptions r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D207418
2024-05-19 22:28:23 +00:00
Hubert Boma Manilla 2db2984f38 Bug 1889281 - [devtools] Display column breakpoints for codemirror 6 r=devtools-reviewers,nchevobbe
This patch creates a new extension and api enable marking content nodes

Differential Revision: https://phabricator.services.mozilla.com/D207408
2024-05-19 22:28:23 +00:00
Hubert Boma Manilla 412baef0b9 Bug 1894725 - [devtools] Scroll to the function when using the copy function context menu item r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D209676
2024-05-19 22:24:16 +00:00
Nicolas Chevobbe badb49de19 Bug 1897469 - [devtools] Fix focus-indicator glitch in inspector sidebar tabs. r=jdescottes,devtools-reviewers.
We make the focused tab appear in fronts of the others,
so the box-shadow of the focus-indicator applies properly
on each side.
We also hide the small line on active tab when it is also
focused, so we avoid it to overlap with the focus-indicator
outline.

Differential Revision: https://phabricator.services.mozilla.com/D210818
2024-05-17 16:10:18 +00:00
Nicolas Chevobbe 99013436f5 Bug 1674321 - [devtools] Tweak matching bracket style. r=devtools-reviewers,bomsy.
We used to have an outline all around the brackets, making
it hard to distinguish the cursor if it was close.
Switching to a simple underline so it's less distracting.

Differential Revision: https://phabricator.services.mozilla.com/D210331
2024-05-17 11:44:56 +00:00
Nicolas Chevobbe e39b6ccdc1 Bug 1897139 - [devtools] Share blocked request string between console and netmonitor. r=devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D210649
2024-05-17 07:42:17 +00:00
Nicolas Chevobbe e58349d131 Bug 1895536 - [devtools] Update network request blocked string. r=devtools-reviewers,ochameau.
Requests can be blocked because of many reasons, but the label was always
saying it was because of DevTools.
Update the label so we follow what's done in Netmonitor.

Differential Revision: https://phabricator.services.mozilla.com/D210471
2024-05-16 12:40:22 +00:00
Nicolas Chevobbe 78c8fde8c1 Bug 1896652 - [devtools] Fix layout glitch in storage table and variable view. r=devtools-reviewers,ochameau.
The plain class that was removed in Bug 1896330 was set
on a few elements in the variable view, the table and
the chart widgets, as well as in the inspector breadcrumb.
This patch removes the plain class and adjust styling
where it's needed.

Differential Revision: https://phabricator.services.mozilla.com/D210316
2024-05-15 15:56:15 +00:00
Valentin Gosu df76ed5c04 Bug 1784496 - The necko consumers should use the priority's incremental flag r=necko-reviewers,kershaw
This patch sets the incremental flag on document and image channels

Differential Revision: https://phabricator.services.mozilla.com/D209235
2024-05-15 08:18:42 +00:00
Gregory Pappas 2292f2bdfa Bug 1842478 - Remove layout.css.individual-transform.enabled pref r=boris,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D184176
2024-05-14 08:33:44 +00:00
Nicolas Chevobbe 3b36e62d91 Bug 1844446 - [devtools] Don't use desugared selectors for selector highlighter. r=devtools-reviewers,bomsy.
Instead, we use the new CSSStyleRule.querySelectorAll method to retrieve the
elements to highlight.
We still compute a "selector", which is basically a concatenation of the
ancestor rules, so we can still mark the rule as highlighted when we display a
different StyleRule front for a rule that was previously highlighted.

Differential Revision: https://phabricator.services.mozilla.com/D208364
2024-05-14 06:19:43 +00:00
Nicolas Chevobbe 7e3ff18292 Bug 1844446 - [devtools] Send rules matching selectors indexes instead of the selector strings. r=devtools-reviewers,bomsy.
This is done to avoid a performance issue with deeply nested rules,
where computing the desugared selector can be super expensive.
This should help overall since we're doing a bit less work, as well
as returning smaller data.

Differential Revision: https://phabricator.services.mozilla.com/D207727
2024-05-14 06:19:43 +00:00
Stanca Serban ae48cb8dcc Backed out changeset afa417babef9 (bug 1842478) for causing mochitests failures in test_transitions_per_property.html. CLOSED TREE 2024-05-14 08:00:39 +03:00
Gregory Pappas 19a51180e7 Bug 1842478 - Remove layout.css.individual-transform.enabled pref r=boris,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D184176
2024-05-14 01:20:52 +00:00
Gregory Pappas 594ae0c85a Bug 1861958 - Remove layout.css.container-queries.enabled pref r=emilio,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D192207
2024-05-13 21:54:28 +00:00
Narcis Beleuzu 6415998d6e Backed out changeset d062a9fa5bb6 (bug 1861958) for "container" related failures. CLOSED TREE 2024-05-13 23:14:39 +03:00
Gregory Pappas d96214ed79 Bug 1861958 - Remove layout.css.container-queries.enabled pref r=emilio,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D192207
2024-05-13 17:17:52 +00:00
Julian Descottes 5a2ab6d6db Bug 1895434 - [devtools] Stop forcing the Performance panel to be displayed in the Browser Toolbox r=devtools-reviewers,nchevobbe
We used to force the preferences for the new performance panel to true for the Browser Toolbox to avoid showing the old performance panel, regardless of the preferences set by the user for their regular devtools.

However, now that the old performance panel is gone, it should be fine to let users decide if they want the panel or not via the devtools Settings panel.
Also the performance panel is on by default, so it shouldn't make it more complicated to profile on clean profiles.

Differential Revision: https://phabricator.services.mozilla.com/D210148
2024-05-13 11:41:13 +00:00
cypherpunks1 932827a0a2 Bug 1892052 - Do not persist custom network requests on PBM. r=devtools-reviewers,bomsy,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D207762
2024-05-13 10:24:32 +00:00
Nicolas Chevobbe 468323a509 Bug 1888645 - [devtools] Fix SmartTrace crash with wasm frames. r=devtools-reviewers,bomsy.
In some cases, we were getting null sourceId, which was causing an exception
to be thrown in `getFormattedSourceId` since it expects a string.
We add a simple guard in this function so we don't throw anymore.

But we shouldn't get null sourceId in the first place. It looks like for
some Wasm sources, the SavedFrame sourceId can be 0, which wasn't playing
well with some loose check we were doing in the sources manager.

Finally, the "Copy metadata" button we display when a console message crash
wasn't working. The message now includes the targetFront, which can be serialized
in JSON, so we simply ignore it.

Differential Revision: https://phabricator.services.mozilla.com/D206105
2024-05-13 10:17:15 +00:00
Nazım Can Altınova cd328db9f0 Bug 1895398 - Change the about:profiling test assertion to only check the area it intends to check r=profiler-reviewers,florian
Previously this assertion was checking the whole preset values, including
interval, threads list and the enabled features. But if you look at the info
message above, it actually only intends to test a specific edge case of a
threads filter. So it's not really necessary to check the interval and the
features since that's not really important for this assertion.

I initially wanted to change this assertion because it caused multiple backouts
in the past when we changed the default values of some features. I think it's
better to not check the features here at all to make sure that we won't have
any more backouts in the future.

Differential Revision: https://phabricator.services.mozilla.com/D209612
2024-05-10 10:30:19 +00:00
Tooru Fujisawa 93e31d8b1f Bug 1893611 - Add shouldAvoidSideEffects debugger flag and use it in Services resolve hook. r=iain,devtools-reviewers,nchevobbe
In order to abort eager evaluation when executing a resolve hook with side-effect,
especially the Services' hook which imports ES module, which is not undo-able,
introduce a dedicate debugger flag to ask to avoid side-effectful operation in
the resolve hook.

Differential Revision: https://phabricator.services.mozilla.com/D208970
2024-05-08 10:56:39 +00:00
Hubert Boma Manilla 5d85945437 Bug 1889276 - [devtools] Fix editor scrolling in codemirror 6 r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D202125
2024-05-07 23:53:33 +00:00
Hubert Boma Manilla 23a61d41b2 Bug 1894659 - [devtools] Fix duplicate breakpoints on really long lines r=devtools-reviewers,nchevobbe
`visibleRanges` can return multiple ranges (mostly for large sources the overflow the current viewport),
and those might contain the same line, causing duplicates.
Switching from cm.visibleRanges to cm.viewport

Differential Revision: https://phabricator.services.mozilla.com/D209233
2024-05-07 00:04:16 +00:00
Nicolas Chevobbe 8ec35e6993 Bug 1894709 - [devtools] Fix browser_rules_pseudo-element_01.js intermittent. r=devtools-reviewers,jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D209556
2024-05-06 14:52:59 +00:00
Nicolas Chevobbe d604cfb8b7 Bug 1894603 - [devtools] Display nested keyframes rules in the Rules view. r=devtools-reviewers,bomsy.
Recursively traverse css rules so we can collect
keyframes rules nested in other rules, which should
behave as regular rules.
We also don't collect ancestor rules for keyframe rules,
as they can only be direct child of @keyframes rules, and
we'd rather display the @keyframes ancestor data at some
point.

Differential Revision: https://phabricator.services.mozilla.com/D209354
2024-05-06 05:21:44 +00:00
Hubert Boma Manilla 235f6fbf11 Bug 1889277 - [devtools] Highlight selected lines of code for codemirror 6 r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D209138
2024-05-05 13:11:04 +00:00
Hubert Boma Manilla 8ae9dd40fc Bug 1889277 - [devtools] Highlighting line on selection in code mirror 6 r=devtools-reviewers,nchevobbe
Note: While testing you might notice there is no scrolling, this is being fixed in D202125

Differential Revision: https://phabricator.services.mozilla.com/D205070
2024-05-05 13:11:04 +00:00