Cristian Tuns
d0272b92b7
Backed out 8 changesets (bug 1651518, bug 1883847) dt failures in nsTArray.h. CLOSED TREE
...
Backed out changeset 481558275c1d (bug 1651518)
Backed out changeset 5337435e8bca (bug 1651518)
Backed out changeset 8fe0c1a4da7f (bug 1651518)
Backed out changeset 840a0d9db260 (bug 1651518)
Backed out changeset eaab9de5819d (bug 1651518)
Backed out changeset cf71de92d782 (bug 1651518)
Backed out changeset d778691464db (bug 1651518)
Backed out changeset af28e5f719e8 (bug 1883847)
2024-05-22 09:02:19 -04:00
Alexandre Poirot
34e5032104
Bug 1651518 - [devtools] Ensure spawning DistinctSystemPrincipalLoader.sys.mjs only once. r=devtools-reviewers,nchevobbe
...
This is important to spawn this ESM only once between regular and browser toolbox,
and especially between various callsites used by the browser toolbox.
Otherwise we may start loading modules in two distinct system loaders
and may have inconsistancies when using `instanceof`.
Differential Revision: https://phabricator.services.mozilla.com/D207432
2024-05-22 11:50:44 +00:00
Cristina Horotan
ca70119cfa
Backed out 8 changesets (bug 1651518, bug 1883847) for causing damp failures at toolbox/browser-toolbox.js CLOSED TREE
...
Backed out changeset 4ec70db12f48 (bug 1651518)
Backed out changeset b2b138889ad6 (bug 1651518)
Backed out changeset efda5c09b0ea (bug 1651518)
Backed out changeset b0de4113f8fb (bug 1651518)
Backed out changeset 03cf235d2a80 (bug 1651518)
Backed out changeset 58e71c27f1fd (bug 1651518)
Backed out changeset f7fb390c3965 (bug 1651518)
Backed out changeset b8a2473c47c0 (bug 1883847)
2024-05-22 04:00:53 +03:00
Alexandre Poirot
3d2406db93
Bug 1651518 - [devtools] Ensure spawning DistinctSystemPrincipalLoader.sys.mjs only once. r=devtools-reviewers,nchevobbe
...
This is important to spawn this ESM only once between regular and browser toolbox,
and especially between various callsites used by the browser toolbox.
Otherwise we may start loading modules in two distinct system loaders
and may have inconsistancies when using `instanceof`.
Differential Revision: https://phabricator.services.mozilla.com/D207432
2024-05-21 14:09:33 +00:00
Nicolas Chevobbe
b64ccccc10
Bug 1896847 - [devtools] Add matching bracket styling in cm6. r=bomsy,devtools-reviewers.
...
Differential Revision: https://phabricator.services.mozilla.com/D210901
2024-05-21 05:43:20 +00:00
Hubert Boma Manilla
6ee10584ed
Bug 1890269 - [devtools] Implementing search highlight in codemirror 6 r=devtools-reviewers,nchevobbe
...
This patch
- Gets the search in file feature working for codemirror 6 (Use Ctrl/CMD F to open in the editor)
- Highlights search results in the editor, when using the search panel on the left.
- Includes the @codemirror/search package in the codemirror bundle. This enables using the `RegExpCursor`
Differential Revision: https://phabricator.services.mozilla.com/D208110
2024-05-20 09:50:41 +00:00
Hubert Boma Manilla
999135a4da
Bug 1891336 - [devtools] Highlight text during pause and for exceptions r=devtools-reviewers,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D207418
2024-05-19 22:28:23 +00:00
Hubert Boma Manilla
2db2984f38
Bug 1889281 - [devtools] Display column breakpoints for codemirror 6 r=devtools-reviewers,nchevobbe
...
This patch creates a new extension and api enable marking content nodes
Differential Revision: https://phabricator.services.mozilla.com/D207408
2024-05-19 22:28:23 +00:00
Nicolas Chevobbe
badb49de19
Bug 1897469 - [devtools] Fix focus-indicator glitch in inspector sidebar tabs. r=jdescottes,devtools-reviewers.
...
We make the focused tab appear in fronts of the others,
so the box-shadow of the focus-indicator applies properly
on each side.
We also hide the small line on active tab when it is also
focused, so we avoid it to overlap with the focus-indicator
outline.
Differential Revision: https://phabricator.services.mozilla.com/D210818
2024-05-17 16:10:18 +00:00
Nicolas Chevobbe
99013436f5
Bug 1674321 - [devtools] Tweak matching bracket style. r=devtools-reviewers,bomsy.
...
We used to have an outline all around the brackets, making
it hard to distinguish the cursor if it was close.
Switching to a simple underline so it's less distracting.
Differential Revision: https://phabricator.services.mozilla.com/D210331
2024-05-17 11:44:56 +00:00
Nicolas Chevobbe
78c8fde8c1
Bug 1896652 - [devtools] Fix layout glitch in storage table and variable view. r=devtools-reviewers,ochameau.
...
The plain class that was removed in Bug 1896330 was set
on a few elements in the variable view, the table and
the chart widgets, as well as in the inspector breadcrumb.
This patch removes the plain class and adjust styling
where it's needed.
Differential Revision: https://phabricator.services.mozilla.com/D210316
2024-05-15 15:56:15 +00:00
Gregory Pappas
2292f2bdfa
Bug 1842478 - Remove layout.css.individual-transform.enabled pref r=boris,devtools-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D184176
2024-05-14 08:33:44 +00:00
Stanca Serban
ae48cb8dcc
Backed out changeset afa417babef9 (bug 1842478) for causing mochitests failures in test_transitions_per_property.html. CLOSED TREE
2024-05-14 08:00:39 +03:00
Gregory Pappas
19a51180e7
Bug 1842478 - Remove layout.css.individual-transform.enabled pref r=boris,devtools-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D184176
2024-05-14 01:20:52 +00:00
Hubert Boma Manilla
5d85945437
Bug 1889276 - [devtools] Fix editor scrolling in codemirror 6 r=devtools-reviewers,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D202125
2024-05-07 23:53:33 +00:00
Hubert Boma Manilla
23a61d41b2
Bug 1894659 - [devtools] Fix duplicate breakpoints on really long lines r=devtools-reviewers,nchevobbe
...
`visibleRanges` can return multiple ranges (mostly for large sources the overflow the current viewport),
and those might contain the same line, causing duplicates.
Switching from cm.visibleRanges to cm.viewport
Differential Revision: https://phabricator.services.mozilla.com/D209233
2024-05-07 00:04:16 +00:00
Hubert Boma Manilla
cfc1737fd0
Bug 1889283 - [devtools] Add support for inline previews r=devtools-reviewers,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D208267
2024-05-05 13:11:03 +00:00
Henrik Skupin
a05a1f4dca
Bug 1892248 - [devtools] Remove backward compatibility code for Firefox 127. r=devtools-backward-compat-reviewers,devtools-reviewers,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D209198
2024-05-02 11:48:36 +00:00
Hubert Boma Manilla
c66148a707
Bug 1887649 - [devtools] Show the conditional/log breakpoint panel in codemirror 6 r=devtools-reviewers,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D205578
2024-04-30 22:15:17 +00:00
Tamas Szentpeteri
dac2560d0e
Backed out changeset c18051672452 (bug 1887649) for causing dt failures in browser_dbg-breakpoints-cond-ui-state.js. CLOSED TREE
2024-04-30 09:43:05 +03:00
Hubert Boma Manilla
976b715f39
Bug 1887649 - [devtools] Show the conditional/log breakpoint panel in codemirror 6 r=devtools-reviewers,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D205578
2024-04-30 05:57:42 +00:00
Nicolas Chevobbe
8384623980
Bug 1892901 - [devtools] Remove performEOFFixup preserveBackslash parameter. r=devtools-reviewers,bomsy.
...
The parameter was always passed with true,
except in a unit test.
Differential Revision: https://phabricator.services.mozilla.com/D208320
2024-04-30 05:12:54 +00:00
Nicolas Chevobbe
5532aef13b
Bug 1892895 - [devtools] Remove JS CSS Lexer. r=devtools-reviewers,ochameau.
...
Differential Revision: https://phabricator.services.mozilla.com/D208318
2024-04-26 09:18:12 +00:00
Nicolas Chevobbe
e5e5834f1d
Bug 1892923 - [devtools] Use InspectorCSSParser in browser_filter-editor-01.js. r=devtools-reviewers,ochameau.
...
Depends on D208317
Differential Revision: https://phabricator.services.mozilla.com/D208333
2024-04-26 09:18:12 +00:00
Nicolas Chevobbe
92dd86afee
Bug 1890552 - [devtools] Use InspectorCSSParser in output-parser.js doParse. r=devtools-reviewers,ochameau.
...
Differential Revision: https://phabricator.services.mozilla.com/D207407
2024-04-26 09:18:11 +00:00
Nicolas Chevobbe
e89bfd931a
Bug 1890552 - [devtools] Use InspectorCSSParser in output-parser.js addInsetPointNodes. r=devtools-reviewers,bomsy.
...
Differential Revision: https://phabricator.services.mozilla.com/D207406
2024-04-26 09:18:11 +00:00
Nicolas Chevobbe
e7b97f59b1
Bug 1890552 - [devtools] Use InspectorCSSParser in output-parser.js addEllipsePointNodes. r=devtools-reviewers,bomsy.
...
Differential Revision: https://phabricator.services.mozilla.com/D207405
2024-04-26 09:18:10 +00:00
Nicolas Chevobbe
2919f1b06c
Bug 1890552 - [devtools] Use InspectorCSSParser in output-parser.js addCirclePointNodes. r=devtools-reviewers,bomsy.
...
Differential Revision: https://phabricator.services.mozilla.com/D207404
2024-04-26 09:18:10 +00:00
Nicolas Chevobbe
0888942263
Bug 1890552 - [devtools] Use InspectorCSSParser in output-parser.js addPolygonPointNodes. r=devtools-reviewers,bomsy.
...
Differential Revision: https://phabricator.services.mozilla.com/D207403
2024-04-26 09:18:09 +00:00
Nicolas Chevobbe
43f7625691
Bug 1890552 - [devtools] Use InspectorCSSParser in output-parser.js sanitizeURL. r=devtools-reviewers,ochameau.
...
Differential Revision: https://phabricator.services.mozilla.com/D207402
2024-04-26 09:18:09 +00:00
Nicolas Chevobbe
de4ffa55e6
Bug 1888607 - [devtools] Use InspectorCSSParser in parseDeclarationsInternal. r=devtools-reviewers,ochameau.
...
Differential Revision: https://phabricator.services.mozilla.com/D206092
2024-04-23 08:43:03 +00:00
Hubert Boma Manilla
3e437ed282
Bug 1888864 - [devtools] Add click and context menu event listeners for the editor content r=devtools-reviewers,nchevobbe
...
With this patch the context menu for the editor should be visible
Differential Revision: https://phabricator.services.mozilla.com/D206291
2024-04-22 11:56:39 +00:00
Nicolas Chevobbe
ca57e329c5
Bug 1888441 - [devtools] Use InspectorCSSParser in CSSCompleter. r=devtools-reviewers,bomsy.
...
This requires some changes as the token type and text from the cssparser
differs from the JS-based CSS lexer.
Differential Revision: https://phabricator.services.mozilla.com/D206023
2024-04-17 05:57:13 +00:00
Nicolas Chevobbe
3c2ffad25b
Bug 1889938 - [devtools] Use InspectorCSSParser in LinearEasingFunctionWidget.js parseTimingFunction. r=devtools-reviewers,ochameau.
...
Differential Revision: https://phabricator.services.mozilla.com/D206875
2024-04-17 05:57:12 +00:00
Nicolas Chevobbe
a1c6a52938
Bug 1889920 - [devtools] Use InspectorCSSParser in CubicBezierWidget.js parseTimingFunction. r=devtools-reviewers,ochameau.
...
Differential Revision: https://phabricator.services.mozilla.com/D206773
2024-04-17 05:57:12 +00:00
Nicolas Chevobbe
48ccfb6997
Bug 1889875 - [devtools] Use InspectorCSSParser in CssAngle#valid. r=devtools-reviewers,ochameau.
...
Differential Revision: https://phabricator.services.mozilla.com/D206752
2024-04-17 05:57:11 +00:00
Nicolas Chevobbe
b340518289
Bug 1888363 - [devtools] Use InspectorCSSParser in tokenizeFilterValue. r=devtools-reviewers,bomsy.
...
Thanks to the way cssparser handle tokens, we can get rid of the quote handling
that was done in `CSSFilterEditorWidget`
Differential Revision: https://phabricator.services.mozilla.com/D205991
2024-04-16 12:11:59 +00:00
Aron Cseh
12dda8a2c9
Backed out 5 changesets (bug 1888615, bug 1889871, bug 1888609, bug 1888353, bug 1888363) for causing dt failures on browser_webconsole_location_styleeditor_link.js CLOSED TREE
...
Backed out changeset ef8e96126716 (bug 1889871)
Backed out changeset a68f24368621 (bug 1888615)
Backed out changeset 1783cd63d2c4 (bug 1888609)
Backed out changeset 62333a10235e (bug 1888363)
Backed out changeset 03888776c90d (bug 1888353)
2024-04-16 13:18:32 +03:00
Nicolas Chevobbe
740f9edcea
Bug 1888363 - [devtools] Use InspectorCSSParser in tokenizeFilterValue. r=devtools-reviewers,bomsy.
...
Thanks to the way cssparser handle tokens, we can get rid of the quote handling
that was done in `CSSFilterEditorWidget`
Differential Revision: https://phabricator.services.mozilla.com/D205991
2024-04-16 07:39:36 +00:00
Julian Descottes
1a81713270
Bug 1845037 - [devtools] Revert DevTools screenshots to use the default downloads directory r=devtools-reviewers,ochameau
...
Revert the DevTools bits from Bug 1072345 to be consistent with the Screenshots feature from Firefox.
Differential Revision: https://phabricator.services.mozilla.com/D207413
2024-04-15 15:05:57 +00:00
Nicolas Chevobbe
a2325cda51
Bug 1718894 - [devtools] Display swatches for functions with css variables. r=devtools-reviewers,bomsy.
...
This should show the color swatch for case like `rgb(var(--r), 0, var(--b))`.
Differential Revision: https://phabricator.services.mozilla.com/D206985
2024-04-10 04:59:53 +00:00
Alexandre Poirot
d7f3cddc7f
Bug 1888171 - [devtools] Convert Browser Loader to ESM. r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
...
Differential Revision: https://phabricator.services.mozilla.com/D205867
2024-03-28 15:15:24 +00:00
Norisz Fay
8b02ae61da
Backed out 2 changesets (bug 1887872) for causing dt failures on browser_dbg-old-breakpoint.js CLOSED TREE
...
Backed out changeset b32b818f2175 (bug 1887872)
Backed out changeset 705494857aed (bug 1887872)
2024-03-27 21:22:10 +02:00
Alexandre Poirot
1ec9670095
Bug 1887872 - [devtools] Set breakpoints on toolbox opening. r=devtools-reviewers,devtools-backward-compat-reviewers,bomsy
...
Register them as soon as we open devtools, instead of waiting for debugger panel opening.
So that breakpoints can work even if we did not open debugger panel yet.
So far, only debugger statement would force the opening of the debugger.
This allows to remove the redundant code from debugger frontend.
Also clarify in this patch that thread-utils exports thread configurations.
Differential Revision: https://phabricator.services.mozilla.com/D205772
2024-03-27 17:04:34 +00:00
artem manushenkov
0c607a8763
Bug 1731635 [devtools] Add option to disable split console r=nchevobbe,fluent-reviewers,devtools-reviewers,bolsson
...
Differential Revision: https://phabricator.services.mozilla.com/D204142
2024-03-27 06:34:50 +00:00
Boris Chiou
ccd5f9238c
Bug 1887738 - Remove preferences of motion path (ray(), basic-shapes, coord-box, offset-position). r=layout-reviewers,devtools-reviewers,emilio,nchevobbe
...
We have shipped them for more than 3 months and we don't have issue
right now. Chromium also removed the flags, so it should be fine to drop
them to make the code simpler.
Differential Revision: https://phabricator.services.mozilla.com/D205615
2024-03-26 16:52:03 +00:00
Alexandre Poirot
c867832007
Bug 1789981 - [devtools] Convert last DevTools JSM to ESM. r=devtools-reviewers,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D202438
2024-03-26 08:29:22 +00:00
Hubert Boma Manilla
34047e8c3a
Bug 1886967 - [devtools] Cleanup the API to make more consitent r=devtools-reviewers,nchevobbe
...
- Added the requirement for a new `id` property to markers passed to the `setLineGutterMarkers` API.
- Changed `gutterLineClassName` to `lineClassName` the API name already indicates that it is the gutter, no need to have gutter in the property name, this also amkes it consistent with `setLineContentMarker`
- Changed `createGutterLineElementNode` to `createLineElementNode` for same reason as above.
Differential Revision: https://phabricator.services.mozilla.com/D205435
2024-03-25 21:56:12 +00:00
Hubert Boma Manilla
1f236dbd77
Bug 1884651 - [devtools] Rendering debug lines when paused in code mirror 6 r=devtools-reviewers,nchevobbe
...
In this patch
- we begin to render debug lines when paused.
- New APIs are added to add and remove line content markers
Differential Revision: https://phabricator.services.mozilla.com/D204243
2024-03-25 21:56:11 +00:00
pstanciu
26e14298bd
Backed out 3 changesets (bug 1884651) for causing pause line failures e.g. on browser_dbg-keyboard-shortcuts.js
...
Backed out changeset 571e7f23a751 (bug 1884651)
Backed out changeset 3c52a12e9f0c (bug 1884651)
Backed out changeset f7201f71c231 (bug 1884651)
2024-03-25 17:18:30 +02:00