Commit Graph
7 Commits
Author SHA1 Message Date
Mark Banner 91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Alexandre Poirot 07e6ce0083 Bug 1792848 - [devtools] Use absolute URLs to import modules in devtools/shared. r=Honza,devtools-backward-compat-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D158643
2022-10-12 15:56:22 +00:00
Ben Delevingne ec3cc0db5d Bug 1673386 - remove defer from devtools/shared/tests/xpcshell/test_executeSoon.js. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D94739
2020-10-27 15:23:22 +00:00
Logan Smyth 2746f14953 Bug 1601179 - Enable async stacks but limit captured async stacks to debuggees. r=jorendorff,smaug
The 'asyncStack' flag on JS execution contexts is used as a general switch
to enable async stack capture across all locations in SpiderMonkey, but
this causes problems because it can at times be too much of a performance
burden to general and track all of these stacks.

Since the introduction of this option, we have only enabled it on Nightly
and DevEdition for non-mobile builds, which has left a lot of users unable
to take advantage of this data while debugging.

This patch enables async stack traces across all of Firefox, but introduces
a new pref to toggle the scope of the actual expensive part of async stacks,
which is _capturing_ them and keeping them alive in memory. The new pref
limits the capturing of async stack traces to only debuggees, unless an
explicit pref is flipped to capture async traces for all cases.

This means that while async stacks are technically enabled, and code could
manually capture a stack and pass it back to SpiderMonkey and see that stack
reflected in later captured stacks, SpiderMonkey itself and related async
DOM APIs, among others, will not capture stacks or pass them to SpiderMonkey,
so there should be no general change in performance by enabling the broader
feature itself, unless the user is actively debugging the page.

One effect of this patch is that if you have the debugger open and then close
it, objects that have async stacks associated with them will retain those
stacks and they will continue to show up in stack traces, no _new_ stacks
will be captured. jorendorff and I have decided that this is okay because
the expectation that the debugger fully revert every possible effect that it
could have on a page is a nice goal but not a strict requirement.

Differential Revision: https://phabricator.services.mozilla.com/D68503
2020-06-14 02:41:45 +00:00
Alexandre Poirot e4582cd9a0 Bug 1609716 - Unify xpcshell test folders in devtools. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D60160
2020-01-20 13:56:04 +00:00
Cosmin Sabou eb2d2dd49c Backed out changeset ccd058375096 (bug 1609716) for devtools failures on browser_device_custom_remove. CLOSED TREE 2020-01-20 18:11:34 +02:00
Alexandre Poirot f2e7460a19 Bug 1609716 - Unify xpcshell test folders in devtools. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D60160
2020-01-20 13:56:04 +00:00