Part 1 of migrating passwordmgr.properties to fluent: Converting the strings from LoginManagerPrompter
1. The following strings [saveLoginMsg2, saveLoginMsgNoUser2, saveLoginButtonDeny.label, saveLoginButtonDeny.accesskey, updateLoginMsg3, updateLoginMsgNoUser3, updateLoginButtonDelete.label, updateLoginButtonDelete.accesskey] are not migrated as the messages are changed. They get replaced by [save-password-message, save-password-button-deny, update-password-messsage, update-password-button-delete]
2. The remaining string from LoginManagerPrompter are migrated by the python script.
Differential Revision: https://phabricator.services.mozilla.com/D195931
Ensure the focusable and actionable control is also labeled, so an assistive technology user would know the purpose of this control. It should not only be announced as `Close` but also provide a context by referencing the search mode title text as well, so the "History" search would be announced as `Close History mode` or just `Close History` or similar.
Also, since there were a series of test cases failing the a11y-checks because of this unlabeled control, we remove the `fail-if` notations from their test manifests to allow for the accessibility tests to run and expect to pass, as they should be.
Differential Revision: https://phabricator.services.mozilla.com/D196095
prewarming the AVDs was done for CI, where AVDs are used only once in
each task using them, and the cost of first use is high. Prewarming
reduces that overhead.
However, the ARM AVD is not used on CI (anymore?), so we don't need
them prewarmed. This unblocks the situation wrt the failure to run
the emulator on CI, while not addressing the underlying issues, so that
CoT keys can be rotated without waiting for the full situation to be
resolved.
Differential Revision: https://phabricator.services.mozilla.com/D195820
Setting `MOZBUILD_STATE_PATH` and/or moving the `state_dir` can cause
problems with installed hg extensions due to stale references in the
mercurial.ini file. Doing this check should allow the user the fix
the problem without having to deciper the confusing errors that
appear as a result.
An environment variable (MACH_IGNORE_HGRC_STATE_DIR_MISMATCH) was
added to ignore this check if for some reason a user intentionally wants
to use extensions installed elsewhere.
Differential Revision: https://phabricator.services.mozilla.com/D183210
Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2:
- Use `config.toml` to list UniFFI sources. This makes it easier to
associate data with them, for example the `crate_name` field that's
now required to generate the sources.
- Enable the `extern-rustbuffer` feature on `uniffi_core`
- Updated the external types fixture to work around
https://github.com/mozilla/uniffi-rs/issues/1872
Ran mach vendor and mach cargo vet to update the Rust crates.
Differential Revision: https://phabricator.services.mozilla.com/D195163
If this is not done, the next person to vendor will also make all of the changes in this commit, which is unnecessary noise.
Differential Revision: https://phabricator.services.mozilla.com/D183450
This patch prevents the mozperftest unit tests from installing the opencv-python/mozperftest-tools module during unit tests.
Differential Revision: https://phabricator.services.mozilla.com/D195901
As this code is uncovered by automated tests, I verified the changes manually:
1. In `about:preferences`, set a non-English preferred language.
2. Visit some public page (Perhaps not necessary? Not sure.)
3. In `about:config`, toggle the `privacy.resistFingerprinting` pref to true
This should present you with a confirmation prompt with the migrated message.
Differential Revision: https://phabricator.services.mozilla.com/D195446
In many cases, using CONFIG["CPU_ARCH"] will silently do the unexpected
thing now that it doesn't exist anymore. In case there are in-flight
patches using it, it's better to avoid those causing subtle problems
after a rebase by making most uses of the variable throw an exception.
Differential Revision: https://phabricator.services.mozilla.com/D195158
This patch updates mozperftest-tools to 0.2.9, and removes the opencv-python 4.5 install since it interferes with the new opencv-python package that has a lower minimum version for python (version 3.7).
Differential Revision: https://phabricator.services.mozilla.com/D195774
This patch fixes an issue where only `perftest.ini` manifests were being parsed for mozperftest tests in perfdocs. It's temporary as we will move all ini manifests to toml in the future. At the same time, this patch adds missing documentation for some new mozperftest tests that use a toml manifest to define the tests.
Differential Revision: https://phabricator.services.mozilla.com/D194251
Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2:
- Use `config.toml` to list UniFFI sources. This makes it easier to
associate data with them, for example the `crate_name` field that's
now required to generate the sources.
- Enable the `extern-rustbuffer` feature on `uniffi_core`
- Updated the external types fixture to work around
https://github.com/mozilla/uniffi-rs/issues/1872
Ran mach vendor and mach cargo vet to update the Rust crates.
Differential Revision: https://phabricator.services.mozilla.com/D195163
Prior to this change, --disable-optimize clobber builds on macOS took 50%
longer. Build telemetry shows over 80% of developer builds on macOS use
--disable-optimize.
The defaults for HOST_OPTIMIZE_FLAGS that are set in old-configure.in can be
overriden by setting the variable in your mozconfig. For example, setting:
HOST_OPTIMIZE_FLAGS=-O1
Differential Revision: https://phabricator.services.mozilla.com/D195459
Prior to this change, --disable-optimize clobber builds on macOS took 50%
longer. Build telemetry shows over 80% of developer builds on macOS use
--disable-optimize.
The defaults for HOST_OPTIMIZE_FLAGS that are set in old-configure.in can be
overriden by setting the variable in your mozconfig. For example, setting:
HOST_OPTIMIZE_FLAGS=-O1
Differential Revision: https://phabricator.services.mozilla.com/D195459
Some time after bug 1237610 originally added telemetry gathering to the build
process, the code changed to gather it via Glean in bug 1651424. Later, bug
1867968 removed some of the old code, but it missed the removal of
get_build_opts. This change removes that function and a few other functions in
the same file that appear to be unused.
Differential Revision: https://phabricator.services.mozilla.com/D195354
Also remove dependencies that we don't depend on directly. I assume these were
previously added to get a lockfile of sorts, but maintaining our dependencies'
dependencies manually is an excercise in futility.
Let's forget about locking, and if it becomes a problem implement locking into
mach's sites logic.
Differential Revision: https://phabricator.services.mozilla.com/D195300
On Windows, paths provided to FileFinder may contain backslashes, which
will cause uses of `mozpath.match` later on to fail when they try to
compare mixed-path values. To avoid this, normalize those paths on
receipt.
(Also, silence a lint by pulling the global `args` variable into a
function, so that it is no longer occluded by the various function
parameters named `args`.)
Differential Revision: https://phabricator.services.mozilla.com/D194448
This includes a containers.json version increment and the necessary migration,
as the StringBundle identifiers are replaced with a Fluent reference.
As it's not possible to filter the attributes that are applied with DOM localization,
the code in utilityOverlay.js is a little clumsy. The non-acceskey versions are needed
due to bug 1297738, i.e. the long-press menu available from the tab bar down arrow.
Previously, the "Manage containers" menu item and its accesskey were defined in two places.
These are here combined into one.
Differential Revision: https://phabricator.services.mozilla.com/D194510
This migration creates a new FTL file under mobile/android/.
As GeckoView isn't actually localised (see bug 1605358), this file is not exposed to localisers.
A migration script is still included,
as previous localisations of the strings are available from their Fennec days.
Running the script will fail in an m-c checkout bootstrapped for desktop development;
it's possible to hack around this by manually setting
the `l10n_toml` value in `python/l10n/test_fluent_migrations/fmt.py`.
Differential Revision: https://phabricator.services.mozilla.com/D194541
Updated uniffi-bindgen-gecko-js to work with UniFFI 0.25.2:
- Use `config.toml` to list UniFFI sources. This makes it easier to
associate data with them, for example the `crate_name` field that's
now required to generate the sources.
- Enable the `extern-rustbuffer` feature on `uniffi_core`
- Updated the external types fixture to work around
https://github.com/mozilla/uniffi-rs/issues/1872
Ran mach vendor and mach cargo vet to update the Rust crates.
Differential Revision: https://phabricator.services.mozilla.com/D195163
Add a `get_mozilla_upstream_remote` method for `GitRepository` that
scans the output of `git remote -v` for an official Mozilla URL. Use
this URL in `base_ref` to limit the remotes considered for remote
branches, defaulting to `--remotes` without an argument if one can't
be found.
Differential Revision: https://phabricator.services.mozilla.com/D194881