mirror of
https://github.com/HeyPuter/firefox.git
synced 2026-11-15 05:00:02 -10:00
4e94de9f6dc14a3068e626b70ff20e652fedad51
58
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
 Kent Tamura
|
22dd6ca6af |
Bug 1896317 [wpt PR 46220] - RubyLB: ::first-line style should not be applied to all rubies, a=testonly
Automatic update from web-platform-tests RubyLB: ::first-line style should not be applied to all rubies Sub-LineBreakers always referred to InlineItems for ::first-line incorrectly because the constructor for them don't have an InlineBreakToken. This CL fixes it by passing the parent LineBreaker through SetInputRange(), then PrepareNextLine() updates items_data_. Bug: 324111880 Change-Id: I1c19b727335fb1b636f731b58155789b60480c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528710 Reviewed-by: Koji Ishii <[email protected]> Auto-Submit: Kent Tamura <[email protected]> Commit-Queue: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1299875} -- wpt-commits: b9491b534cb1a6991c5afaf65fc4960e55c506b4 wpt-pr: 46220 |
||
|
Kent Tamura
|
79e2bc6920 |
Bug 1896048 [wpt PR 46196] - RubyLB: ruby-position should be valid for ::first-line, a=testonly
Automatic update from web-platform-tests RubyLB: `ruby-position` should be valid for ::first-line https://drafts.csswg.org/css-pseudo/#first-line-styling > * the ruby-position property (see [CSS-RUBY-1]) Bug: 324111880 Change-Id: Icc8901b29d0352b1cfa50238fca969884c5fa9a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526384 Commit-Queue: Koji Ishii <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Auto-Submit: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1299087} -- wpt-commits: ef0e939fc091f0066a80490495df72773bd81bd3 wpt-pr: 46196 |
||
|
Kent Tamura
|
5039716b7c |
Bug 1895825 [wpt PR 46178] - RubyLB: position:relative outside of ruby-text should move it., a=testonly
Automatic update from web-platform-tests RubyLB: position:relative outside of ruby-text should move it. InlineLayoutStateStack::ApplyRelativePositioning() for annotation lines should be applied after ApplyRelativePositioning() for the base line. * Call ApplyRelativePositioning() for the base line and annotation lines almost same time, with passing ancestor relative offsets. * Call CreateBoxFragments() for annotation lines just before CreateBoxFragments() for the base line. * Remove FinalizeAnnotationLines(). * Don't move InlineLayoutStateStack::ruby_column_list_ out. It's necessary until CreateBoxFragments(). Bug: 324111880 Change-Id: I2cf66af6118ad52ffedf7579930bde25c794ca5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493166 Commit-Queue: Koji Ishii <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Auto-Submit: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1298506} -- wpt-commits: 6ca6cf86c9378bc6659febb8f1fc4185b1fdf757 wpt-pr: 46178 |
||
|
Kent Tamura
|
0a874c3c55 |
Bug 1893101 [wpt PR 45865] - Layout: Fix incorrect annotation space computation for atomic-inlines, a=testonly
Automatic update from web-platform-tests Layout: Fix incorrect annotation space computation for atomic-inlines ComputeAnnotationOverflow() should take into account of atomic inline boxes. Bug: 336592423 Change-Id: Ia6343f13ecb59b44c26bc00f19476479013a34aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5480273 Reviewed-by: Koji Ishii <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1291724} -- wpt-commits: 270b59561b55d2dd50345e92448fc2bcdb4cca5b wpt-pr: 45865 |
||
|
Kent Tamura
|
291c4ea90c |
Bug 1891647 [wpt PR 45731] - css-ruby: Import rubyDOM-*-rt-block-*.html in WebKit/Blink, a=testonly
Automatic update from web-platform-tests css-ruby: Import rubyDOM-*-rt-block-*.html in WebKit/Blink * Merge rubyDOM-insert-rt-block-*.html into ruby-dynamic-insertion-005.html. * Merge rubyDOM-remove-rt-block-*.html into ruby-dynamic-removal-003.html. Change-Id: Idffdaf1587bd3df4faa988d0cd6c6fe933715df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5456511 Commit-Queue: Koji Ishii <[email protected]> Auto-Submit: Kent Tamura <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1287832} -- wpt-commits: b13bfb616d79e6e4063a71d80caa28e326bd1d30 wpt-pr: 45731 |
||
|
Kent Tamura
|
34737a9b9b |
Bug 1864780 [wpt PR 43162] - [CSS display:ruby*] Don't fix position and float for <rt>, a=testonly
Automatic update from web-platform-tests [CSS display:ruby*] Don't fix position and float for <rt> We have forced `position: static; float: none;` for <rt>. We don't need it any longer. Changing these property values blockifies `display: ruby-text`, and it won't work as ruby-text. The new behavior is compatible with Firefox. Bug: 880802 Change-Id: Iec2886c64f48f360258ef17a6885b047dfff3be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5028779 Commit-Queue: Koji Ishii <[email protected]> Auto-Submit: Kent Tamura <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1224752} -- wpt-commits: f6e86730951e1dac4377e0ad67342180df1ee29c wpt-pr: 43162 |
||
|
Natalia Csoregi
|
fd9c9ce3e8 |
Backed out 259 changesets (bug 1858251, bug 1864135, bug 1862628, bug 1864134, bug 1864495, bug 1862531, bug 1864790, bug 1865066, bug 1864792, bug 1864566, bug 1864844, bug 1857775, bug 1864031, bug 1863959, bug 1863670, bug 1864462, bug 1863803, bug 1864780, bug 1864357, bug 1863585, bug 1864227, bug 1863859, bug 1860640, bug 1863618, bug 1864814, bug 1864197, bug 1864648, bug 1865447, bug 1864432, bug 1864402, bug 1857476, bug 1864633, bug 1864208, bug 1863709, bug 1864049, bug 1848745, bug 1864547, bug 1860042, bug 1864558, bug 1863331, bug 1861356, bug 1864535, bug 1863442, bug 1864532, bug 1862413, bug 1863562, bug 1864766, bug 1862863, bug 1863333, bug 1863774, bug 1863378, bug 1862325, bug 1864777, bug 1859333, bug 1861376, bug 1838259, bug 1865141, bug 1863313, bug 1864769, bug 1864077, bug 1862392, bug 1864372, bug 1864848, bug 1862615, bug 1863388, bug 1864026, bug 1864595, bug 1864802, bug 1864017, bug 1863656, bug 1863923, bug 1864604, bug 1864303, bug 1863987, bug 1863013, bug 1864225, bug 1863909, bug 1864630, bug 1865003, bug 1864250, bug 1863541, bug 1863516, bug 1864763, bug 1863161, bug 1863740, bug 1862700, bug 1865608, bug 1863784, bug 1863593, bug 1864600, bug 1865142, bug 1864249, bug 1863764, bug 1865135, bug 1863683, bug 1863493, bug 1864367, bug 1860770, bug 1864036, bug 1849891, bug 1864540, bug 1865576, bug 1860704, bug 1863582, bug 1864860, bug 1865189, bug 1863634, bug 1864248, bug 1864929, bug 1863405, bug 1864594, bug 1863446, bug 1864657, bug 1864831, bug 1862343, bug 1864539, bug 1865418, bug 1862979, bug 1863654, bug 1864906, bug 1864097, bug 1863888, bug 1865303, bug 1864029, bug 1863851, bug 1864065, bug 1863069, bug 1865337, bug 1863739, bug 1864467, bug 1864563, bug 1863862, bug 1864770, bug 1864439, bug 1864428, bug 1864567, bug 1865432, bug 1859366, bug 1863648, bug 1864973, bug 1864635, bug 1864055, bug 1864311, bug 1863767, bug 1865577, bug 1865274, bug 1862012, bug 1864650, bug 1865030, bug 1864360, bug 1863915, bug 1864358, bug 1865107, bug 1864230, bug 1856055, bug 1863364, bug 1865056, bug 1863704, bug 1857222, bug 1721499, bug 1864368, bug 1862440, bug 1865251, bug 1865022, bug 1865314, bug 1862099, bug 1864586, bug 1860937, bug 1864177, bug 1864470, bug 1863816, bug 1864302, bug 1864061, bug 1857583, bug 1865325, bug 1864757, bug 1864373, bug 1864625, bug 1864812, bug 1864552) for causing spidermonkey bustages on wasm/jsapi/module/moduleSource.tentative.any.js. CLOSED TREE
Backed out changeset 6ec912c267ab (bug 1865608) Backed out changeset a891101f2c04 (bug 1864373) Backed out changeset 8c72380f65d6 (bug 1865576) Backed out changeset d02bf86e02ab (bug 1865577) Backed out changeset 508ebc54a93d (bug 1865447) Backed out changeset e8637be97c1c (bug 1865447) Backed out changeset f167f9e40390 (bug 1865022) Backed out changeset ecebe10f15dd (bug 1865022) Backed out changeset 91e5dfcce3ad (bug 1865418) Backed out changeset c1234e3ea426 (bug 1864017) Backed out changeset 1ff5884e071d (bug 1864017) Backed out changeset e7e4fa3aecc2 (bug 1862343) Backed out changeset 869e7b93db2b (bug 1865432) Backed out changeset 6dbecfa2ba73 (bug |
||
|
Kent Tamura
|
0c7c4d6014 |
Bug 1864780 [wpt PR 43162] - [CSS display:ruby*] Don't fix position and float for <rt>, a=testonly
Automatic update from web-platform-tests [CSS display:ruby*] Don't fix position and float for <rt> We have forced `position: static; float: none;` for <rt>. We don't need it any longer. Changing these property values blockifies `display: ruby-text`, and it won't work as ruby-text. The new behavior is compatible with Firefox. Bug: 880802 Change-Id: Iec2886c64f48f360258ef17a6885b047dfff3be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5028779 Commit-Queue: Koji Ishii <[email protected]> Auto-Submit: Kent Tamura <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1224752} -- wpt-commits: f6e86730951e1dac4377e0ad67342180df1ee29c wpt-pr: 43162 |
||
|
Jonathan Kew
|
b3026604e6 |
Bug 1819726 - Handle bidi for rb and rt boxes. r=emilio
Patch proposed by Xidorn appears to work as expected. Added testcase to WPT. Differential Revision: https://phabricator.services.mozilla.com/D171445 |
||
|
Gérard Talbot
|
7e644a48bb |
Bug 1783478 [wpt PR 35365] - rbc-rtc-basic-001.html test was missing a <link rel="match" href="..."> to its reference, a=testonly
Automatic update from web-platform-tests rbc-rtc-basic-001.html test was missing a <link rel='match' href='' to its reference (#35365) -- wpt-commits: 19d452e70a4ace1014d47c4eeb2d44ee88bb8218 wpt-pr: 35365 |
||
|
Gérard Talbot
|
696a5fbf59 |
Bug 1728208 [wpt PR 30238] - [css-ruby] Added 1 intra-base test, a=testonly
Automatic update from web-platform-tests [css-ruby] Added 1 intra-base test (#30238) * Added 1 intra-base test * Complexified intra-base-white-space-001 test * Update css/css-ruby/intra-base-white-space-001.html Co-authored-by: fantasai <[email protected]> Co-authored-by: fantasai <[email protected]> -- wpt-commits: 42e9ca1955ded2015b21a43866021b49dbb6e7d1 wpt-pr: 30238 |
||
|
Gérard Talbot
|
02cbc18731 |
Bug 1760463 [wpt PR 33271] - [css-ruby] Adding japanese .woff font resource into block-ruby-001 test and reference, a=testonly
Automatic update from web-platform-tests [css-ruby] Adding japanese .woff font resource into block-ruby-001 test and reference (#33271) * Replaced japanese char. with latin char. in block-ruby-001 * Improved block-ruby-001 and added japanese .woff font -- wpt-commits: e7c65660d5183d41a1c1330f9615f40dbe6f447e wpt-pr: 33271 |
||
|
Gérard Talbot
|
3df1db6163 |
Bug 1718687 [wpt PR 29535] - [css-ruby] Creating a reliable ruby text pairing test and reference, a=testonly
Automatic update from web-platform-tests Creating a reliable ruby text pairing test and reference -- wpt-commits: 0387de5dd1d67e2fa9c6c63d32d47ff17c11bb42 wpt-pr: 29535 |
||
|
Daniel Smith
|
60429adfc1 |
Bug 1746965 [wpt PR 32151] - Remove empty css flags tags from the css directory (non-CSS2) (8/8), a=testonly
Automatic update from web-platform-tests Remove empty css flags tags from the css directory (non-CSS2) (8/8) (#32151) * remove empty flags tags from the (non CSS2) css directories * remove extra spaces from merge -- wpt-commits: 5e295079d07ef43bdd9fe1ccea9b59067fc5ae46 wpt-pr: 32151 |
||
|
Tim Nguyen
|
192ac20002 |
Bug 1745380 [wpt PR 31999] - Move ruby tests out of vendor-imports (#8615), a=testonly
Automatic update from web-platform-tests Move ruby tests out of vendor-imports (#8615) -- wpt-commits: d854644fdf6b3d7a4075dbf69a519251fd7b4cfd wpt-pr: 31999 |
||
|
Morten Stenshorne
|
0f015efa7f |
Bug 1732060 [wpt PR 30876] - Don't include BR clearance in the line's height., a=testonly
Automatic update from web-platform-tests Don't include BR clearance in the line's height. Including clearance in the line height may result in tall monolithic content, which is problematic for block fragmentation, especially for column balancing. Instead, store trailing clearance in the layout result, so that the block layout algorithm can add it to the layout position for subsequent content. We already use a similar trick for ruby annotations, and some care is required so that we don't move back above the clearance offset when canceling ruby annotations overflow (which happens in some cases). There was no test coverage for this, so added three tests for that (they pass both and without this CL). Also added a multicol test that demonstrates what this fixes in column balancing. Bug: 829028 Change-Id: I84e58326e9ada78e3f29ad01d8043a173626aea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168645 Commit-Queue: Morten Stenshorne <[email protected]> Reviewed-by: Ian Kilpatrick <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#923502} -- wpt-commits: faa9a85d068538c986ba01119789194f92f8d344 wpt-pr: 30876 |
||
|
Alexandru Michis
|
31a11889ae |
Backed out 160 changesets (bug 1730136, bug 1729734, bug 1730484, bug 1731289, bug 1731278, bug 1733783, bug 1732014, bug 1732017, bug 1732016, bug 1732010, bug 1732013, bug 1730377, bug 1730578, bug 1732018, bug 1731288, bug 1731335, bug 1732054, bug 1731333, bug 1732059, bug 1732058, bug 1732651, bug 1732650, bug 1731339, bug 1731338, bug 1731330, bug 1731319, bug 1731315, bug 1651513, bug 1732033, bug 1731265, bug 1732652, bug 1732368, bug 1724852, bug 1730579, bug 1724548, bug 1732009, bug 1594736, bug 1732649, bug 1731320, bug 1731321, bug 1729775, bug 1732048, bug 1731325, bug 1732641, bug 1731328, bug 1731282, bug 1732644, bug 1732043, bug 1732646, bug 1732042, bug 1731344, bug 1731309, bug 1731269, bug 1731340, bug 1731341, bug 1731342, bug 1731343, bug 1731304, bug 1731305, bug 1731306, bug 1732029, bug 1716997, bug 1731284, bug 1720812, bug 1728269, bug 1732648, bug 1731294, bug 1731295, bug 1730296, bug 1732065, bug 1731252, bug 1730023, bug 1732038, bug 1732073, bug 1732070, bug 1732639, bug 1732032, bug 1731259, bug 1732037, bug 1732035, bug 1731327, bug 1730295, bug 1710346, bug 1723584, bug 1731297, bug 1731270, bug 1730299, bug 1728730, bug 1731274, bug 1730256, bug 1730495, bug 1732024, bug 1732047, bug 1732044, bug 1716072, bug 1729099, bug 1716030, bug 1732645, bug 1732028, bug 1730302, bug 1732066, bug 1732067, bug 1732060, bug 1732040, bug 1732062, bug 1732063, bug 1732020, bug 1732021, bug 1732022, bug 1732647, bug 1732068, bug 1732026) for causing spidermonkey failures.
CLOSED TREE Backed out changeset 72551ab47a3b (bug 1733783) Backed out changeset 7739ab6bad61 (bug 1724548) Backed out changeset 7643034b7a84 (bug 1732652) Backed out changeset c542c361dede (bug 1732651) Backed out changeset 352b18e7b596 (bug 1732650) Backed out changeset 08ca563b22c2 (bug 1732650) Backed out changeset 7b7067c4e778 (bug 1732649) Backed out changeset 0ca1bd937952 (bug |
||
|
Morten Stenshorne
|
ae6e96bacd |
Bug 1732060 [wpt PR 30876] - Don't include BR clearance in the line's height., a=testonly
Automatic update from web-platform-tests Don't include BR clearance in the line's height. Including clearance in the line height may result in tall monolithic content, which is problematic for block fragmentation, especially for column balancing. Instead, store trailing clearance in the layout result, so that the block layout algorithm can add it to the layout position for subsequent content. We already use a similar trick for ruby annotations, and some care is required so that we don't move back above the clearance offset when canceling ruby annotations overflow (which happens in some cases). There was no test coverage for this, so added three tests for that (they pass both and without this CL). Also added a multicol test that demonstrates what this fixes in column balancing. Bug: 829028 Change-Id: I84e58326e9ada78e3f29ad01d8043a173626aea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168645 Commit-Queue: Morten Stenshorne <[email protected]> Reviewed-by: Ian Kilpatrick <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#923502} -- wpt-commits: faa9a85d068538c986ba01119789194f92f8d344 wpt-pr: 30876 |
||
|
Gérard Talbot
|
8993cadb64 |
Bug 1722997 [wpt PR 29841] - [css-ruby] Tweaked block-ruby-005 test and reference, a=testonly
Automatic update from web-platform-tests [css-ruby] Tweaked block-ruby-005 test and reference (#29841) * Tweaked block-ruby-005 test and reference * Improved, tweaked block-ruby-005 and its reference -- wpt-commits: 4935b8010a8121913c30bad6460b31a8554d9090 wpt-pr: 29841 |
||
|
Gérard Talbot
|
4242ce31d9 |
Bug 1728200 [wpt PR 30237] - [css-ruby] 2 basic rb and rt display tests, a=testonly
Automatic update from web-platform-tests 2 basic rb and rt display tests (#30237) -- wpt-commits: 3561e3996e33c89034683f6f7f0174f69ba25fe8 wpt-pr: 30237 |
||
|
Gérard Talbot
|
34862f629d |
Bug 1722970 [wpt PR 29840] - [css-ruby] Created basic test on rbc and rtc elements, a=testonly
Automatic update from web-platform-tests [css-ruby] Created basic test on rbc and rtc elements (#29840) * Created basic test on rbc and rtc elements * Removing useless, unneeded declarations * Improving rbc-rtc-basic-001.html and its reference -- wpt-commits: be2c5bd43833b03f515ebc0283512926195eac50 wpt-pr: 29840 |
||
|
Ian Kilpatrick
|
83a8b4658a |
Bug 1726069 [wpt PR 30044] - [block-in-inline] Fix various ruby + floats issues., a=testonly
Automatic update from web-platform-tests [block-in-inline] Fix various ruby + floats issues. Ruby had a few different issues (see new tests). - A ruby annotation would "pull" down a float (test 001). - A ruby annotation would intersect with floats (test 002,003). This fixes these issues. Specifically we look at annotation overflow to determining if a line will fix in a given layout opportunity, and use the ruby block adjust to positioning floats. Bug: 716930 Change-Id: I4a25fbd22a93647e7af54b654e786a8d3504ae4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3065855 Reviewed-by: Kent Tamura <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Commit-Queue: Ian Kilpatrick <[email protected]> Cr-Commit-Position: refs/heads/master@{#912571} -- wpt-commits: 139f569b206ec3b24351b0eb98f7a76c95c553cb wpt-pr: 30044 |
||
|
Gérard Talbot
|
22d482d0f2 |
Bug 1722584 [wpt PR 29809] - [css-ruby] Basic improperly-contained-annotation test and 2 references, a=testonly
Automatic update from web-platform-tests [css-ruby] Basic improperly-contained-annotation test and 2 references (#29809) * Created a basic improperly-contained-annotation test and 2 references * Removing 1 reference, renaming the other * Removed comment and tuned test and reference -- wpt-commits: a668cd5a949a11c1039abfc7d2b1e4a9a48dc744 wpt-pr: 29809 |
||
|
Gérard Talbot
|
96e7d8b09b |
Bug 1722923 [wpt PR 29839] - [css-ruby] Filename-renamed 2 ruby-base-container tests, a=testonly
Automatic update from web-platform-tests [css-ruby] Filename-renamed 2 ruby-base-container tests (#29839) * Filename-renamed 2 ruby-base-container tests * Updated 2 tests and 1 reference issue 29515 -- wpt-commits: 7735055e603fd0c1e5bf6eaa9bca378206b45a00 wpt-pr: 29839 |
||
|
Gérard Talbot
|
1746e27bd2 |
Bug 1723014 [wpt PR 29843] - [css-ruby] Tweaked block-ruby-003 test and reference, a=testonly
Automatic update from web-platform-tests Tweaked block-ruby-003 test and reference (#29843) -- wpt-commits: 9650980b2c8e313a395be04c960346c8980bc83f wpt-pr: 29843 |
||
|
Gérard Talbot
|
bfe57fdf08 |
Bug 1723001 [wpt PR 29842] - [css-ruby] Tweaked block-ruby-004 test and reference, a=testonly
Automatic update from web-platform-tests Tweaked block-ruby-004 test and reference (#29842) -- wpt-commits: c9625eb5cfc604191fec066e6ce217ab59b3c6ae wpt-pr: 29842 |
||
|
Xidorn Quan
|
ac7eb128ae |
Bug 1696721 part 3 - Fix intrinsic isize calculation for ruby frame. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D109228 |
||
|
Xidorn Quan
|
45ad19de34 |
Bug 1697529 - Implement visibility: collapse support for ruby text. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D107990 |
||
|
Xidorn Quan
|
f95072bfa2 |
Bug 1694748 part 3 - Enable ruby-position: alternate by default. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D107384 |
||
|
Xidorn Quan
|
45bd4f3061 |
Bug 1694748 part 2 - Implement layout of ruby-position: alternate. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D107383 |
||
|
Kent Tamura
|
f17e3d9bd1 |
Bug 1645966 [wpt PR 24161] - RubyNG: A line shouldn't provide annotation space if it has text-emphasis, a=testonly
Automatic update from web-platform-tests RubyNG: A line shouldn't provide annotation space if it has text-emphasis * A line has text-emphasis at the 'under' side, and the next line has ruby at 'over' side, or * A line has ruby at the 'under' side, and the next line has text-emphasis at 'over' side In these two cases, text-emphasis and ruby could be overlapped. This CL fixes this issue. Note: - The legacy ruby also has this issue, but this CL doesn't fix it for the legacy ruby. - The FAIL line in external/wpt/css/css-ruby/line-spacing-expected.txt is expected. We'll fix it soon. Bug: 1069817 Change-Id: Ie2201d577c58a77000c7ace7a1f3de718866a989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245991 Reviewed-by: Yoshifumi Inoue <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/master@{#778687} -- wpt-commits: bfcaaa8a2261e974b1a162ddd4155984098e90ca wpt-pr: 24161 |
||
|
Xidorn Quan
|
a7eb04bfeb |
Bug 1641139 - Reflow absolute frames in ruby container and ruby base container. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D77584 |
||
|
Butkovits Atila
|
e8bd270b63 | Backed out changeset 6bb6a5cdc941 (bug 1641139) for causing failures at abs-in-ruby-base-container.html. CLOSED TREE | ||
|
Xidorn Quan
|
871e145e1e |
Bug 1641139 - Reflow absolute frames in ruby container and ruby base container. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D77584 |
||
|
Kent Tamura
|
4985b97916 |
Bug 1641456 [wpt PR 23817] - css-ruby: Add a test for '3.5. Line Spacing', a=testonly
Automatic update from web-platform-tests css-ruby: Add a test for '3.5. Line Spacing' Bug: crbug.com/1069817 Change-Id: Ie3b4bb52e9151939026df20e37459de596d78545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217714 Commit-Queue: Kent Tamura <[email protected]> Commit-Queue: Koji Ishii <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/master@{#772573} -- wpt-commits: 5389f61985bba1bee593247dbf01ce5d89048b3d wpt-pr: 23817 |
||
|
Florian Rivoal
|
10af4810b2 |
Bug 1637909 [wpt PR 23591] - [css-ruby] test parsing of the ruby-merge property, a=testonly
Automatic update from web-platform-tests [css-ruby] test parsing of the ruby-merge property (#23591) See https://github.com/w3c/csswg-drafts/issues/5004 -- wpt-commits: 48950262c7bfde62ce876471f354b878b06958ce wpt-pr: 23591 |
||
|
Sam Bowen
|
2b59583bd4 |
Bug 1636575 [wpt PR 23492] - Update name in files from Mozilla internship., a=testonly
Automatic update from web-platform-tests Update name in files from Mozilla internship. These were some files I worked on when I interned at Mozilla using my personal email address. The author name in the files is out of date. Change-Id: I5c5a08294676a3c800787bf34fc844d155c9548b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190978 Reviewed-by: Mounir Lamouri <[email protected]> Commit-Queue: Sam Bowen <[email protected]> Cr-Commit-Position: refs/heads/master@{#767528} -- wpt-commits: a49081e46a18e439defbd77d18cc5e261d68b215 wpt-pr: 23492 |
||
|
Kent Tamura
|
79946e24f0 |
Bug 1636017 [wpt PR 23449] - css-ruby: Fix incorrect tests in ruby-position.html, a=testonly
Automatic update from web-platform-tests css-ruby: Fix incorrect tests in ruby-position.html ruby-position property should work with 'ruby text container boxes'. So ruby-position on <rt> should not work. https://drafts.csswg.org/css-ruby-1/#rubypos Bug: https://github.com/web-platform-tests/wpt/issues/23386 Change-Id: I3c3e7a762c8f88d5ffce1101692b06b6e496e49d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186615 Commit-Queue: Koji Ishii <[email protected]> Auto-Submit: Kent Tamura <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/master@{#766290} -- wpt-commits: bf9b762dad89dd35757cd160fc9d96c385a873b6 wpt-pr: 23449 |
||
|
Sebastian Hengst
|
00ce601d70 |
Backed out 210 changesets (bug 1634781, bug 1635593, bug 1636959, bug 1635957, bug 1634942, bug 1629179, bug 1634613, bug 1633868, bug 1636952, bug 1634944, bug 1635539, bug 1636045, bug 1589335, bug 1636575, bug 1635043, bug 1635996, bug 1635643, bug 1635994, bug 1634529, bug 1593063, bug 1635049, bug 1633606, bug 1635808, bug 1636310, bug 1636358, bug 1634070, bug 1635418, bug 1636258, bug 1634622, bug 1625663, bug 1635306, bug 1635004, bug 1634575, bug 1636399, bug 1635086, bug 1626529, bug 1636693, bug 1634136, bug 1635323, bug 1633934, bug 1634249, bug 1636652, bug 1636565, bug 1629063, bug 1633854, bug 1636090, bug 1600404, bug 1634802, bug 1635928, bug 1635425, bug 1633673, bug 1636099, bug 1636345, bug 1635078, bug 1637109, bug 1635342, bug 1635838, bug 1633074, bug 1637101, bug 1635804, bug 1634630, bug 1634774, bug 1632046, bug 1636017, bug 1633690, bug 1635673, bug 1636115, bug 1635138, bug 1636910, bug 1637211, bug 1636462, bug 1634118, bug 1635336, bug 1634161, bug 1636978, bug 1632614, bug 1634581, bug 1636834, bug 1635337, bug 1633787, bug 1633588, bug 1636833, bug 1635702, bug 1634298, bug 1635316, bug 1634725, bug 1475158, bug 1636230, bug 1633441, bug 1635971, bug 1636573, bug 1634157, bug 1634150, bug 1633593, bug 1636020, bug 1635479, bug 1633999, bug 1636532, bug 1634510, bug 1636066, bug 1634718, bug 1637245, bug 1635141, bug 1636475, bug 1635304, bug 1634114, bug 1635782, bug 1635751, bug 1635780, bug 1629089, bug 1636435, bug 1634297, bug 1634697, bug 1636126, bug 1635217, bug 1636000, bug 1635896, bug 1635817, bug 1636527, bug 1635815, bug 1631821, bug 1635813, bug 1634183, bug 1636853, bug 1633594, bug 1635453, bug 1634807, bug 1630901, bug 1635845, bug 1635988, bug 1633611, bug 1635195, bug 1635712, bug 1634067, bug 1636172, bug 1625005, bug 1634214, bug 1633691, bug 1636134, bug 1631998, bug 1634612, bug 1636322, bug 1634794, bug 1634611, bug 1635315, bug 1636605, bug 1636288, bug 1635541, bug 1636875, bug 1636876, bug 1636449, bug 1636448, bug 1630074, bug 1637486, bug 1628246, bug 1633577) for breaking spidermonkey tasks. CLOSED TREE
Backed out changeset 7baa72e0d62c (bug 1637486) Backed out changeset 24e38d0cf349 (bug 1635702) Backed out changeset a99469886218 (bug 1635702) Backed out changeset 0bd06c295951 (bug 1637211) Backed out changeset 893f40e8ac70 (bug 1637211) Backed out changeset 7e4449460eee (bug 1636952) Backed out changeset abc7724f7d24 (bug |
||
|
Sam Bowen
|
805f70456e |
Bug 1636575 [wpt PR 23492] - Update name in files from Mozilla internship., a=testonly
Automatic update from web-platform-tests Update name in files from Mozilla internship. These were some files I worked on when I interned at Mozilla using my personal email address. The author name in the files is out of date. Change-Id: I5c5a08294676a3c800787bf34fc844d155c9548b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190978 Reviewed-by: Mounir Lamouri <[email protected]> Commit-Queue: Sam Bowen <[email protected]> Cr-Commit-Position: refs/heads/master@{#767528} -- wpt-commits: a49081e46a18e439defbd77d18cc5e261d68b215 wpt-pr: 23492 |
||
|
Kent Tamura
|
578eb54c01 |
Bug 1636017 [wpt PR 23449] - css-ruby: Fix incorrect tests in ruby-position.html, a=testonly
Automatic update from web-platform-tests css-ruby: Fix incorrect tests in ruby-position.html ruby-position property should work with 'ruby text container boxes'. So ruby-position on <rt> should not work. https://drafts.csswg.org/css-ruby-1/#rubypos Bug: https://github.com/web-platform-tests/wpt/issues/23386 Change-Id: I3c3e7a762c8f88d5ffce1101692b06b6e496e49d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186615 Commit-Queue: Koji Ishii <[email protected]> Auto-Submit: Kent Tamura <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/master@{#766290} -- wpt-commits: bf9b762dad89dd35757cd160fc9d96c385a873b6 wpt-pr: 23449 |
||
|
Kent Tamura
|
50a2ef2110 |
Bug 1632746 [wpt PR 23221] - Implement and ship 'ruby-position' CSS property, a=testonly
Automatic update from web-platform-tests
Implement and ship 'ruby-position' CSS property
This CL implements 'ruby-position' CSS property, which is a property
independent from the existing '-webkit-ruby-position', but these
properties share a single ComputedStyle field.
We apply neither legacy name alias [1] nor legacy shorthands [2] because
- Acceptable keyword sets are different in ruby-position and
-webkit-ruby-position.
- Avoid behavior changes with |element.style.webkitRubyPosition =
'after'|.
* core/css/css_computed_style_declaration.cc
Add 'ruby-position' to getComputedStyle() enumeration.
* core/css/parser/css_parser_fast_paths.cc
Add setting for fast-path parsing
* core/css/properties/longhands/longhands_custom.cc
Add CSSValueFromComputedStyleInternal() to translate a ComputedStyle::
GetRubyPosition() value to 'over' or 'under'.
* core/css/resolver/style_builder_converter.{h,cc}
Add a function to convert a parsed CSS keyword to a
blink::RubyPosition value.
* web_tests/external/wpt/css/css-ruby/ruby-position.html
New test to check ruby annotation position.
* web_tests/fast/ruby/ruby-position-om.html
New test to check relationship between ruby-position and
-webkit-ruby-position.
Approved intent: https://t.co/nmCPv0Onhk
[1] https://drafts.csswg.org/css-cascade/#legacy-name-alias
[2] https://drafts.csswg.org/css-cascade/#legacy-shorthand
Bug: 196690
Change-Id: I2f00099f90a2222b7ddba8b58c3a532f3b997744
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152569
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/master@{#762664}
--
wpt-commits: ae457cd8b39790508e841f581e2066871859db1a
wpt-pr: 23221
|
||
|
Florian Rivoal
|
8f5feed217 |
Bug 1628972 [wpt PR 22843] - [css-ruby] Test for M/B/P around base/annotation container boxes, a=testonly
Automatic update from web-platform-tests [css-ruby] Test for M/B/P around base/annotation container boxes (#22843) Relates to https://github.com/w3c/csswg-drafts/issues/4937 -- wpt-commits: 73c2c2bbb9c8ea7ef99649f342099aee16718e78 wpt-pr: 22843 |
||
|
Florian Rivoal
|
b0cbaadda3 |
Bug 1631324 [wpt PR 23103] - [css-ruby] tests for https://github.com/w3c/csswg-drafts/issues/4631, a=testonly
Automatic update from web-platform-tests [css-ruby] tests for https://github.com/w3c/csswg-drafts/issues/4631 (#23103) -- wpt-commits: 711f50ca736d1a1a3baadb57a2b5dd658e32c0fe wpt-pr: 23103 |
||
|
Arthur Iakab
|
3a1cd64b07 |
Backed out 283 changesets (bug 1632885, bug 1631324, bug 1631891, bug 1631973, bug 1631550, bug 1632882, bug 1631654, bug 1630540, bug 1630628, bug 1631482, bug 1631652, bug 1631088, bug 1631120, bug 1631715, bug 1631083, bug 1488323, bug 1632334, bug 1632883, bug 1632238, bug 1632031, bug 1631817, bug 1632233, bug 1632230, bug 1631390, bug 1631126, bug 1630530, bug 1630760, bug 1628956, bug 1630630, bug 1631881, bug 1631648, bug 1632171, bug 1633228, bug 1633385, bug 1633387, bug 1630544, bug 1631034, bug 1633309, bug 1631923, bug 1632172, bug 1632410, bug 1632411, bug 1633435, bug 1632327, bug 1632320, bug 1632328, bug 1632329, bug 1631807, bug 1630889, bug 1631004, bug 1628915, bug 1628916, bug 1631961, bug 1630934, bug 1631732, bug 1627693, bug 1631731, bug 1631100, bug 1630354, bug 1630654, bug 1632860, bug 1630685, bug 1632398, bug 1625889, bug 1632656, bug 1632395, bug 1632258, bug 1632310, bug 1633426, bug 1633427, bug 1633420, bug 1632253, bug 1630955, bug 1631939, bug 1630572, bug 1630973, bug 1610634, bug 1632819, bug 1629485, bug 1632816, bug 1631030, bug 1631033, bug 1631032, bug 1630808, bug 1632382, bug 1632383, bug 1632702, bug 1632703, bug 1631507, bug 1631501, bug 1631989, bug 1633094, bug 1631356, bug 1619698, bug 1623734, bug 1630741, bug 1630749, bug 1630699, bug 1632174, bug 1630745, bug 1630823, bug 1632477, bug 1631900, bug 1628010, bug 1630693, bug 1627202, bug 1630909, bug 1624639, bug 1630938, bug 1630700, bug 1628931, bug 1633643, bug 1630469, bug 1630702, bug 1631513, bug 1633000, bug 1630703, bug 1621081, bug 1633489, bug 1630932, bug 1630931, bug 1630930, bug 1633277, bug 1587902, bug 1630831, bug 1632773, bug 1630689, bug 1630145, bug 1631850, bug 1631985, bug 1627208, bug 1631948, bug 1631115, bug 1631110, bug 1631111, bug 1633364, bug 1632905, bug 1632168, bug 1631470, bug 1632604, bug 1631764, bug 1630768, bug 1632608, bug 1630692, bug 1631485, bug 1632512, bug 1633578, bug 1629688, bug 1632282, bug 1631279, bug 1632041, bug 1632044, bug 1631842, bug 1633704, bug 1630846, bug 1632681, bug 1631967, bug 1630842, bug 1624710, bug 1631286, bug 1632610, bug 1630798, bug 1631777, bug 1631264, bug 1630669, bug 1630711, bug 1630915, bug 1630910, bug 1632506, bug 1632195, bug 1632190, bug 1629196, bug 1631601, bug 1632988, bug 1632596, bug 1632746, bug 1632537, bug 1633114, bug 1622512, bug 1630906, bug 1626150, bug 1633059, bug 1632435, bug 1631098, bug 1631413, bug 1632266, bug 1617988, bug 1630684, bug 1630147, bug 1632106, bug 1631704, bug 1631314, bug 1630709, bug 1633056, bug 1632222, bug 1630861, bug 1632580, bug 1628972, bug 1631148, bug 1632586) for causing web platform failures.
CLOSED TREE Backed out changeset 2545233d9410 (bug 1633704) Backed out changeset 60a87bfc559a (bug 1633114) Backed out changeset 5e9a6c965ed7 (bug 1633114) Backed out changeset 82fba3a68f28 (bug 1632041) Backed out changeset eb40eab59089 (bug 1632041) Backed out changeset c1c2c8827a01 (bug 1633056) Backed out changeset a21b653891a4 (bug 1633056) Backed out changeset dcec16f6a03d (bug 1630955) Backed out changeset 099aa92486bc (bug |
||
|
Kent Tamura
|
9feff211db |
Bug 1632746 [wpt PR 23221] - Implement and ship 'ruby-position' CSS property, a=testonly
Automatic update from web-platform-tests
Implement and ship 'ruby-position' CSS property
This CL implements 'ruby-position' CSS property, which is a property
independent from the existing '-webkit-ruby-position', but these
properties share a single ComputedStyle field.
We apply neither legacy name alias [1] nor legacy shorthands [2] because
- Acceptable keyword sets are different in ruby-position and
-webkit-ruby-position.
- Avoid behavior changes with |element.style.webkitRubyPosition =
'after'|.
* core/css/css_computed_style_declaration.cc
Add 'ruby-position' to getComputedStyle() enumeration.
* core/css/parser/css_parser_fast_paths.cc
Add setting for fast-path parsing
* core/css/properties/longhands/longhands_custom.cc
Add CSSValueFromComputedStyleInternal() to translate a ComputedStyle::
GetRubyPosition() value to 'over' or 'under'.
* core/css/resolver/style_builder_converter.{h,cc}
Add a function to convert a parsed CSS keyword to a
blink::RubyPosition value.
* web_tests/external/wpt/css/css-ruby/ruby-position.html
New test to check ruby annotation position.
* web_tests/fast/ruby/ruby-position-om.html
New test to check relationship between ruby-position and
-webkit-ruby-position.
Approved intent: https://t.co/nmCPv0Onhk
[1] https://drafts.csswg.org/css-cascade/#legacy-name-alias
[2] https://drafts.csswg.org/css-cascade/#legacy-shorthand
Bug: 196690
Change-Id: I2f00099f90a2222b7ddba8b58c3a532f3b997744
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152569
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/master@{#762664}
--
wpt-commits: ae457cd8b39790508e841f581e2066871859db1a
wpt-pr: 23221
|
||
|
Florian Rivoal
|
e47223954c |
Bug 1628972 [wpt PR 22843] - [css-ruby] Test for M/B/P around base/annotation container boxes, a=testonly
Automatic update from web-platform-tests [css-ruby] Test for M/B/P around base/annotation container boxes (#22843) Relates to https://github.com/w3c/csswg-drafts/issues/4937 -- wpt-commits: 73c2c2bbb9c8ea7ef99649f342099aee16718e78 wpt-pr: 22843 |
||
|
Florian Rivoal
|
cfa33cba01 |
Bug 1631324 [wpt PR 23103] - [css-ruby] tests for https://github.com/w3c/csswg-drafts/issues/4631, a=testonly
Automatic update from web-platform-tests [css-ruby] tests for https://github.com/w3c/csswg-drafts/issues/4631 (#23103) -- wpt-commits: 711f50ca736d1a1a3baadb57a2b5dd658e32c0fe wpt-pr: 23103 |
||
|
Xidorn Quan
|
5ba5adc146 |
Bug 1603354 - Treat empty ruby base/text container as if there is an empty inline element inside. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D61078 |
||
|
Xidorn Quan
|
12ccdcd22e |
Bug 1144465 - Resolve bidi inside ruby. r=jfkthame
This commit changes IsBidiLeaf to mark ruby boxes not a bidi leaf, since conceptually they are not. I auditted all uses of it, and I believe it makes more sense this way. Differential Revision: https://phabricator.services.mozilla.com/D58290 |