Commit Graph
18 Commits
Author SHA1 Message Date
Masayuki Nakano c6185be88c Bug 1832726 - part 1: Make Android widget always dispatch keyboard events during composition r=m_kato,geckoview-reviewers
I think that we don't need the prefs to disable the behavior because the
behavior conforms to UI Events definition and we've shipped the behavior in
2018.  Therefore, nobody shouldn't require to disable the behavior.

Differential Revision: https://phabricator.services.mozilla.com/D177999
2023-05-16 22:42:59 +00:00
Masayuki Nakano 76e8fb822d Bug 1792515 - Rename InputContext::mHTMLInputInputmode to mHTMLInputMode r=m_kato,geckoview-reviewers
Now, `inputmode` attribute (`inputMode` in the DOM interface) is a global
attribute for `contenteditable`.  Therefore, `Input` is not necessary and
`Inputmode` should be `InputMode`.

Differential Revision: https://phabricator.services.mozilla.com/D158244
2022-09-29 14:06:03 +00:00
Sandor Molnar 761cdbb956 Backed out changeset a00513981ecf (bug 1792515) for causing bug 1792767 CLOSED TREE 2022-09-29 04:56:22 +03:00
Masayuki Nakano fe522290da Bug 1792515 - Rename InputContext::mHTMLInputInputmode to mHTMLInputMode r=m_kato,geckoview-reviewers
Now, `inputmode` attribute (`inputMode` in the DOM interface) is a global
attribute for `contenteditable`.  Therefore, `Input` is not necessary and
`Inputmode` should be `InputMode`.

Depends on D157894

Differential Revision: https://phabricator.services.mozilla.com/D158244
2022-09-28 23:55:23 +00:00
Masayuki Nakano 34c118bb52 Bug 1746104 - part 6-3: Wrap ContentCache::mText with Maybe r=m_kato
For managing the state of text content cache independent from selection, it
should be wrapped with `Maybe`.

Differential Revision: https://phabricator.services.mozilla.com/D137429
2022-02-07 22:33:40 +00:00
Masayuki Nakano a61550f298 Bug 1746104 - part 6-0: Clean up logging code in ContentCache.cpp r=m_kato
Differential Revision: https://phabricator.services.mozilla.com/D137426
2022-02-07 22:33:39 +00:00
Masayuki Nakano 01a0864593 Bug 1746104 - part 5-4: Make widget code handle no selection case at getting selection change notifications r=m_kato,geckoview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D137425
2022-02-07 22:33:38 +00:00
Masayuki Nakano d0db3082cb Bug 1746104 - part 5-3: Make SelectionChangeDataBase treat no range case r=m_kato
Unfortunately, it cannot has `Maybe` because of used by a union.  Therefore,
it needs to manage with `bool` members of whether it's initialized with or
without error and whether it has a range.

Note that this changes `nsITextInputProcessorCallback.idl` which is currently
only for automated tests too.  The new behavior will be tested by the last
patch in this bug.

Differential Revision: https://phabricator.services.mozilla.com/D137424
2022-02-07 22:33:38 +00:00
Masayuki Nakano 74f158e3c2 Bug 1746104 - part 5-2: Add some utility methods to IMENotification::SelectionChangeDataBase r=m_kato
Differential Revision: https://phabricator.services.mozilla.com/D137423
2022-02-07 22:33:38 +00:00
Masayuki Nakano 45742c9174 Bug 1746104 - part 2-3: Clean up some code in IMEData.h r=m_kato
I'd like to use `OffsetAndData` in `IMMHandler` to store selection range.
Before doing this, this patch adds some useful methods into it.

Differential Revision: https://phabricator.services.mozilla.com/D137411
2022-02-07 22:33:33 +00:00
Masayuki Nakano 46aaa872b0 Bug 1683226 - part 11: Get rid of IMEEnabled::Plugin r=m_kato
Differential Revision: https://phabricator.services.mozilla.com/D100123
2020-12-21 08:26:24 +00:00
Masayuki Nakano 9c26cefd0e Bug 1683226 - part 1: Make IMEState::Enabled an enum class r=m_kato,geckoview-reviewers
Before deleting `IMEState::Enabled::PLUGIN`, let's make it an enum class
for making the change safer.  Almost all of this change is done by
"replace" of VSCode.

Differential Revision: https://phabricator.services.mozilla.com/D100100
2020-12-21 05:52:03 +00:00
Masayuki Nakano bd2f542196 Bug 1678553 - part 1: Make TSFTextStore::Composition manage start offset and composition string with a class r=m_kato
This patch creates `OffsetAndData` for managing start offset in flat-text
content and composition string in one place.  And it supports stream to
log it easier.

Then, this patch makes `TSFTextStore::Composition` inherits it for sharing
similar code with other similar data.

Note that the new class guarantees that it won't return overflown offset
and it won't cut overflown string from max offset.

Differential Revision: https://phabricator.services.mozilla.com/D97947
2020-11-26 10:34:13 +00:00
Makoto Kato a616c12bc3 Bug 1425291 - Part 3. Add autocapitalize to InputContext. r=masayuki
Autocapitalize isn't applied if type is url, email or password. If these types,
truncate autocapitalize value in InputContext not to pass it to widget.

Differential Revision: https://phabricator.services.mozilla.com/D86676
2020-09-15 14:27:00 +00:00
Makoto Kato bc9699ca2c Bug 1654146 - Clean up InputContext logging. r=masayuki
Actually, altough TSF and IMEStateManager have the logging for InputContext,
I would like to use common logging code using `ToString.h`.

Differential Revision: https://phabricator.services.mozilla.com/D84287
2020-07-21 08:12:04 +00:00
Jonathan Watt ce19f554ca Bug 1634154. Make widget/gtk buildable outside of unified-build environment. r=karlt
Differential Revision: https://phabricator.services.mozilla.com/D73123
2020-05-01 03:02:13 +00:00
Makoto Kato 155c01d7e0 Bug 1617778 - Use ToString.h to share text and selection change logging. r=masayuki
It is useful to use ToString.h to log text and selection change instead of
adding it each source code. Actually, there is same code in
IMEContentObserver and widget.

Also, mozilla namespace is required since this conflicts with
WinModifierKeyState.h.

Differential Revision: https://phabricator.services.mozilla.com/D64021
2020-02-28 04:45:05 +00:00
Makoto Kato a121f3389a Bug 1577685 - Move some utility functions from IMEStateManager to widget. r=masayuki
I would like to log `IMEState` and `InputContextAction`in widget. But this
utilities are in `IMEStateManager`, so I would like to move it to widget
by using `mozilla/ToString.h`.

Differential Revision: https://phabricator.services.mozilla.com/D44103
2019-08-30 05:56:58 +00:00