Commit Graph
13 Commits
Author SHA1 Message Date
Gabriele Svelto e1e9346196 Bug 1831092 - Use the new pull-based API for all crash annotations and remove the global annotations table r=jgilbert,necko-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,padenot,handyman,afranchuk,valentin,alwu,sotaro
This changes comes with several different refactorings all rolled into one,
unfotunately I couldn't find a way to pull them apart:
- First of all annotations now can either recorded (that is, we copy the value
  and have the crash reporting code own the copy) or registered. Several
  annotations are changed to use this functionality so that we don't need to
  update them as their value change.
- The code in the exception handler is modified to read the annotations from
  the mozannotation_client crate. This has the unfortunate side-effect that
  we need three different bits of code to serialize them: one for annotations
  read from a child process, one for reading annotations from the main process
  outside of the exception handler and one for reading annotations from the
  main process within the exception handler. As we move to fully
  out-of-process crash reporting the last two methods will go away.
- The mozannotation_client crate now doesn't record annotation types anymore.
  I realized as I was working on this that storing types at runtime has two
  issues: the first one is that buggy code might change the type of an
  annotation (that is record it under two different types at two different
  moments), the second issue is that types might become corrupt during a
  crash, so better enforce them at annotation-writing time. The end result is
  that the mozannotation_* crates now only store byte buffers, track the
  format the data is stored in (null-terminated string, fixed size buffer,
  etc...) but not the type of data each annotation is supposed to contain.
- Which brings us to the next change: concrete types for annotations are now
  enforced when they're written out. If an annotation doesn't match the
  expected type it's skipped. Storing an annotation with the wrong type will
  also trigger an assertion in debug builds.

Differential Revision: https://phabricator.services.mozilla.com/D195248
2024-03-04 10:24:43 +00:00
kriswright 1b55ccd124 Bug 1829252 - Guard parent AvailableMemoryWatcherBase members with a mutex. r=xpcom-reviewers,nika
This further guards methods that weren't covered under individual OS implementations.

Differential Revision: https://phabricator.services.mozilla.com/D188955
2023-09-25 17:25:19 +00:00
Haik Aftandilian ea7b0a1beb Bug 1730066 - Enable tab unloading on macOS r=spohl
Enable tab unloading on macOS when the OS memory pressure level reaches "critical".

Add a gtest that exercises the memory pressure response by testing that a tab unload attempt occurs and the internal memory-pressure notification is sent. Test does not cause a real OS memory pressure event.

Use the memory_pressure(1) macOS command to generate artificial memory pressure events to test the browser response. For example, the following artificially puts the OS in the "critical" memory pressure level for 60 seconds.

`$ sudo memory_pressure -S -l critical -s 60`

Differential Revision: https://phabricator.services.mozilla.com/D126560
2021-10-21 04:43:35 +00:00
Toshihito Kikuchi 81d710ec23 Bug 1729918 - Annotate the user interaction state. r=haik
This patch adds a crash annotation named *LastInteractionDuration*, that indicates
the length of the user interaction duration if the crash happen when the user is
inactive.

Differential Revision: https://phabricator.services.mozilla.com/D125718
2021-10-05 04:41:53 +00:00
Narcis Beleuzu cb00fed26f Backed out changeset 656210ea1124 (bug 1729918) for Bp-hybrid bustages on AvailableMemoryWatcher.cpp . CLOSED TREE 2021-10-04 17:46:18 +03:00
Toshihito Kikuchi b785935113 Bug 1729918 - Annotate the user interaction state. r=haik
This patch adds a crash annotation named *LastInteractionDuration*, that indicates
the length of the user interaction duration if the crash happen when the user is
inactive.

Differential Revision: https://phabricator.services.mozilla.com/D125718
2021-10-04 13:21:23 +00:00
Marian-Vasile Laza 474eba8121 Backed out changeset cda6b6fe842a (bug 1729918) for causing buid bustages. CLOSED TREE 2021-10-04 11:21:01 +03:00
Toshihito Kikuchi 2570c0070e Bug 1729918 - Annotate the user interaction state. r=haik
This patch adds a crash annotation named *LastInteractionDuration*, that indicates
the length of the user interaction duration if the crash happen when the user is
inactive.

Differential Revision: https://phabricator.services.mozilla.com/D125718
2021-10-04 07:01:46 +00:00
Haik Aftandilian 5f933c2e89 Bug 1723604 - Patch 2 - Include memory_watcher data in Mac event pings r=mac-reviewers,bradwerth
Record duration of memory pressure periods in event pings using the support added in bug 1715858.

Differential Revision: https://phabricator.services.mozilla.com/D121795
2021-08-05 06:07:39 +00:00
Haik Aftandilian 58e9175744 Bug 1723604 - Patch 1 - Refactor the MacMemoryPressureLevel enum into a basic class r=mac-reviewers,bradwerth
Differential Revision: https://phabricator.services.mozilla.com/D121794
2021-08-05 06:07:39 +00:00
Haik Aftandilian c3ab9fc0d4 Bug 1714382 - Include the Mac memory pressure state in crash reports r=spohl,KrisWright
Subscribe to memory pressure events on macOS and add crash report annotations to parent and content process crash reports that can be used to determine if the system was under memory pressure at the time of the crash.

Include the memory pressure level reported via the DISPATCH_SOURCE_TYPE_MEMORYPRESSURE dispatch with timestamps of transitions, the memory pressure level as read from the kern.memorystatus_vm_pressure_level sysctl, and a measurement of the percentage of available memory in the system read from the kern.memorystatus_level sysctl.

Differential Revision: https://phabricator.services.mozilla.com/D116725
2021-07-27 16:17:43 +00:00
Iulian Moraru f921988c43 Backed out changeset 4f0fe70a0e34 (bug 1714382) for causing assertion failures on nsCycleCollector.cpp. CLOSED TREE 2021-07-27 02:48:53 +03:00
Haik Aftandilian 1783c9d65f Bug 1714382 - Include the Mac memory pressure state in crash reports r=spohl,KrisWright
Subscribe to memory pressure events on macOS and add crash report annotations to parent and content process crash reports that can be used to determine if the system was under memory pressure at the time of the crash.

Include the memory pressure level reported via the DISPATCH_SOURCE_TYPE_MEMORYPRESSURE dispatch with timestamps of transitions, the memory pressure level as read from the kern.memorystatus_vm_pressure_level sysctl, and a measurement of the percentage of available memory in the system read from the kern.memorystatus_level sysctl.

Differential Revision: https://phabricator.services.mozilla.com/D116725
2021-07-26 22:52:33 +00:00