Commit Graph
227 Commits
Author SHA1 Message Date
Kris Maglione b3990a2d91 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW
2018-04-24 20:18:09 -07:00
Kris Maglione edea7a2390 Bug 1454202: Part 4 - Convert add-on providers to use promise-based methods. r=aswan
MozReview-Commit-ID: 9e4CtcxWSiM
2018-04-21 15:30:40 -07:00
Kris Maglione d3bbf87c83 Bug 1454202: Part 1 - Update legacy callers to use Promise-based AddonManager APIs. r=aswan
***
Bug 1454202: Part 1a - Auto-replace uses of callback-based AddonManager APIs with Promise-based versions. r=aswan

This was done using the following script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/4cd5ae959765d0965dd0cc635de3e953bf46edbb/processors/aom-api-generators.jsm

MozReview-Commit-ID: 8hobLz15a66
***
Bug 1454202: Part 1b - Manually fix eslint errors after auto-rewrite. r=aswan

This also deletes an obsolete test whose xpcshell variant was already deleted.

MozReview-Commit-ID: DM9W9Q2SVIE
***
Bug 1454202: Part 1c - Manually fix non-eslint issues after auto-rewrite. r=aswan

MozReview-Commit-ID: DtMscWZuExc
2018-04-14 19:38:18 -07:00
Julian Descottes 77cdcb1aa0 Bug 1445197 - part 3: Move about:debugging worker module to a shared module;r=ochameau
Extract all the logic that will be shared between about debugging and the application
panel to a dedicated client module.

MozReview-Commit-ID: Ccnmp3dCZpW
2018-04-20 16:27:15 +02:00
Ciure Andrei 7d0d7e8fbb Backed out 4 changesets (bug 1445197)for ESlint failure, on a CLOSED TREE a=backout
Backed out changeset 422bbd33b4e3 (bug 1445197)
Backed out changeset 086638cc851c (bug 1445197)
Backed out changeset 11f5214dc193 (bug 1445197)
Backed out changeset eae47509bc27 (bug 1445197)
2018-04-18 23:50:12 +03:00
Julian Descottes 73ad967535 Bug 1445197 - part 3: Move about:debugging worker module to a shared module;r=ochameau
Extract all the logic that will be shared between about debugging and the application
panel to a dedicated client module.

MozReview-Commit-ID: Ccnmp3dCZpW
2018-04-05 21:45:15 +02:00
Andreea Pavel 9f90c53976 Backed out 4 changesets (bug 1445197) for failing mochitest devtools on multiple files e.g. devtools/client/aboutdebugging/test/browser_service_workers.js on a CLOSED TREE
Backed out changeset 4b6f77cfd686 (bug 1445197)
Backed out changeset ba9ffea6d216 (bug 1445197)
Backed out changeset a0345830e1cf (bug 1445197)
Backed out changeset 3e9acd2c8bd3 (bug 1445197)
2018-04-18 20:19:34 +03:00
Julian Descottes 35c97e7776 Bug 1445197 - part 3: Move about:debugging worker module to a shared module;r=ochameau
Extract all the logic that will be shared between about debugging and the application
panel to a dedicated client module.

MozReview-Commit-ID: Ccnmp3dCZpW
2018-04-05 21:45:15 +02:00
Csoregi Natalia e399c3ce77 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-04-18 01:39:35 +03:00
Kris Maglione 31b62bd68b Bug 1453881: Part 1a - Automatically write add_task(function*) to add_task(async function) r=ochameau
This was done using the script at:

https://bitbucket.org/kmaglione/m-c-rewrites/src/bc5629735d8c7e4150f376d4a906e7c7c23132ba/processors/add-task-async.jsm?at=default&fileviewer=file-view-default

MozReview-Commit-ID: KxuS9Cen87
2018-04-12 21:10:04 -07:00
Julian Descottes 4542abbbe4 Bug 1379116 - Localize hardcoded addon installation error string in about:debugging;r=ochameau
MozReview-Commit-ID: 1dnaoWrtaSS
2018-04-17 11:49:02 +02:00
Alexandre Poirot d10cea6483 Bug 1453712 - Use a preference to set the testing flag. r=jryans
MozReview-Commit-ID: 1cjSQnXtc4h
2018-04-12 09:22:42 -07:00
Jonathan Kingston e8dbd6acf1 Bug 1374741 - Within devtools/ tests make openUILinkIn() provide the correct triggeringPrincipal. r=jryans
MozReview-Commit-ID: GNEe8H0sc4L
2018-02-21 23:21:03 +00:00
Brian Birtles 93df0e7bd8 Bug 1444301 - Move disable pop-up autohide feature to toolbox menu; r=jryans
MozReview-Commit-ID: 3cJKqIxaFkV
2018-04-05 10:13:22 +09:00
Nicolas Chevobbe 8007c0babc Bug 1382581 - Adapt extension code to the EventEmitter change in devtools/client/framework; r=rpl.
MozReview-Commit-ID: 3I7kmXiPOqd
2018-03-14 18:12:17 +01:00
Alexandre Poirot 22e91d7acd Bug 1440321 - Convert Task.jsm to async/await in devtools/client. r=jryans
MozReview-Commit-ID: HaGOC5cn3JD
2018-03-12 19:46:35 -05:00
J. Ryan Stinnett 8d1c817851 Bug 1443081 - Apply spacing via eslint --fix for DevTools. r=jdescottes
MozReview-Commit-ID: 2RVNt140Zte
2018-03-12 13:44:41 -05:00
J. Ryan Stinnett 742921268c Bug 1442312 - Wait for addon reload to finish in tests. r=jdescottes
In about:debugging's browser_addon_reload.js test, we would request a reload
without waiting for it to reply.  This led to the RDP connection closing before
the reply could be sent, triggering later errors.

For better test correctness, we now emit an event on reply and the test waits to
receive it before proceeding.

MozReview-Commit-ID: Jfps7MJ6Pzo
2018-03-08 19:05:32 -06:00
J. Ryan Stinnett a7231a768e Bug 1442312 - Move allowed rejections into specific tests they apply to. r=ochameau
By moving only the rejections that actually still apply into each test and out
of the shared head file, we are much more likely to notice new instances and
catch them when writing and editing tests in the future.

Bug 1018184 can be used to actually resolve these issues.

MozReview-Commit-ID: Qb71PsuutB
2018-03-08 18:14:52 -06:00
J. Ryan Stinnett aa067adb85 Bug 1436187 - Move existing shared head files to devtools/client/shared. r=bgrins
Move shared-head.js and shared-redux-head.js into shared.

MozReview-Commit-ID: 5NUxcl9gkLl
2018-03-02 19:14:05 -06:00
Cosmin Sabou 111a73f847 Backed out 4 changesets (bug 1436187) for mochitest devtools failures at browser_se_editors-error-gutter.js on a CLOSED TREE
Backed out changeset 253f74e28723 (bug 1436187)
Backed out changeset 9875771c9967 (bug 1436187)
Backed out changeset b2d808aa8c2e (bug 1436187)
Backed out changeset e747480f3cd2 (bug 1436187)
2018-03-07 22:04:35 +02:00
J. Ryan Stinnett 039b00fd39 Bug 1436187 - Move existing shared head files to devtools/client/shared. r=bgrins
Move shared-head.js and shared-redux-head.js into shared.

MozReview-Commit-ID: 5NUxcl9gkLl
2018-03-02 19:14:05 -06:00
Alexandre Poirot 13e5d4f0f5 Bug 1434374 - Auto-rewrite Cu.import into ChromeUtils.import or require calls. r=jdescottes
MozReview-Commit-ID: 7YyLu5q23Hs
2018-02-07 01:37:36 -08:00
Andrew McCreight 272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione 0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/37e3803c7a23385bab5ea077ba8692bcfe1608fc/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/37e3803c7a23385bab5ea077ba8692bcfe1608fc/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian 483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione 683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/37e3803c7a23385bab5ea077ba8692bcfe1608fc/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Julian Descottes a46329cb93 Bug 1272774 - allow listTabs to return favicon data from PlacesUtils;r=ochameau
MozReview-Commit-ID: 8bkn3mG6YkL
2018-01-04 17:25:45 +01:00
Julian Descottes 5b07830664 Backed out changeset 00b1cae7d55f (bug 1425393) for failing devtools/client/aboutdebugging/test/browser_service_workers.js r=backout
MozReview-Commit-ID: ELnV9jwTwtV
2018-01-11 10:43:40 +01:00
Julian Descottes 4ca0e568b7 Bug 1425393 - open sw tabs in background in about:debugging tests;r=ochameau
MozReview-Commit-ID: 8UyrTDtHa7b
2017-12-12 15:49:36 -06:00
Julian Descottes 627cbf096f Bug 1425897 - Fix race condition in about:debugging test helper;r=baku
MozReview-Commit-ID: ELvxWzld9Um
2017-12-20 19:40:49 +01:00
Cosmin Sabou 5a4f6452e3 Merge mozilla-inbound to mozilla-central. r=merge a=merge 2017-12-13 12:14:29 +02:00
Ben Kelly 66f4be5f20 Bug 1293277 P9 Disable browser_service_workers_push_service.js on non-e10s due to races. r=jryans 2017-12-12 15:44:48 -05:00
Julian Descottes 85cbd25137 Bug 1423687 - show warning in about:debugging when loading a temporary legacy extension;r=aswan,pbro
MozReview-Commit-ID: I9U5zzwZCSj
2017-12-08 14:44:46 +01:00
Julian Descottes 5bd5b3601c Bug 1386613 - stop using waitForMutations in aboutdebugging tests (remaining tests);r=ochameau
MozReview-Commit-ID: HDNzIFwp4Ur
2017-12-05 22:44:18 +01:00
Julian Descottes 6024c760fb Bug 1386613 - stop using waitForMutations in aboutdebugging tests (addons);r=ochameau
MozReview-Commit-ID: Ii32r9Dhjje
2017-12-05 22:17:15 +01:00
Julian Descottes e84c5847e4 Bug 1386613 - stop using waitForMutations in aboutdebugging tests (serviceworkers);r=ochameau
MozReview-Commit-ID: 3JMEZUx8rTt
2017-12-05 17:40:34 +01:00
Julian Descottes 079ca3b7a2 Bug 1413051 - fix aboutdebugging addon tip icon in RTL;r=ochameau
MozReview-Commit-ID: 3aMuHiBHhVG
2017-12-04 14:07:50 +01:00
Julian Descottes 19fef9ac4c Bug 1411565 - about:debugging connect to remote runtime using url parameters;r=ochameau
This changeset adds basic remote connection functionality to about:debugging.
About:debugging can target a remote firefox instance if the host and port
parameters are passed as URL search params.

The feature is not explicitly exposed at the moment and there is no UI to
connect an instance, and no UI feedback when connected to a remote instance.

When connected, about:debugging should correctly list tabs, workers and addons
for the target instance of Firefox. Debugging features work for all supported
targets.

Known limitations:
- preferences are read from the local Firefox instance (multiprocess, addon
  debugging etc...). At the moment the remote instance must be manually
  correctly configured

MozReview-Commit-ID: DOekSCb96XC
2017-10-23 10:15:40 +02:00
Julian Descottes 21b6d9f77b Bug 1416711 - Add registerAllActors API;r=ochameau
Most of the codebase that needs to create a debugger server
can use a server with all actors registered.

Define an additional method registerAllActors to do that.

By previous implementations, all the call sites that were
using browser: true were indirectly using tab & root: true
as well. So all the call sites using browser: true have been
migrated to registerAllActors and the specific behavior of
the browser: true case has been removed. Passing browser:true
to registerActors now only registers browser specific actors.

MozReview-Commit-ID: F3sx71eGrdG
2017-11-13 21:22:15 +01:00
Julian Descottes 6e8668e849 Bug 1416711 - Stop guarding consumer calls to DebuggerServer.init();r=ochameau
DebuggerServer.init() already bails out if it was previously initialized
so we could avoid guarding the calls to init() with it everywhere.

Registering an actor module several times is also a noop as the Server
keeps a map of all the already registered modules and will bail out if
the module is already known.

MozReview-Commit-ID: 4ONLlx9253i
2017-11-13 21:04:43 +01:00
Andrew Swan 27440712bb Bug 1353861 Handle .zip files as temporary addons r=jdescottes
MozReview-Commit-ID: A9MQtnT16LV
2017-11-15 22:03:34 -08:00
Michael Ratcliffe 153ca3dd90 Bug 1417444 - about:debugging to use prop-types and react-dom-factories r=jdescottes
MozReview-Commit-ID: EQ5MSMrvdWW
2017-11-15 14:48:37 +00:00
Michael Ratcliffe b38a205ab4 Bug 1411920 - about:debugging to ES6 classes r=jdescottes
MozReview-Commit-ID: Js4NQoGfgtI
2017-10-26 13:20:22 +01:00
Maxime Vaillancourt ad9ea28c31 Bug 1411199 - CamelCase all aboutdebugging component files. r=jdescottes 2017-10-24 22:59:21 -04:00
Joel Maher 5953e2d68d Bug 1387827 - Disable 2 devtools tests on coverage builds for frequent timeouts. r=gbrown, a=test-only 2017-10-16 11:42:23 -04:00
Julian Descottes c9de765291 Bug 1361080 - display devtools onboarding screen if devtools.enabled if false;r=ochameau
MozReview-Commit-ID: 6TtOAGc9Zzl
2017-08-28 15:12:03 +02:00
Nicolas Chevobbe fee723d060 Bug 1403895 - Remove devtools/shared/client/main.js; r=ochameau.
Remove the main file that we don't need anymore and modify all
the imports to target the specific file they now need.

MozReview-Commit-ID: 2uWjTnAMAU0
2017-09-29 15:24:14 +02:00