The TestMetadata and TestResolver classes aren't technically part of the build
system. The only connection is that they consume some build system output.
The next patch in this series is going to be merging in a bunch of other test
resolving logic from other parts of the tree. Moving this out first allows us
to keep that extra logic out of mozbuild.
MozReview-Commit-ID: 1eq4SjFVCyW
The default debug console line limit is far too short, especially when
debugging a debug build or a build with some logging turned on. I've never
had any issues with turning off the limit, so hopefully this is fine for
everyone else too.
MozReview-Commit-ID: Krlo7XPEjE0
By default the build console is limited to 500 lines. This can be far too
short, especially when building using `mach build --verbose`. I've run with
this value set to 1,000,000 before without issue, so 10,000 should be fine.
MozReview-Commit-ID: GxBUjW7nOYJ
Previously, client.mk made the decision of whether to perform a PGO
build. This required passing around MOZ_PGO and invoking a separate
make target if this variable was set.
In this commit, we move this logic to Makefile.in. We employ a special
mechanism in rules.mk to override the default make target so
`make` evaluates "profiledbuild" if MOZ_PGO is set. This also
required using an explicit target for $(MAKE) invocations inside
the "profiledbuild" rule to avoid infinite recursion.
MozReview-Commit-ID: 8sHiVspMisM
The webdriver crate's dependencies are accounted for through geckodriver's
Cargo.lock file, because the webdriver dependency is given by path.
This commit reverts 540273e5cf22 made in bug 1412037.
MozReview-Commit-ID: F0q9bDN3pqd
When repackaging, we want to take all localization resources from the source package,
and add all localization resources from the repackage target locale.
This patch makes packager.l10n scan for `localization` directories in l10n_finder and
add them.
MozReview-Commit-ID: CRLP3bOAyDx
I /think/ the only scenario where we wouldn't be able to evaluate
a config environment after configure was the case where
MOZ_BUILD_PROJECTS was in play. Since we removed support for that
feature, let's drop support for treating the config environment
as optional.
MozReview-Commit-ID: 4sz9dOwaA3y
While we're here, also move the low-level code to invoke configure
to a proper Python module.
We needed to muck around with the log manager because the underlying
logger for output changed from "mach" (which is registered by default)
to something under the "mozbuild" hierarchy.
MozReview-Commit-ID: 4rlCxOwcVu1
The goal is to move this lower-level code somewhere where it can be
reused.
The only meaningful code change as part of the move was handling
of the mach context. Before, we could access self._mach_context.
After, we need to pass it as an argument. This also uncovered a bug
where "telemetry_handler" could be None but we called it
unconditionally. We now guard this call with an "if."
MozReview-Commit-ID: FWw4l6H1ayS
In general, we shouldn't have so much business logic in mach_commands.py
files.
I'd like to move more of the low-level "perform a build" logic out of
mach_commands.py to facilitate some future work. That code makes use of
this output processing code. So as the first step in moving the build
code, we move its dependencies.
As part of this, I also cleaned up some random unused imports around
lines that were touched.
No meaningful code changes were performed as part of the code move.
MozReview-Commit-ID: 96mGWUJ7oLb
This commit adds two new xpcshell tests, both of them testing whether the
security state in TransportSecurityInfo includes the new
STATE_CERT_DISTRUST_IMMINENT flag under the correct circumstances.
The first test, test_symantec_apple_google.js, tests the four combinations of
certs that chain to an affected Symantec root: with/without a whitelisted
intermediate, and before/after the notBefore cutoff date.
The second test, test_symantec_apple_google_unaffected.js, tests an unrelated
ca->intermediate->ee chain that does not chain to an affected root, and ensures
the flag is not set.
This patch adds SymantecSanctionsServer to the mozbuild and xpcshell test
infrastructure files to ensure it runs properly on TaskCluster, too.
MozReview-Commit-ID: GtUXH2VFFh
The new file contains changes that optimize for final file size:
* The components are stored as an integer index/key into a map
instead of strings.
* Paths are stored in hierarchical dicts.
* No indentation is used.
These changes significantly redude redundancy in string data. For every
file in the repo, the raw JSON size is decreased from 27,074,607 to
7,643,529 bytes.
MozReview-Commit-ID: 58FWSct8W39
We want all files in the repo to be annotated with a Bugzilla
component. This change will cause the CI task to fail if files are
missing annotations.
MozReview-Commit-ID: Kn6dheQqEsk
Previously, the CI task invoked 2 mach commands and performed manual
gzip compressed. This was sub-optimal for a few reasons:
* Redundant moz.build evaluation made execution slower
* Potential for shell expansion to interfere with wildcards
* Made it harder to change exit code
By moving all logic into a mach command, we eliminate all the issues
around using shell.
Behavior of the new command and the CI task should be backwards
compatible.
MozReview-Commit-ID: HUFvLteKLOO
LineIO currently attempts to convert bytes to unicode using the
system preferred encoding. This can obviously fail for some byte
sequences.
In many cases, the conversion is happening for purposes of logging.
In these cases, Unicode validation shouldn't be that important to
us.
So, this commit teaches LineIO to accept an argument defining its
Unicode error mode. We also teach relevant users of LineIO doing
logging to switch the default mode from "strict" to "replace" so
invalid Unicode byte sequences can be logged with the Unicode
replacement character.
During review, glandium pointed out that it may make better sense
to defer Unicode decoding to the logging layer instead of in LineIO.
I agree with this idea. But it can be implemented in another bug:
for now we should unbust the build system.
MozReview-Commit-ID: 7miuSDY8Xzv
DONTBUILD because this only gets run as part of a manual `mach vendor rust`
invocation and won't run in a regular CI run.
MozReview-Commit-ID: FMym1BsEAFe
This is required for "./mach vendor rust" to pick up on
testing/webdriver's dependency tree. This change should have been
made when the webdriver crate was vendored in the tree in the first place.
MozReview-Commit-ID: 5sqRojm0bGD
This was mainly used to support Universal MacOS builds, which were
removed several months ago.
In theory, someone could be using this feature to build multiple
applications with one build system invocation. But given that client.mk
is no longer the preferred interface to the build system and multiple
applications can be built by running `mach build` with different
mozconfigs, I don't think support for this feature is worth keeping.
This commit removes support for MOZ_BUILD_PROJECTS and related
functionality from client.mk. Support for recognizing
MOZ_CURRENT_PROJECT in configure and mozconfig evaluation has also
been removed. This includes support for the ac_add_app_options
mozconfig function.
Good riddance.
MozReview-Commit-ID: 7xI2jYxDFFr
IPDL generation consists of a single ipdl.py invocation on all the
*.ipdl and *.ipdlh files in the tree. Unfortunately the headers that are
generated are placed into directories corresponding to the namespaces
declared within the IDPL, and can't be determined solely based on the
input filename. As such, we have to do a quick parsing of the AST in
order to grab the namespaces and calculate the filenames for the .h
files.
The downside of this approach is that all *.ipdl/*.ipdlh files are
considered inputs for the tup backend, so editing one will perform
moz.build generation before running ipdl.py. This could be fixed by
either standardizing the generated header layout, or fixing tup to
somehow allow unspecified outputs.
MozReview-Commit-ID: DzF2ryLEsrg
IPDL generation consists of a single ipdl.py invocation on all the
*.ipdl and *.ipdlh files in the tree. Unfortunately the headers that are
generated are placed into directories corresponding to the namespaces
declared within the IDPL, and can't be determined solely based on the
input filename. As such, we have to do a quick parsing of the AST in
order to grab the namespaces and calculate the filenames for the .h
files.
The downside of this approach is that all *.ipdl/*.ipdlh files are
considered inputs for the tup backend, so editing one will perform
moz.build generation before running ipdl.py. This could be fixed by
either standardizing the generated header layout, or fixing tup to
somehow allow unspecified outputs.
MozReview-Commit-ID: DzF2ryLEsrg