Commit Graph
2724 Commits
Author SHA1 Message Date
Emilio Cobos Álvarez 1c20c25eda Bug 232598 - Return null for unset attributes in XUL. r=smaug,devtools-reviewers,omc-reviewers,zombie,nchevobbe,settings-reviewers,application-update-reviewers,credential-management-reviewers,mossop,aminomancer,bytesized,issammani,sessionstore-reviewers,dao
I just got bit by this in bug 1873833, let's just fix it. There isn't
all that much stuff depending on it anymore.

Differential Revision: https://phabricator.services.mozilla.com/D204496
2024-03-18 09:15:07 +00:00
artem manushenkov 0f7d9b6173 Bug 1763961 [devtools] Make unchecking "Pick an element from the page" in "Available Toolbox Buttons" disable hotkey for opening element picker/inspector r=jdescottes,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D203948
2024-03-13 12:47:28 +00:00
Alexandre Poirot 486f2de3dd Bug 1883947 - [devtools] Expand netmonitor test coverage in the Browser Toolbox. r=devtools-reviewers,nchevobbe
Cover opening the details panel and verify that one header is displayed.

Differential Revision: https://phabricator.services.mozilla.com/D203956
2024-03-11 14:21:06 +00:00
Dave Townsend 2af4d349f3 Bug 1864896: Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
Differential Revision: https://phabricator.services.mozilla.com/D202959
2024-03-05 14:21:15 +00:00
Alexandre Poirot 28d867992f Bug 1881141 - [devtools] Factorize code around target and thread configuration management. r=devtools-reviewers,nchevobbe
This should help connect preferences to server's target configurations.
Once we get rid of thread's actor attach sequence, we may be able to also fold the getThreadOptions's preferences into this new system.

Differential Revision: https://phabricator.services.mozilla.com/D202277
2024-02-21 22:04:17 +00:00
Alexandre Poirot 53c578d1cf Bug 1865439 - [devtools] Re-introduce a preference to allow disabling the debugger overlay displayed on paused. r=devtools-reviewers,nchevobbe
`devtools.debugger.features.overlay` boolean preference will control this paused overlay.
(same name as an old preference which used to do that)

Differential Revision: https://phabricator.services.mozilla.com/D201697
2024-02-21 22:04:17 +00:00
echrs 07d1104355 Bug 1878635 - Remove Deprecated.sys.mjs r=Standard8,devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D201737
2024-02-20 20:33:24 +00:00
Alexandre Poirot c9c5297677 Bug 1853899 - [devtools] Introduce a new Menu Button dedicated to source maps. r=devtools-reviewers,nchevobbe
It allows
* toggling Source Map support entirely
* open the source map URL (when a bundle file is currently selected)
* open the mapped source (original or bundle)
* toggle the "open original source by default" setting
* show source map status (source map error, is it original or bundle file, is this a regular source?)

Differential Revision: https://phabricator.services.mozilla.com/D187577
2024-02-20 11:14:33 +00:00
Tooru Fujisawa 0791e8d3c4 Bug 1875639 - Part 1: Use global option instead of loadInDevToolsLoader option. r=ochameau,devtools-reviewers
global option supercedes loadInDevToolsLoader, with omitting the
implicit contextual loader behavior.
In order to make the API less error-prone, use global option, with requireing
global option in DevTools global, to choose from shared global or explicit
contextual loader.

Differential Revision: https://phabricator.services.mozilla.com/D199466
2024-02-20 04:49:57 +00:00
Gijs Kruitbosch b33d5685da Bug 1780071 - Manual fixes/disabling of no-comparison-or-assignment-inside-ok for exceptional cases, r=Standard8,devtools-reviewers,anti-tracking-reviewers,places-reviewers,dom-storage-reviewers,pbz,asuth,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D198979
2024-02-19 23:30:40 +00:00
Narcis Beleuzu e2b42b8b1d Backed out changeset 749f10073ff4 (bug 1853899) for dt failure on browser_dbg-sourcemaps-bogus.js CLOSED TREE 2024-02-09 03:56:22 +02:00
Alexandre Poirot 658bd889e8 Bug 1853899 - [devtools] Introduce a new Menu Button dedicated to source maps. r=devtools-reviewers,nchevobbe
It allows
* toggling Source Map support entirely
* open the source map URL (when a bundle file is currently selected)
* open the mapped source (original or bundle)
* toggle the "open original source by default" setting
* show source map status (source map error, is it original or bundle file, is this a regular source?)

Differential Revision: https://phabricator.services.mozilla.com/D187577
2024-02-08 16:43:59 +00:00
Nicolas Chevobbe b02a0c76f9 Bug 1878490 - [devtools] Expose devtools.inspector.rule-view.focusNextOnEnter in settings panel. r=devtools-reviewers,fluent-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D200611
2024-02-06 06:07:08 +00:00
Tooru Fujisawa a9a43831ea Bug 1878457 - Part 2: ESMify consumers of performance-new modules. r=julienw,profiler-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200559
2024-02-05 23:23:32 +00:00
Alexandre Poirot e2b21e2461 Bug 1848159 - [devtools] Synchronize tracer state between console and debugger. r=devtools-reviewers,nchevobbe
Ensure updating the tracing state from the TracerCommand,
so that its internal state is correct whenever we start tracing
via the console or debugger.

Differential Revision: https://phabricator.services.mozilla.com/D196961
2024-01-30 20:18:50 +00:00
Gijs Kruitbosch 3288f177a4 Bug 1780071 - autofix devtools/ violations of no-comparison-or-assignment-inside-ok r=profiler-reviewers,devtools-reviewers,julienw,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D198975
2024-01-26 13:12:07 +00:00
Joel Maher 3662d84cd4 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-25 00:27:05 +00:00
Stanca Serban 71d0d5cf96 Backed out changeset 54462970f797 (bug 1873732) for causing web platform tests failures. 2024-01-24 21:08:19 +02:00
Joel Maher 04ec786571 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-24 16:35:54 +00:00
Alexandre Poirot e1abf62065 Bug 1834725 - [devtools] Log source map errors to the console directly from SourceMapLoader. r=devtools-reviewers,nchevobbe
The main goal here is to re-throw the exception so that the debugger can start displaying source map errors.

Note that the previous changeset tweaked the StyleEditor code to handle exceptions.
The Debugger will be handled in the next changeset.

Differential Revision: https://phabricator.services.mozilla.com/D187576
2024-01-15 12:57:19 +00:00
Natalia Csoregi 63d346b505 Backed out 4 changesets (bug 1834725) for causing failures on browser_styleeditor_loading_with_containers.js. CLOSED TREE
Backed out changeset 0965e956200a (bug 1834725)
Backed out changeset 4a8151163607 (bug 1834725)
Backed out changeset a56f42223377 (bug 1834725)
Backed out changeset a920356b63eb (bug 1834725)
2024-01-11 19:57:47 +02:00
Alexandre Poirot 31e7b41420 Bug 1834725 - [devtools] Log source map errors to the console directly from SourceMapLoader. r=devtools-reviewers,nchevobbe
The main goal here is to re-throw the exception so that the debugger can start displaying source map errors.

Note that the previous changeset tweaked the StyleEditor code to handle exceptions.
The Debugger will be handled in the next changeset.

Differential Revision: https://phabricator.services.mozilla.com/D187576
2024-01-11 15:27:25 +00:00
Alexandre Poirot b90fb2709b Bug 1767760 - [devtools] Avoid intermittend on browser_target_parents.js. r=jdescottes,devtools-reviewers
Some workers running in the parent process might be initializating or destroying
and their target front won't be fully populated.
This test is brittle as it interact with any firefox parent process worker.
As we don't control them from the test they may be in arbitrary state.

Differential Revision: https://phabricator.services.mozilla.com/D197092
2024-01-03 17:39:13 +00:00
Alexandre Poirot 641c35b909 Bug 1835614 - [devtools] Use a custom resource for traces. r=devtools-reviewers,nchevobbe
This help reduce the RDP overhead by only transferring what is strictly necessary.
The console message resources bundles various useless attributes.

This also help use a custom rendering in the frontend so that traces can
be displayed distinctly and differently from the console API calls.

Differential Revision: https://phabricator.services.mozilla.com/D196020
2023-12-19 18:01:52 +00:00
Narcis Beleuzu 54a3764889 Backed out 2 changesets (bug 1835614) for xpcshell failure on test_tracer.js . CLOSED TREE
Backed out changeset 4501d1fb176a (bug 1835614)
Backed out changeset 60b933696a41 (bug 1835614)
2023-12-19 12:54:32 +02:00
Alexandre Poirot 193fc9986e Bug 1835614 - [devtools] Use a custom resource for traces. r=devtools-reviewers,nchevobbe
This help reduce the RDP overhead by only transferring what is strictly necessary.
The console message resources bundles various useless attributes.

This also help use a custom rendering in the frontend so that traces can
be displayed distinctly and differently from the console API calls.

Differential Revision: https://phabricator.services.mozilla.com/D196020
2023-12-19 09:20:33 +00:00
Alexandre Poirot 011905c3b8 Bug 1868571 - [devtools] Run two blank runs before starting memory tracking test. r=devtools-reviewers,nchevobbe
For some reason, the debugger has a different behavior the second time it opens
compared to its very first opening. So that distinct React elements are instantiated
and are then reported as leaks...

Differential Revision: https://phabricator.services.mozilla.com/D196191
2023-12-13 16:10:50 +00:00
Nazım Can Altınova 300057fced Bug 1867599 - Add profiler logging method to JS tracer r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D190576
2023-12-04 13:57:23 +00:00
Alexandre Poirot 3396c9add0 Bug 1867603 - [devtools] Introduce a tracer command to toggle tracing without the debugger. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D195125
2023-12-02 08:53:38 +00:00
Joel Maher cac31d18e3 Bug 1859873 - batch 13 xpcshell.ini -> .toml. r=aryx,devtools-reviewers,profiler-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D194161
2023-11-21 12:32:50 +00:00
Nicolas Chevobbe 948380c4d8 Bug 1863398 - [devtools] Cleanup Toolbox store DOM mutation breakpoints on target destroy. r=devtools-reviewers,ochameau.
DOM mutation breakpoints are set on specific node fronts,
and we would keep retrieving node fronts from now discarded
targets after the page navigated.

Differential Revision: https://phabricator.services.mozilla.com/D193087
2023-11-14 15:58:07 +00:00
Anna Yeddi 1ff2d7d161 Bug 1863584 - Remove skip-if for a11y_checks that previously crashed with @ mozilla::detail::InvalidArrayIndex r=Gijs,Standard8
We had to skip-if those tests that were crashing during a11y_checks and since the bug 1849230 is resolved now these test can be re-enabled (whenever possible). Two tests have also been failing intermittently, thus they are remaining skipped, but the comment is updated to remove the mention of the crash.

Differential Revision: https://phabricator.services.mozilla.com/D193230
2023-11-11 10:47:21 +00:00
Sergey Galich 3f47b8e5e9 Bug 1862410 - Removing unused LoginReputation service and updating link to Chromium's safe browsing protobuf r=dimi,webdriver-reviewers,perftest-reviewers,devtools-reviewers,geckoview-reviewers,jonalmeida,owlish
Differential Revision: https://phabricator.services.mozilla.com/D192464
2023-11-06 19:13:09 +00:00
Anna Yeddi fcae49bef3 Bug 1858041 - Pt.4. Temporarily skip some Tier 2 a11y_checks for unexpecredly failing/passing or crashing on Autoland. r=devtools-reviewers,credential-management-reviewers,issammani
There are some a11y_checks that are intermittently failing on Autoland and pass on Try and vice versa. Also, a couple of tests are crashing while performing a11y_checks, thus they are to be skipped while we continue the investigation into each of them.

Related bugs:
- Fail-if tests: meta bug 1848402
- Explore capturing click events for a11y_checks: bug 1692110

Differential Revision: https://phabricator.services.mozilla.com/D192086
2023-10-31 17:20:39 +00:00
Magnus Melin d85a9133fd Bug 1861492 - don't try to set devtools menus etc. for non-Firefox apps. r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D192000
2023-10-30 16:48:02 +00:00
Tom Marble a2de3b16d5 Bug 1859905 - convert .ini manifests to .toml: batch 19 browser_*.ini r=jmaher,webdriver-reviewers,necko-reviewers,extension-reviewers,devtools-reviewers,anti-tracking-reviewers,valentin,robwu,pbz
Differential Revision: https://phabricator.services.mozilla.com/D191771
2023-10-25 21:47:25 +00:00
Natalia Csoregi 2f242d6035 Backed out changeset 1ca403a2c00e (bug 1859905) for causing failures on test_mochitest_integration.py CLOSED TREE 2023-10-25 22:26:24 +03:00
Tom Marble 622224fb99 Bug 1859905 - convert .ini manifests to .toml: batch 19 browser_*.ini r=jmaher,webdriver-reviewers,necko-reviewers,extension-reviewers,devtools-reviewers,anti-tracking-reviewers,valentin,robwu,pbz
Differential Revision: https://phabricator.services.mozilla.com/D191771
2023-10-25 17:12:24 +00:00
Mark Banner cc2be2ea34 Bug 1858673 - Remove now unnecessary disabling of ESLint no-unsanitized/* rules from test files. r=freddyb,media-playback-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,places-reviewers,aosmond,sgalich,dao,padenot
Differential Revision: https://phabricator.services.mozilla.com/D190985
2023-10-24 08:48:41 +00:00
Dave Townsend f2f7777e96 Bug 1857999: Move XML stylesheet processing instructions to link elements. r=Gijs,webdriver-reviewers,settings-reviewers,application-update-reviewers,devtools-reviewers,places-reviewers,Standard8,whimboo,bytesized,ochameau
The result of running the automated script available at https://github.com/Mossop/depi

Differential Revision: https://phabricator.services.mozilla.com/D190681
2023-10-18 07:04:41 +00:00
Dave Townsend 2017f6222f Bug 1857999: Add html namespace declarations for files that are missing it. r=Gijs,webdriver-reviewers,devtools-reviewers
The automated scripts requires an already present namespace prefix for the
xhtml namespace so just manually add those for documents that don't already have
one.

Differential Revision: https://phabricator.services.mozilla.com/D190680
2023-10-18 07:04:41 +00:00
Dave Townsend 22522ed709 Bug 1857999: Devtools should always inject additional stylesheets as link elements. r=ochameau,devtools-reviewers
Improves the logic to always insert stylesheets as link elements regardless of
whether it is into a html document or not. In order for the ordering to be
correct the insertion must occur after existing link elements in the document
have been parsed so the `theme-switching.js` script must always be loaded after
link elements. The storage client appears to be the only existing document where
that wasn't already the case.

Differential Revision: https://phabricator.services.mozilla.com/D190797
2023-10-18 07:04:41 +00:00
Sandor Molnar 099f0fd4c3 Backed out 4 changesets (bug 1857999) for causing dt failures on browser_theme_switching.js & Mn failures at test_element_state_chrome.py CLOSED TREE
Backed out changeset 75f5e6e3d917 (bug 1857999)
Backed out changeset 0d0c1d1e80e7 (bug 1857999)
Backed out changeset b8a03d31ecea (bug 1857999)
Backed out changeset dd5a10f9cfff (bug 1857999)
2023-10-16 14:12:22 +03:00
Dave Townsend 92c3ea0f78 Bug 1857999: Move XML stylesheet processing instructions to link elements. r=Gijs,webdriver-reviewers,settings-reviewers,application-update-reviewers,devtools-reviewers,places-reviewers,Standard8,whimboo,bytesized,ochameau
The result of running the automated script available at https://github.com/Mossop/depi

Differential Revision: https://phabricator.services.mozilla.com/D190681
2023-10-16 09:43:26 +00:00
Dave Townsend 473e1ffcaa Bug 1857999: Add html namespace declarations for files that are missing it. r=Gijs,webdriver-reviewers,devtools-reviewers
The automated scripts requires an already present namespace prefix for the
xhtml namespace so just manually add those for documents that don't already have
one.

Differential Revision: https://phabricator.services.mozilla.com/D190680
2023-10-16 09:43:25 +00:00
Dave Townsend a8dfbf56a3 Bug 1857999: Devtools should always inject additional stylesheets as link elements. r=ochameau,devtools-reviewers
Improves the logic to always insert stylesheets as link elements regardless of
whether it is into a html document or not. In order for the ordering to be
correct the insertion must occur after existing link elements in the document
have been parsed so the `theme-switching.js` script must always be loaded after
link elements. The storage client appears to be the only existing document where
that wasn't already the case.

Differential Revision: https://phabricator.services.mozilla.com/D190797
2023-10-16 09:43:25 +00:00
Anna Yeddi fa882e1cf5 Bug 1849021 - Temporarily disable some Tier 2 a11y_checks for DevTools that cause crashes. r=devtools-reviewers,profiler-reviewers,nchevobbe,julienw
There are two main types of crashes that are tracked separately:
1. `application crashed [@ mozilla::detail::InvalidArrayIndex_CRASH]` that is tracked in bug 1849230
2. `application crashed [@ operator==<mozilla::a11y::LocalAccessible, mozilla::a11y::LocalAccessible>]` that is tracked in bug 1849179

Skipping the tests that have crashed on Try more than once during the bug 1849021 work until the intermittent issues are resolved.

Depends on D186405

Differential Revision: https://phabricator.services.mozilla.com/D190139
2023-10-09 18:20:23 +00:00
Anna Yeddi e1ba7c0b2e Bug 1849021 - Temporarily fail-if some Tier 2 a11y_checks for DevTools while the larger a11y improvement work is in progress. r=Jamie,devtools-reviewers,nchevobbe,profiler-reviewers,julienw
Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests were temporarily fail-if'ed in the directory's browser.ini file. After the ongoing accessibility improvements work is completed, we'll need to re-run a11y-checks, investigate new failures, and for confirmed bugs individual defects should be filed.

When the individual test failures are resolved and the individual bugs are closed, remove the fail-if condition for a11y_checks from the appropriate files/sections to ensure better test coverage and to avoid regressions in a11y of these components.

Depends on D189007

Differential Revision: https://phabricator.services.mozilla.com/D186405
2023-10-09 18:20:23 +00:00
Nicolas Chevobbe 8b9660a7aa Bug 1843358 - [devtools] Dismiss events tooltip on Escape. r=devtools-reviewers,bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D190155
2023-10-09 09:40:11 +00:00
Cristian Tuns 896197e59e Backed out 30 changesets (bug 1854447, bug 1855491, bug 1854646, bug 1854520, bug 1854528, bug 1854506, bug 1854502, bug 1854443, bug 1854538, bug 1854525, bug 1854660, bug 1854514, bug 1854460, bug 1854625, bug 1854228, bug 1854517, bug 1854533, bug 1692110, bug 1854636, bug 1849021, bug 1854512, bug 1854522, bug 1854509, bug 1854452, bug 1854536, bug 1854531) for causing multiple tier 2 failures on a11y-checks. CLOSED TREE
Backed out changeset 5714b7239b70 (bug 1849021)
Backed out changeset 91e5d7de3484 (bug 1849021)
Backed out changeset cc3142b909f6 (bug 1854660)
Backed out changeset 76d2a8ae9c19 (bug 1854646)
Backed out changeset 36460a147684 (bug 1854636)
Backed out changeset c7529a962a8c (bug 1854625)
Backed out changeset 791f9b03ea96 (bug 1854538)
Backed out changeset bd3f3cb434a5 (bug 1854536)
Backed out changeset 16f4f5bdcaa7 (bug 1855491)
Backed out changeset 6258bab20196 (bug 1854533)
Backed out changeset 29dca16eee2e (bug 1854531)
Backed out changeset 3a69d2c3f562 (bug 1854528)
Backed out changeset 0c63a9ea8b34 (bug 1854525)
Backed out changeset 5795bb6187a5 (bug 1854522)
Backed out changeset 7d4a123a432f (bug 1854520)
Backed out changeset ec95287bd702 (bug 1854517)
Backed out changeset 9914c1481f0d (bug 1854514)
Backed out changeset 25d85e656905 (bug 1854512)
Backed out changeset 828657f2ab73 (bug 1854509)
Backed out changeset 9d8b2e14c375 (bug 1854506)
Backed out changeset 1b3ee1e46e12 (bug 1854502)
Backed out changeset 37c2ec0851dc (bug 1854460)
Backed out changeset c2a60a8fc2d3 (bug 1854452)
Backed out changeset 744a163f2bd1 (bug 1854447)
Backed out changeset 1a9629dae7d5 (bug 1854443)
Backed out changeset c3d5c1ba2a84 (bug 1854228)
Backed out changeset dcd05518b004 (bug 1692110)
Backed out changeset 1c65a4cb618c (bug 1692110)
Backed out changeset 603b891147bd (bug 1692110)
Backed out changeset 53e2fac79d84 (bug 1692110)
2023-10-07 14:43:05 -04:00