Commit Graph
154 Commits
Author SHA1 Message Date
Hubert Boma Manilla 11e553435e Bug 1882060 - [devtools] Add gutter events for click and context menu r=devtools-reviewers,nchevobbe
With this patch
- The line gutter context menu will get displayed on right click of the gutter
- Clicking line gutter should set breakpoints

Note not covered in this patch:-
- Context menu feaures might not work
- Line breakpoints are not showing yet ( this is coming in a future patch)

Differential Revision: https://phabricator.services.mozilla.com/D203210
2024-03-18 09:51:29 +00:00
Hubert Boma Manilla 3d21a16949 Bug 1882333 - [devtools] Update the editor toggle button size when the editior dimensions change r=devtools-reviewers,nchevobbe
This patch updates the size of the button (above the editor gutter) which toogles the sidebar for codemirror 6.
Note this was broken with the current codemirror as wel so fixed both.

Also adding the ability to attach an updateListener to the editor we can listen for editor changes.

Differential Revision: https://phabricator.services.mozilla.com/D202398
2024-03-18 09:51:27 +00:00
Dave Townsend 2af4d349f3 Bug 1864896: Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
Differential Revision: https://phabricator.services.mozilla.com/D202959
2024-03-05 14:21:15 +00:00
Nicolas Chevobbe dfac8eca38 Bug 1881677 - [devtools] Fix CodeMirror 6 wrapping. r=bomsy,devtools-reviewers.
Differential Revision: https://phabricator.services.mozilla.com/D202546
2024-02-23 15:44:02 +00:00
Nicolas Chevobbe 83718d377b Bug 1881247 - [devtools] Use esm for CodeMirror 6 bundle. r=devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D202310
2024-02-23 12:33:51 +00:00
Sandor Molnar 2e811b0318 Backed out changeset cc4383344170 (bug 1881247) for causing lint failures at devtools/client/shared/sourceeditor/editor.js CLOSED TREE 2024-02-23 09:16:42 +02:00
Nicolas Chevobbe 1b845db481 Bug 1881247 - [devtools] Use esm for CodeMirror 6 bundle. r=devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D202310
2024-02-23 06:54:54 +00:00
Hubert Boma Manilla a913d4e702 Bug 1878647 - [devtools] Fix debugger editor line wrapping for codemirror 6 r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D201808
2024-02-22 16:56:26 +00:00
Hubert Boma Manilla 22dcb385ee Bug 1878647 - [devtools] Show text in the debugger with codemirror 6 r=devtools-reviewers,nchevobbe
This patch enables showing basic source text content on source selection.

Differential Revision: https://phabricator.services.mozilla.com/D201809
2024-02-22 16:56:26 +00:00
Nicolas Chevobbe a37ae20735 Bug 1877989 - [devtools] Add CodeMirror 6 in tree. r=devtools-reviewers,bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D200305
2024-02-08 14:39:41 +00:00
Mark Banner c4f2b2d3ac Bug 1878553 - Define *.config.(m)js files as node based for ESLint. r=mossop,devtools-reviewers,omc-reviewers,nchevobbe,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D200582
2024-02-07 08:55:29 +00:00
Cristian Tuns 8829a8d6c5 Backed out 11 changesets (bug 1878554, bug 1878553, bug 1878556) for causing node failures in aboutwelcome CLOSED TREE
Backed out changeset 425f70fa7e5a (bug 1878556)
Backed out changeset 2ab3a28f5c04 (bug 1878556)
Backed out changeset fb2e02682c8c (bug 1878556)
Backed out changeset 2fc5e630568e (bug 1878554)
Backed out changeset 78839d5841b4 (bug 1878554)
Backed out changeset e0ab31d2de1b (bug 1878554)
Backed out changeset 4eb59e4ebafa (bug 1878554)
Backed out changeset ab1e077d3f84 (bug 1878554)
Backed out changeset ef999f293e3e (bug 1878553)
Backed out changeset cf49920cb1ad (bug 1878553)
Backed out changeset 95f0fce63726 (bug 1878553)
2024-02-07 01:26:39 -05:00
Mark Banner 7fdf48bc1f Bug 1878553 - Define *.config.(m)js files as node based for ESLint. r=mossop,devtools-reviewers,omc-reviewers,nchevobbe,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D200582
2024-02-06 22:32:51 +00:00
Nicolas Chevobbe 22f57f2472 Bug 1877428 - [devtools] Use proper private fields in Editor. r=bomsy,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D199973
2024-01-31 05:57:19 +00:00
Nicolas Chevobbe 8ed318df6c Bug 1877428 - [devtools] Turn Editor into a proper ES6 class. r=bomsy,devtools-reviewers.
Differential Revision: https://phabricator.services.mozilla.com/D199972
2024-01-31 05:57:18 +00:00
Emilio Cobos Álvarez aac1ce993c Bug 1866063 - Prevent flickering of the source editor by hiding it till loaded. r=devtools-reviewers,nchevobbe
Much like we we do here:

  https://searchfox.org/mozilla-central/rev/d7f837add602d270f2b2958b3ab5206dc85965c0/devtools/client/framework/toolbox.js#2605

This is not an ideal fix but it fixes the immediate flicker.

The real fix would be addressing
https://github.com/w3c/csswg-drafts/issues/9624

Depends on D194395

Differential Revision: https://phabricator.services.mozilla.com/D194396
2023-11-23 11:05:53 +00:00
Emilio Cobos Álvarez a239157a27 Bug 1866063 - Always use an HTML iframe for codemirror. r=devtools-reviewers,nchevobbe
Using a XUL iframe introduces some flickering with about:blank that I
don't think I want to dig into much. Just use HTML here.

Depends on D194394

Differential Revision: https://phabricator.services.mozilla.com/D194395
2023-11-23 10:06:48 +00:00
Emilio Cobos Álvarez b30a1bf423 Bug 1866063 - Simplify codemirror editor iframe set-up. r=devtools-reviewers,nchevobbe
This doesn't change behavior but makes it easier to reason about.

Differential Revision: https://phabricator.services.mozilla.com/D194394
2023-11-23 09:57:15 +00:00
Tom Marble 6c1231e2e8 Bug 1853244 - convert .ini manifests to .toml: batch 6 {caps,devtools,dom}/**/browser.ini r=jmaher,media-playback-reviewers,devtools-reviewers,profiler-reviewers,alwu,nchevobbe,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D188856
2023-09-22 20:42:14 +00:00
Alexandre Poirot 27f68e6323 Bug 1320607 - [devtools] Remove the generated CSS Properties database. r=devtools-reviewers,nchevobbe
This wasn't really used anymore.
We are fetching the database from the server runtime in order to support
remote debugging correctly, where frontend CSS may be different from debuggee CSS.

Differential Revision: https://phabricator.services.mozilla.com/D187492
2023-09-07 20:59:34 +00:00
Butkovits Atila 76e7dfa668 Backed out changeset fb19de542f01 (bug 1320607) for causing python failures complaining about test_devtools_database_parsing . CLOSED TREE 2023-09-07 18:58:05 +03:00
Alexandre Poirot 7198ba3de1 Bug 1320607 - [devtools] Remove the generated CSS Properties database. r=devtools-reviewers,nchevobbe
This wasn't really used anymore.
We are fetching the database from the server runtime in order to support
remote debugging correctly, where frontend CSS may be different from debuggee CSS.

Differential Revision: https://phabricator.services.mozilla.com/D187492
2023-09-07 13:08:37 +00:00
Mark Banner 806a90f3f1 Bug 1846570 - Convert more jsm style imports to ES modules (devtools). r=devtools-reviewers,nchevobbe
Depends on D185071

Differential Revision: https://phabricator.services.mozilla.com/D185072
2023-08-02 13:43:07 +00:00
Alexandre Poirot c42905da36 Bug 1838443 - [devtools] Move preview data from redux store to react state. r=devtools-reviewers,perftest-reviewers,sparky,bomsy
This data is transient and only specific to the Editor's index react component.
There is no need to share nor persist this data in Redux,
this would avoid unecessary complexity/layers and avoid a few state updates.

Note that the target.match(:hover) was probably a poorly documented way to prevent
rending preview for token that are no longer hovered (the comment about whitespace sounds weird).

Also tweak waitForSelectedSource to also wait for CodeMirror to be updated.
Otherwise, we might try to hover tokens while CodeMirror is still udpating...
While doing that, use the L10N string instead of the final localized string.

Differential Revision: https://phabricator.services.mozilla.com/D180992
2023-06-19 17:18:27 +00:00
Mark Banner 0f2402949a Bug 1826062 - Manual fixes for Prettier 2.8.8 upgrade. r=mossop,webdriver-reviewers,extension-reviewers,devtools-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D177908
2023-05-20 12:26:55 +00:00
Mark Banner 0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner 91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Mark Banner 0fadbc1ec4 Bug 1829618 - Enable Prettier on json files (automatic fixes). r=perftest-reviewers,webcompat-reviewers,extension-reviewers,andi,desktop-theme-reviewers,pip-reviewers,devtools-reviewers,sync-reviewers,mossop,denschub,dao,sparky,robwu,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D176336
2023-05-09 16:14:51 +00:00
Emilio Cobos Álvarez cdff2ecc8e Bug 1820534 - Move front-end to modern flexbox. r=Gijs,dao,settings-reviewers,credential-management-reviewers,sgalich,devtools-reviewers,nchevobbe
Done mostly automatically via find/replace following the conversions
specified here:

  https://groups.google.com/a/mozilla.org/g/firefox-dev/c/9sGpF1TNbLk/m/QpU3oTUuAgAJ

For the most part I think the "flex: N N" usage could be simplified to
just "flex: N", but I wanted to preserve behavior (-moz-box-flex sets
both flex-grow and flex-shrink).

I changed legacy layout to also look at the order property rather than
-moz-box-ordinal-group because it made splitters and treecols easier (we
don't need to deal with both orders).

Differential Revision: https://phabricator.services.mozilla.com/D171715
2023-03-08 16:13:57 +00:00
Stanca Serban 5d57898ee6 Backed out changeset c25af897c9bc (bug 1820534) for causing reftests and mochitests failures. 2023-03-08 17:34:42 +02:00
Emilio Cobos Álvarez e15feb465b Bug 1820534 - Move front-end to modern flexbox. r=Gijs,dao,settings-reviewers,credential-management-reviewers,sgalich,devtools-reviewers,nchevobbe
Done mostly automatically via find/replace following the conversions
specified here:

  https://groups.google.com/a/mozilla.org/g/firefox-dev/c/9sGpF1TNbLk/m/QpU3oTUuAgAJ

For the most part I think the "flex: N N" usage could be simplified to
just "flex: N", but I wanted to preserve behavior (-moz-box-flex sets
both flex-grow and flex-shrink).

I changed legacy layout to also look at the order property rather than
-moz-box-ordinal-group because it made splitters and treecols easier (we
don't need to deal with both orders).

Differential Revision: https://phabricator.services.mozilla.com/D171715
2023-03-08 14:11:35 +00:00
Mark Banner b3474f4614 Bug 1812977 - Remove now unnecessary import-globals-from statements in devtools. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D168071
2023-01-30 19:33:38 +00:00
Alexandre Poirot 59fe57c052 Bug 1793396 - [devtools] Use absolute URLs in all usages of loader.lazyRequireGetter. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D158489
2022-10-03 18:57:13 +00:00
Alexandre Poirot a85b82697f Bug 1792847 - [devtools] Use absolute URLs to import modules in devtools/client/shared. r=jdescottes,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D158379
2022-09-30 15:17:39 +00:00
nchevobbe e0c71f7498 Bug 1791405 - [devtools] Block key events in source editor for u0000 keys. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D157738
2022-09-23 01:30:36 +00:00
Alexandre Poirot 0f32f335e3 Bug 1789201 - [devtools] Expose Services as a global to all DevTools modules. r=perftest-reviewers,nchevobbe,julienw,AlexandruIonescu
This will help transition to ES Modules as this symbol is exposed to them.

$ sed -ie "/require(.Services.)/d" $(git grep -l 'require("Services")' devtools/)
$ sed -ie "/loader.lazyRequireGetter(this, .Services./d" $(git grep -l 'loader.lazyRequireGetter(this, "Services"' devtools/)
+ the edition of builtin-modules.js + eslintrc.js
+ manual eslint fixes
+ removal of devtools-services in the debugger, except for jest tests

Differential Revision: https://phabricator.services.mozilla.com/D156401
2022-09-09 07:22:51 +00:00
Alexandre Poirot adf29caacd Bug 1788032 - [devtools] Convert devtools/client JSM to ES Modules. r=bomsy
This is the result of:
$ ./mach esmify devtools/client/

Differential Revision: https://phabricator.services.mozilla.com/D156181
2022-09-06 18:37:10 +00:00
Mark Banner 3387a89bc7 Bug 1786197 - Turn on ESLint rule for prefer-boolean-length-check for devtools. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D155167
2022-08-26 13:39:34 +00:00
Nicolas Chevobbe 3605097f71 Bug 1783858 - [devtools] Directly pass text and mode when creating a new CodeMirror document in the debugger. r=ochameau.
We used to create the document, then set the text and the mode, which seemed to
trigger unecessary updates in CodeMirror.
Since CodeMirror document can take an initial value and mode, we make this a possibility
in the source editor, and use it from the debugger codebase.

We take this as an opportunity to move the `getMode` function to `source-document.js` as
it's only used from there, and put the logic to not highlight big files there.
The unit test for the function are moved to the same folder the function now lives in,
and are adapted to the new signature.

Differential Revision: https://phabricator.services.mozilla.com/D154096
2022-08-23 06:42:37 +00:00
Emilio Cobos Álvarez 0f16115b60 Bug 1784265 - Drop support for flex attribute values other than 0 and 1. r=dholbert,mconley,preferences-reviewers
This makes it easier to get parity between legacy and regular flex
without having to either have tons of arbitrary attribute selectors in
the xul sheet, nor adding attribute lookup hacks to the html flexbox
layout.

Also, reimplement the remaining supported flex attribute-values (0 and 1)
purely in terms of CSS rules in xul.css (regardless of whether
emulate-moz-box-with-flex is enabled).

In practice these are pretty uncommon and the style attribute does the
trick in every case I've tried.

Add a debug-only assertion to ensure we preserve behavior for now.

Add a new test with another behavior difference between flexbox
emulation and old xul layout because the old reftest now passes. Use
replaced elements, which in modern flex are treated differently.

Differential Revision: https://phabricator.services.mozilla.com/D154394
2022-08-12 23:13:41 +00:00
Marian-Vasile Laza b160c98958 Backed out 3 changesets (bug 1784265) for causing reftest failures on flex-emulation-1.xhtml. CLOSED TREE
Backed out changeset 415da4b53bdd (bug 1784265)
Backed out changeset e27b21c54b1f (bug 1784265)
Backed out changeset fcb1a053fbe2 (bug 1784265)
2022-08-13 01:14:13 +03:00
Emilio Cobos Álvarez 5c4a2beefd Bug 1784265 - Drop support for flex attribute values other than 0 and 1. r=dholbert,mconley,preferences-reviewers
This makes it easier to get parity between legacy and regular flex
without having to either have tons of arbitrary attribute selectors in
the xul sheet, nor adding attribute lookup hacks to the html flexbox
layout.

Also, reimplement the remaining supported flex attribute-values (0 and 1)
purely in terms of CSS rules in xul.css (regardless of whether
emulate-moz-box-with-flex is enabled).

In practice these are pretty uncommon and the style attribute does the
trick in every case I've tried.

Add a debug-only assertion to ensure we preserve behavior for now.

Add a new test with another behavior difference between flexbox
emulation and old xul layout because the old reftest now passes. Use
replaced elements, which in modern flex are treated differently.

Differential Revision: https://phabricator.services.mozilla.com/D154394
2022-08-12 19:34:34 +00:00
Cristian Tuns 0f236800ac Backed out changeset 1b9afbfab196 (bug 1783858) for causing devtools failures on browser_dbg-features-wasm.js CLOSED TREE 2022-08-11 10:18:26 -04:00
Nicolas Chevobbe 42a72514ca Bug 1783858 - [devtools] Directly pass text and mode when creating a new CodeMirror document in the debugger. r=ochameau.
We used to create the document, then set the text and the mode, which seemed to
trigger unecessary updates in CodeMirror.
Since CodeMirror document can take an initial value and mode, we make this a possibility
in the source editor, and use it from the debugger codebase.

We take this as an opportunity to move the `getMode` function to `source-document.js` as
it's only used from there, and put the logic to not highlight big files there.
The unit test for the function are moved to the same folder the function now lives in,
and are adapted to the new signature.

Differential Revision: https://phabricator.services.mozilla.com/D154096
2022-08-11 12:48:49 +00:00
Mark Banner 6d03c63e2d Bug 1330099 - Enable object-shorthand eslint rule. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D153567
2022-08-03 14:57:05 +00:00
Mark Banner 1e3410cbdd Bug 1782008 - Remove now unnecessary .eslintrc.js files. r=webcompat-reviewers,extension-reviewers,media-playback-reviewers,pip-reviewers,denschub,rpl,alwu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D152736
2022-08-03 11:16:20 +00:00
Nicolas Chevobbe a64d1b5b08 Bug 1777787 - [devtools] Display non-printable chars in CodeMirror. r=jdescottes.
This adds some character (e.g. right-to-left override) to CodeMirror default list of
special characters (see https://codemirror.net/5/doc/manual.html#option_specialChar).
We also take this opportunity to show the unicode value for those, instead of the
default red dot CodeMirror provides.

Differential Revision: https://phabricator.services.mozilla.com/D152421
2022-07-22 16:25:00 +00:00
Cristian Tuns 7c304dab35 Backed out changeset b5ed92b74381 (bug 1777787) for causing mochitest failures on browser_styleeditor_filesave.js CLOSED TREE 2022-07-22 05:27:11 -04:00
Nicolas Chevobbe f31d2d5493 Bug 1777787 - [devtools] Display non-printable chars in CodeMirror. r=jdescottes.
This adds some character (e.g. right-to-left override) to CodeMirror default list of
special characters (see https://codemirror.net/5/doc/manual.html#option_specialChar).
We also take this opportunity to show the unicode value for those, instead of the
default red dot CodeMirror provides.

Differential Revision: https://phabricator.services.mozilla.com/D152421
2022-07-22 05:53:44 +00:00
Nicolas Chevobbe 6d9f55b2da Bug 1757581 - [devtools] Don't handle Ctrl/Cmd+U in JSTerm. r=jdescottes.
The shortcut is already used to open view-source and we want to let it through.
CodeMirror is using Ctrl+U for its undoSelection command, but it doesn't seem
like an important feature, so we can simply drop it.

Differential Revision: https://phabricator.services.mozilla.com/D141229
2022-03-17 15:51:27 +00:00