This includes the following API:
* Debugger.Object.prototype.createSource
* startColumn field of the parameter object
* Debugger.Script.prototype.startColumn
* return value
* Debugger.Script.prototype.getPossibleBreakpoints
* minColumn and maxColumn property of the query
* columnNumber property of the returned array elements
* Debugger.Script.prototype.getOffsetMetadata
* columnNumber property of the returned array elements
* Debugger.Script.prototype.getOffsetLocation
* columnNumber property of the returned array elements
* Debugger.Script.prototype.getAllColumnOffsets
* columnNumber property of the returned array elements
* Debugger.Script.prototype.getOffsetsCoverage
* columnNumber property of the returned array elements
* Debugger.Source.prototype.startColumn
* return value
This patch modifies DevTools code to convert the column number from/to 1-origin,
while keep using 0-origin on their side.
One exception is the WASM's column number, which had been using 1-origin 1.
Each consumer in DevTools handles the WASM case, and the code can be removed
once DevTools internal also switches to 1-origin column number.
The other exception is to use 1-based column number in logCustomFormatterError,
which is folded from bug 1864783 patch.
Differential Revision: https://phabricator.services.mozilla.com/D193270
This includes the following API:
* Debugger.Object.prototype.createSource
* startColumn field of the parameter object
* Debugger.Script.prototype.startColumn
* return value
* Debugger.Script.prototype.getPossibleBreakpoints
* minColumn and maxColumn property of the query
* columnNumber property of the returned array elements
* Debugger.Script.prototype.getOffsetMetadata
* columnNumber property of the returned array elements
* Debugger.Script.prototype.getOffsetLocation
* columnNumber property of the returned array elements
* Debugger.Script.prototype.getAllColumnOffsets
* columnNumber property of the returned array elements
* Debugger.Script.prototype.getOffsetsCoverage
* columnNumber property of the returned array elements
* Debugger.Source.prototype.startColumn
* return value
This patch modifies DevTools code to convert the column number from/to 1-origin,
while keep using 0-origin on their side.
One exception is the WASM's column number, which had been using 1-origin 1.
Each consumer in DevTools handles the WASM case, and the code can be removed
once DevTools internal also switches to 1-origin column number.
The other exception is to use 1-based column number in logCustomFormatterError,
which is folded from bug 1864783 patch.
Differential Revision: https://phabricator.services.mozilla.com/D193270
This documents how one can wirelessly debug a Firefox for Android app
over Wi-Fi, without requiring a USB cable.
The steps here differ from the official documentation at
https://developer.android.com/tools/adb#connect-to-a-device-over-wi-fi
in the following ways:
- Omitted unnecessary dependency on Android Studio.
- Added instruction to look up the IP address from Internet / Wi-Fi
settings instead of relying on the displayed IP address. The latter
is not reliable, e.g. when a VPN is enabled.
- Added explicit instruction to use "adb connect" to avoid dependency
on mDNS.
Differential Revision: https://phabricator.services.mozilla.com/D193390
This is a long overdue update to better describe the key actors:
root, descriptor, watcher, target and target-scope actors.
Differential Revision: https://phabricator.services.mozilla.com/D181136
This is a long overdue update to better describe the key actors:
root, descriptor, watcher, target and target-scope actors.
Differential Revision: https://phabricator.services.mozilla.com/D181136
- Rename the general section to `ignoring sources`
- Update the image for the ignore a source section
- Added content and images for ignore line and ignore lines
Differential Revision: https://phabricator.services.mozilla.com/D179316
These objects are either internal JS Object created internally within spidermonkey,
or some objects that the Debugger API wasn't able to retrieve a precise allocation stack.
In both cases, it makes the investigations hard as we have no clue what these objects are.
Differential Revision: https://phabricator.services.mozilla.com/D175347
Some actors weren't using any specification. They now have to pass a bare minimal spec object.
Unifying them to the regular Actor interface helps merging constructor with initialize
and instantiate all the actors without any code branch.
Differential Revision: https://phabricator.services.mozilla.com/D169359
This actor was only used by the legacy listener.
Its main method was listStores which exposed all the storage type actors.
Now they are exposed via storage Resource watchers.
This requires to tweak the decision making to show the storage panel
as the actor no longer exists... Unfortunately we can't check for
resource traits on the watcher actor as the browser toolbox
on older runtime won't expose it.
Note that this.front wasn't used for a little while in ui.js.
I had to keep a few things in the frontend in order to still be able
to connect to old servers. But I put lots of comments to do proper cleanup later.
Differential Revision: https://phabricator.services.mozilla.com/D166770