Commit Graph
2513 Commits
Author SHA1 Message Date
Alexandre Poirot cdf43b47f6 Bug 1793573 - [devtools] Convert devtools test JSMs to ESMs. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D158573
2022-10-05 16:07:26 +00:00
Alexandre Poirot 59fe57c052 Bug 1793396 - [devtools] Use absolute URLs in all usages of loader.lazyRequireGetter. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D158489
2022-10-03 18:57:13 +00:00
Alexandre Poirot 450d14d375 Bug 1793395 - [devtools] Use absolute URLs for all custom loader's require. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D158488
2022-10-03 18:57:12 +00:00
Alexandre Poirot 9beeb07755 Bug 1792847 - [devtools] Use absolute URLs to import modules in devtools/client/framework. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D158373
2022-09-30 15:17:36 +00:00
Emilio Cobos Álvarez f06ff95430 Bug 1792473 - Use modern flex emulation in devtools. r=devtools-reviewers,jdescottes
This shouldn't have any behavior change, other than avoiding XUL / CSS
interaction issues.

I had to tweak a bit a few of the webconsole split styles to preserve
behavior (even though without the styles it ends up working out because
the collapsed console would be out of view anyways).

The reason for the changes are:

 * visibility: collapse doesn't prevent min-height from applying on
   modern flexbox. So just collapse it using height properly. We need to
   use !important, at least on height, to override the style attribute
   set by the splitter.

 * Tweak the splitting setup of the console a bit more to match legacy
   behavior.

 * I need to contain: size on some scrollers and replaced elements so
   that they flex properly rather than taking as much space as they need
   (this kinda sucks but oh well). We could set min-width/height: 0
   instead if you think it's easier to understand but contain is more
   robust.

I needed to adjust the test since the fractional part of the container
wasn't getting rounded on my machine, but that's a pre-existing issue
that happens with my DPI settings both before and after the patch.

Differential Revision: https://phabricator.services.mozilla.com/D158183
2022-09-29 20:58:54 +00:00
Butkovits Atila 1121d1a2ba Backed out changeset d79027c38f41 (bug 1792473) for causing failure at test_focus_general.xhtml. CLOSED TREE 2022-09-29 21:26:52 +03:00
Emilio Cobos Álvarez 25b406b31b Bug 1792473 - Use modern flex emulation in devtools. r=devtools-reviewers,jdescottes
This shouldn't have any behavior change, other than avoiding XUL / CSS
interaction issues.

I had to tweak a bit a few of the webconsole split styles to preserve
behavior (even though without the styles it ends up working out because
the collapsed console would be out of view anyways).

The reason for the changes are:

 * visibility: collapse doesn't prevent min-height from applying on
   modern flexbox. So just collapse it using height properly. We need to
   use !important, at least on height, to override the style attribute
   set by the splitter.

 * Tweak the splitting setup of the console a bit more to match legacy
   behavior.

 * I need to contain: size on some scrollers and replaced elements so
   that they flex properly rather than taking as much space as they need
   (this kinda sucks but oh well). We could set min-width/height: 0
   instead if you think it's easier to understand but contain is more
   robust.

I needed to adjust the test since the fractional part of the container
wasn't getting rounded on my machine, but that's a pre-existing issue
that happens with my DPI settings both before and after the patch.

Differential Revision: https://phabricator.services.mozilla.com/D158183
2022-09-29 16:50:35 +00:00
Emilio Cobos Álvarez 274ea43371 Bug 1792656 - Use style attribute to set min-width on toolbox host frame. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D158271
2022-09-29 16:44:31 +00:00
Andreea Pavel 734e00a91f Backed out 5 changesets (bug 1700909) for failing browser_ext_addon_debugging_netmonitor.js on a CLOSED TREE
Backed out changeset 9bc3e4820f59 (bug 1700909)
Backed out changeset 998c0ec4f9d3 (bug 1700909)
Backed out changeset 6f6fe066fc38 (bug 1700909)
Backed out changeset e53aaf8ffe5b (bug 1700909)
Backed out changeset 3dbeffe25878 (bug 1700909)
2022-09-29 19:40:43 +03:00
Alexandre Poirot 2fa2a439ea Bug 1700909 - [devtools] Migrate gDevTools.showToolbox from descriptor to commands. r=jdescottes
This migrate gDevTools.showToolbox, but also the Toolbox now receives a commands right away,
and no longer need to create commands out of the descriptor front.

I'm removing browser_two_tabs as it is focusing on testing Tab Descriptors (RootFront.listTabs+getTab)
and Tab targets (TabDescriptor.getTarget).
Using getTarget on descriptor is legacy codepath for a while now.
We should now rather cover commands instead of these low level RDP methods.

Differential Revision: https://phabricator.services.mozilla.com/D157796
2022-09-29 14:43:26 +00:00
Alexandre Poirot 06d9cc9c05 Bug 1700909 - [devtools] Migrate DescriptorMixin.shouldCloseClient to Commands. r=jdescottes
Note that this depends on the following patch, in order to destroy commands from the toolbox.
Commands have always been destroying the related client. This was a significant simplification in test.
So that I had to reverse the default value of shouldCloseClient and only toggle it to false
where it is strictly needed. Ideally only for about:debugging toolboxes (and two tests).

Differential Revision: https://phabricator.services.mozilla.com/D158206
2022-09-29 14:43:26 +00:00
Alexandre Poirot 4386d3e35c Bug 1700909 - [devtools] Migrate descriptorFromURL to commandsFromURL. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D157944
2022-09-29 14:43:25 +00:00
Alexandre Poirot 03239d33fd Bug 1700909 - [devtools] Migrate TabDescriptorFactory to LocalTabCommandsFactory. r=jdescottes
Also move iKnownTab to gDevTools.hasToolboxForTab as it feel more natural.

Differential Revision: https://phabricator.services.mozilla.com/D157943
2022-09-29 14:43:25 +00:00
Alexandre Poirot 0d20bb1ccb Bug 1700909 - [devtools] Stop exposing Toolbox.descriptorFront. r=jdescottes
Instead we should we querying Toolbox.commands.descriptorFront.

Differential Revision: https://phabricator.services.mozilla.com/D157942
2022-09-29 14:43:24 +00:00
Mark Banner a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Alexandre Poirot acb64f5211 Bug 1791969 - [devtools] Migrate lazyRequireGetter for JSM to ChromeUtils.defineModuleGetter. r=jdescottes
There was some imports of sys.mjs which I migrated to `ChromeUtils.defineESModuleGetters`.

Differential Revision: https://phabricator.services.mozilla.com/D158129
2022-09-28 16:20:08 +00:00
Alexandre Poirot 58b38d7c16 Bug 1791969 - [devtools] Import all JSM in DevTools via ChromeUtils.import. r=jdescottes
Convert all imports but the one related to SessionDataHelper
as that's an hybrid module which is loaded as a JSM from the main thread,
but loaded as a common js module from the worker thread.

We will be able to drop this once we can migrate this JSM to ESM
once we support loading ESM from the worker thread.

Differential Revision: https://phabricator.services.mozilla.com/D158007
2022-09-26 13:01:33 +00:00
Alexandre Poirot 633eb069ef Bug 1791832 - [devtools] Convert devtools/startup JSM to ES Modules. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D157911
2022-09-26 10:48:05 +00:00
Alexandre Poirot 52cc15a830 Bug 1791055 - [devtools] Migrate to CommandsFactory to instantiate all descriptors. r=jdescottes,perftest-reviewers,AlexandruIonescu
This help factorise all code trying to instantiate a server and a client everywhere.
This will also help migrate from descriptor to commands in Toolbox constructor.

A good way to track all leftover manual instantiation of descriptors is to look for mainRoot.get*.
There should only be tests now, and descriptor-from-url, which I would to convert once
we migrate toolbox constructor from descriptor to commands.

Differential Revision: https://phabricator.services.mozilla.com/D157737
2022-09-24 07:14:58 +00:00
Jan Odvarko 695d3b5257 Bug 1761367 - Firefox DevTools User Docs mention removed Web Developer submenu r=jdescottes,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D157789
2022-09-23 12:06:14 +00:00
Julian Descottes a6dda16e85 Bug 1791640 - [devtools] Do not use custom zoom keys when the toolbox is hosted in a tab r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D157830
2022-09-21 17:49:38 +00:00
Alexandre Poirot 0c4e317914 Bug 1789980 - [devtools] Migrate all callsites using require("chrome") to use Components.* global symbols. r=jdescottes,perftest-reviewers,AlexandruIonescu
This will help transition to ES Modules as we won't be able to expose a magic "chrome" ESM.
Also, most of these symbols are exposed as global already.
All but:
* `components` which is `Components`,
* `CC` which is `Components.Constructor`,
* `Cm` which is `Components.manager`.

$ sed -ie "/require(.chrome.)/d" $(git grep -l 'require("chrome")' devtools/)
+ manual edits for all three exceptions

Differential Revision: https://phabricator.services.mozilla.com/D156936
2022-09-20 12:52:27 +00:00
Alexandre Poirot 2c60e181a5 Bug 1789980 - [devtools] Stop exposing require("chrome"), instead expose Components.* as globals. r=jdescottes
This will actually make commonjs module behave like JSM/ESM.
Where you have access to Components, Cc, Ci, Cu and Cr as globals.

This patch is based on the usage of Sandbox's wantComponents,
which will expose all these globals for us.
Then, I'm handling the special cases of Services and ChromeWorker,
which have nothing to do with Components.* APIs.

Differential Revision: https://phabricator.services.mozilla.com/D156935
2022-09-20 12:52:26 +00:00
Joel Maher 1325c90046 Bug 1790868 - clean up 32 bit annotations for tests that don't run on 32 bit, and general cleanup. r=aryx
Differential Revision: https://phabricator.services.mozilla.com/D157352
2022-09-16 12:40:13 +00:00
Alexandre Poirot 4ff70fda6f Bug 1780912 - [devtools] Make the local web extension toolbox be always on top. r=nchevobbe,eemeli
This allows to keep the DevTools visible while interacting with the Firefox
window where the extension is running.

This behavior is enabled by default, but can be disable on-demand via a button
in the top toolbar.
Note that it requires to close and reopen the window/toolbox as platform APIs
disallow changing this behavior "live" on a given window.

Differential Revision: https://phabricator.services.mozilla.com/D155843
2022-09-15 07:31:31 +00:00
Julian Descottes 88152a265d Bug 1790821 - [devtools] Fix resizing side-docked toolbox using the splitter r=ochameau,emilio
Adding a test explicitly resizing the toolbox by manipulating the splitter in both horizontal and vertical configurations

Differential Revision: https://phabricator.services.mozilla.com/D157339
2022-09-14 19:04:57 +00:00
Emilio Cobos Álvarez 4602999b68 Bug 1790299 - Make XUL splitter use height property rather than attribute. r=jdescottes,tnikkel
Existing splitter and DevTools tests keep passing with this.

Differential Revision: https://phabricator.services.mozilla.com/D157062
2022-09-13 10:02:05 +00:00
Nicolas Chevobbe 48647cab11 Bug 1788601 - [devtools] Fix ESLint consistent-return failures in devtools/client/framework. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D156159
2022-09-12 17:41:33 +00:00
Alexandre Poirot 86c7a14e62 Bug 1789202 - [devtools] Expose ChromeUtils as a global to all DevTools modules. r=perftest-reviewers,nchevobbe,AlexandruIonescu
This will help transition to ES Modules as this symbol is exposed to them.

$ sed -ie "/require(.ChromeUtils.)/d" $(git grep -l 'require("ChromeUtils")' devtools/)
$ sed -ie "/loader.lazyRequireGetter(this, .ChromeUtils./d" $(git grep -l 'loader.lazyRequireGetter(this, "ChromeUtils"' devtools/)
+ the edition of builtin-modules.js + eslintrc.js + manual eslint fixes

Differential Revision: https://phabricator.services.mozilla.com/D156402
2022-09-09 07:22:51 +00:00
Alexandre Poirot 0f32f335e3 Bug 1789201 - [devtools] Expose Services as a global to all DevTools modules. r=perftest-reviewers,nchevobbe,julienw,AlexandruIonescu
This will help transition to ES Modules as this symbol is exposed to them.

$ sed -ie "/require(.Services.)/d" $(git grep -l 'require("Services")' devtools/)
$ sed -ie "/loader.lazyRequireGetter(this, .Services./d" $(git grep -l 'loader.lazyRequireGetter(this, "Services"' devtools/)
+ the edition of builtin-modules.js + eslintrc.js
+ manual eslint fixes
+ removal of devtools-services in the debugger, except for jest tests

Differential Revision: https://phabricator.services.mozilla.com/D156401
2022-09-09 07:22:51 +00:00
Noemi Erli 233f0fcdf4 Backed out 2 changesets (bug 1780912) for causing failures in browser_aboutdebugging_addons_debug_console.js CLOSED TREE
Backed out changeset d2360a2a3d70 (bug 1780912)
Backed out changeset 21f1e9031be0 (bug 1780912)
2022-09-08 01:59:18 +03:00
Alexandre Poirot ce1e1a4cbe Bug 1780912 - [devtools] Make the local web extension toolbox be always on top. r=nchevobbe,eemeli
This allows to keep the DevTools visible while interacting with the Firefox
window where the extension is running.

This behavior is enabled by default, but can be disable on-demand via a button
in the top toolbar.
Note that it requires to close and reopen the window/toolbox as platform APIs
disallow changing this behavior "live" on a given window.

Differential Revision: https://phabricator.services.mozilla.com/D155843
2022-09-07 21:00:17 +00:00
lyavor 312735b885 Bug 1709150 - Consider linter rule to make https the default for all kind of tests we add. r=Standard8,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D149394
2022-09-07 08:45:12 +00:00
Alexandre Poirot b1ec4a4679 Bug 1783821 - [devtools] Manual rewrites r=bomsy
In md files and code comments and mostly from common js files.

I'm moving away from require to load sys.mjs files so that we are closer
to what we do in mozilla-central.

Differential Revision: https://phabricator.services.mozilla.com/D154073
2022-09-05 12:29:57 +00:00
Alexandre Poirot 444e6f2298 Bug 1783821 - [devtools] Load Launcher.sys.mjs via ChromeUtils.importESModule. r=perftest-reviewers,bomsy,arai,sparky
This is the result of:
$ ./mach esmify --imports . --prefix=devtools/client/framework/browser-toolbox

Differential Revision: https://phabricator.services.mozilla.com/D154072
2022-09-05 12:29:57 +00:00
Alexandre Poirot 9c762d0a34 Bug 1783821 - [devtools] Convert Launcher JSM to an ES Module. r=bomsy
This is the result of:
$ ./mach esmify devtools/client/framework/browser-toolbox/Launcher.jsm

Differential Revision: https://phabricator.services.mozilla.com/D154071
2022-09-05 12:29:56 +00:00
Alexandre Poirot 3cadeaeb46 Bug 1788536 - [devtools] Use descriptorType instead of a type decipher from toolbox URL. r=jdescottes
This helps having the right type, even if we open the toolbox without any search params
in about:devtools-toolbox URL.

Differential Revision: https://phabricator.services.mozilla.com/D156134
2022-09-02 09:10:01 +00:00
Nicolas Chevobbe a361a2ece2 Bug 1787685 - [devtools] Fix ChromeDebugToolbar styling in Windows High Contrast mode. r=jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D156274
2022-09-02 08:09:44 +00:00
Alexandre Poirot 623d46660e Bug 1787999 - [devtools] Show pseudo locale settings only in the browser toolbox. r=nchevobbe
Note that it will also stop showing locale and popup settings for remote browser toolboxes.
Toolbox.isBrowserToolbox being false for this usecase.

Differential Revision: https://phabricator.services.mozilla.com/D155956
2022-09-01 08:41:51 +00:00
Alexandre Poirot aa440f1a2c Bug 1787409 - [devtools] Resolve toolbox's opening only once the meatball menu is updated. r=nchevobbe
_buildTabs/_setInitialMeatballState wasn't awaited for.
So that preference front request might be pending when closing the toolbox too quickly in tests.

We should wait for all RDP requests to be completed before resolving Toolbox.open.

Differential Revision: https://phabricator.services.mozilla.com/D155872
2022-09-01 08:41:50 +00:00
Alexandre Poirot 72d3ca6549 Bug 1787992 - [devtools] Expose gDevTools.showToolboxForWebExtension to open a webext toolbox in a dedicated window. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D155950
2022-09-01 08:41:49 +00:00
Nicolas Chevobbe 6f2db18829 Bug 1787514 - [devtools] Fix failing framework jest tests. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D155808
2022-08-30 16:08:57 +00:00
Alexandre Poirot fe4b93e68d Bug 1787990 - [devtools] Remove devtools.toolbox.sideEnabled r=jdescottes
This has been added many years ago when introducing side hosts.
We should now consider this a builtin feature.

Differential Revision: https://phabricator.services.mozilla.com/D155392
2022-08-30 06:57:05 +00:00
Alexandre Poirot 531f08b810 Bug 1693686 - [devtools] Display the navigation buttons in WebExtension toolboxes. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D155563
2022-08-29 08:54:00 +00:00
Mark Banner 3387a89bc7 Bug 1786197 - Turn on ESLint rule for prefer-boolean-length-check for devtools. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D155167
2022-08-26 13:39:34 +00:00
Daisuke Akatsuka d3b71faba0 Bug 1783877: Disable inspector quick action if already opening. r=daleharvey,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D155191
2022-08-24 22:02:44 +00:00
Emilio Cobos Álvarez 0f16115b60 Bug 1784265 - Drop support for flex attribute values other than 0 and 1. r=dholbert,mconley,preferences-reviewers
This makes it easier to get parity between legacy and regular flex
without having to either have tons of arbitrary attribute selectors in
the xul sheet, nor adding attribute lookup hacks to the html flexbox
layout.

Also, reimplement the remaining supported flex attribute-values (0 and 1)
purely in terms of CSS rules in xul.css (regardless of whether
emulate-moz-box-with-flex is enabled).

In practice these are pretty uncommon and the style attribute does the
trick in every case I've tried.

Add a debug-only assertion to ensure we preserve behavior for now.

Add a new test with another behavior difference between flexbox
emulation and old xul layout because the old reftest now passes. Use
replaced elements, which in modern flex are treated differently.

Differential Revision: https://phabricator.services.mozilla.com/D154394
2022-08-12 23:13:41 +00:00
Marian-Vasile Laza b160c98958 Backed out 3 changesets (bug 1784265) for causing reftest failures on flex-emulation-1.xhtml. CLOSED TREE
Backed out changeset 415da4b53bdd (bug 1784265)
Backed out changeset e27b21c54b1f (bug 1784265)
Backed out changeset fcb1a053fbe2 (bug 1784265)
2022-08-13 01:14:13 +03:00
Emilio Cobos Álvarez 5c4a2beefd Bug 1784265 - Drop support for flex attribute values other than 0 and 1. r=dholbert,mconley,preferences-reviewers
This makes it easier to get parity between legacy and regular flex
without having to either have tons of arbitrary attribute selectors in
the xul sheet, nor adding attribute lookup hacks to the html flexbox
layout.

Also, reimplement the remaining supported flex attribute-values (0 and 1)
purely in terms of CSS rules in xul.css (regardless of whether
emulate-moz-box-with-flex is enabled).

In practice these are pretty uncommon and the style attribute does the
trick in every case I've tried.

Add a debug-only assertion to ensure we preserve behavior for now.

Add a new test with another behavior difference between flexbox
emulation and old xul layout because the old reftest now passes. Use
replaced elements, which in modern flex are treated differently.

Differential Revision: https://phabricator.services.mozilla.com/D154394
2022-08-12 19:34:34 +00:00
Nicolas Chevobbe 1d71a7b123 Bug 1783373 - [devtools] Pass isPrivate property to Downloads.createDownload. r=jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D154528
2022-08-12 16:53:15 +00:00