Commit Graph
17 Commits
Author SHA1 Message Date
Alexandre Poirot b3203496a3 Bug 1700106 - [devtools] Remove the waitForTick custom eslint global from DevTools mochitests. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D109475
2021-03-23 15:51:16 +00:00
Julian Descottes 0b18daa66c Bug 1616250 - Wait for next tick after show/hide tooltip in DevTools tooltip tests r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D71554
2020-04-20 15:57:44 +00:00
Nicolas Chevobbe c1124335cf Bug 1621239 - Round values returned by calculate(Horizontal|Vertical)Position in HTMLTooltip. r=jdescottes.
There are currently cases where the HTMLTooltip would "jump"
when its content is updated whereas it shouldn't, as when
applying those result to CSS, decimals aren't taken into
account (so a "left" of 152.9999 would translate into a
CSS "left" property of 152px).
Rounding those values seems to fix the issue.

Differential Revision: https://phabricator.services.mozilla.com/D66576
2020-03-12 23:12:29 +00:00
Nicolas Chevobbe 13579fb6a5 Bug 1616847 - When xulWrapper is visible move it instead of trying to show it again. r=jdescottes.
If the XUL wrapper was opened and a consumer called show again,
the panel wouldn't update its position. This can be fixed by checking the
state of the element, and if it's open move the panel using `_moveXulWrapperTo`.

With this change in place, we can remove the updateContainerBounds methods,
as it has the same arguments and is only used in one place.

Differential Revision: https://phabricator.services.mozilla.com/D63488
2020-03-06 13:02:22 +00:00
Narcis Beleuzu 4ee0475f73 Backed out 2 changesets (bug 1616847, bug 1609942) for dt failures on browser_jsterm_autocomplete_control_space.js . CLOSED TREE
Backed out changeset c1d7d5e9a18b (bug 1609942)
Backed out changeset 7a5178ee8cd2 (bug 1616847)
2020-02-28 22:05:05 +02:00
Nicolas Chevobbe df3967f5da Bug 1616847 - When xulWrapper is visible move it instead of trying to show it again. r=jdescottes.
If the XUL wrapper was opened and a consumer called show again,
the panel wouldn't update its position. This can be fixed by checking the
state of the element, and if it's open move the panel using `_moveXulWrapperTo`.

With this change in place, we can remove the updateContainerBounds methods,
as it has the same arguments and is only used in one place.

Differential Revision: https://phabricator.services.mozilla.com/D63488
2020-02-28 15:08:22 +00:00
Cosmin Sabou 3056d5d619 Backed out 2 changesets (bug 1616847, bug 1609942) for devtools failures on browser_jsterm_autocomplete_getters_cache.js.
CLOSED TREE

Backed out changeset 0ee1ac6bab06 (bug 1609942)
Backed out changeset 2357c3d7aa4a (bug 1616847)
2020-02-26 21:39:11 +02:00
Nicolas Chevobbe f178c1ae0e Bug 1616847 - When xulWrapper is visible move it instead of trying to show it again. r=jdescottes.
If the XUL wrapper was opened and a consumer called show again,
the panel wouldn't update its position. This can be fixed by checking the
state of the element, and if it's open move the panel using `_moveXulWrapperTo`.

With this change in place, we can remove the updateContainerBounds methods,
as it has the same arguments and is only used in one place.

Differential Revision: https://phabricator.services.mozilla.com/D63488
2020-02-26 13:03:41 +00:00
Julian Descottes 2f90ec41e6 Bug 1590408 - Backed out changeset 84708a4f040d from Bug 1552146 r=miker
The positioning of the arrow was correct, but due to the way the arrow was rotated, the visual center of the arrow did not match the center of the arrow box
Backing out the JS change here, CSS patch later in the queue

Differential Revision: https://phabricator.services.mozilla.com/D52668
2019-11-12 15:45:57 +00:00
Michael Ratcliffe 5c5ff75b10 Bug 1552146 - [Inactive CSS] Fine tune the tooltip's position in hidpi and non-hidpi modes r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D44846
2019-09-12 10:14:34 +00:00
Victor Porof b7732ae890 Bug 1561435 - Format devtools/client/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35884
2019-07-05 11:24:38 +02:00
Julian Descottes 82711b9a8f Bug 1454696 - Run eslint --fix for prefer-const;r=yulia
MozReview-Commit-ID: F6xUXCgdRE4
2018-06-01 12:36:09 +02:00
Alexandre Poirot 22e91d7acd Bug 1440321 - Convert Task.jsm to async/await in devtools/client. r=jryans
MozReview-Commit-ID: HaGOC5cn3JD
2018-03-12 19:46:35 -05:00
Julian Descottes 9d649d3159 Bug 1266456 - part6: HTMLTooltip show() now accepts x,y offsets;r=bgrins
The autocomplete popup is displayed relatively to an anchor, but will be
shifted on the x-axis in order to be aligned with the word being completed.

To support this, the HTMLTooltip show() method now accepts x and y offsets.

MozReview-Commit-ID: 1cR3XFPdcVy
2016-06-20 21:07:08 +02:00
Julian Descottes acf216e545 Bug 1267401 - part1: Rename HTMLTooltip properties for backward comp with Tooltip;r=bgrins
Rename document -> doc for consistency and parent to panel
for test compatibility.

MozReview-Commit-ID: KHT7plLtNQc
2016-05-23 22:49:21 +02:00
Julian Descottes 1a1cef3282 Bug 1273827 - Wait for reflow after showing HTMLTooltip in tests;r=ochameau
MozReview-Commit-ID: 1qKKXO8iRyD
2016-05-16 15:06:42 +02:00
Julian Descottes d162f12420 Bug 1259834 - Create basic HTML tooltip API;r=bgrins
First implementation of HTML based tooltip to be used in devtools
instead of XUL panels. API is similar to the current API of
Tooltip.js

MozReview-Commit-ID: 8njiKBubLSj
2016-05-04 14:44:57 +02:00