Commit Graph
160 Commits
Author SHA1 Message Date
Emilio Cobos Álvarez e4f566a08e Bug 1884294 - Move alert-small / info-small to devtools-shared-images. r=devtools-reviewers,nchevobbe
So that they can be loaded by the highlighters.

Differential Revision: https://phabricator.services.mozilla.com/D204014
2024-03-08 13:19:15 +00:00
Dave Townsend 2af4d349f3 Bug 1864896: Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
Differential Revision: https://phabricator.services.mozilla.com/D202959
2024-03-05 14:21:15 +00:00
Alexandre Poirot 18a41e4ec0 Bug 1651522 - [devtools] Implement server side Service Worker targets. r=devtools-reviewers,nchevobbe
Note that Service worker Target are no longer destroyed on navigation.
Not from the server side, nor the frontend.

I had to disable specialized Headers preview.
For some reason, the "Headers" global doesn't exist in the debugger module global scope.

Differential Revision: https://phabricator.services.mozilla.com/D166319
2023-11-21 09:17:31 +00:00
Sandor Molnar 4e996c2806 Backed out 4 changesets (bug 1651522) for causing dt failures on devtools/shared/commands/target/tests/browser_target_command_service_workers_navigation.js CLOSED TREE
Backed out changeset 81d3ee520ab6 (bug 1651522)
Backed out changeset 7871ba0badea (bug 1651522)
Backed out changeset f80194bc4d6c (bug 1651522)
Backed out changeset 9855542eb321 (bug 1651522)
2023-11-20 15:15:55 +02:00
Alexandre Poirot 52fe46fec7 Bug 1651522 - [devtools] Implement server side Service Worker targets. r=devtools-reviewers,nchevobbe
Note that Service worker Target are no longer destroyed on navigation.
Not from the server side, nor the frontend.

I had to disable specialized Headers preview.
For some reason, the "Headers" global doesn't exist in the debugger module global scope.

Differential Revision: https://phabricator.services.mozilla.com/D166319
2023-11-20 10:37:02 +00:00
Zachary Svoboda 824d105a3d Bug 1673582 - Introduce theme-link-color for better contrast on devtools links r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D187863
2023-09-19 07:00:47 +00:00
Emilio Cobos Álvarez c8d2c23403 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
2023-07-09 11:34:05 +00:00
Stanca Serban 27c720052b Backed out changeset 1c835137f532 (bug 1824886) for causing multiple failures. CLOSED TREE 2023-07-06 02:11:59 +03:00
Emilio Cobos Álvarez 8053b896a6 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
2023-07-05 21:59:44 +00:00
Cosmin Sabou 20fa44fbeb Backed out 2 changesets (bug 1824886) for causing failures on browser_all_files_referenced.js. CLOSED TREE
Backed out changeset 650ef77d1c4d (bug 1824886)
Backed out changeset 1c835137f532 (bug 1824886)
2023-07-06 00:42:53 +03:00
Emilio Cobos Álvarez b1433254b6 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
2023-07-05 18:21:31 +00:00
Julian Descottes ccefe86c05 Bug 1828430 - [devtools] Use underline for devtools links opening pages in tabs or windows r=devtools-reviewers,nchevobbe
Depends on D175924

Differential Revision: https://phabricator.services.mozilla.com/D175925
2023-04-20 13:48:46 +00:00
Alexandre Poirot d7a3f2cb45 Bug 1807898 - [devtools] Remove all callsites passing a now-useless telemetry sessionId. r=devtools-reviewers,nchevobbe
Note that there is still one leftover usage of sessionId related to performance markers,
which isn't related to telemetry... but a way to distinguish toolbox instances.

Differential Revision: https://phabricator.services.mozilla.com/D165936
2023-01-04 18:28:33 +00:00
Alexandre Poirot f082da3878 Bug 1792847 - [devtools] Use absolute URLs to import modules in devtools/client/application. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D158371
2022-09-30 15:17:35 +00:00
Alexandre Poirot 0c4e317914 Bug 1789980 - [devtools] Migrate all callsites using require("chrome") to use Components.* global symbols. r=jdescottes,perftest-reviewers,AlexandruIonescu
This will help transition to ES Modules as we won't be able to expose a magic "chrome" ESM.
Also, most of these symbols are exposed as global already.
All but:
* `components` which is `Components`,
* `CC` which is `Components.Constructor`,
* `Cm` which is `Components.manager`.

$ sed -ie "/require(.chrome.)/d" $(git grep -l 'require("chrome")' devtools/)
+ manual edits for all three exceptions

Differential Revision: https://phabricator.services.mozilla.com/D156936
2022-09-20 12:52:27 +00:00
Alexandre Poirot 0f32f335e3 Bug 1789201 - [devtools] Expose Services as a global to all DevTools modules. r=perftest-reviewers,nchevobbe,julienw,AlexandruIonescu
This will help transition to ES Modules as this symbol is exposed to them.

$ sed -ie "/require(.Services.)/d" $(git grep -l 'require("Services")' devtools/)
$ sed -ie "/loader.lazyRequireGetter(this, .Services./d" $(git grep -l 'loader.lazyRequireGetter(this, "Services"' devtools/)
+ the edition of builtin-modules.js + eslintrc.js
+ manual eslint fixes
+ removal of devtools-services in the debugger, except for jest tests

Differential Revision: https://phabricator.services.mozilla.com/D156401
2022-09-09 07:22:51 +00:00
Mark Banner 3387a89bc7 Bug 1786197 - Turn on ESLint rule for prefer-boolean-length-check for devtools. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D155167
2022-08-26 13:39:34 +00:00
Mark Banner 6d03c63e2d Bug 1330099 - Enable object-shorthand eslint rule. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D153567
2022-08-03 14:57:05 +00:00
Geoff Lankow f044ee051e Bug 1698112 - Stop referencing browser files from toolkit, and prevent it happening again with a test. r=preferences-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D128974
2021-10-21 21:54:52 +00:00
Abhishek Sharma 2c703b1e30 Bug 1685638 - Change :not(:disabled) to :enabled in CSS files. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D101130
2021-01-19 14:02:38 +00:00
Ricky Stewart 31b8ca9716 Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara 612312a64c Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart 065d2eb893 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Dorel Luca 95b44c982f Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart 43baed3c18 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Ben Delevingne d90a8026fb Bug 1582699 - [devtools] Consolidate thunk middlewares. r=nchevobbe
Merge `thunk-with-options` behavior directly into `thunk`, update `thunk` and `thunk-with-options` callsites and finally remove now unused `thunk-with-options` (as well as netmonitor's own `thunk`)

Depends on D92888

Differential Revision: https://phabricator.services.mozilla.com/D93195
2020-10-13 07:45:52 +00:00
Ben Delevingne 2aea6ca83e Bug 1582699 - [devtools] Update thunk actions to take an object as an argument. r=nchevobbe
In short, thunk actions are changing from a signature with 2 parameters (dispatch and getState): `(dispatch, getState)`, to an object that contains those properties: `({ dispatch, getState })`.
This is done so we can merge thunk and thunk-with-options

Differential Revision: https://phabricator.services.mozilla.com/D92888
2020-10-13 07:48:12 +00:00
Nicolas Chevobbe 124ea2f1a0 Bug 1573779 - [devtools] Rename WorkerTarget to WorkerDescriptor. r=ochameau,jdescottes,devtools-backward-compat-reviewers.
This renames the current WorkerTargetActor which is actually a descriptor.
We also rename the existing `workerTargetFront` occurences to `workerDescriptorFront`
to avoid confusion when we do introduce the real worker fronts and actors.

Differential Revision: https://phabricator.services.mozilla.com/D91100
2020-09-29 14:30:24 +00:00
Dorel Luca 2767dba5fe Backed out 3 changesets (bug 1573779, bug 1662734) for Geckoview failures. CLOSED TREE
Backed out changeset 0adff4f08b28 (bug 1662734)
Backed out changeset c6bb84f2a032 (bug 1573779)
Backed out changeset 0c605800aa6b (bug 1573779)
2020-09-29 12:59:39 +03:00
Nicolas Chevobbe afff47ed89 Bug 1573779 - [devtools] Rename WorkerTarget to WorkerDescriptor. r=ochameau,jdescottes,devtools-backward-compat-reviewers.
This renames the current WorkerTargetActor which is actually a descriptor.
We also rename the existing `workerTargetFront` occurences to `workerDescriptorFront`
to avoid confusion when we do introduce the real worker fronts and actors.

Differential Revision: https://phabricator.services.mozilla.com/D91100
2020-09-28 12:27:22 +00:00
Belén Albeza a25e69d62c Bug 1653998 - View source of worker from the Application panel r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D86039
2020-08-07 12:47:34 +00:00
Belén Albeza aa80cfb303 Bug 1637538 - Change debug button in the Application panel for a link as per latest UX mockups r=jdescottes,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D85605
2020-08-04 18:36:38 +00:00
Belén Albeza 60cc1d1674 Bug 1639605 - Part 2: Add a new ManifestUrlItem component to show manifest URLs correctly in RTL mode r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D84724
2020-07-24 13:25:44 +00:00
Belén Albeza cc8a5d081f Bug 1639605 - Part 1: Fix display of colors in RTL mode in the Manifest page r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D84723
2020-07-24 13:17:04 +00:00
Belén Albeza 55914b96a3 Bug 1651630 - Part 2: Hide the debug button instead of disabling it r=jdescottes,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D83484
2020-07-16 13:41:24 +00:00
Belén Albeza 3d24f1f335 Bug 1651630 - Part 1: Allow start button to work regardless of debugger pref r=jdescottes,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D83482
2020-07-16 13:13:40 +00:00
Cameron McCormack 34d3b448a7 Bug 1620467 - Part 4: Change internal uses of -moz-appearance to appearance and -moz-default-appearance. r=emilio,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,ntim,agi,miketaylr
Uses of `-moz-appearance: none` are changed to `appearance: none`.

Uses of other values that are simply reverting the appearance back to
its default are changed to `appearance: auto`.

Uses of values in UA sheets that are defining the inherent appearance of
widgets are changed to:

  appearance: auto;
  -moz-default-appearance: <value>;

since those values are either no longer supported on (-moz-)appearance,
or are still supported but only in some limited form.

There are some uses of `-moz-appearance: textfield` on <input
type=number> elements that are renamed to `appearance: textfield`.

Differential Revision: https://phabricator.services.mozilla.com/D83430
2020-07-16 22:04:14 +00:00
Christoph Kerschbaumer 161f7ad113 Bug 1652997: Package all devtools css files and load them using the internal chrome: protocol. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D83656
2020-07-15 16:02:28 +00:00
Belén Albeza 9c3652b5c4 Bug 1643253 - Part 1: Add telemetry middleware to record application panel events r=jdescottes,janerik
Differential Revision: https://phabricator.services.mozilla.com/D82044
2020-07-13 14:58:29 +00:00
Belén Albeza 3e082eea6a Bug 1635402 - UX polish: empty pages r=jdescottes,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D81362
2020-07-13 15:36:35 +00:00
Sebastian Hengst 2a2459f031 Backed out 3 changesets (bug 1145314) on request from ckerschb for regressions (e.g. bug 1650951)
Backed out changeset 664cc562ddf3 (bug 1145314)
Backed out changeset 9640a9d093c7 (bug 1145314)
Backed out changeset 5492ac0e42f7 (bug 1145314)
2020-07-07 09:32:27 +02:00
Tiger Oakes 73cbde7f97 Bug 1605688 - Strip alpha when opaque, r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D82266
2020-07-06 16:34:54 +00:00
Christoph Kerschbaumer 6d9b9085ff Bug 1145314: Package all devtools css files and load them using the internal chrome: protocol. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D78896
2020-07-03 08:12:22 +00:00
Narcis Beleuzu f439b0e9c9 Backed out 2 changesets (bug 1145314) for mochitest failures on test_bug995943.xhtml . CLOSED TREE
Backed out changeset 0500cb344e6f (bug 1145314)
Backed out changeset f524ffe669ca (bug 1145314)
2020-07-02 20:50:46 +03:00
Christoph Kerschbaumer 0745716ac3 Bug 1145314: Package all devtools css files and load them using the internal chrome: protocol. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D78896
2020-07-02 15:03:52 +00:00
Csoregi Natalia 178189064a Backed out 2 changesets (bug 1145314) for node debugger failure. CLOSED TREE
Backed out changeset 550f9596f16b (bug 1145314)
Backed out changeset 93dbc3fe146a (bug 1145314)
2020-07-02 12:37:06 +03:00
Christoph Kerschbaumer dc83bf1b46 Bug 1145314: Package all devtools css files and load them using the internal chrome: protocol. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D78896
2020-07-02 08:17:17 +00:00
Butkovits Atila 195003e687 Backed out changeset fa56a4ad6f4a (bug 1605688) for devtools failures on browser_devtools_api_destroy.js. CLOSED TREE 2020-07-01 02:17:31 +03:00
Tiger Oakes 764c606030 Bug 1605688 - Strip alpha when opaque, r=jdescottes,ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D76062
2020-06-30 14:49:42 +00:00
Itiel 209c8f3f55 Bug 1641271 - Fix the icons for dark mode in the Service Workers in the Application panel r=ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D77101
2020-06-05 15:46:19 +00:00