Commit Graph
1190 Commits
Author SHA1 Message Date
Alexandre Poirot be63276971 Bug 1770282 - [devtools] Fix browser_toolbox_toolbar_overflow_button_visibility.js intermittent. r=devtools-reviewers,nchevobbe
This is MacOS specific.

Differential Revision: https://phabricator.services.mozilla.com/D210899
2024-05-20 16:03:25 +00:00
Andrew Halberstadt a680bcd3e1 Bug 1868440 - [ci] Upgrade taskcluster-taskgraph to v7.4.0, r=perftest-reviewers,geckoview-reviewers,ci-and-tooling,devtools-reviewers,taskgraph-reviewers,releng-reviewers,mach-reviewers,omc-reviewers,jmaher,hneiva,aminomancer,jari,dom-storage-reviewers,afinder,asuth,bhearsum,owlish
Differential Revision: https://phabricator.services.mozilla.com/D206260
2024-04-18 20:39:09 +00:00
Stanca Serban 3dbb534055 Backed out 2 changesets (bug 1868440) for gecko decision task broken. CLOSED TREE
Backed out changeset 4b22948d849a (bug 1868440)
Backed out changeset 837bdcb3694a (bug 1868440)
2024-04-18 21:25:43 +03:00
Andrew Halberstadt ef4f1e168b Bug 1868440 - [ci] Upgrade taskcluster-taskgraph to v7.4.0, r=perftest-reviewers,geckoview-reviewers,ci-and-tooling,devtools-reviewers,taskgraph-reviewers,releng-reviewers,mach-reviewers,omc-reviewers,jmaher,hneiva,aminomancer,jari,dom-storage-reviewers,afinder,asuth,bhearsum,owlish
Differential Revision: https://phabricator.services.mozilla.com/D206260
2024-04-18 17:50:50 +00:00
Yi Xiong Wong bef11a2dc2 Bug 1880914 - Move browser/tab closing functions. r=Gijs,perftest-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,sfoster,kshampur
Differential Revision: https://phabricator.services.mozilla.com/D206197
2024-04-08 17:21:01 +00:00
Alexandre Poirot 6c428aaabd Bug 1866814 - [devtools] Merge all DevTools JS Actors into a single DOM Process JS Actor. r=devtools-reviewers,nchevobbe
* The formers JSWindow Actors used independently to create Target Actor for WindowGlobals, Web workers and Service workers
  are all unified behind a single JSProcess Actor pair which was only used to create target actors for DOM Content Processes.
* The DevToolsProcess JSProcess actor now actively monitor the currently watched target types
  in order to start and stop listeners specific to each target type.
  We no longer rely on JSWindow Actors to observe WindowGlobal instantiations.

* `watchedByDevTools` is now consistantly set from each WindowGlobal's content process, via the WindowGlobalTargetActor.
  With the new setup, the parent process no longer track WindowGlobal/BrowsingContext's and so there is no
  natural place to flag them. While, in the content process, the target actor is an obvious place.
  There is just one trick in window global target watcher in order to also set this flag on initial about blank documents.

* `browser-element-host` Session Data is now slightly more simple. It works like any other similar session data attribute.
  But we have to ignore any pending exception coming up from updateDomainSessionDataForServiceWorkers call as that be still pending
  while the toolbox closes, which make the JS Process Actor be unregistered,
  and ultimately make the underlying sendQuery promise be rejected.
* The `loader` is made specific to each Watcher/connection and put in the connections map,
  so that we can better support content toolbox & browser toolbox usecases
  and we have a unique place to define the loader per watcher/connection.

* browser_target_command_detach.js: detach is no longer enough. It wouldn't stop watching and prevent the re-instantiation
  of the target actor. We now have to stop watching for targets. This actually better match what happens on toolbox closing.
  This test was meant as a unit test for covering remote debugging reusing the same DevToolsClient for debugger the same tab.
* `browser_toolbox_watchedByDevTools`. The management of watchedByDevTools is now driven from the content process.
  And because the DevTools Server and especially the watcher actor is destroyed without an explicit RDP request
  that the toolbox destruction is waiting for, we can't rely on closeToolbox to know
  when the server is fully cleaned up.

Differential Revision: https://phabricator.services.mozilla.com/D203409
2024-04-02 08:54:51 +00:00
Cristian Tuns db7b2a330c Backed out 3 changesets (bug 1866814) for causing bc failures browser_ext_devtools_inspectedWindow_targetSwitch.js CLOSED TREE
Backed out changeset 5d59dd808307 (bug 1866814)
Backed out changeset f503f5d02d1e (bug 1866814)
Backed out changeset d27f783be149 (bug 1866814)
2024-03-28 08:37:11 -04:00
Alexandre Poirot ee299a8d02 Bug 1866814 - [devtools] Merge all DevTools JS Actors into a single DOM Process JS Actor. r=devtools-reviewers,nchevobbe
* The formers JSWindow Actors used independently to create Target Actor for WindowGlobals, Web workers and Service workers
  are all unified behind a single JSProcess Actor pair which was only used to create target actors for DOM Content Processes.
* The DevToolsProcess JSProcess actor now actively monitor the currently watched target types
  in order to start and stop listeners specific to each target type.
  We no longer rely on JSWindow Actors to observe WindowGlobal instantiations.

* `watchedByDevTools` is now consistantly set from each WindowGlobal's content process, via the WindowGlobalTargetActor.
  With the new setup, the parent process no longer track WindowGlobal/BrowsingContext's and so there is no
  natural place to flag them. While, in the content process, the target actor is an obvious place.
  There is just one trick in window global target watcher in order to also set this flag on initial about blank documents.

* `browser-element-host` Session Data is now slightly more simple. It works like any other similar session data attribute.
  But we have to ignore any pending exception coming up from updateDomainSessionDataForServiceWorkers call as that be still pending
  while the toolbox closes, which make the JS Process Actor be unregistered,
  and ultimately make the underlying sendQuery promise be rejected.
* The `loader` is made specific to each Watcher/connection and put in the connections map,
  so that we can better support content toolbox & browser toolbox usecases
  and we have a unique place to define the loader per watcher/connection.

* browser_target_command_detach.js: detach is no longer enough. It wouldn't stop watching and prevent the re-instantiation
  of the target actor. We now have to stop watching for targets. This actually better match what happens on toolbox closing.
  This test was meant as a unit test for covering remote debugging reusing the same DevToolsClient for debugger the same tab.
* `browser_toolbox_watchedByDevTools`. The management of watchedByDevTools is now driven from the content process.
  And because the DevTools Server and especially the watcher actor is destroyed without an explicit RDP request
  that the toolbox destruction is waiting for, we can't rely on closeToolbox to know
  when the server is fully cleaned up.

Differential Revision: https://phabricator.services.mozilla.com/D203409
2024-03-28 10:47:17 +00:00
artem manushenkov 0c607a8763 Bug 1731635 [devtools] Add option to disable split console r=nchevobbe,fluent-reviewers,devtools-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D204142
2024-03-27 06:34:50 +00:00
Emilio Cobos Álvarez 1c20c25eda Bug 232598 - Return null for unset attributes in XUL. r=smaug,devtools-reviewers,omc-reviewers,zombie,nchevobbe,settings-reviewers,application-update-reviewers,credential-management-reviewers,mossop,aminomancer,bytesized,issammani,sessionstore-reviewers,dao
I just got bit by this in bug 1873833, let's just fix it. There isn't
all that much stuff depending on it anymore.

Differential Revision: https://phabricator.services.mozilla.com/D204496
2024-03-18 09:15:07 +00:00
artem manushenkov 0f7d9b6173 Bug 1763961 [devtools] Make unchecking "Pick an element from the page" in "Available Toolbox Buttons" disable hotkey for opening element picker/inspector r=jdescottes,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D203948
2024-03-13 12:47:28 +00:00
Dave Townsend 2af4d349f3 Bug 1864896: Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
Differential Revision: https://phabricator.services.mozilla.com/D202959
2024-03-05 14:21:15 +00:00
Alexandre Poirot 28d867992f Bug 1881141 - [devtools] Factorize code around target and thread configuration management. r=devtools-reviewers,nchevobbe
This should help connect preferences to server's target configurations.
Once we get rid of thread's actor attach sequence, we may be able to also fold the getThreadOptions's preferences into this new system.

Differential Revision: https://phabricator.services.mozilla.com/D202277
2024-02-21 22:04:17 +00:00
Gijs Kruitbosch b33d5685da Bug 1780071 - Manual fixes/disabling of no-comparison-or-assignment-inside-ok for exceptional cases, r=Standard8,devtools-reviewers,anti-tracking-reviewers,places-reviewers,dom-storage-reviewers,pbz,asuth,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D198979
2024-02-19 23:30:40 +00:00
Gijs Kruitbosch 3288f177a4 Bug 1780071 - autofix devtools/ violations of no-comparison-or-assignment-inside-ok r=profiler-reviewers,devtools-reviewers,julienw,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D198975
2024-01-26 13:12:07 +00:00
Joel Maher 3662d84cd4 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-25 00:27:05 +00:00
Stanca Serban 71d0d5cf96 Backed out changeset 54462970f797 (bug 1873732) for causing web platform tests failures. 2024-01-24 21:08:19 +02:00
Joel Maher 04ec786571 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-24 16:35:54 +00:00
Alexandre Poirot b90fb2709b Bug 1767760 - [devtools] Avoid intermittend on browser_target_parents.js. r=jdescottes,devtools-reviewers
Some workers running in the parent process might be initializating or destroying
and their target front won't be fully populated.
This test is brittle as it interact with any firefox parent process worker.
As we don't control them from the test they may be in arbitrary state.

Differential Revision: https://phabricator.services.mozilla.com/D197092
2024-01-03 17:39:13 +00:00
Alexandre Poirot 011905c3b8 Bug 1868571 - [devtools] Run two blank runs before starting memory tracking test. r=devtools-reviewers,nchevobbe
For some reason, the debugger has a different behavior the second time it opens
compared to its very first opening. So that distinct React elements are instantiated
and are then reported as leaks...

Differential Revision: https://phabricator.services.mozilla.com/D196191
2023-12-13 16:10:50 +00:00
Joel Maher cac31d18e3 Bug 1859873 - batch 13 xpcshell.ini -> .toml. r=aryx,devtools-reviewers,profiler-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D194161
2023-11-21 12:32:50 +00:00
Anna Yeddi 1ff2d7d161 Bug 1863584 - Remove skip-if for a11y_checks that previously crashed with @ mozilla::detail::InvalidArrayIndex r=Gijs,Standard8
We had to skip-if those tests that were crashing during a11y_checks and since the bug 1849230 is resolved now these test can be re-enabled (whenever possible). Two tests have also been failing intermittently, thus they are remaining skipped, but the comment is updated to remove the mention of the crash.

Differential Revision: https://phabricator.services.mozilla.com/D193230
2023-11-11 10:47:21 +00:00
Anna Yeddi fcae49bef3 Bug 1858041 - Pt.4. Temporarily skip some Tier 2 a11y_checks for unexpecredly failing/passing or crashing on Autoland. r=devtools-reviewers,credential-management-reviewers,issammani
There are some a11y_checks that are intermittently failing on Autoland and pass on Try and vice versa. Also, a couple of tests are crashing while performing a11y_checks, thus they are to be skipped while we continue the investigation into each of them.

Related bugs:
- Fail-if tests: meta bug 1848402
- Explore capturing click events for a11y_checks: bug 1692110

Differential Revision: https://phabricator.services.mozilla.com/D192086
2023-10-31 17:20:39 +00:00
Tom Marble a2de3b16d5 Bug 1859905 - convert .ini manifests to .toml: batch 19 browser_*.ini r=jmaher,webdriver-reviewers,necko-reviewers,extension-reviewers,devtools-reviewers,anti-tracking-reviewers,valentin,robwu,pbz
Differential Revision: https://phabricator.services.mozilla.com/D191771
2023-10-25 21:47:25 +00:00
Natalia Csoregi 2f242d6035 Backed out changeset 1ca403a2c00e (bug 1859905) for causing failures on test_mochitest_integration.py CLOSED TREE 2023-10-25 22:26:24 +03:00
Tom Marble 622224fb99 Bug 1859905 - convert .ini manifests to .toml: batch 19 browser_*.ini r=jmaher,webdriver-reviewers,necko-reviewers,extension-reviewers,devtools-reviewers,anti-tracking-reviewers,valentin,robwu,pbz
Differential Revision: https://phabricator.services.mozilla.com/D191771
2023-10-25 17:12:24 +00:00
Mark Banner cc2be2ea34 Bug 1858673 - Remove now unnecessary disabling of ESLint no-unsanitized/* rules from test files. r=freddyb,media-playback-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,places-reviewers,aosmond,sgalich,dao,padenot
Differential Revision: https://phabricator.services.mozilla.com/D190985
2023-10-24 08:48:41 +00:00
Dave Townsend 22522ed709 Bug 1857999: Devtools should always inject additional stylesheets as link elements. r=ochameau,devtools-reviewers
Improves the logic to always insert stylesheets as link elements regardless of
whether it is into a html document or not. In order for the ordering to be
correct the insertion must occur after existing link elements in the document
have been parsed so the `theme-switching.js` script must always be loaded after
link elements. The storage client appears to be the only existing document where
that wasn't already the case.

Differential Revision: https://phabricator.services.mozilla.com/D190797
2023-10-18 07:04:41 +00:00
Sandor Molnar 099f0fd4c3 Backed out 4 changesets (bug 1857999) for causing dt failures on browser_theme_switching.js & Mn failures at test_element_state_chrome.py CLOSED TREE
Backed out changeset 75f5e6e3d917 (bug 1857999)
Backed out changeset 0d0c1d1e80e7 (bug 1857999)
Backed out changeset b8a03d31ecea (bug 1857999)
Backed out changeset dd5a10f9cfff (bug 1857999)
2023-10-16 14:12:22 +03:00
Dave Townsend a8dfbf56a3 Bug 1857999: Devtools should always inject additional stylesheets as link elements. r=ochameau,devtools-reviewers
Improves the logic to always insert stylesheets as link elements regardless of
whether it is into a html document or not. In order for the ordering to be
correct the insertion must occur after existing link elements in the document
have been parsed so the `theme-switching.js` script must always be loaded after
link elements. The storage client appears to be the only existing document where
that wasn't already the case.

Differential Revision: https://phabricator.services.mozilla.com/D190797
2023-10-16 09:43:25 +00:00
Anna Yeddi fa882e1cf5 Bug 1849021 - Temporarily disable some Tier 2 a11y_checks for DevTools that cause crashes. r=devtools-reviewers,profiler-reviewers,nchevobbe,julienw
There are two main types of crashes that are tracked separately:
1. `application crashed [@ mozilla::detail::InvalidArrayIndex_CRASH]` that is tracked in bug 1849230
2. `application crashed [@ operator==<mozilla::a11y::LocalAccessible, mozilla::a11y::LocalAccessible>]` that is tracked in bug 1849179

Skipping the tests that have crashed on Try more than once during the bug 1849021 work until the intermittent issues are resolved.

Depends on D186405

Differential Revision: https://phabricator.services.mozilla.com/D190139
2023-10-09 18:20:23 +00:00
Anna Yeddi e1ba7c0b2e Bug 1849021 - Temporarily fail-if some Tier 2 a11y_checks for DevTools while the larger a11y improvement work is in progress. r=Jamie,devtools-reviewers,nchevobbe,profiler-reviewers,julienw
Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests were temporarily fail-if'ed in the directory's browser.ini file. After the ongoing accessibility improvements work is completed, we'll need to re-run a11y-checks, investigate new failures, and for confirmed bugs individual defects should be filed.

When the individual test failures are resolved and the individual bugs are closed, remove the fail-if condition for a11y_checks from the appropriate files/sections to ensure better test coverage and to avoid regressions in a11y of these components.

Depends on D189007

Differential Revision: https://phabricator.services.mozilla.com/D186405
2023-10-09 18:20:23 +00:00
Cristian Tuns 896197e59e Backed out 30 changesets (bug 1854447, bug 1855491, bug 1854646, bug 1854520, bug 1854528, bug 1854506, bug 1854502, bug 1854443, bug 1854538, bug 1854525, bug 1854660, bug 1854514, bug 1854460, bug 1854625, bug 1854228, bug 1854517, bug 1854533, bug 1692110, bug 1854636, bug 1849021, bug 1854512, bug 1854522, bug 1854509, bug 1854452, bug 1854536, bug 1854531) for causing multiple tier 2 failures on a11y-checks. CLOSED TREE
Backed out changeset 5714b7239b70 (bug 1849021)
Backed out changeset 91e5d7de3484 (bug 1849021)
Backed out changeset cc3142b909f6 (bug 1854660)
Backed out changeset 76d2a8ae9c19 (bug 1854646)
Backed out changeset 36460a147684 (bug 1854636)
Backed out changeset c7529a962a8c (bug 1854625)
Backed out changeset 791f9b03ea96 (bug 1854538)
Backed out changeset bd3f3cb434a5 (bug 1854536)
Backed out changeset 16f4f5bdcaa7 (bug 1855491)
Backed out changeset 6258bab20196 (bug 1854533)
Backed out changeset 29dca16eee2e (bug 1854531)
Backed out changeset 3a69d2c3f562 (bug 1854528)
Backed out changeset 0c63a9ea8b34 (bug 1854525)
Backed out changeset 5795bb6187a5 (bug 1854522)
Backed out changeset 7d4a123a432f (bug 1854520)
Backed out changeset ec95287bd702 (bug 1854517)
Backed out changeset 9914c1481f0d (bug 1854514)
Backed out changeset 25d85e656905 (bug 1854512)
Backed out changeset 828657f2ab73 (bug 1854509)
Backed out changeset 9d8b2e14c375 (bug 1854506)
Backed out changeset 1b3ee1e46e12 (bug 1854502)
Backed out changeset 37c2ec0851dc (bug 1854460)
Backed out changeset c2a60a8fc2d3 (bug 1854452)
Backed out changeset 744a163f2bd1 (bug 1854447)
Backed out changeset 1a9629dae7d5 (bug 1854443)
Backed out changeset c3d5c1ba2a84 (bug 1854228)
Backed out changeset dcd05518b004 (bug 1692110)
Backed out changeset 1c65a4cb618c (bug 1692110)
Backed out changeset 603b891147bd (bug 1692110)
Backed out changeset 53e2fac79d84 (bug 1692110)
2023-10-07 14:43:05 -04:00
Anna Yeddi 083acf985a Bug 1849021 - Temporarily disable some Tier 2 a11y_checks for DevTools that cause crashes. r=devtools-reviewers,profiler-reviewers,nchevobbe,julienw
There are two main types of crashes that are tracked separately:
1. `application crashed [@ mozilla::detail::InvalidArrayIndex_CRASH]` that is tracked in bug 1849230
2. `application crashed [@ operator==<mozilla::a11y::LocalAccessible, mozilla::a11y::LocalAccessible>]` that is tracked in bug 1849179

Skipping the tests that have crashed on Try more than once during the bug 1849021 work until the intermittent issues are resolved.

Depends on D186405

Differential Revision: https://phabricator.services.mozilla.com/D190139
2023-10-06 18:11:41 +00:00
Anna Yeddi f069716c4e Bug 1849021 - Temporarily disable some Tier 2 a11y_checks for DevTools while the larger a11y improvement work is in progress. r=Jamie,devtools-reviewers,nchevobbe,profiler-reviewers,julienw
Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests were temporarily skipped in the directory's browser.ini file. After the ongoing accessibility improvements work is completed, we'll need to re-run a11y-checks, investigate new failures, and for confirmed bugs individual defects should be filed.

When the individual test failures are resolved and the individual bugs are closed, remove the fail-if condition for a11y_checks from the appropriate files/sections to ensure better test coverage and to avoid regressions in a11y of these components.

Differential Revision: https://phabricator.services.mozilla.com/D186405
2023-10-06 18:11:40 +00:00
Nicolas Chevobbe 34cdb11876 Bug 1843309 - [devtools] Add aria-pressed attribute on toolbox toggle buttons. r=devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D189741
2023-10-03 04:59:03 +00:00
Tom Marble 6c1231e2e8 Bug 1853244 - convert .ini manifests to .toml: batch 6 {caps,devtools,dom}/**/browser.ini r=jmaher,media-playback-reviewers,devtools-reviewers,profiler-reviewers,alwu,nchevobbe,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D188856
2023-09-22 20:42:14 +00:00
Marco Bonardo 6874dffc71 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-15 09:16:34 +00:00
Sandor Molnar 5d8dd001ad Backed out 3 changesets (bug 1852963) for causing remote failures on remote/shared/messagehandler/test/browser/browser_session_data.js CLOSED TREE
Backed out changeset 98de7bc404c3 (bug 1852963)
Backed out changeset edf1527c9a99 (bug 1852963)
Backed out changeset 34357750f69c (bug 1852963)
2023-09-14 20:29:06 +03:00
Marco Bonardo c5fb3dbb49 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-14 16:33:13 +00:00
Alexandre Poirot 140d755231 Bug 1845768 - [devtools] Only try to open URL as JS files in debugger/view-source if DevTools are opened in the current tab. r=devtools-reviewers,perftest-reviewers,jdescottes,sparky
This will prevent opening any links with the ":\d+" suffix anytime devtools were opened in the past.

Differential Revision: https://phabricator.services.mozilla.com/D185826
2023-08-21 08:01:36 +00:00
Gregory Pappas a57c4f9405 Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D184623
2023-08-01 23:01:02 +00:00
Julian Descottes 89db250d07 Bug 1767760 - [devtools] Check workerDescriptorFront.isDestroyed in browser_target_parents.js r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D184555
2023-07-26 12:55:02 +00:00
Kershaw Chang 8c73084fff Bug 1838829 - Skip failed tests, r=necko-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,dimi,valentin,robwu
Differential Revision: https://phabricator.services.mozilla.com/D181251
2023-06-28 13:21:00 +00:00
Norisz Fay a17cc174f1 Backed out 2 changesets (bug 1838829) for causing perma mochitest failure with dom/websocket/tests being skipped CLOSED TREE
Backed out changeset 19a5d4f1850a (bug 1838829)
Backed out changeset 97cd8a256954 (bug 1838829)
2023-06-27 02:52:52 +03:00
Kershaw Chang 49115434d9 Bug 1838829 - Skip failed tests, r=necko-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,dimi,valentin,robwu
Differential Revision: https://phabricator.services.mozilla.com/D181251
2023-06-26 14:22:14 +00:00
Norisz Fay da37f6c50c Backed out 5 changesets (bug 1838829) for causing mochitest failures CLOSED TREE
Backed out changeset 693d34c8447d (bug 1838829)
Backed out changeset 903d9ff4afaa (bug 1838829)
Backed out changeset 5e51feff7467 (bug 1838829)
Backed out changeset e125be49d2a6 (bug 1838829)
Backed out changeset 1a8cf3c83dc4 (bug 1838829)
2023-06-22 03:37:07 +03:00
Kershaw Chang 8ae645cecc Bug 1838829 - Skip failed tests, r=necko-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,dimi,valentin,robwu
Differential Revision: https://phabricator.services.mozilla.com/D181251
2023-06-21 19:43:33 +00:00
Alexandre Poirot c42905da36 Bug 1838443 - [devtools] Move preview data from redux store to react state. r=devtools-reviewers,perftest-reviewers,sparky,bomsy
This data is transient and only specific to the Editor's index react component.
There is no need to share nor persist this data in Redux,
this would avoid unecessary complexity/layers and avoid a few state updates.

Note that the target.match(:hover) was probably a poorly documented way to prevent
rending preview for token that are no longer hovered (the comment about whitespace sounds weird).

Also tweak waitForSelectedSource to also wait for CodeMirror to be updated.
Otherwise, we might try to hover tokens while CodeMirror is still udpating...
While doing that, use the L10N string instead of the final localized string.

Differential Revision: https://phabricator.services.mozilla.com/D180992
2023-06-19 17:18:27 +00:00
Julian Descottes 2e75e17301 Bug 1836046 - [devtools] Remove the enable devtools popup for the F12 experiment r=devtools-reviewers,desktop-theme-reviewers,fluent-reviewers,flod,dao,ochameau
We will add another onboarding popup in the future, but we should first remove this old unused UI for the F12 experiment.

Differential Revision: https://phabricator.services.mozilla.com/D179664
2023-06-08 17:41:27 +00:00