Commit Graph
36 Commits
Author SHA1 Message Date
Alexandre Poirot c42905da36 Bug 1838443 - [devtools] Move preview data from redux store to react state. r=devtools-reviewers,perftest-reviewers,sparky,bomsy
This data is transient and only specific to the Editor's index react component.
There is no need to share nor persist this data in Redux,
this would avoid unecessary complexity/layers and avoid a few state updates.

Note that the target.match(:hover) was probably a poorly documented way to prevent
rending preview for token that are no longer hovered (the comment about whitespace sounds weird).

Also tweak waitForSelectedSource to also wait for CodeMirror to be updated.
Otherwise, we might try to hover tokens while CodeMirror is still udpating...
While doing that, use the L10N string instead of the final localized string.

Differential Revision: https://phabricator.services.mozilla.com/D180992
2023-06-19 17:18:27 +00:00
Mark Banner 91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Emilio Cobos Álvarez 82ee3ddc29 Bug 1817381 - Ignore OS zoom in devtools. r=devtools-reviewers,nchevobbe
What devtools wants to do is ignoring the website-specific zoom.

It seems KDE 5.27 on X11 uses the text scale factor to implement scaling
of GTK apps completely (including Firefox), rather than the global
integer GTK scaling combined with it.

This makes this difference way more obvious than it otherwise would.

Differential Revision: https://phabricator.services.mozilla.com/D170195
2023-02-20 16:35:04 +00:00
Cristina Horotan fbc15256c2 Backed out changeset 9d6e541704c3 (bug 1817381) for causing multiple dt failures on a CLOSED TREE 2023-02-20 11:00:48 +02:00
Emilio Cobos Álvarez a02f063ed4 Bug 1817381 - Ignore OS zoom in devtools. r=devtools-reviewers,nchevobbe
What devtools wants to do is ignoring the website-specific zoom.

It seems KDE 5.27 on X11 uses the text scale factor to implement scaling
of GTK apps completely (including Firefox), rather than the global
integer GTK scaling combined with it.

This makes this difference way more obvious than it otherwise would.

Differential Revision: https://phabricator.services.mozilla.com/D170195
2023-02-20 08:01:42 +00:00
Alexandre Poirot 9beeb07755 Bug 1792847 - [devtools] Use absolute URLs to import modules in devtools/client/framework. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D158373
2022-09-30 15:17:36 +00:00
Julian Descottes bfb875751c Bug 1694140 - [devtools] Stop using TargetFactory forTab in devtools browser mochitests r=nchevobbe
Depends on D105999

This patch is mostly a mechanical rewrite of:
```lang=javascript
const target = await TargetFactory.forTab(tab);
const toolbox = await gDevTools.showToolbox(target, "inspector");
```
to
```lang=javascript
const toolbox = await gDevTools.showToolboxForTab(tab, { toolId: "inspector" });
```

The main changes are:
- if the target was actually used in the test, it is now retrieved from toolbox.target
- the arguments for showToolboxForTab are using an option argument, to avoid the occasional showToolbox("inspector", null, null, null, startTime, null, reason);

I suspect that any signature rewrite mistake would have been caught on try.
There a few less mechanical changes:
- devtools/client/framework/test/browser_toolbox_screenshot_tool.js the toolId "console" was omitted because this id doesn't match any tool (author probably meant "webconsole")
- a few tests were: 1/ first creating a target, 2/ looping on tool definitions to get supported tools 3/ opening the toolbox with each supported tool. To support this I extracted a helper called `getSupportedToolIds` which opens a temporary toolbox to list all supported tool ids
- all the tests under storage/ use a single helper to start the test, which can open toolboxes for both tab targets and other targets. This made it more complicated to refactor. We could also drop this part and just refactor each test when we actually modify forTab/showToolbox to only work with descriptors

All in all the goal of this stack is to pave the way to stop handling targets when using forTab/showToolbox, and behind the scenes stop replying on targets to cache open toolboxes. We don't aim to kill all the call sites, just get them to a smaller number so that the next refactors will be easier.

Differential Revision: https://phabricator.services.mozilla.com/D106000
2021-02-25 18:02:52 +00:00
Brindusan Cristian ae215d4017 Backed out 10 changesets (bug 1694140, bug 1694886, bug 1688688) for devtools failures on browser_CORS-console-warnings.js. CLOSED TREE
Backed out changeset 1b7367a27d9a (bug 1694886)
Backed out changeset d5a70a3143ad (bug 1694140)
Backed out changeset 74adaced5c0a (bug 1694140)
Backed out changeset 0b8f857e3f90 (bug 1694140)
Backed out changeset 45a8dc952aba (bug 1694140)
Backed out changeset 299f17e9cb6f (bug 1694140)
Backed out changeset 6beb9dd48ef3 (bug 1694140)
Backed out changeset 5f6688e8fe4c (bug 1694140)
Backed out changeset ae1fa0484c91 (bug 1688688)
Backed out changeset 8a0f5c24ed9a (bug 1688688)
2021-02-25 16:07:39 +02:00
Julian Descottes ad1b3020e8 Bug 1694140 - [devtools] Stop using TargetFactory forTab in devtools browser mochitests r=nchevobbe
Depends on D105999

This patch is mostly a mechanical rewrite of:
```lang=javascript
const target = await TargetFactory.forTab(tab);
const toolbox = await gDevTools.showToolbox(target, "inspector");
```
to
```lang=javascript
const toolbox = await gDevTools.showToolboxForTab(tab, { toolId: "inspector" });
```

The main changes are:
- if the target was actually used in the test, it is now retrieved from toolbox.target
- the arguments for showToolboxForTab are using an option argument, to avoid the occasional showToolbox("inspector", null, null, null, startTime, null, reason);

I suspect that any signature rewrite mistake would have been caught on try.
There a few less mechanical changes:
- devtools/client/framework/test/browser_toolbox_screenshot_tool.js the toolId "console" was omitted because this id doesn't match any tool (author probably meant "webconsole")
- a few tests were: 1/ first creating a target, 2/ looping on tool definitions to get supported tools 3/ opening the toolbox with each supported tool. To support this I extracted a helper called `getSupportedToolIds` which opens a temporary toolbox to list all supported tool ids
- all the tests under storage/ use a single helper to start the test, which can open toolboxes for both tab targets and other targets. This made it more complicated to refactor. We could also drop this part and just refactor each test when we actually modify forTab/showToolbox to only work with descriptors

All in all the goal of this stack is to pave the way to stop handling targets when using forTab/showToolbox, and behind the scenes stop replying on targets to cache open toolboxes. We don't aim to kill all the call sites, just get them to a smaller number so that the next refactors will be easier.

Differential Revision: https://phabricator.services.mozilla.com/D106000
2021-02-25 12:58:14 +00:00
Joel Maher b6788b7287 Bug 1652440 - adjust devtools to work with object.is() instead of ==. r=rcaliman,jdescottes
adjust devtools to work with object.is() instead of ==

Differential Revision: https://phabricator.services.mozilla.com/D83302
2020-07-22 14:53:16 +00:00
Victor Porof b7732ae890 Bug 1561435 - Format devtools/client/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35884
2019-07-05 11:24:38 +02:00
Alexandre Poirot 0ccb191bef Bug 1485676 - Connect to local server from TargetFactory.forTab and make TabTarget always remote-like. r=yulia
Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4078

MozReview-Commit-ID: JAwiySsBZBu
2018-09-24 09:52:55 -07:00
shindli dbbcc1c04f Backed out 9 changesets (bug 1485676) for failures in browser/tools/mozscreenshots/devtools/browser_devtools.js CLOSED TREE
Backed out changeset d358feec4ca1 (bug 1485676)
Backed out changeset ed554dbb062f (bug 1485676)
Backed out changeset 6e78058df94d (bug 1485676)
Backed out changeset 3a6f1b0e71f4 (bug 1485676)
Backed out changeset 16d2403aa787 (bug 1485676)
Backed out changeset 454eddf52157 (bug 1485676)
Backed out changeset 926f725f2183 (bug 1485676)
Backed out changeset fb03f174bd5f (bug 1485676)
Backed out changeset ceb93dd1799a (bug 1485676)
2018-09-24 15:27:27 +03:00
Alexandre Poirot ded1511af6 Bug 1485676 - Connect to local server from TargetFactory.forTab and make TabTarget always remote-like. r=yulia
Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4078

MozReview-Commit-ID: JAwiySsBZBu
2018-09-24 01:25:01 -07:00
Gurzau Raul a532c08398 Backed out 9 changesets (bug 1485676) for failing at damp inspector/cold-open.js on a CLOSED TREE
Backed out changeset 4de2e71debfe (bug 1485676)
Backed out changeset e63025150c7a (bug 1485676)
Backed out changeset f9ef30ae3f7f (bug 1485676)
Backed out changeset a83636fab16a (bug 1485676)
Backed out changeset b1fd24929e09 (bug 1485676)
Backed out changeset acb27b915742 (bug 1485676)
Backed out changeset ba2157632772 (bug 1485676)
Backed out changeset d1d6b9bc2372 (bug 1485676)
Backed out changeset d7646ea8640b (bug 1485676)
2018-09-22 19:42:04 +03:00
Alexandre Poirot a9337c9d24 Bug 1485676 - Connect to local server from TargetFactory.forTab and make TabTarget always remote-like. r=yulia
Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4078

MozReview-Commit-ID: JAwiySsBZBu
2018-09-22 08:34:20 -07:00
arthur.iakab 12a839773f Backed out 9 changesets (bug 1485676)for perma failures in devtools/client/canvasdebugger/test/browser_canvas-actor-test-01.js CLOSED TREE
Backed out changeset 9f5ec2aa7109 (bug 1485676)
Backed out changeset 0d530c1316a4 (bug 1485676)
Backed out changeset 03278e6fe685 (bug 1485676)
Backed out changeset 275463260056 (bug 1485676)
Backed out changeset 4c5a956b33f7 (bug 1485676)
Backed out changeset d8fe80bb0e3c (bug 1485676)
Backed out changeset 56240996921f (bug 1485676)
Backed out changeset ec0a322f5cc9 (bug 1485676)
Backed out changeset f0f4f9407970 (bug 1485676)
2018-09-21 12:48:48 +03:00
Alexandre Poirot 6bdb907e8d Bug 1485676 - Connect to local server from TargetFactory.forTab and make TabTarget always remote-like. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D4078
2018-09-21 08:07:48 +00:00
Boris Zbarsky 3af9dccacb Bug 1476145 part 4. Stop using getInterface(nsIDOMWindowUtils) in devtools. r=bgrins 2018-07-24 19:47:41 -04:00
Julian Descottes 82711b9a8f Bug 1454696 - Run eslint --fix for prefer-const;r=yulia
MozReview-Commit-ID: F6xUXCgdRE4
2018-06-01 12:36:09 +02:00
Mantaroh Yoshinaga b309084887 Bug 1455462 - Part 5. Add toolbox's menu position test. r=jdescottes
This test will check that popup menu of toolbox will be displayed under the
menu button. This test tolerates an error since some platform (like macOS)
will add the offset value. (i.e. eIntID_ContextMenuOffsetHorizontal and
eIntID_ContextMenuOffsetVertical)

MozReview-Commit-ID: 5TaM5JiNhdk
2018-05-11 09:31:58 +09:00
Mantaroh Yoshinaga eba12dc476 Bug 1455462 - Part 4. Use the async_task in devtool's zoom test. r=jdescottes
This patch will change test to use the async_task before touching this tests and
use the first decimal place when checking a result.

MozReview-Commit-ID: DBkvLtEmEa3
2018-05-11 09:08:09 +09:00
Mark Banner 963b2a1b45 Bug 1451659 - Automated ESLint fixes for devtools/client/framework/. r=jdescottes
MozReview-Commit-ID: 26jRtf8ZzTr
2018-04-04 22:10:09 +01:00
Tom Tromey 1976c3df85 Bug 1312041 - remove requireRawId rewriting in favor of Loader paths; r=jryans
MozReview-Commit-ID: 6OSszbKpp74
2016-10-25 21:30:18 -06:00
Wes Kocher 20d9f9713d Backed out 2 changesets (bug 1312041) for mass failures a=backout
Backed out changeset c4f42d7d5453 (bug 1312041)
Backed out changeset 9bfbc8480d43 (bug 1312041)
2016-11-01 10:30:45 -07:00
Tom Tromey d1b2d82846 Bug 1312041 - remove requireRawId rewriting in favor of Loader paths; r=jryans
MozReview-Commit-ID: 6OSszbKpp74
2016-10-25 21:30:18 -06:00
Alexandre Poirot 35acaa9d89 Bug 1298082 - Replace toolbox.frame usages with equivalents around toolbox.win. r=jryans
MozReview-Commit-ID: ClpBWEZbKq1
2016-08-30 06:42:25 -07:00
Julian Descottes dfd3d00d61 Bug 1295610 - Migrate devtools/client/framework to use l10n.js instead of Services.string;r=tromey
MozReview-Commit-ID: BwcfFPf85hu
2016-08-19 20:02:15 +02:00
Alexandre Poirot 51346cf61c Bug 1268447 - Convert webconsole to use new key shortcut module. r=bgrins 2016-05-31 14:17:03 -07:00
Alexandre Poirot 9ba9816597 Bug 1268450 - Convert toolbox key shortcut to stop using XUL. r=jryans 2016-05-25 08:31:05 -07:00
Ryan VanderMeulen 67f0d40a09 Backed out 3 changesets (bug 1268450) for browser_keybindings_03.js timeouts.
Backed out changeset 466d5c96f439 (bug 1268450)
Backed out changeset 9d79d99a3e18 (bug 1268450)
Backed out changeset 9090f1b3c2e4 (bug 1268450)
2016-05-19 22:48:37 -04:00
Alexandre Poirot a98861463d Bug 1268450 - Convert toolbox key shortcut to stop using XUL. r=jryans 2016-05-19 16:13:00 -04:00
J. Ryan Stinnett 530b903fcf Bug 1271084 - Apply ESLint autofixes to ignored /devtools files. r=tromey
For simple rules like function spacing, we can auto-fix these across the code
base so they are followed in a consistent way.

To generate this patch, I ran:

./mach eslint devtools --no-ignore --fix

After this, I reverted any changes to third party files that we really do want
to ignore.

MozReview-Commit-ID: 6Q8BApkAW20
2016-05-18 12:49:23 -05:00
Brian Grinstead 38a4f145c9 Bug 1269497 - Provide toolbox.win getter to make lines shorter in tests;r=jdescottes
MozReview-Commit-ID: 9KuWzsyHQGF
2016-05-03 07:41:20 -07:00
Lin Clark 93a502a1d1 Bug 1245667 - Use standard license boilerplate in framework js files. r=bgrins
MozReview-Commit-ID: 31xbv6rirPg
2016-02-16 16:14:53 -08:00
J. Ryan Stinnett a3073e0420 Bug 912121 - Migrate major DevTools directories. rs=devtools
Move major DevTools files to new directories using the following steps:

hg mv browser/devtools devtools/client
hg mv toolkit/devtools/server devtools/server
hg mv toolkit/devtools devtools/shared

No other changes are made.
2015-09-21 12:02:24 -05:00