This will help simplify all callsites manually setting this attribute.
I inlined simplification of all toolOpened/toolClosed in this changeset,
but all usages of recordEvent will be simplified in the next changeset.
Toolbox.sessionId is now only used by console performance markers in
order to help differentiate toolbox instances.
Note that about:debugging was also using a dedicated sessionId.
Differential Revision: https://phabricator.services.mozilla.com/D165935
This will help transition to ES Modules as this symbol is exposed to them.
$ sed -ie "/require(.Services.)/d" $(git grep -l 'require("Services")' devtools/)
$ sed -ie "/loader.lazyRequireGetter(this, .Services./d" $(git grep -l 'loader.lazyRequireGetter(this, "Services"' devtools/)
+ the edition of builtin-modules.js + eslintrc.js
+ manual eslint fixes
+ removal of devtools-services in the debugger, except for jest tests
Differential Revision: https://phabricator.services.mozilla.com/D156401
`WebConsoleConnectionProxy` is now only used for:
- listening to `lastPrivateContextExited`, which can be done from the top-level
console front instead
- setting `NetworkMonitor.saveRequestAndResponseBodies` for toolbox we don't have
network resource support for, which would be better done in `startWatchingNetworkResources`.
This means we don't need to keep a Map of additional proxies.
The only impact is on `clearMessagesCache`, where we now fetch all fronts with
`getAllFronts` instead of looping through the Map of additional proxies.
This change highlighted some race condition in tests, as it's now slightly slower.
So we add a new `clearMessagesCacheAsync` function, which is doing the same thing
as `clearMessagesCache`, except it's not `oneway`, so we can know when the cache
was indeed cleared, and we emit an event to indicate when the cache was cleared.
We can't simply remove `oneway` from `clearMessagesCache` as it causes backward
compatibility issues we can't avoid.
This also highlighted an issue with the cache not being cleared on `console.clear`
when it is batched, so we fix this (a test was failing without it).
The next patch in the queue will completely remove `WebConsoleConnectionProxy`.
Differential Revision: https://phabricator.services.mozilla.com/D150085
- we don't need to override WebConsole.currentTarget as it should pull the current top target via targetList instead of toolbox
- BrowserConsole constructor then no longer need to receive the target as argument
- and finally, BrowserConsoleManager can pass around the descriptor instead of the first target.
Differential Revision: https://phabricator.services.mozilla.com/D109493
At the moment, we don't have any guards in the targetList to _not_ execute the
creation/destruction listeners once the toolbox gets destroyed.
We only have a stopListening function on the targetList that is called when we
close the toolbox, but we can't rely only on that since it's also called when
doing a target switch (and working around that is very racy).
One solution would be to follow the common pattern we have everywhere by having
a destroy method that we would check before trying to call the listeners callback.
This might help with intermittent test failures.
Differential Revision: https://phabricator.services.mozilla.com/D88765
In the Browser toolbox destroy function, we now wait for
any pending connection initialization promise.
In the test we close the browser toolbox at the end.
We also need to guard a few method in the connection proxy
to ensure the instances we use are still alive before using
them.
Differential Revision: https://phabricator.services.mozilla.com/D71171
In the Browser toolbox destroy function, we now wait for
any pending connection initialization promise.
In the test we close the browser toolbox at the end.
We also need to guard a few method in the connection proxy
to ensure the instances we use are still alive before using
them.
Differential Revision: https://phabricator.services.mozilla.com/D71171
This demonstrates using the Resources API for the console messages,
using the existing actor methods. It helps proving that this will work against old runtimes.
But the plan is to followup in bug 1620243 so that we implement this code on the server side.
This will help getting rid of this LegacyImplementation code and have a simplier code on the server.
Differential Revision: https://phabricator.services.mozilla.com/D65526
Before, each callsite had to mention which type it would like to listen to.
But at the same time, TargetList was gating this listening via the devtools fission preference.
It sounds easier if all the logic to define if we are listening to additional targets
and which types is written in one place.
Differential Revision: https://phabricator.services.mozilla.com/D57009
We store the created DebuggerClient when opening the Browser Console
so we can close it when closing the Browser Console window.
The Browser Console window `unload` event listener is moved out of
the BrowserConsole class to the BrowserConsoleManager, so we can close
the DebuggerClient when the window is closed (plus it makes more sense
to have it here since that's where we create the window).
Finally, functions that were inlined in toggleBrowserConsole are moved
as method of the BrowserConsoleManager for clarity.
Differential Revision: https://phabricator.services.mozilla.com/D43930
We retrieve the preference in the hudservice, where
WebConsoles and BrowserConsoles are created from.
If the pref is set to true, we assign a different
title to the Browser Console window so it will be
easier to spot.
The preference is then passes to the BrowserConsole,
WebConsole, WebConsoleUI and finally WebConsoleConnectionProxy
instances.
Later, we'll check this pref to connect to different
targets and listen to new ones.
Depends on D39646
Differential Revision: https://phabricator.services.mozilla.com/D39647