Commit Graph
1692 Commits
Author SHA1 Message Date
Nicolas Chevobbe 7e3ff18292 Bug 1844446 - [devtools] Send rules matching selectors indexes instead of the selector strings. r=devtools-reviewers,bomsy.
This is done to avoid a performance issue with deeply nested rules,
where computing the desugared selector can be super expensive.
This should help overall since we're doing a bit less work, as well
as returning smaller data.

Differential Revision: https://phabricator.services.mozilla.com/D207727
2024-05-14 06:19:43 +00:00
Nicolas Chevobbe 9b1522fec0 Bug 1868732 - [devtools] Add tests for ::target-text pseudo elements. r=devtools-reviewers,bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D206507
2024-04-24 12:28:42 +00:00
Nathan LaPre a337b03937 Bug 1849160 - Part 4: Update tests in light of new ancestor role requirements, r=Jamie,devtools-reviewers,nchevobbe,geckoview-reviewers,ohall
This revision updates newly-failing tests after implementing the ancestor
requirements for certain child roles. Generally, this revision adds ancestors
where appropriate, because tests largely are not testing this particular
behavior.

Differential Revision: https://phabricator.services.mozilla.com/D205880
2024-04-10 17:22:14 +00:00
Nicolas Chevobbe 3f151d357e Bug 1882964 - [devtools] Turn getRuleBodyTextOffsets into getRuleBodyText for easier unicode chars handling. r=layout-reviewers,devtools-reviewers,emilio,ochameau.
`InspectorUtils.getRuleBodyTextOffset` was returning bytes position, and we
were using them directly in Javascript `substring`, which causes problem
with non-ascii chars.
Instead of returning offsets to compute the rule string, we directly return
the string from InspectorUtils which is easier to work with.

Differential Revision: https://phabricator.services.mozilla.com/D204523
2024-04-08 08:37:14 +00:00
Norisz Fay 7ded2bfda7 Backed out 4 changesets (bug 1849160) for causing gv-junit failure on AccessibilityTest#testSelectable CLOSED TREE
Backed out changeset 0fb937f8c362 (bug 1849160)
Backed out changeset fe5651e406e5 (bug 1849160)
Backed out changeset 8f14ad3ed8b4 (bug 1849160)
Backed out changeset 9a745f454db2 (bug 1849160)
2024-04-02 07:32:11 +03:00
Nathan LaPre 25d3b68e8a Bug 1849160 - Part 4: Update tests in light of new ancestor role requirements, r=Jamie,devtools-reviewers,nchevobbe
This revision updates newly-failing tests after implementing the ancestor
requirements for certain child roles. Generally, this revision adds ancestors
where appropriate, because tests largely are not testing this particular
behavior.

Differential Revision: https://phabricator.services.mozilla.com/D205880
2024-04-02 02:17:39 +00:00
Alexandre Poirot f74f2467f4 Bug 1888171 - [devtools] Convert worker loader module to ESM. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D205865
2024-03-28 15:15:22 +00:00
Christoph Kerschbaumer 3b2005752a Bug 1885313: Update tests within devtools/ to work with https-first enabled, r=jdescottes,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D205724
2024-03-27 10:22:55 +00:00
Alexandre Poirot c867832007 Bug 1789981 - [devtools] Convert last DevTools JSM to ESM. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D202438
2024-03-26 08:29:22 +00:00
Nicolas Chevobbe 94fc97f9cc Bug 1882741 - [devtools] Do not show inactive CSS warning for align-content on (inline-)block elements. r=devtools-reviewers,fluent-reviewers,bolsson,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D203408
2024-03-20 16:41:18 +00:00
Alexandre Poirot 26d9f9bb91 Bug 1713093 - [devtools] Remove TargetMixin.attachThread. r=devtools-reviewers,nchevobbe
This code was only used for workers targets, which weren't passing breakpoints
from the server side via "sessionData" concept.
Instead, we were still relying on the frontend to pass them and only after that
manually requesting the thread to resume its execution.

Now, there is still a notion of "attach" around the thread actor.
While all the targets are immediately instantiating their related thread actor,
the thread actor isn't active by default.
It becomes active as soon as:
* SOURCE or THREAD_STATE resource is watched
* breakpoints are set via session data (breakpoint list actor)
* thread configuration are set via session data (thread configuration actor)
I had to do one of these things in order to keep test from working.
In the production code, we do most of these things by default on the toolbox startup.
We could revise this behavior by:
* always attaching the thread actor, but it may start pausing unexpectedly in some tests.
* decouple sources from breakpoints within the thread actor, so that watching for sources doesn't necessarily "attach" the thread actor and activate breakpoints/debugger statements.
* have a new thread configuration to explicitly enable the thread actor pausing features.

I'm often using thread configuration to enable pausing in tests.
This required to improve xpcshell test helpers to be able to use Watcher/Commands.

About browser_target_command_bfcache.js, the DevTools code is now so quick that the
back/forward requests at done too quickly one after the other and fail actually moving to
the other document.

Differential Revision: https://phabricator.services.mozilla.com/D166321
2024-03-20 12:30:17 +00:00
Alexandre Poirot 34c1fb2d98 Bug 1713093 - [devtools] Ensure processing all the target actors in xpcshell tests. r=devtools-reviewers,nchevobbe
We were only processing the first one being registered.
Luckily we weren't testing session data enough in xpcshell to have trouble because of this.
(this changeset fixes test failure when applying the next one)

Differential Revision: https://phabricator.services.mozilla.com/D203101
2024-03-20 12:30:16 +00:00
Nicolas Chevobbe e4137ed7a1 Bug 1884230 - [devtools] Revert Bug 1882964 to fix regression. r=devtools-reviewers,bomsy.
Since we're at the end of the cycle, let's fix the regression
by reverting getRuleText to use the JS lexer again.
A test case is added to prevent future regression when we'll
try to move this to an InspectorUtils method again.

Differential Revision: https://phabricator.services.mozilla.com/D204621
2024-03-14 15:26:31 +00:00
pstanciu 5a1a45a9a8 Backed out 6 changesets (bug 1713093, bug 1691986) for turning Bug 1767717 into permafail. CLOSED TREE
Backed out changeset b0285f8abf2e (bug 1713093)
Backed out changeset 6532dbabf879 (bug 1713093)
Backed out changeset 2670f26f6bff (bug 1713093)
Backed out changeset a63d603a1973 (bug 1713093)
Backed out changeset 0118d0bc64ba (bug 1713093)
Backed out changeset e29a81bc7299 (bug 1691986)
2024-03-08 20:32:38 +02:00
Alexandre Poirot 9f0c59245f Bug 1713093 - [devtools] Remove TargetMixin.attachThread. r=devtools-reviewers,nchevobbe
This code was only used for workers targets, which weren't passing breakpoints
from the server side via "sessionData" concept.
Instead, we were still relying on the frontend to pass them and only after that
manually requesting the thread to resume its execution.

Now, there is still a notion of "attach" around the thread actor.
While all the targets are immediately instantiating their related thread actor,
the thread actor isn't active by default.
It becomes active as soon as:
* SOURCE or THREAD_STATE resource is watched
* breakpoints are set via session data (breakpoint list actor)
* thread configuration are set via session data (thread configuration actor)
I had to do one of these things in order to keep test from working.
In the production code, we do most of these things by default on the toolbox startup.
We could revise this behavior by:
* always attaching the thread actor, but it may start pausing unexpectedly in some tests.
* decouple sources from breakpoints within the thread actor, so that watching for sources doesn't necessarily "attach" the thread actor and activate breakpoints/debugger statements.
* have a new thread configuration to explicitly enable the thread actor pausing features.

I'm often using thread configuration to enable pausing in tests.
This required to improve xpcshell test helpers to be able to use Watcher/Commands.

About browser_target_command_bfcache.js, the DevTools code is now so quick that the
back/forward requests at done too quickly one after the other and fail actually moving to
the other document.

Differential Revision: https://phabricator.services.mozilla.com/D166321
2024-03-06 13:43:48 +00:00
Alexandre Poirot 074f53663f Bug 1713093 - [devtools] Ensure processing all the target actors in xpcshell tests. r=devtools-reviewers,nchevobbe
We were only processing the first one being registered.
Luckily we weren't testing session data enough in xpcshell to have trouble because of this.
(this changeset fixes test failure when applying the next one)

Differential Revision: https://phabricator.services.mozilla.com/D203101
2024-03-06 13:43:47 +00:00
Dave Townsend 2af4d349f3 Bug 1864896: Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
Differential Revision: https://phabricator.services.mozilla.com/D202959
2024-03-05 14:21:15 +00:00
Nicolas Chevobbe 11dca72b03 Bug 1882964 - [devtools] Use InspectorUtils.getRuleBodyTextOffsets in getRuleText. r=devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D203234
2024-03-05 08:36:23 +00:00
Alexandre Poirot f616bb4bf5 Bug 1865439 - [devtools] Rename ThreadActor's _parent to targetActor. r=devtools-reviewers,nchevobbe
By protocol.js conventions, most target scopes actors have a `targetActor` attribute set to their parent,
i.e. the related target actor. Thread Actor was old enough to not follow this pattern.

Also remove the second constructor argument and `global` attribute as it was unused.

Differential Revision: https://phabricator.services.mozilla.com/D201696
2024-02-21 22:04:16 +00:00
Nathan LaPre 574c54d7c0 Bug 1656330: Implement grid role, mapping, r=Jamie,devtools-reviewers,nchevobbe
This revision adds a Gecko GRID role, matching the ARIA 'grid' role, and
implements its platform mappings. It then remaps the ARIA 'grid' role to the
Gecko GRID role. Finally, this revision removes the expected-fail for the
relevant formerly-failing web platform test and updates existing tests.

Differential Revision: https://phabricator.services.mozilla.com/D202040
2024-02-21 03:31:55 +00:00
Alexandre Poirot 75fcbff4a7 Bug 1875045 - [devtools] Release Object actors by bulk. r=devtools-reviewers,devtools-backward-compat-reviewers,nchevobbe
For now we were releasing object actors one by one.
This would force to send an individual RDP request for each of them.
The console often release all objects actors related to older console message
going over the maximum limit of displayed console messages (10k).
This can easily grow in a large number of actors to be released,
either if console message are receiving many arguments and/or
if many console are logged.

We have to have one request per target as the actors could only be reached
within same-thread actor.
In order to prepare for ObjectFront removal, introduce a target-scoped "Objects" actor
which is a singleton per Target. It will receive the new "release in bulk objects actors"
method. Later, it will start implementing all the existing methods of the Object Actor
in order to migrate away from having to instantiate one Object Front (notice the singular on "Object"),
per inspected JS Object.

On the fronted side a new Object Command is introduced in order to abstract away the RDP/Fronts work.

Differential Revision: https://phabricator.services.mozilla.com/D198784
2024-01-29 13:59:51 +00:00
Gijs Kruitbosch 3288f177a4 Bug 1780071 - autofix devtools/ violations of no-comparison-or-assignment-inside-ok r=profiler-reviewers,devtools-reviewers,julienw,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D198975
2024-01-26 13:12:07 +00:00
Iulian Moraru f78b22948f Backed out 2 changesets (bug 1875045) for causing dt failures on browser_webconsole_console_logging_workers_api.js. CLOSED TREE
Backed out changeset 533ecc686bac (bug 1875045)
Backed out changeset f4ac089ead5a (bug 1875045)
2024-01-26 16:09:31 +02:00
Alexandre Poirot 3574d88b24 Bug 1875045 - [devtools] Release Object actors by bulk. r=devtools-reviewers,devtools-backward-compat-reviewers,nchevobbe
For now we were releasing object actors one by one.
This would force to send an individual RDP request for each of them.
The console often release all objects actors related to older console message
going over the maximum limit of displayed console messages (10k).
This can easily grow in a large number of actors to be released,
either if console message are receiving many arguments and/or
if many console are logged.

We have to have one request per target as the actors could only be reached
within same-thread actor.
In order to prepare for ObjectFront removal, introduce a target-scoped "Objects" actor
which is a singleton per Target. It will receive the new "release in bulk objects actors"
method. Later, it will start implementing all the existing methods of the Object Actor
in order to migrate away from having to instantiate one Object Front (notice the singular on "Object"),
per inspected JS Object.

On the fronted side a new Object Command is introduced in order to abstract away the RDP/Fronts work.

Differential Revision: https://phabricator.services.mozilla.com/D198784
2024-01-26 10:41:43 +00:00
Jonathan Kew 5c2c2026b5 Bug 1852478 - Update property_database.js for conversion of white-space and text-wrap to shorthands. r=firefox-style-system-reviewers,emilio,devtools-reviewers,nchevobbe
Also fix up devtools data/tests now that white-space is a shorthand.

Differential Revision: https://phabricator.services.mozilla.com/D198792
2024-01-26 09:40:03 +00:00
Cristian Tuns b0886adb5c Backed out 4 changesets (bug 1758391, bug 1852478) for causing build bustages in UseCounterMetrics.cpp CLOSED TREE
Backed out changeset fe673f87d86a (bug 1852478)
Backed out changeset d466ccbd1aad (bug 1852478)
Backed out changeset c0fa98fec39a (bug 1758391)
Backed out changeset 04d322f23fd0 (bug 1852478)
2024-01-25 18:29:39 -05:00
Jonathan Kew 4570d7572a Bug 1852478 - Update property_database.js for conversion of white-space and text-wrap to shorthands. r=firefox-style-system-reviewers,emilio,devtools-reviewers,nchevobbe
Also fix up devtools data/tests now that white-space is a shorthand.

Differential Revision: https://phabricator.services.mozilla.com/D198792
2024-01-25 22:20:06 +00:00
Joel Maher 3662d84cd4 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-25 00:27:05 +00:00
Stanca Serban 71d0d5cf96 Backed out changeset 54462970f797 (bug 1873732) for causing web platform tests failures. 2024-01-24 21:08:19 +02:00
Joel Maher 04ec786571 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-24 16:35:54 +00:00
Nicolas Chevobbe e09a0ec37d Bug 1865264 - [devtools] Remove CssRule/CssSheet unused source getters. r=devtools-reviewers,ochameau.
test_css-logic-media-queries.html was only checking this property,
and we have a mochitest equivalent checking the UI (browser_rules_media-queries.js),
so we remove it.

Depends on D193872

Differential Revision: https://phabricator.services.mozilla.com/D193873
2023-11-22 09:37:37 +00:00
Nicolas Chevobbe 6e6afdd3e1 Bug 1865026 - [devtools] Don't send unused mediaText property. r=devtools-reviewers,ochameau.
This looks like a legacy property that we're not using anymore.

Differential Revision: https://phabricator.services.mozilla.com/D193872
2023-11-22 09:37:36 +00:00
Joel Maher cac31d18e3 Bug 1859873 - batch 13 xpcshell.ini -> .toml. r=aryx,devtools-reviewers,profiler-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D194161
2023-11-21 12:32:50 +00:00
James Teh 5081580270 Bug 1863480: Expose all relations via xpcAccessible::GetRelations. r=morgan,devtools-reviewers,nchevobbe
Previously, only an outdated hard-coded subset was being exposed.
This meant that missing relations such as details and error message were not exposed in the DevTools Accessibility Inspector.
We now expose all relations in the RelationType enum so we don't need to keep this up to date.

Differential Revision: https://phabricator.services.mozilla.com/D193008
2023-11-09 05:19:01 +00:00
Alexandre Poirot d647366308 Bug 1861943 - [devtools] Introduce a server side method to set all data entry values in one call. r=devtools-reviewers,nchevobbe
This will help bug 1569775 and bug 1651522 to update the whole entries of a given data type.

As there is little difference between adding new entries and replacing all entries,
I'm tuning the existing addSessionDataEntry methods to support both behaviors.

Differential Revision: https://phabricator.services.mozilla.com/D192243
2023-11-06 12:37:24 +00:00
Alexandre Poirot c1c35002f9 Bug 1861142 - [devtools] Better handle exception while parsing console commands. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D192271
2023-11-03 09:40:30 +00:00
Nicolas Chevobbe a670cbbb32 Bug 1861031 - [devtools] Handle InspectorUtils.getBlockLineCounts returning null. r=devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D191862
2023-10-26 16:01:58 +00:00
Mark Banner cc2be2ea34 Bug 1858673 - Remove now unnecessary disabling of ESLint no-unsanitized/* rules from test files. r=freddyb,media-playback-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,places-reviewers,aosmond,sgalich,dao,padenot
Differential Revision: https://phabricator.services.mozilla.com/D190985
2023-10-24 08:48:41 +00:00
Sebastian Zartner cf3e93c8a0 Bug 1858937 - [devtools] Enable preference layout.css.text-wrap-balance.enabled in tests for inactive CSS in DevTools. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D190999
2023-10-14 16:10:38 +00:00
Sebastian Zartner 798f509d51 Bug 1851756 - [devtools] Handle 'text-wrap: balance;' in inactive CSS. r=devtools-reviewers,nchevobbe,flod.
Differential Revision: https://phabricator.services.mozilla.com/D190505
2023-10-12 10:48:43 +00:00
Tom Marble 6c1231e2e8 Bug 1853244 - convert .ini manifests to .toml: batch 6 {caps,devtools,dom}/**/browser.ini r=jmaher,media-playback-reviewers,devtools-reviewers,profiler-reviewers,alwu,nchevobbe,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D188856
2023-09-22 20:42:14 +00:00
Tom Marble d70780c99c Bug 1850545 - convert .ini manifests to .toml: batch 3 chrome.ini (bis) r=jmaher,geckoview-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,places-reviewers,profiler-reviewers,m_kato,mak,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D187597
2023-09-13 18:28:32 +00:00
Sebastian Zartner ede6514ba4 Bug 1849235 - [devtools] Handle ::cue pseudo-element's ignored properties in inactive CSS. r=devtools-reviewers,fluent-reviewers,flod,nchevobbe.
Differential Revision: https://phabricator.services.mozilla.com/D186509
2023-09-09 21:16:57 +00:00
Sebastian Zartner fc04233d84 Bug 1842175 - [devtools] Handle ::first-letter pseudo-element's ignored properties in inactive CSS. r=devtools-reviewers,fluent-reviewers,flod,nchevobbe.
Differential Revision: https://phabricator.services.mozilla.com/D186493
2023-09-08 19:32:26 +00:00
Sebastian Zartner 5c735718b3 Bug 1849255 - [devtools] Handle ::placeholder pseudo-element's ignored properties in inactive CSS. r=devtools-reviewers,fluent-reviewers,nchevobbe.
Differential Revision: https://phabricator.services.mozilla.com/D186742
2023-09-07 20:14:31 +00:00
Sebastian Zartner 5eb95bb51e Bug 1842174 - [devtools] Handle ::first-line pseudo-element's ignored properties in inactive CSS. r=devtools-reviewers,fluent-reviewers,flod,jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D186188
2023-08-16 20:34:57 +00:00
Sebastian Zartner 611e035114 Bug 1583912 - [devtools] Handle ignored properties in non-multi-column containers in inactive CSS. r=devtools-reviewers,fluent-reviewers,flod,jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D186096
2023-08-14 20:41:29 +00:00
Sebastian Zartner a0a8952db4 Bug 1583906 - [devtools] Handle 'empty-cells' property in inactive CSS. r=devtools-reviewers,fluent-reviewers,flod,jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D186082
2023-08-14 20:14:34 +00:00
Gregory Pappas 4a586d99c4 Bug 1847285 - Remove unused devtools.storage.test.forceLegacyActors r=devtools-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D185467
2023-08-07 12:33:49 +00:00
Tooru Fujisawa 0460d6c07b Bug 1842701 - Part 1.9: Directly call command function for :command style. r=nchevobbe,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D185115
2023-08-07 12:12:23 +00:00