Commit Graph
133 Commits
Author SHA1 Message Date
Frederic Wang d14f083509 Bug 1846718 - Negative linethickness should be interpreted as 0. r=emilio
See https://w3c.github.io/mathml-core/#dfn-linethickness

Differential Revision: https://phabricator.services.mozilla.com/D185152
2023-08-02 18:09:37 +00:00
Frederic Wang 4eab0ed25c Bug 1845707 - Remove preferences for invalid markup. r=emilio
This commit removes the preference
mathml.error_message_layout_for_invalid_markup.disabled that controls
whether we layout invalid markup with the special "invalid-markup"
message. It has been set to true since Firefox 106. For now, this
"invalid-markup" layout is still used for the legacy implementation
of the <maction> element and will be removed in bug 1788223.

Differential Revision: https://phabricator.services.mozilla.com/D184691
2023-07-31 05:23:26 +00:00
Iulian Moraru 98e647c031 Backed out changeset 10692fd51184 (bug 1845707) for causing Bug 1845914. CLOSED TREE 2023-07-30 16:51:28 +03:00
Frederic Wang 49e0f155ac Bug 1845707 - Remove preferences for invalid markup. r=emilio
This commit removes the preference
mathml.error_message_layout_for_invalid_markup.disabled that controls
whether we layout invalid markup with the special "invalid-markup"
message. It has been set to true since Firefox 106. For now, this
"invalid-markup" layout is still used for the legacy implementation
of the <maction> element and will be removed in bug 1788223.

Differential Revision: https://phabricator.services.mozilla.com/D184691
2023-07-28 05:43:16 +00:00
Noemi Erli 63b0c2e194 Backed out changeset c6981d9b3b12 (bug 1845707) for causing bustage in nsMathMLSelectedFrame.cpp 2023-07-27 17:56:58 +03:00
Frederic Wang 6a3581f06c Bug 1845707 - Remove preferences for invalid markup. r=emilio
This commit removes the preference
mathml.error_message_layout_for_invalid_markup.disabled that controls
whether we layout invalid markup with the special "invalid-markup"
message. It has been set to true since Firefox 106. For now, this
"invalid-markup" layout is still used for the legacy implementation
of the <maction> element and will be removed in bug 1788223.

Differential Revision: https://phabricator.services.mozilla.com/D184691
2023-07-27 13:56:47 +00:00
Emilio Cobos Álvarez 529c9ee321 Bug 1839922 - Remove usage of {Has,Get}Attr(kNameSpaceID_None, ..). r=edgar
We have more readable and faster versions (that just omit the namespace
arg).

Mostly done via sed, with a couple helpers to use the faster lookups
where possible.

Differential Revision: https://phabricator.services.mozilla.com/D181795
2023-06-23 10:01:32 +00:00
sskcvqikf 9a203ce2a6 Bug 1797012 - Change NS_STYLE_MATH_STYLE_* macros to enum StyleMathStyle. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D160016
2022-10-24 17:47:34 +00:00
Marian-Vasile Laza b44b3fb628 Backed out changeset f39d284f4db7 (bug 1797012) for causing wpt failures on frac-1.html. CLOSED TREE 2022-10-24 15:46:12 +03:00
sskcvqikf 97899b4a8d Bug 1797012 - Change NS_STYLE_MATH_STYLE_* macros to enum StyleMathStyle. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D160016
2022-10-24 09:29:05 +00:00
Frederic Wang 0e3d11e1b0 Bug 1793452 - Remove flags PARSE_ALLOW_UNITLESS and CONVERT_UNITLESS_TO_PERCENT. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D158547
2022-10-07 12:57:08 +00:00
Frederic Wang d3fff0eddd Bug 1583037 - Do not layout MathML as an error message when a layout error occurs. r=emilio
See https://groups.google.com/g/mozilla.dev.platform/c/hMf_Z1JSApQ

Differential Revision: https://phabricator.services.mozilla.com/D46725
2022-09-06 09:51:52 +00:00
Frederic Wang 543bd084f2 Bug 1784014 - Remove MathML preference mfrac_bevelled_attribute. r=emilio
- remove flag and corresponding warning/counter.
- remove attribute from parsers, but keep the atom since it's
  used by TreeSanitizer.
- remove tests for mfrac@bevelled, there is a WPT test to check it's
  not supported.
- layout/mathml/tests/test_bug975681.html is removed, its tests are
  currently (wrongly) all disabled when the flag is off and equivalent
  tests for attributes other than bevelled exist in WPT.

Differential Revision: https://phabricator.services.mozilla.com/D154199
2022-08-27 07:22:22 +00:00
Frederic Wang 0b1a133908 Bug 1784009 - Remove MathML preference mfrac_linethickness_names. r=emilio
- Remove preference, warning and counter.
- Remove tests checking support for it, or replacing with
  equivalent 50% and 300% values.

Differential Revision: https://phabricator.services.mozilla.com/D154198
2022-08-26 14:21:47 +00:00
Frederic Wang b63fa57143 Bug 1784003 - Remove MathML preference deprecated_alignment_attributes. r=emilio
- Remove code for align/denumalign/numalign attributes.
- Remove tests checking support for them.
- Remove warning message and counter.
- numalign/denomalign atoms are not removed, since they
  are still used by nsTreeSanitizer.

Differential Revision: https://phabricator.services.mozilla.com/D154197
2022-08-26 12:31:16 +00:00
Andrew Osmond 66c6bad8f6 Bug 1779519 - gfxFontCache expiration tracker operations should be more atomic. r=jfkthame
gfxFontCache acquires and releases its mutex during various operations.
In order to keep the state internally consistent, we should only release
the lock after the full operation is complete. This involves moving the
deletion of gfxFont to outside the lock via a temporary discard array.

The expiration state should not be protected by the gfxFont's mutex
since we don't hold it during most operations. Instead we should hold
gfxFontCache's mutex because then we can guarantee the operation is
atomic, particularly when a worker wants a font, and the main thread is
aging the generations.

When a font is returned from gfxFontCache, we now return it already
removed from the tracker, and with its refcount updated. This avoids any
potential races between the expiration timer and a worker accessing the
font, as well as simplying the callers so they don't need to be aware of
addref-ing manually in case the result is to be discarded (so that it
gets readded to the tracker).

Differential Revision: https://phabricator.services.mozilla.com/D151821
2022-07-14 19:53:09 +00:00
criss 380e3e436f Backed out changeset e4cd98b5984d (bug 1779519) for causing build bustages. CLOSED TREE 2022-07-14 22:06:53 +03:00
Andrew Osmond 8cb302b7c5 Bug 1779519 - gfxFontCache expiration tracker operations should be more atomic. r=jfkthame
gfxFontCache acquires and releases its mutex during various operations.
In order to keep the state internally consistent, we should only release
the lock after the full operation is complete. This involves moving the
deletion of gfxFont to outside the lock via a temporary discard array.

The expiration state should not be protected by the gfxFont's mutex
since we don't hold it during most operations. Instead we should hold
gfxFontCache's mutex because then we can guarantee the operation is
atomic, particularly when a worker wants a font, and the main thread is
aging the generations.

When a font is returned from gfxFontCache, we now return it already
removed from the tracker, and with its refcount updated. This avoids any
potential races between the expiration timer and a worker accessing the
font, as well as simplying the callers so they don't need to be aware of
addref-ing manually in case the result is to be discarded (so that it
gets readded to the tracker).

Differential Revision: https://phabricator.services.mozilla.com/D151821
2022-07-14 18:35:49 +00:00
Daniel Holbert 4a2ce32ff4 Bug 1754295 part 2: Fix non-unified build errors in layout/mathml, and mark it as safe to build in non-unified mode. r=TYLin
Build errors fixed here:

layout/mathml/nsMathMLmpaddedFrame.h:68:14: error: field has incomplete type 'nsCSSValue'

* Fixed by including this type's header.

[various files]: error: use of undeclared identifier 'nsLayoutUtils'

* Fixed by including the nsLayoutUtils header.

[various files]: error: member access into incomplete type 'mozilla::dom::Element'

* These are for calls to [something]->AsElement()->HasAttr() and SetAttr(). Fixed by including Element.h in all affected .cpp files.

[various files]: error: member access into incomplete type 'nsINode::Document' (aka 'mozilla::dom::Document')

* These are for calls to mContent->OwnerDoc()->WarnOnceAbout(). Fixed by including Document.h in all affected files.

Depends on D138202

Differential Revision: https://phabricator.services.mozilla.com/D138203
2022-02-08 23:29:56 +00:00
Miko Mynttinen 8df6649834 Bug 1720804 - Part 1: Move majority of the display list code inside mozilla namespace r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D120041
2021-07-19 11:28:20 +00:00
Alexandru Michis 9b9c5fe24e Backed out 2 changesets (bug 1720804) for causing bustages.
CLOSED TREE

Backed out changeset 5278e88c6d34 (bug 1720804)
Backed out changeset 1acb4ed79b6b (bug 1720804)
2021-07-16 18:10:11 +03:00
Miko Mynttinen 397ffc88e1 Bug 1720804 - Part 1: Move majority of the display list code inside mozilla namespace r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D120041
2021-07-16 14:36:34 +00:00
Simon Giesecke a9f246233d Bug 1673931 - Remove dependency of BindingUtils.h on Document.h.
Differential Revision: https://phabricator.services.mozilla.com/D95048

Depends on D95047
2020-11-23 16:08:03 +00:00
Frederic Wang d1307efb2f Bug 1665975 - Implement the math-style property. r=emilio
This patch renames the internal -moz-math-display to math-style and
exposes it under the layout.css.math-style.enabled preference. The
initial value becomes "normal" but that does not affect the default
MathML behavior since the UA style sheet sets the math-style property
explicitly on <math> tags. WPT tests are updated to use the syntax
approved by the CSSWG.

Intent to prototype: https://groups.google.com/forum/#!msg/mozilla.dev.platform/1hQQ7ISudGo/_yLEckEeBQAJ

Differential Revision: https://phabricator.services.mozilla.com/D90731
2020-09-23 13:04:48 +00:00
Narcis Beleuzu 35a6a3358d Backed out changeset 9480237e1e6f (bug 1665975) for xpcshell failure on test_css-properties-db.js. CLOSED TREE 2020-09-23 13:06:21 +03:00
Frederic Wang f64410ed17 Bug 1665975 - Implement the math-style property. r=emilio
This patch renames the internal -moz-math-display to math-style and
exposes it under the layout.css.math-style.enabled preference. The
initial value becomes "normal" but that does not affect the default
MathML behavior since the UA style sheet sets the math-style property
explicitly on <math> tags. WPT tests are updated to use the syntax
approved by the CSSWG.

Intent to prototype: https://groups.google.com/forum/#!msg/mozilla.dev.platform/1hQQ7ISudGo/_yLEckEeBQAJ

Differential Revision: https://phabricator.services.mozilla.com/D90731
2020-09-23 08:14:38 +00:00
Bogdan Tara 927f3a012a Backed out changeset 0da5103ba772 (bug 1665975) for mozglue_static::panic_hook mass crashes CLOSED TREE 2020-09-21 10:07:03 +03:00
Frederic Wang a965428c15 Bug 1665975 - Implement the math-style property. r=emilio
This patch renames the internal -moz-math-display to math-style and
exposes it under the layout.css.math-style.enabled preference. The
initial value becomes "normal" but that does not affect the default
MathML behavior since the UA style sheet sets the math-style property
explicitly on <math> tags. WPT tests are updated to use the syntax
approved by the CSSWG.

Intent to prototype: https://groups.google.com/forum/#!msg/mozilla.dev.platform/1hQQ7ISudGo/_yLEckEeBQAJ

Differential Revision: https://phabricator.services.mozilla.com/D90731
2020-09-21 05:41:51 +00:00
Botond Ballo adf0abe07c Bug 1629732 - Fix non-unified build errors in layout/mathml. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D71247
2020-04-17 01:43:08 +00:00
Simon Giesecke e613597e90 Bug 1613985 - Use default for equivalent-to-default constructors/destructors in layout. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D66016
2020-03-17 09:38:32 +00:00
Simon Giesecke 459f898390 Bug 1613985 - Use MOZ_COUNTED_DEFAULT_CTOR_*/MOZ_COUNTED_DTOR_* macros. r=froydnj
This removes the need for explicit #ifdef NS_BUILD_REFCNT_LOGGING without
introducing user-defined destructors when it is not defined.

Also, some uses of virtual for declaring destructors are replaced by the
appropriate override declaration through these changes.

Differential Revision: https://phabricator.services.mozilla.com/D62604
2020-02-20 11:40:14 +00:00
Dorel Luca ccba316db1 Backed out 2 changesets (bug 1613985) for Build bustage on Windows2012. CLOSED TREE
Backed out changeset fd177b40b561 (bug 1613985)
Backed out changeset fb6d62b7f28d (bug 1613985)
2020-02-19 22:22:41 +02:00
Simon Giesecke 037dd3192f Bug 1613985 - Use MOZ_COUNTED_DEFAULT_CTOR_*/MOZ_COUNTED_DTOR_* macros. r=froydnj
This removes the need for explicit #ifdef NS_BUILD_REFCNT_LOGGING without
introducing user-defined destructors when it is not defined.

Also, some uses of virtual for declaring destructors are replaced by the
appropriate override declaration through these changes.

Differential Revision: https://phabricator.services.mozilla.com/D62604
2020-02-19 18:05:38 +00:00
Emilio Cobos Álvarez 79768ff848 Bug 1611181 - Make direction use an enum class. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D60857
2020-01-24 11:46:14 +00:00
Frederic Wang 26fed10c0c Bug 1587572 - Remove support for the mfrac@bevelled attribute. r=emilio
See https://groups.google.com/forum/#!topic/mozilla.dev.platform/9pEvlYn-Xyw

Differential Revision: https://phabricator.services.mozilla.com/D49299
2019-10-17 09:41:06 +00:00
Frederic Wang 4008c7303b Bug 1548530 - Remove support for numalign/denomalign/align attributes. r=emilio
Intent to unship: https://groups.google.com/forum/#!topic/mozilla.dev.platform/JnJVGTmIwPE

- Introduce a new preference option mathml.deprecated_alignment_attributes.disabled()
  to disable alignment attributes for mfrac/munder/mover/munderover elements.
- Disable the attributes in Nightly and when running WPT tests.
- Enable the attributes in other channels but add a counter and deprecation warning.
- Remove failure expectation for WPT test frac-numalign-denomalign-001.html for mfrac
- Add new WPT test for underover-legacy-align-attribute-001.html for munder/mover/munderover
- Enable the attributes for MathML reftests checking these attributes.
- Disable numalign/denomalign test for Mochitest test_bug975681.html when the attributes
  are disabled.

Differential Revision: https://phabricator.services.mozilla.com/D46712
2019-09-22 11:25:26 +00:00
Frederic Wang f706457aa1 Bug 1579602 - Rename nsMathMLElement to dom::MathMLElement. r=bzbarsky
This commit renames nsMathMLElement/nsMathMLElementFactory classes into
MathMLElement/MathMLElementFactory and moves the former into the mozilla::dom
namespace. This is a preliminary step to introduce MathML DOM (bug 1579602).
Code behavior is not changed.

Differential Revision: https://phabricator.services.mozilla.com/D45128
2019-09-13 16:27:54 +00:00
Frédéric Wang c44a2a161e Bug 1575542 - Add counter and warnings for deprecated MathML lengths. r=emilio
This commit introduces new counters and deprecation warnings for the following
MathML features:
* mathspace names (bug 1575542)
* mathsize names (bug 1548527)
* linethickness names (bug 1548529)

Note: helper parsing functions for mfrac and mpadded are changed to non-static
in order to pass the document parameter needed to log warnings to the console.

Change manually tested with
    <math>
      <mspace width="thinmathspace"></mspace>
      <mpadded width="2thickmathspace"></mpadded>
      <mfrac linethickness="thin"><mn>1</mn><mn>2</mn></mfrac>
      <mtext mathsize="big">3</mtext>
    </math>

Differential Revision: https://phabricator.services.mozilla.com/D42890
2019-08-22 06:29:26 +00:00
Frédéric Wang c2fae4ecdd Bug 1548529 - Remove values "thin", "thick", "medium" values of mfrac@linethickness. r=emilio
See https://github.com/mathml-refresh/mathml/issues/4
and https://groups.google.com/forum/#!topic/mozilla.dev.platform/G91-vBeC3Rw

This commit introduces a new preference option
mathml.mfrac_linethickness_names.disabled to disable linethickness names. For
now, these names are only disabled in Nightly builds. Announcements and actual
disabling of this and other MathML features will be considered later.

* test_bug553917.html is updated to check that these values now cause an error
  message to be logged into the console.
* mstyle-1.xhtml is updated to use a numeric linethickness since the point of
  the test is just to check that the attribute is not supported on mstyle, not
  about the actual attribute value.
* Other fractions tests relying on linethickness names are executed with the
  proper preference adjustment.
* mathml/presentation-markup/fractions/frac-linethickness-001.html is now
  closer to its expectation ; however the test still fails because nonzero
  unitless values are not removed yet. See
  https://github.com/mathml-refresh/mathml/issues/24

Differential Revision: https://phabricator.services.mozilla.com/D42323
2019-08-16 17:41:59 +00:00
Frédéric Wang fd17c34e11 Bug 1572211 - Do not rely on AxisHeight for the layout of mfrac elements without bar. r=emilio
AxisHeight is not involved in the layout of <mfrac> with zero linethickness:
https://mathml-refresh.github.io/mathml-core/#fraction-with-zero-line-thickness

Confirmed by Microsoft:
https://lists.w3.org/Archives/Public/public-mathml4/2019Aug/0019.html

See https://github.com/mathml-refresh/mathml/issues/123

Differential Revision: https://phabricator.services.mozilla.com/D41189
2019-08-13 15:05:26 +00:00
Oana Pop Rus eb48b5e3de Backed out 2 changesets (bug 1572211) for mochitests failures on test_stack-parameters.html on a CLOSED TREE
Backed out changeset 48fa8b517d7b (bug 1572211)
Backed out changeset a5d589b74745 (bug 1572211)
2019-08-13 18:01:33 +03:00
Frédéric Wang 53629e8b5d Bug 1572211 - Do not rely on AxisHeight for the layout of mfrac elements without bar. r=emilio
AxisHeight is not involved in the layout of <mfrac> with zero linethickness:
https://mathml-refresh.github.io/mathml-core/#fraction-with-zero-line-thickness

Confirmed by Microsoft:
https://lists.w3.org/Archives/Public/public-mathml4/2019Aug/0019.html

See https://github.com/mathml-refresh/mathml/issues/123

Differential Revision: https://phabricator.services.mozilla.com/D41189
2019-08-13 09:51:58 +00:00
L. David Baron 94e5b517b7 Bug 1571250 - Convert flags passed to ReflowChild, FinishReflowChild, SyncFrameViewAfterReflow and from GetXULLayoutFlags / GetLayoutFlags into an enum class. r=TYLin
It seems better to convert this before adding a new flag (in bug
1547759) and risking replacing the wrong 0 with a flag.

Differential Revision: https://phabricator.services.mozilla.com/D40562
2019-08-08 19:48:19 +00:00
Miko Mynttinen 5be1561bbc Bug 1549751 - Part 2: Add nsPaintedDisplayItem r=mattwoodrow
Move ApplyOpacity(), CanApplyOpacity(), Paint() and PaintWithClip() methods to nsPaintedDisplayItem

Differential Revision: https://phabricator.services.mozilla.com/D30225
2019-05-08 13:49:56 +00:00
Masayuki Nakano ad09cbb08f Bug 1544343 - part 2: Make factory methods take mozilla::PresShell instead of nsIPresShell r=emilio
Additionally, this patch makes `nsFrame.h` stop including `nsIPresShell.h`
and makes each users include `mozilla/PresShell.h` instead.  So, this improves
rebuild performance of `nsIPresShell.h` (and `mozilla/PresShell.h` in the
future).

Note that due to `nsIFrame::PresShell()`, `mozilla::` prefix is necessary for
`PresShell` in a lot of classes which are derived from `nsIFrame` even in
`.cpp` files.

Differential Revision: https://phabricator.services.mozilla.com/D27476
2019-04-16 07:24:49 +00:00
Matt Woodrow 5ff5f07450 Bug 1539673 - Support fallible display item construction. r=miko
Differential Revision: https://phabricator.services.mozilla.com/D25167
2019-04-01 16:53:11 +00:00
Ryan Hunt a96492f0f6 Bug 1523969 part 14 - Move method definition inline comments to new line in 'layout/'. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D21115
2019-02-25 16:09:24 -06:00
Emilio Cobos Álvarez df05b5492b Bug 1525371 - Kill ComputedStyle::mPresContext, move the pointer to the frame instead. r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D18734
2019-02-07 11:15:36 +01:00
Sylvestre Ledru e5a134f73a Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset
2018-11-30 11:46:48 +01:00
Emilio Cobos Álvarez 1d4859a89a Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt on a CLOSED TREE
MozReview-Commit-ID: JPopq0LudD
2018-03-22 20:06:24 +01:00