Commit Graph
4 Commits
Author SHA1 Message Date
Steinar H. Gunderson 193441babb Bug 1821354 [wpt PR 38905] - Trim whitespace around CSS custom declarations., a=testonly
Automatic update from web-platform-tests
Trim whitespace around CSS custom declarations.

There was a spec change a few years back, requiring us to
strip spaces and comments from the beginning and end of CSS
custom property declarations.

We take a slight performance hit:

Initial style (µs)     Before     After    Perf      95% CI (BCa)
=================== ========= ========= ======= =================
ECommerce               10041      9994   +0.5%  [ +0.1%,  +0.9%]
Encyclopedia           106735    106744   -0.0%  [ -0.6%,  +0.4%]
Extension              132830    133009   -0.1%  [ -0.6%,  +0.2%]
News                    42534     42653   -0.3%  [ -1.0%,  +0.1%]
Search                   2636      2662   -1.0%  [ -1.4%,  -0.6%]
Social1                 23298     23312   -0.1%  [ -0.3%,  +0.2%]
Social2                  1039      1042   -0.3%  [ -1.0%,  +0.4%]
Sports                  42680     42985   -0.7%  [ -1.0%,  -0.5%]
Video                   41971     42134   -0.4%  [ -0.6%,  -0.1%]
Geometric mean                            -0.3%  [ -0.5%,  -0.1%]

Parse (µs)             Before     After    Perf      95% CI (BCa)
=================== ========= ========= ======= =================
ECommerce                1360      1372   -0.9%  [ -1.2%,  -0.4%]
Encyclopedia             7349      7384   -0.5%  [ -0.7%,  -0.2%]
Extension                1349      1352   -0.2%  [ -1.2%,  +0.2%]
News                     7929      7982   -0.7%  [ -1.0%,  -0.3%]
Search                   4965      4997   -0.6%  [ -0.9%,  -0.4%]
Social1                 14752     14837   -0.6%  [ -0.8%,  -0.3%]
Social2                   617       620   -0.4%  [ -1.4%,  +0.7%]
Sports                  56182     56318   -0.2%  [ -0.6%,  +0.0%]
Video                   34720     35091   -1.1%  [ -1.3%,  -0.8%]
Geometric mean                            -0.6%  [ -0.9%,  -0.4%]

Recalc style (µs)      Before     After    Perf      95% CI (BCa)
=================== ========= ========= ======= =================
ECommerce               11417     11378   +0.3%  [ -0.2%,  +0.8%]
Encyclopedia            83808     84066   -0.3%  [ -1.4%,  +0.1%]
Extension              120362    120394   -0.0%  [ -0.7%,  +0.3%]
News                    31566     31549   +0.1%  [ -1.2%,  +0.5%]
Search                    242       242   -0.0%  [ -1.5%,  +0.7%]
Social1                 17242     17203   +0.2%  [ -0.1%,  +0.4%]
Social2                   602       593   +1.4%  [ +0.7%,  +2.1%]
Sports                  22817     22874   -0.3%  [ -0.5%,  +0.0%]
Video                   25931     25969   -0.1%  [ -0.4%,  +0.1%]
Geometric mean                            +0.1%  [ -0.5%,  +0.5%]

We save a little bit of RAM, obviously, but not much.

Fixed: 1211112
Fixed: 1220144
Change-Id: Ib7656de36d6a94d85ba25ecf60e9879b21c36468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341633
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Steinar H Gunderson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1116326}

--

wpt-commits: c3ab769723cb249535a8845cc35af80975b8926d
wpt-pr: 38905
2023-03-29 12:51:13 +00:00
Ian Kilpatrick e8ecac8f5e Bug 1571788 [wpt PR 18297] - [css-layout-api] Convert to promise based API., a=testonly
Automatic update from web-platform-tests
[css-layout-api] Convert to promise based API.

As above! This switches the API from being generator based, to promise
based.

This introduces the specification's work queue, which is run until
exhaustion. After the work queue has been run the given promise should
be resolved, (if not we fallback to block layout).

This also introduces the CustomLayoutScope, and CustomLayoutToken
which are used together.

The CustomLayoutToken is a heap allocated class held onto objects which
should only be used within a certain layout pass. E.g. you cannot
hold onto a fragment from a previous layout pass, and use it within
the current layout pass.

This is managed by a stack allocated CustomLayoutScope, which once
destroyed marks the CustomLayoutToken as "detached". Any object which
has a "detached" token shouldn't be used.

The CustomLayoutScope is also used to hold onto the work queue.

Bug: 726125
Change-Id: Ic435c8c50fe3d3779f068b41eada815253d0b78b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716035
Commit-Queue: Ian Kilpatrick <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#684927}

--

wpt-commits: dd38623d0edc9005cf87397feb2e011eb0679c52
wpt-pr: 18297
2019-08-09 20:31:41 +00:00
Darren Shen c30b166114 Bug 1442473 [wpt PR 9738] - [css-typed-om] Whitelist supported properties., a=testonly
Automatic update from web-platform-tests[css-typed-om] Whitelist supported properties.

This patch whitelists all our supported properties. Any property that
is not supported will return a base CSSStyleValue. This ensures that
we don't accidentally produce unexpected results for properties that
we haven't tested it.

We also add a few new properties to support, bringing the total number
of property tests to 50. We also remove support for 'z-index' because
it uses <integers> which we don't support yet.

transition-duration is failing tests because we currently convert
ms to seconds when we compute, which is incorrect.

Some paint/layout tests depend on properties that are not whitelisted,
so we've changed them:
- border-radius -> margin-left
- align-items -> empty-cell

Bug: 816402
Change-Id: I84d2fd8a15df92624122f0c1ecf4f7c42f928928
Reviewed-on: https://chromium-review.googlesource.com/942651
Reviewed-by: nainar <[email protected]>
Commit-Queue: Darren Shen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540397}

wpt-commits: 12e0354d971ce3f705991a4f68837d24947865df
wpt-pr: 9738
wpt-commits: 12e0354d971ce3f705991a4f68837d24947865df
wpt-pr: 9738
2018-03-31 22:29:38 +01:00
Ian Kilpatrick 842e9159bf Bug 1439696 [wpt PR 9590] - [css-layout-api] Populate styleMap and give to layout function., a=testonly
Automatic update from web-platform-tests[css-layout-api] Populate styleMap and give to layout function.

This adds both style-invalidation for the LayoutCustom object, as well
as giving the populated StylePropertyMapReadOnly to the layout()
function.

ComputedStyle::DiffNeedsFullLayout now needs a Document in order to look
up the DocumentLayoutDefinition, to see which properties need to checked
for change.

Bug: 726125
Change-Id: Ie462cb624ba413c796131433ea4eae9bb9f3ec13
Reviewed-on: https://chromium-review.googlesource.com/926906
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/master@{#538268}

wpt-commits: 6aeb9ea2a3874d39418e7ea15778a719ec0d482d
wpt-pr: 9590
wpt-commits: 6aeb9ea2a3874d39418e7ea15778a719ec0d482d
wpt-pr: 9590
2018-03-31 22:24:39 +01:00