Arch Linux doesn't come with a VERSION_ID at all, but it has a BUILD_ID.
Semantically, falling back to BUILD_ID when VERSION_ID is not present
would seem fair play:
Per https://www.freedesktop.org/software/systemd/man/latest/os-release.html:
BUILD_ID=
A string uniquely identifying the system image originally used as the
installation base. In most cases, VERSION_ID or IMAGE_ID+IMAGE_VERSION
are updated when the entire system image is replaced during an update.
BUILD_ID may be used in distributions where the original installation
image version is important: VERSION_ID would change during incremental
system updates, but BUILD_ID would not. This field is optional.
Differential Revision: https://phabricator.services.mozilla.com/D209089
The next patch will need the Linux version of LaunchApp to side-effect
the LaunchOptions in some cases; given that none of the callers ever
try to reuse a LaunchOptions, we might as well change it from a const
reference to an rvalue reference. The Mac version is also changed,
because it uses the same declaration / function type.
Also, the overload of LaunchApp that takes a CommandLine has been
removed, because it was unused.
However, the Windows version is *not* changed; there's no need for it,
and it accepts different types of arguments anyway so it's not necessary
to match the Unix one. Also, the CommandLine overload of the Windows
LaunchApp *is* used and continues to exist.
Differential Revision: https://phabricator.services.mozilla.com/D194455
Done with:
./mach static-analysis check --checks="-*, modernize-concat-nested-namespaces" --fix .
and then clang-format on the files
Differential Revision: https://phabricator.services.mozilla.com/D58217
Done with:
./mach static-analysis check --checks="-*, modernize-concat-nested-namespaces" --fix .
and then clang-format on the files
Differential Revision: https://phabricator.services.mozilla.com/D58217
LSBUtils closes a file descriptor twice, once with fclose and then again with
close. It also does this on a background thread, during startup, which means
it tends to race with main thread code which opens files.
This patch fixes that, and also removes a work-around for the issue in the
MemMapSnapshot code.
MozReview-Commit-ID: JdDHt9ayFEl
Mike Hommey