mirror of
https://github.com/HeyPuter/firefox.git
synced 2026-11-13 20:14:57 -10:00
Rob Wu
1ee7e01feb
As explained in the bug, TabDelegate.onOpenOptionsPage depends on the optionsPageUrl metadata, available at addonManagerDelegate.onReady. Before this patch, metadata received by onReady was not propagated to onOpenOptionsPage because the delegate was not updated past the initial onInstalled phase. Consequently, optionsPageUrl remained null even when the metadata indicated otherwise. This patch fixes the issue by calling registerTabHandler again, on the latest metadata. Although not strictly necessary, registerActionHandler is also called again. There are other addonManagerDelegate that receive an extension instance, those do not require new delegate re-registrations because the underlying metadata does not change. Differential Revision: https://phabricator.services.mozilla.com/D305732