mirror of
https://github.com/HeyPuter/firefox.git
synced 2026-11-13 20:14:57 -10:00
This is a large number of largely mechanical changes. When possible, the code was called to directly call `.get()` instead, performing the assertions manually. In many places PromiseFlatCString() calls were added to dynamically copy the strings into null terminated buffers if the string was not null terminated. Differential Revision: https://phabricator.services.mozilla.com/D286158
220 lines
8.2 KiB
C++
220 lines
8.2 KiB
C++
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "gtest/gtest.h"
|
|
#include "mozilla/Preferences.h"
|
|
#include "mozilla/SpinEventLoopUntil.h"
|
|
#include "nsITimer.h"
|
|
#include "nsTArray.h"
|
|
#include "nsIObserver.h"
|
|
#include "nsThreadUtils.h"
|
|
#include "nsServiceManagerUtils.h"
|
|
#include "nsWeakReference.h"
|
|
|
|
using namespace mozilla;
|
|
|
|
class TestWeakPrefObserver final : public nsIObserver,
|
|
public nsSupportsWeakReference {
|
|
public:
|
|
NS_DECL_ISUPPORTS
|
|
NS_IMETHOD Observe(nsISupports* aSubject, const char* aTopic,
|
|
const char16_t* aData) override {
|
|
mNotifyCount++;
|
|
return NS_OK;
|
|
}
|
|
int mNotifyCount = 0;
|
|
|
|
private:
|
|
~TestWeakPrefObserver() = default;
|
|
};
|
|
|
|
NS_IMPL_ISUPPORTS(TestWeakPrefObserver, nsIObserver, nsISupportsWeakReference)
|
|
|
|
TEST(PrefsBasics, Errors)
|
|
{
|
|
Preferences::SetBool("foo.bool", true, PrefValueKind::Default);
|
|
Preferences::SetBool("foo.bool", false, PrefValueKind::User);
|
|
ASSERT_EQ(Preferences::GetBool("foo.bool", false, PrefValueKind::Default),
|
|
true);
|
|
ASSERT_EQ(Preferences::GetBool("foo.bool", true, PrefValueKind::User), false);
|
|
|
|
Preferences::SetInt("foo.int", -66, PrefValueKind::Default);
|
|
Preferences::SetInt("foo.int", -77, PrefValueKind::User);
|
|
ASSERT_EQ(Preferences::GetInt("foo.int", 1, PrefValueKind::Default), -66);
|
|
ASSERT_EQ(Preferences::GetInt("foo.int", 1, PrefValueKind::User), -77);
|
|
|
|
Preferences::SetUint("foo.uint", 88, PrefValueKind::Default);
|
|
Preferences::SetUint("foo.uint", 99, PrefValueKind::User);
|
|
ASSERT_EQ(Preferences::GetUint("foo.uint", 1, PrefValueKind::Default), 88U);
|
|
ASSERT_EQ(Preferences::GetUint("foo.uint", 1, PrefValueKind::User), 99U);
|
|
|
|
Preferences::SetFloat("foo.float", 3.33f, PrefValueKind::Default);
|
|
Preferences::SetFloat("foo.float", 4.44f, PrefValueKind::User);
|
|
ASSERT_FLOAT_EQ(
|
|
Preferences::GetFloat("foo.float", 1.0f, PrefValueKind::Default), 3.33f);
|
|
ASSERT_FLOAT_EQ(Preferences::GetFloat("foo.float", 1.0f, PrefValueKind::User),
|
|
4.44f);
|
|
}
|
|
|
|
TEST(PrefsBasics, Serialize)
|
|
{
|
|
// Ensure that at least this one preference exists
|
|
Preferences::SetBool("foo.bool", true, PrefValueKind::Default);
|
|
ASSERT_EQ(Preferences::GetBool("foo.bool", false, PrefValueKind::Default),
|
|
true);
|
|
|
|
nsCString str;
|
|
Preferences::SerializePreferences(str, true);
|
|
fprintf(stderr, "%s\n", str.get());
|
|
// Assert that some prefs were not sanitized
|
|
ASSERT_NE(nullptr, strstr(str.get(), "B--:"));
|
|
ASSERT_NE(nullptr, strstr(str.get(), "I--:"));
|
|
ASSERT_NE(nullptr, strstr(str.get(), "S--:"));
|
|
// Assert that something was sanitized
|
|
ASSERT_NE(
|
|
nullptr,
|
|
strstr(
|
|
str.get(),
|
|
"I-S:56/datareporting.policy.dataSubmissionPolicyAcceptedVersion"));
|
|
}
|
|
|
|
TEST(PrefsBasics, WeakObserverIdleSweep)
|
|
{
|
|
// In gtest there is no RefreshDriver to drive idle scheduling and we don't
|
|
// want to wait for the maximum idle delay. A repeating timer provides enough
|
|
// main-thread activity for the idle task machinery to find idle time.
|
|
nsCOMPtr<nsITimer> keepAlive = NS_NewTimer();
|
|
keepAlive->InitWithNamedFuncCallback(
|
|
[](nsITimer*, void*) {}, nullptr, 16, nsITimer::TYPE_REPEATING_SLACK,
|
|
"PrefsBasics.WeakObserverIdleSweep.keepAlive"_ns);
|
|
|
|
// Drain any startup-triggered sweep runner before we begin.
|
|
TimeStamp drainDeadline =
|
|
TimeStamp::Now() + TimeDuration::FromMilliseconds(100);
|
|
MOZ_ALWAYS_TRUE(
|
|
SpinEventLoopUntil("PrefsBasics.WeakObserverIdleSweep.drain"_ns,
|
|
[&] { return TimeStamp::Now() >= drainDeadline; }));
|
|
NS_ProcessPendingEvents(nullptr);
|
|
|
|
static const char kPref[] = "test.weak.observer.sweep";
|
|
Preferences::SetBool(kPref, false);
|
|
|
|
uint32_t countWithObserver;
|
|
{
|
|
RefPtr<TestWeakPrefObserver> observer = new TestWeakPrefObserver();
|
|
nsresult rv = Preferences::AddWeakObserver(observer, kPref);
|
|
ASSERT_TRUE(NS_SUCCEEDED(rv));
|
|
countWithObserver = Preferences::GetCallbackCount();
|
|
}
|
|
|
|
// Observer expired, but no pref change — callback is still in the list.
|
|
EXPECT_EQ(Preferences::GetCallbackCount(), countWithObserver);
|
|
|
|
// Changing the pref notifies the expired observer, scheduling an idle sweep.
|
|
Preferences::SetBool(kPref, true);
|
|
|
|
// Spin the event loop until the idle sweep runs and removes the callback.
|
|
MOZ_ALWAYS_TRUE(SpinEventLoopUntil(
|
|
"PrefsBasics.WeakObserverIdleSweep"_ns,
|
|
[&] { return Preferences::GetCallbackCount() < countWithObserver; }));
|
|
|
|
keepAlive->Cancel();
|
|
}
|
|
|
|
TEST(PrefsBasics, WeakObserverRegistrationSweep)
|
|
{
|
|
// In gtest there is no RefreshDriver to drive idle scheduling and we don't
|
|
// want to wait for the maximum idle delay. A repeating timer provides enough
|
|
// main-thread activity for the idle task machinery to find idle time.
|
|
nsCOMPtr<nsITimer> keepAlive = NS_NewTimer();
|
|
keepAlive->InitWithNamedFuncCallback(
|
|
[](nsITimer*, void*) {}, nullptr, 16, nsITimer::TYPE_REPEATING_SLACK,
|
|
"PrefsBasics.WeakObserverRegistrationSweep.keepAlive"_ns);
|
|
|
|
// Drain any pending sweep runner before we begin.
|
|
TimeStamp drainDeadline =
|
|
TimeStamp::Now() + TimeDuration::FromMilliseconds(100);
|
|
MOZ_ALWAYS_TRUE(
|
|
SpinEventLoopUntil("PrefsBasics.WeakObserverRegistrationSweep.drain"_ns,
|
|
[&] { return TimeStamp::Now() >= drainDeadline; }));
|
|
NS_ProcessPendingEvents(nullptr);
|
|
|
|
static const char kPref[] = "test.weak.observer.regsweep";
|
|
Preferences::SetBool(kPref, false);
|
|
|
|
uint32_t countWithObserver;
|
|
{
|
|
RefPtr<TestWeakPrefObserver> observer = new TestWeakPrefObserver();
|
|
nsresult rv = Preferences::AddWeakObserver(observer, kPref);
|
|
ASSERT_TRUE(NS_SUCCEEDED(rv));
|
|
countWithObserver = Preferences::GetCallbackCount();
|
|
}
|
|
|
|
// Observer expired, but callback is still in the list.
|
|
EXPECT_EQ(Preferences::GetCallbackCount(), countWithObserver);
|
|
|
|
// Register 512 weak observers to hit the periodic sweep threshold.
|
|
// Keep them alive during registration to avoid address reuse causing
|
|
// duplicate keys in the observer hashtable.
|
|
static constexpr uint32_t kSweepInterval = 512;
|
|
nsTArray<RefPtr<TestWeakPrefObserver>> observers(kSweepInterval);
|
|
for (uint32_t i = 0; i < kSweepInterval; i++) {
|
|
observers.AppendElement(new TestWeakPrefObserver());
|
|
Preferences::AddWeakObserver(observers.LastElement(), kPref);
|
|
}
|
|
EXPECT_EQ(Preferences::GetCallbackCount(),
|
|
countWithObserver + kSweepInterval);
|
|
|
|
// Let all observers expire at once.
|
|
observers.Clear();
|
|
|
|
// Spin the event loop until the sweep removes all expired callbacks.
|
|
MOZ_ALWAYS_TRUE(SpinEventLoopUntil(
|
|
"PrefsBasics.WeakObserverRegistrationSweep"_ns,
|
|
[&] { return Preferences::GetCallbackCount() < countWithObserver; }));
|
|
|
|
keepAlive->Cancel();
|
|
}
|
|
|
|
TEST(PrefsBasics, FreeObserverListRemovesAllCallbacks)
|
|
{
|
|
Preferences::SetBool("test.free.a.pref", false);
|
|
Preferences::SetBool("test.free.b.pref", false);
|
|
|
|
uint32_t baselineCount = Preferences::GetCallbackCount();
|
|
|
|
nsCOMPtr<nsIPrefService> prefService =
|
|
do_GetService(NS_PREFSERVICE_CONTRACTID);
|
|
ASSERT_TRUE(prefService);
|
|
|
|
nsCOMPtr<nsIPrefBranch> branchA;
|
|
nsresult rv = prefService->GetBranch("test.free.a.", getter_AddRefs(branchA));
|
|
ASSERT_TRUE(NS_SUCCEEDED(rv));
|
|
|
|
nsCOMPtr<nsIPrefBranch> branchB;
|
|
rv = prefService->GetBranch("test.free.b.", getter_AddRefs(branchB));
|
|
ASSERT_TRUE(NS_SUCCEEDED(rv));
|
|
|
|
RefPtr<TestWeakPrefObserver> obs1 = new TestWeakPrefObserver();
|
|
RefPtr<TestWeakPrefObserver> obs2 = new TestWeakPrefObserver();
|
|
RefPtr<TestWeakPrefObserver> obs3 = new TestWeakPrefObserver();
|
|
|
|
// Interleave observer registration across the two branches.
|
|
rv = branchA->AddObserver("pref", obs1, false);
|
|
ASSERT_TRUE(NS_SUCCEEDED(rv));
|
|
rv = branchB->AddObserver("pref", obs2, false);
|
|
ASSERT_TRUE(NS_SUCCEEDED(rv));
|
|
rv = branchA->AddObserver("pref", obs3, false);
|
|
ASSERT_TRUE(NS_SUCCEEDED(rv));
|
|
EXPECT_EQ(Preferences::GetCallbackCount(), baselineCount + 3);
|
|
|
|
// Releasing branchA should only remove its two callbacks.
|
|
branchA = nullptr;
|
|
EXPECT_EQ(Preferences::GetCallbackCount(), baselineCount + 1);
|
|
|
|
// Releasing branchB removes the remaining one.
|
|
branchB = nullptr;
|
|
EXPECT_EQ(Preferences::GetCallbackCount(), baselineCount);
|
|
}
|