Files
firefox/widget/windows/WinCompositorWindowThread.h
Emilio Cobos Álvarez a6ac1e4254 Bug 2041771 - Deal with spurious wakeups in WinWindowOcclusionTracker and WinCompositorWindowThread properly. r=gfx-reviewers,aosmond
The previous code assumed that if a condvar woke up spuriously, the
status would be CVStatus::Timeout, but that seems wrong (doesn't match
the WaitForAddress semantics, and wasn't guaranteed to begin with).

Instead, guard shutdown completion with a variable. While at it, move
the monitor outside the instances, there's no real reason it needs to be
there.

Differential Revision: https://phabricator.services.mozilla.com/D304074
2026-06-02 15:00:57 +00:00

64 lines
1.7 KiB
C++

/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef widget_windows_WinCompositorWindowThread_h
#define widget_windows_WinCompositorWindowThread_h
#include "base/thread.h"
#include "base/message_loop.h"
namespace mozilla {
namespace widget {
struct WinCompositorWnds {
HWND mCompositorWnd;
HWND mInitialParentWnd;
WinCompositorWnds(HWND aCompositorWnd, HWND aInitialParentWnd)
: mCompositorWnd(aCompositorWnd), mInitialParentWnd(aInitialParentWnd) {}
};
class WinCompositorWindowThread final {
NS_INLINE_DECL_THREADSAFE_REFCOUNTING_WITH_DELETE_ON_MAIN_THREAD(
WinCompositorWindowThread)
public:
/// Can be called from any thread.
static WinCompositorWindowThread* Get();
/// Can only be called from the main thread.
static void Start();
/// Can only be called from the main thread.
static void ShutDown();
/// Can be called from any thread.
static MessageLoop* Loop();
/// Can be called from any thread.
static bool IsInCompositorWindowThread();
/// Can be called from any thread.
static WinCompositorWnds CreateCompositorWindow();
/// Can be called from any thread.
static void DestroyCompositorWindow(WinCompositorWnds aWnds);
private:
explicit WinCompositorWindowThread(base::Thread* aThread);
~WinCompositorWindowThread() {}
void ShutDownTask();
UniquePtr<base::Thread> const mThread;
// Has ShutDown been called on us? We might have survived if our thread join
// timed out.
bool mHasAttemptedShutdown = false;
};
} // namespace widget
} // namespace mozilla
#endif // widget_windows_WinCompositorWindowThread_h