mirror of
https://github.com/HeyPuter/firefox.git
synced 2026-11-13 20:14:57 -10:00
Mitchell Hentges
0144095049
All commands declaring a virtualenv will have them activated before the command executes. Removes all now-redundant manual activations of declared virtualenvs. Commands that don't declare a virtualenv will still implicitly be associated with the "common" virtualenv, but unlike explicit virtualenv declarations it'll have to be activated manually, just like it was before this patch. To smooth the migration with existing usages, virtualenv activation behaviour was changed slightly: if attempting to activate a new virtualenv, but the source venv is already command venv, then raise an exception. (In the future, we should improve testability of virtualenv scaffolding logic so that tests can be added for this sort of thing.) This did cause some issues with some tests, which will be solved more cleanly with bug 1724273. In the meantime, minimal modifications were made to failing tests to keep them green: * `test_command_line.py` was activating the `common` virtualenv so that it could install `mozproxy`, and use its CLI. Instead, I modified the test to use `mozproxy` using the "module" interface (`python -m mozproxy ...`). At that point, `MozbuildObject` was unnecessary and usages were replaced with simpler variants. * `test_vendor.py` needed its explicit `activate_virtualenv()` call patched out. It still needs to use a virtualenv's Python executable, but due to `sys.executable` now being kept up-to-date as of bug 1717051, it could be used directly. Differential Revision: https://phabricator.services.mozilla.com/D122892
This directory contains common Python code. The basic rule is that if Python code is cross-module (that's "module" in the Mozilla meaning - as in "module ownership") and is MPL-compatible, it should go here. What should not go here: * Vendored python modules (use third_party/python instead) * Python that is not MPL-compatible (see other-licenses/) * Python that has good reason to remain close to its "owning" (Mozilla) module (e.g. it is only being consumed from there). Historical information can be found at https://bugzilla.mozilla.org/show_bug.cgi?id=775243 https://bugzilla.mozilla.org/show_bug.cgi?id=1346025