Files
firefox/devtools/client/shared/components/tree/LabelCell.js
T
James Teh aa6433b484 Bug 1898661: In the Dev Tools tree LabelCell and TreeCell components, don't aria-labelledby the span with the column header. r=devtools-reviewers,nchevobbe
Now that the a11y engine correctly traverses aria-labelledby during name computation per the spec, the aria-labelledby overrides the content of the cell when computing the name for the tree item.
Strictly speaking, putting aria-labelledby on a span is a spec violation these days anyway.

Differential Revision: https://phabricator.services.mozilla.com/D211503
2024-05-27 06:40:35 +00:00

74 lines
2.2 KiB
JavaScript

/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
"use strict";
// Make this available to both AMD and CJS environments
define(function (require, exports, module) {
const { Component } = require("devtools/client/shared/vendor/react");
const dom = require("devtools/client/shared/vendor/react-dom-factories");
const PropTypes = require("devtools/client/shared/vendor/react-prop-types");
/**
* Render the default cell used for toggle buttons
*/
class LabelCell extends Component {
// See the TreeView component for details related
// to the 'member' object.
static get propTypes() {
return {
title: PropTypes.string,
member: PropTypes.object.isRequired,
renderSuffix: PropTypes.func,
};
}
render() {
const title = this.props.title;
const member = this.props.member;
const level = member.level || 0;
const renderSuffix = this.props.renderSuffix;
const iconClassList = ["treeIcon"];
if (member.hasChildren && member.loading) {
iconClassList.push("devtools-throbber");
} else if (member.hasChildren) {
iconClassList.push("theme-twisty");
}
if (member.open) {
iconClassList.push("open");
}
return dom.td(
{
className: "treeLabelCell",
title,
style: {
// Compute indentation dynamically. The deeper the item is
// inside the hierarchy, the bigger is the left padding.
"--tree-label-cell-indent": `${level * 16}px`,
},
key: "default",
role: "presentation",
},
dom.span({
className: iconClassList.join(" "),
role: "presentation",
}),
dom.span(
{
className: "treeLabel " + member.type + "Label",
title,
"data-level": level,
},
member.name
),
renderSuffix && renderSuffix(member)
);
}
}
// Exports from this module
module.exports = LabelCell;
});