HeyPuter/firefox
1
0 Fork 0
mirror of https://github.com/HeyPuter/firefox.git synced 2026-11-13 20:14:57 -10:00
Code Issues Packages Projects Releases Wiki Activity
Files
0917ddfc802da24cab5d63f0fcccdbe34494de6f
firefox/testing/web-platform/tests/css/css-break/float-017.html
T
Morten Stenshorne 4d7e3ff049 Bug 1867802 [wpt PR 43474] - Never break at a resumed parallel block flow inline node., a=testonly 
Automatic update from web-platform-tests
Never break at a resumed parallel block flow inline node.

What I did in CL:5063008 caused trouble, because incoming child break
tokens could be re-propagated twice; once in BoxFragmentBuilder::
AddBreakBeforeChild(), and then again when walking through the
unprocessed incoming inline break tokens in BlockLayoutAlgorithm::
Layout().

Revert the code changes from that CL, and replace it with something
better (and simpler): Never consider breaking before a resumed inline
node in a parallel block flow. This is similar to how we already handle
interleaved block formatting context roots. They may also be interrupted
by floats that got pushed from an earlier fragmentainer, and thus not be
able to resume and place anything in one fragmentainer, and try again in
the next. See e.g. web_tests/external/wpt/css/css-break/float-005.html

Bug: 1506393
Change-Id: If580b5a5f33a8b4ddf86677f79d1a9f06819bc51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5077847
Auto-Submit: Morten Stenshorne <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1232515}

--

wpt-commits: cce26e3757dcfd21629f3334072ce9c1292c4d9f
wpt-pr: 43474
2023-12-14 09:31:07 +00:00

22 lines
742 B
HTML
Raw Blame History

<!DOCTYPE html>
<link rel="author" title="Morten Stenshorne" href="mailto:[email protected]">
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1506393">
<link rel="match" href="float-017-ref.html">
<p>The numbers from 1 to 10 should be seen below. Each number only once.</p>
<div style="width:20em; columns:4; gap:0; column-fill:auto; height:100px; line-height:20px; orphans:1; widows:1;">
1<br>
<div style="float:right; contain:size; width:100%; height:200px;"></div>
<div style="display:flow-root; width:100%;">
2<br>
3<br>
<div style="float:right; break-inside:avoid; width:10px; height:200px;"></div>
4<br>
5<br>
6<br>
7<br>
8<br>
9<br>
10<br>
</div>
</div>
Reference in new issue View Git Blame Copy Permalink