Files
firefox/testing/web-platform/tests/css/css-contain/contain-inline-size-multicol.html
T
Morten Stenshorne a91caf4aa9 Bug 1783007 [wpt PR 35322] - Correct multicol min/max with inline-size containment., a=testonly
Automatic update from web-platform-tests
Correct multicol min/max with inline-size containment.

Without this fix, we used to make room for column spanners, which is
wrong if inline-size containment should apply.

Make an existing test more evil, so that it would fail without this fix.

This also fixes a crash, which is what crbug.com/1348714 really was
about. We used to lay out with stale NGInlineNodeData. NGInlineNodeData
used to get updated during min/max calculation (because we didn't honor
size containment), and that takes place (via
CalculateInitialFragmentGeometry() in NGBlockNode::Layout()) before
container query evaluation (which will update the layout object tree
structure). Apparently we don't update NGInlineNodeData again once we
get to actual layout. It could be that there's an underlying cause that
still needs to be addressed here. If someone is unlucky enough to do an
NGInlineNode::PrepareLayoutIfNeeded() before container query evaluation,
it seems that we might end up with stale NGInlineNodeData.

Bug: 1348714
Change-Id: I1996f95138050778ea05d7b20b5301b57c94695a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3807462
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1031461}

--

wpt-commits: b172af8f9f4dc42a501d009e4661fb053fc92391
wpt-pr: 35322
2022-09-04 17:57:48 +00:00

12 lines
725 B
HTML

<!DOCTYPE html>
<title>contain:inline-size on multicol</title>
<link rel="author" title="Morten Stenshorne" href="mailto:[email protected]">
<link rel="help" href="https://drafts.csswg.org/css-contain/#contain-property">
<link rel="help" href="https://drafts.csswg.org/css-contain-3/#containment-inline-size">
<link rel="match" href="../reference/ref-filled-green-100px-square.xht">
<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
<div style="columns:4; column-gap:0; contain:inline-size; width:fit-content; border:solid green; border-width:0 50px; background:red;">
<div style="width:25px; height:200px;"></div>
<div style="column-span:all; width:400px; height:50px;"></div>
</div>