mirror of
https://github.com/HeyPuter/firefox.git
synced 2026-11-13 20:14:57 -10:00
Fredrik Söderquist
e44b938db9
Automatic update from web-platform-tests
Address issues with parse-input-arguments-018.https.html
The test:
external/wpt/css/css-paint-api/parse-input-arguments-018.https.html
is flakily failing or crashing. This turns out to have multiple causes:
1) The generated random string that is part of inputArguments may
not be a valid identifier and thus some invocations of
registerPaint() fail before the input arguments are compared.
2) Because of the thread setup used when running the test, the
assumption about when a definition can be null does not hold.
To address (1), adjust the test to generate strings that are valid
identifiers. For (2), stay consistent with the associated
PaintWorklet's configuration by checking its `is_paint_off_thread_`
flag.
Fixed: 40786499
Change-Id: I3bd1d5eac067e7b9fbc201cb32c69c0a946baab5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5401738
Auto-Submit: Fredrik Söderquist <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Commit-Queue: Robert Flack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1281898}
--
wpt-commits: 22e326dba564862ef9acb848682d30e5ce275d09
wpt-pr: 45402
73 lines
2.6 KiB
HTML
73 lines
2.6 KiB
HTML
<!DOCTYPE html>
|
|
<html class="reftest-wait">
|
|
<link rel="help" href="https://drafts.css-houdini.org/css-paint-api/">
|
|
<link rel="match" href="parse-input-arguments-018-ref.html">
|
|
<style>
|
|
.container {
|
|
width: 100px;
|
|
height: 100px;
|
|
}
|
|
|
|
#canvas-geometry {
|
|
background-image: paint(failureIndicator), paint(geometry);
|
|
}
|
|
</style>
|
|
<script src="/common/reftest-wait.js"></script>
|
|
<script src="/common/worklet-reftest.js"></script>
|
|
<body>
|
|
<p>This test result should show a green rect. The registerPaint('failureIndicator')
|
|
will be called twice and the inputArguments will return two different strings,
|
|
which will throw an exception and the paint function with 'failureIndicator'
|
|
should never be called. In other words, there should be no red painted in the result.</p>
|
|
<div id="canvas-geometry" class="container"></div>
|
|
|
|
<script id="code" type="text/worklet">
|
|
function generateRandomIdentifier(length) {
|
|
const firstChars = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
|
|
const nthChars = firstChars + "0123456789";
|
|
// Pick a letter for the first character so that the string is a valid
|
|
// identifier.
|
|
var text = firstChars.charAt(Math.floor(Math.random() * firstChars.length));
|
|
for (var i = 0; i < length - 1; i++) {
|
|
text += nthChars.charAt(Math.floor(Math.random() * nthChars.length));
|
|
}
|
|
return text;
|
|
}
|
|
|
|
try {
|
|
registerPaint('failureIndicator', class {
|
|
static get inputArguments() {
|
|
// This test is testing the case where an exception should be thrown
|
|
// when two paint definitions with different properties are registered
|
|
// to the same paint worklet. In order to do that, we randomly generate
|
|
// the input properties here. We make the string length 100 to make sure
|
|
// that it is veryyyyyyyyyyyy unlikely that two strings will be the same
|
|
// when running this test.
|
|
var current_str = generateRandomIdentifier(100);
|
|
return [current_str];
|
|
}
|
|
// The paint function here should never be called because the inputArguments
|
|
// will generate two different properties, and that should throw an
|
|
// exception.
|
|
paint(ctx, geom) {
|
|
ctx.fillStyle = 'red';
|
|
ctx.fillRect(0, 0, 50, 50);
|
|
}
|
|
});
|
|
} catch(ex) {
|
|
}
|
|
|
|
registerPaint('geometry', class {
|
|
paint(ctx, geom) {
|
|
ctx.fillStyle = 'green';
|
|
ctx.fillRect(50, 50, 50, 50);
|
|
}
|
|
});
|
|
</script>
|
|
|
|
<script>
|
|
importWorkletAndTerminateTestAfterAsyncPaint(CSS.paintWorklet, document.getElementById('code').textContent);
|
|
</script>
|
|
</body>
|
|
</html>
|