mirror of
https://github.com/HeyPuter/firefox.git
synced 2026-11-13 20:14:57 -10:00
In these tests, the bounds of the red shape were technically already 1px inwards from the bounds of the green shape (at the vertices at least), but that still seems to create an opportunity for a little bit of red fringe along antialiased diagonal lines. An additional pixel of "buffer" is sufficient to avoid this fuzzy mismatch, since it ensures that the edge of the red shape is at least a pixel inwards from the edge of the green shape along the whole diagonal. With that change, there are some remaining visually-imperceptible (maxDifference of 1 in the green channel) fuzzy pixels. These ones are unrelated to the red shape, and I'm adding annotations for them since they're imperceptible and unrelated to what the test is trying to test. We've got https://bugzilla.mozilla.org/show_bug.cgi?id=1840747 to track the former issue (the red fringe), and we have https://bugzilla.mozilla.org/show_bug.cgi?id=1840511 to track the latter issue (off-by-1 in the green color channel). Depends on D182295 Differential Revision: https://phabricator.services.mozilla.com/D182296