mirror of
https://github.com/HeyPuter/firefox.git
synced 2026-11-13 20:14:57 -10:00
Mike Hommey
ce446da747
Comma is the separator for values in options. Like in --with-foo=bar,baz. This is meant to be useful for options with nargs="*", "+", or a fixed value greater than 1. Currently, when an option with another nargs is passed a comma, we reject the value as being multiple values, while one or less is expected. This causes problems with options with nargs=1 that actually CAN have legitimate values containing commas. Examples include: CFLAGS="-Wp,--preprocessor-flag -Wa,--assembler-flag" LDFLAGS=-Wl,--linker-flag" Since options with multiple arguments are the exception, not the norm, let's allow commas in cases where at most a single argument is expected. An alternative would be to explicitly disable comma-splitting on the set of options that can take values containing commas, but that's error-prone. Differential Revision: https://phabricator.services.mozilla.com/D217021
This directory contains common Python code. The basic rule is that if Python code is cross-module (that's "module" in the Mozilla meaning - as in "module ownership") and is MPL-compatible, it should go here. What should not go here: * Vendored python modules (use third_party/python instead) * Python that is not MPL-compatible (see other-licenses/) * Python that has good reason to remain close to its "owning" (Mozilla) module (e.g. it is only being consumed from there). Historical information can be found at https://bugzilla.mozilla.org/show_bug.cgi?id=775243 https://bugzilla.mozilla.org/show_bug.cgi?id=1346025