mirror of
https://github.com/aria2/aria2.git
synced 2024-12-14 09:28:55 +00:00
4e28efd925
Fixed the bug that DiskWriterEntry is not created when its FileEntry.isRequested() is false and it doesn't share a piece with other FileEntries that are requested. This bug causes segmentation fault in the end.
231 lines
7.8 KiB
C++
231 lines
7.8 KiB
C++
#include "MultiFileAllocationIterator.h"
|
|
#include "File.h"
|
|
#include "MultiDiskAdaptor.h"
|
|
#include "FileEntry.h"
|
|
#include "Exception.h"
|
|
#include "array_fun.h"
|
|
#include "TestUtil.h"
|
|
#include "DiskWriter.h"
|
|
#include <algorithm>
|
|
#include <iostream>
|
|
#include <cppunit/extensions/HelperMacros.h>
|
|
|
|
namespace aria2 {
|
|
|
|
class MultiFileAllocationIteratorTest:public CppUnit::TestFixture {
|
|
|
|
CPPUNIT_TEST_SUITE(MultiFileAllocationIteratorTest);
|
|
CPPUNIT_TEST(testAllocate);
|
|
CPPUNIT_TEST(testMakeDiskWriterEntries);
|
|
CPPUNIT_TEST_SUITE_END();
|
|
private:
|
|
|
|
public:
|
|
void setUp() {}
|
|
|
|
void testAllocate();
|
|
void testMakeDiskWriterEntries();
|
|
};
|
|
|
|
|
|
CPPUNIT_TEST_SUITE_REGISTRATION( MultiFileAllocationIteratorTest );
|
|
|
|
void MultiFileAllocationIteratorTest::testMakeDiskWriterEntries()
|
|
{
|
|
SharedHandle<FileEntry> fs[] = {
|
|
SharedHandle<FileEntry>(new FileEntry("file1", 1536, 0)),
|
|
SharedHandle<FileEntry>(new FileEntry("file2", 2048, 1536)),// req no
|
|
SharedHandle<FileEntry>(new FileEntry("file3", 1024, 3584)),
|
|
SharedHandle<FileEntry>(new FileEntry("file4", 1024, 4608)),// req no
|
|
SharedHandle<FileEntry>(new FileEntry("file5", 1024, 5632)),// req no
|
|
SharedHandle<FileEntry>(new FileEntry("file6", 1024, 6656)),// req no
|
|
SharedHandle<FileEntry>(new FileEntry("file7", 256, 7680)),// req no
|
|
SharedHandle<FileEntry>(new FileEntry("file8", 255, 7936)),
|
|
SharedHandle<FileEntry>(new FileEntry("file9", 1025, 8191)),// req no
|
|
SharedHandle<FileEntry>(new FileEntry("fileA", 1024, 9216)),// req no
|
|
SharedHandle<FileEntry>(new FileEntry("fileB", 1024, 10240)),
|
|
};
|
|
fs[1]->setRequested(false); // file2
|
|
fs[3]->setRequested(false); // file4
|
|
fs[4]->setRequested(false); // file5
|
|
fs[5]->setRequested(false); // file6
|
|
fs[6]->setRequested(false); // file7
|
|
fs[8]->setRequested(false); // file9
|
|
fs[9]->setRequested(false); // fileA
|
|
|
|
std::string topDir = "top";
|
|
std::string storeDir = "/tmp/aria2_MultiFileAllocationIteratorTest"
|
|
"_testMakeDiskWriterEntries";
|
|
std::string prefix = storeDir+"/"+topDir;
|
|
|
|
// create empty file4
|
|
createFile(prefix+std::string("/file4"), 0);
|
|
|
|
SharedHandle<MultiDiskAdaptor> diskAdaptor(new MultiDiskAdaptor());
|
|
diskAdaptor->setFileEntries
|
|
(std::deque<SharedHandle<FileEntry> >(&fs[0], &fs[arrayLength(fs)]));
|
|
diskAdaptor->setPieceLength(1024);
|
|
diskAdaptor->setStoreDir(storeDir);
|
|
diskAdaptor->setTopDir(topDir);
|
|
diskAdaptor->openFile();
|
|
|
|
SharedHandle<MultiFileAllocationIterator> itr
|
|
(dynamic_pointer_cast<MultiFileAllocationIterator>
|
|
(diskAdaptor->fileAllocationIterator()));
|
|
|
|
DiskWriterEntries entries = itr->getDiskWriterEntries();
|
|
|
|
CPPUNIT_ASSERT_EQUAL((size_t)11, entries.size());
|
|
|
|
// file1
|
|
CPPUNIT_ASSERT_EQUAL(prefix+std::string("/file1"),
|
|
entries[0]->getFilePath(prefix));
|
|
CPPUNIT_ASSERT(entries[0]->needsFileAllocation());
|
|
CPPUNIT_ASSERT(!entries[0]->getDiskWriter().isNull());
|
|
// file2
|
|
CPPUNIT_ASSERT_EQUAL(prefix+std::string("/file2"),
|
|
entries[1]->getFilePath(prefix));
|
|
CPPUNIT_ASSERT(entries[1]->needsFileAllocation());
|
|
CPPUNIT_ASSERT(!entries[1]->getDiskWriter().isNull());
|
|
// file3
|
|
CPPUNIT_ASSERT_EQUAL(prefix+std::string("/file3"),
|
|
entries[2]->getFilePath(prefix));
|
|
CPPUNIT_ASSERT(entries[2]->needsFileAllocation());
|
|
CPPUNIT_ASSERT(!entries[2]->getDiskWriter().isNull());
|
|
// file4, diskWriter is not null, because file exists.
|
|
CPPUNIT_ASSERT_EQUAL(prefix+std::string("/file4"),
|
|
entries[3]->getFilePath(prefix));
|
|
CPPUNIT_ASSERT(!entries[3]->needsFileAllocation());
|
|
CPPUNIT_ASSERT(!entries[3]->getDiskWriter().isNull());
|
|
// file5
|
|
CPPUNIT_ASSERT_EQUAL(prefix+std::string("/file5"),
|
|
entries[4]->getFilePath(prefix));
|
|
CPPUNIT_ASSERT(!entries[4]->needsFileAllocation());
|
|
CPPUNIT_ASSERT(entries[4]->getDiskWriter().isNull());
|
|
// file6
|
|
CPPUNIT_ASSERT_EQUAL(prefix+std::string("/file6"),
|
|
entries[5]->getFilePath(prefix));
|
|
CPPUNIT_ASSERT(entries[5]->needsFileAllocation());
|
|
CPPUNIT_ASSERT(!entries[5]->getDiskWriter().isNull());
|
|
// file7
|
|
CPPUNIT_ASSERT_EQUAL(prefix+std::string("/file7"),
|
|
entries[6]->getFilePath(prefix));
|
|
CPPUNIT_ASSERT(entries[6]->needsFileAllocation());
|
|
CPPUNIT_ASSERT(!entries[6]->getDiskWriter().isNull());
|
|
// file8
|
|
CPPUNIT_ASSERT_EQUAL(prefix+std::string("/file8"),
|
|
entries[7]->getFilePath(prefix));
|
|
CPPUNIT_ASSERT(entries[7]->needsFileAllocation());
|
|
CPPUNIT_ASSERT(!entries[7]->getDiskWriter().isNull());
|
|
// file9
|
|
CPPUNIT_ASSERT_EQUAL(prefix+std::string("/file9"),
|
|
entries[8]->getFilePath(prefix));
|
|
CPPUNIT_ASSERT(entries[8]->needsFileAllocation());
|
|
CPPUNIT_ASSERT(!entries[8]->getDiskWriter().isNull());
|
|
// fileA
|
|
CPPUNIT_ASSERT_EQUAL(prefix+std::string("/fileA"),
|
|
entries[9]->getFilePath(prefix));
|
|
CPPUNIT_ASSERT(!entries[9]->needsFileAllocation());
|
|
CPPUNIT_ASSERT(entries[9]->getDiskWriter().isNull());
|
|
// fileB
|
|
CPPUNIT_ASSERT_EQUAL(prefix+std::string("/fileB"),
|
|
entries[10]->getFilePath(prefix));
|
|
CPPUNIT_ASSERT(entries[10]->needsFileAllocation());
|
|
CPPUNIT_ASSERT(!entries[10]->getDiskWriter().isNull());
|
|
}
|
|
|
|
void MultiFileAllocationIteratorTest::testAllocate()
|
|
{
|
|
std::string dir = "/tmp";
|
|
std::string topDir = "aria2_MultiFileAllocationIteratorTest_testAllocate";
|
|
std::string prefix = dir+"/"+topDir;
|
|
std::string fname1 = "file1";
|
|
std::string fname2 = "file2";
|
|
std::string fname3 = "file3";
|
|
std::string fname4 = "file4";
|
|
std::string fname5 = "file5";
|
|
std::string fname6 = "file6";
|
|
int64_t length1 = 32769;
|
|
int64_t length2 = 0;
|
|
int64_t length3 = 8;
|
|
int64_t length4 = 10;
|
|
int64_t length5 = 20;
|
|
int64_t length6 = 30;
|
|
|
|
try {
|
|
SharedHandle<MultiDiskAdaptor> diskAdaptor(new MultiDiskAdaptor());
|
|
diskAdaptor->setStoreDir(dir);
|
|
diskAdaptor->setTopDir(topDir);
|
|
diskAdaptor->setPieceLength(1);
|
|
|
|
int64_t offset = 0;
|
|
SharedHandle<FileEntry> fileEntry1(new FileEntry(fname1,
|
|
length1,
|
|
offset));
|
|
offset += length1;
|
|
SharedHandle<FileEntry> fileEntry2(new FileEntry(fname2,
|
|
length2,
|
|
offset));
|
|
|
|
offset += length2;
|
|
SharedHandle<FileEntry> fileEntry3(new FileEntry(fname3,
|
|
length3,
|
|
offset));
|
|
|
|
offset += length3;
|
|
SharedHandle<FileEntry> fileEntry4(new FileEntry(fname4,
|
|
length4,
|
|
offset));
|
|
fileEntry4->setRequested(false);
|
|
|
|
offset += length4;
|
|
SharedHandle<FileEntry> fileEntry5(new FileEntry(fname5,
|
|
length5,
|
|
offset));
|
|
|
|
offset += length5;
|
|
SharedHandle<FileEntry> fileEntry6(new FileEntry(fname6,
|
|
length6,
|
|
offset));
|
|
fileEntry6->setRequested(false);
|
|
|
|
std::deque<SharedHandle<FileEntry> > fs;
|
|
fs.push_back(fileEntry1);
|
|
fs.push_back(fileEntry2);
|
|
fs.push_back(fileEntry3);
|
|
fs.push_back(fileEntry4);
|
|
fs.push_back(fileEntry5);
|
|
fs.push_back(fileEntry6);
|
|
diskAdaptor->setFileEntries(fs);
|
|
|
|
|
|
File(prefix+"/"+fname1).remove();
|
|
File(prefix+"/"+fname2).remove();
|
|
File(prefix+"/"+fname3).remove();
|
|
File(prefix+"/"+fname4).remove();
|
|
File(prefix+"/"+fname5).remove();
|
|
File(prefix+"/"+fname6).remove();
|
|
|
|
// we have to open file first.
|
|
diskAdaptor->initAndOpenFile();
|
|
SharedHandle<MultiFileAllocationIterator> itr
|
|
(dynamic_pointer_cast<MultiFileAllocationIterator>
|
|
(diskAdaptor->fileAllocationIterator()));
|
|
while(!itr->finished()) {
|
|
itr->allocateChunk();
|
|
}
|
|
CPPUNIT_ASSERT_EQUAL((uint64_t)length1, File(prefix+"/"+fname1).size());
|
|
CPPUNIT_ASSERT_EQUAL((uint64_t)length2, File(prefix+"/"+fname2).size());
|
|
CPPUNIT_ASSERT_EQUAL((uint64_t)length3, File(prefix+"/"+fname3).size());
|
|
CPPUNIT_ASSERT(!File(prefix+"/"+fname4).isFile());
|
|
|
|
CPPUNIT_ASSERT_EQUAL((uint64_t)length5, File(prefix+"/"+fname5).size());
|
|
CPPUNIT_ASSERT(!File(prefix+"/"+fname6).isFile());
|
|
|
|
} catch(Exception& e) {
|
|
CPPUNIT_FAIL(e.stackTrace());
|
|
}
|
|
}
|
|
|
|
} // namespace aria2
|