From 9f727d495f9a1b949704f8e76baf25d016d1f4e7 Mon Sep 17 00:00:00 2001 From: John Ott Date: Wed, 10 Aug 2022 12:59:13 -0500 Subject: [PATCH] Remove outdated ctypes requirement The library ctypes has shipped with the python standard library since Python 2.5, however this was still added via the `requires` keyword in setuptools.setup. This results in a spurious requirement being created in the .whl METADATA file, causing warnings when packaged via tools like pex: ``` $ python3 -m pex capstone -o capstone.pex /Users/ott/.venv/lib/python3.9/site-packages/pex/dist_metadata.py:397: PEXWarning: Ignoring 1 `Requires` field in /Users/ott/.pex/installed_wheels/2a4c7a0d4c87aceed3134ae20997a764af1811fee8e151cf5da90e0462822893/capstone-4.0.2-py3-none-macosx_12_arm64.whl metadata: 1.) Requires: ctypes You may have issues using the 'capstone' distribution as a result. More information on this workaround can be found here: https://github.com/pantsbuild/pex/issues/1201#issuecomment-791715585 ``` Since this requirement is outdated, it can just be removed. --- bindings/python/setup.py | 1 - 1 file changed, 1 deletion(-) diff --git a/bindings/python/setup.py b/bindings/python/setup.py index ab680a3dd..50975a382 100755 --- a/bindings/python/setup.py +++ b/bindings/python/setup.py @@ -223,7 +223,6 @@ setup( 'Programming Language :: Python :: 2.7', 'Programming Language :: Python :: 3', ], - requires=['ctypes'], cmdclass=cmdclass, zip_safe=True, include_package_data=True,